[pgAdmin4][Patch]: To fix issues in pgAgent module

2017-12-05 Thread Murtuza Zabuawala
Hi, PFA patch to fix given issues, 1) User was allowed to enter start date ahead of end date while scheduling the job. RM#2921 2) Datetime picker was not displaying in the grid (sub-node collection control). RM#1749 3) Fixed UI issue where validation error was not displaying properly for Datetim

[pgAdmin4][Patch]: To fix the issue in File manager

2017-12-05 Thread Murtuza Zabuawala
Hi, PFA patch to fix referenced before assignment bug in file manager. RM#2934 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/file_manager/__init__.py b/web/pgadmin/misc/file_manager/__init__.py index e51ac2

pgAdmin 4 commit: Update EXPLAIN icons. Fixes #2936

2017-12-05 Thread Dave Page
Update EXPLAIN icons. Fixes #2936 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c74b348bacc32ae7b5a3f1c75067121f29e2ca84 Author: Chethana Kumar Modified Files -- .../misc/static/explain/img/ex_aggregate.png | Bin 574 -> 0

pgAdmin 4 commit: Misc fixes for the pgAgent module:

2017-12-05 Thread Dave Page
Misc fixes for the pgAgent module: 1) User was allowed to enter start date ahead of end date while scheduling a job. Fixes #2921 2) Datetime picker was not displaying in the grid (sub-node collection control). Fixes #1749 3) Fixed UI issue where validation error was not displaying properly for

Re: [pgAdmin4][Patch]: To fix issues in pgAgent module

2017-12-05 Thread Dave Page
Thanks, applied. On Tue, Dec 5, 2017 at 8:53 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix given issues, > 1) User was allowed to enter start date ahead of end date while scheduling > the job. > RM#2921 > > 2) Datetime picker was not displaying in t

pgAdmin 4 commit: Fix a reference before assignment error in the file d

2017-12-05 Thread Dave Page
Fix a reference before assignment error in the file dialogue. Fixes #2934 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=22c38e4562dc23b2669b3fb9f97e8c0a1309cd31 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/file_m

Re: [pgAdmin4][Patch]: To fix the issue in File manager

2017-12-05 Thread Dave Page
Hi Thanks, applied. I noticed whilst testing that the Select button on the file dialogue can become enabled again following navigation to another directory. That then allows you to click it when no files are selected, which of course fails horribly. Can you take a look at that please? https://red

Re: [pgAdmin4][Patch]: To fix the issue in File manager

2017-12-05 Thread Murtuza Zabuawala
Hi Dave, I'm not able to re-produce the issue, I've updated the RM with my steps, please check and let me know If I missed anything. https://redmine.postgresql.org/issues/2937 -- Murtuza On Wed, Dec 6, 2017 at 10:17 AM, Dave Page wrote: > Hi > > Thanks, applied. I noticed whilst testing that t

[pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

2017-12-05 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM #2779: Lost field size. While editing the table column, if we change collate then, the length and the precision are lost. Also, while changing column type, it does not honour the length and precision. Thanks, Khushboo diff --git a/web/pgadmin/browser/