Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

2017-11-21 Thread Neel Patel
Hi Dave, On Mon, Nov 20, 2017 at 8:20 PM, Dave Page wrote: > Hi > > On Mon, Nov 20, 2017 at 1:10 PM, Neel Patel > wrote: > >> Hi, >> >> Please find attached patch to fix RM#2679. >> >> *Issue:-* >> Getting started links does not open second time from "Dashboard" panel if >> User close runtime t

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

2017-11-21 Thread Dave Page
On Tue, Nov 21, 2017 at 9:02 AM, Neel Patel wrote: > Hi Dave, > > On Mon, Nov 20, 2017 at 8:20 PM, Dave Page wrote: > >> Hi >> >> On Mon, Nov 20, 2017 at 1:10 PM, Neel Patel >> wrote: >> >>> Hi, >>> >>> Please find attached patch to fix RM#2679. >>> >>> *Issue:-* >>> Getting started links does

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-21 Thread Dave Page
Hi On Mon, Nov 20, 2017 at 5:47 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Mon, Nov 20, 2017 at 10:40 PM, Dave Page wrote: > >> Hi >> >> On Mon, Nov 20, 2017 at 4:19 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> PFA upd

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

2017-11-21 Thread Neel Patel
Hi Dave, On Tue, Nov 21, 2017 at 2:36 PM, Dave Page wrote: > > > On Tue, Nov 21, 2017 at 9:02 AM, Neel Patel > wrote: > >> Hi Dave, >> >> On Mon, Nov 20, 2017 at 8:20 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Nov 20, 2017 at 1:10 PM, Neel Patel >> > wrote: >>> Hi, Please f

pgAdmin 4 commit: _blank is the correct HTML target for anchors, not _n

2017-11-21 Thread Dave Page
_blank is the correct HTML target for anchors, not _new. Fixes #2679. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b5363e2c4c0d00bf215aa9f3c5369801fe39ae4 Author: Neel Patel Modified Files -- web/pgadmin/dashboard/templates/da

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

2017-11-21 Thread Dave Page
Hi On Tue, Nov 21, 2017 at 9:33 AM, Neel Patel wrote: > Hi Dave, > > > On Tue, Nov 21, 2017 at 2:36 PM, Dave Page wrote: > >> >> >> On Tue, Nov 21, 2017 at 9:02 AM, Neel Patel >> wrote: >> >>> Hi Dave, >>> >>> On Mon, Nov 20, 2017 at 8:20 PM, Dave Page wrote: >>> Hi On Mon, Nov

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Dave Page
HI On Tue, Nov 21, 2017 at 6:16 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch with custom tristate boolean editor for SlickGrid to > make it compatible with Qt runtime. > I have tested it web mode & also modified the feature test accordingly.

pgAdmin 4 commit: Remove the artificial limit of 4000 characters from t

2017-11-21 Thread Dave Page
Remove the artificial limit of 4000 characters from text areas. Fixes #2877 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a85538a1fcc6a9c40c3b0f46d111b16e56974819 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/js

Re: [pgAdmin4][Patch]: Remove limit of 4000 characters from Textarea

2017-11-21 Thread Dave Page
Thanks, patch applied. On Tue, Nov 21, 2017 at 7:27 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where we have hard coded limit of 4000 > characters in Backform Textarea control, with new implementation we won't > limit input unless and u

pgAdmin 4 commit: Quote the owner name when creating types. Fixes #2787

2017-11-21 Thread Dave Page
Quote the owner name when creating types. Fixes #2787 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd8e2fe8a6cd88421a0aca9cb7abcdd28d2bfbc5 Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/types/templates/type/

Re: [pgAdmin4][Patch]: Properly quote owner in Type definition

2017-11-21 Thread Dave Page
Thanks, applied. On Tue, Nov 21, 2017 at 7:50 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where owner is not properly quoted > causing Create/Update type sql to fail. > RM#2787 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

Fix for issue RM2760

2017-11-21 Thread Harshal Dhumal
Hi, Please find attached patch to fix RM2760 and RM2867 -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/file_manager/static/js/file_manager.js b/web/pgadmin/misc/file_manager/static/js/

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-21 Thread Khushboo Vashi
On Tue, Nov 21, 2017 at 5:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch with changes suggested by Ashesh. > Hopefully the last revision :) > > +1 :) > > On Tue, Nov 21, 2017 at 4:12 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Da

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. On Tue, Nov 21, 2017 at 4:16 PM, Dave Page wrote: > HI > > On Tue, Nov 21, 2017 at 6:16 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch with custom tristate boolean editor for SlickGrid to >> make it compatible with Qt runtime. >

Re: Fix for issue RM2760

2017-11-21 Thread Dave Page
Thanks, applied. On Tue, Nov 21, 2017 at 12:06 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix RM2760 and RM2867 > > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise Po

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2017-11-21 Thread Dave Page
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=921269993645205c1667ab116e4c4201cacf55df Author: Harshal Dhumal Modified Fi

pgAdmin 4 commit: Allow connections to be coloured in the treeview and

2017-11-21 Thread Dave Page
Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b284572afee33196aa4b41adaf33a399e985b4b7 Author: Murtuza Zabuawala Modified Files -- docs/e

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

2017-11-21 Thread Dave Page
Thanks! Patch applied, with a minor change to default the query tool header to a white background if a custom foreground colour is specified (otherwise you'd get blue). On Tue, Nov 21, 2017 at 12:07 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patc

pgAdmin 4 commit: Some browsers don't properly support tri-state checkb

2017-11-21 Thread Dave Page
Some browsers don't properly support tri-state checkboxes, so create our own control to handle true/false/null. Fixes #2848 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=930dd8af1fac500749c7a9efa2302b5f3f52b4d4 Author: Murtuza Zabuawala Mo

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Dave Page
Hi On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch. > > On Tue, Nov 21, 2017 at 4:16 PM, Dave Page wrote: > >> HI >> >> On Tue, Nov 21, 2017 at 6:16 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> PFA updat

pgAdmin 4 commit: Fix a yarn warning: "warning From Yarn 1.0 onwards, s

2017-11-21 Thread Dave Page
Fix a yarn warning: "warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts." Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=888082

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Murtuza Zabuawala
​Hi Dave, On Tue, Nov 21, 2017 at 10:53 PM, Dave Page wrote: > Hi > > On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch. >> >> On Tue, Nov 21, 2017 at 4:16 PM, Dave Page wrote: >> >>> HI >>> >>> On Tue, Nov 21

Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-21 Thread Ashesh Vashi
On Wed, Nov 22, 2017 at 11:00 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > On Tue, Nov 21, 2017 at 10:53 PM, Dave Page wrote: > >> Hi >> >> On Tue, Nov 21, 2017 at 1:17 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>>

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

2017-11-21 Thread Neel Patel
Hi Dave, On Tue, Nov 21, 2017 at 3:52 PM, Dave Page wrote: > Hi > > On Tue, Nov 21, 2017 at 9:33 AM, Neel Patel > wrote: > >> Hi Dave, >> >> >> On Tue, Nov 21, 2017 at 2:36 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Nov 21, 2017 at 9:02 AM, Neel Patel >> > wrote: >>> Hi Dave, O

[pgAdmin4][Patch]: To display leading whitespace properly in columns - Query tool

2017-11-21 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where user were not able to see leading whitespace in their columns. RM#2880 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/static/css/sqleditor.css b/web/pgad