[pgAdmin4][runtime][patch]: Fix for RM#2679

Hi, Please find attached patch to fix RM#2679. *Issue:-* Getting started links does not open second time from "Dashboard" panel if User close runtime tab and open any URL again. *Analysis:-* As in runtime Qt application, when user defined "target=_new" then "createWindow" signal is called but wh

pgAdmin 4 commit: Display relevant error messages when access is denied

Display relevant error messages when access is denied creating a schema. Fixes #2094 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fd3a7dd3da1c108b12527ec29f4577c57b00eb2 Author: Murtuza Zabuawala Modified Files -- .../browser

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

Thanks, applied. On Fri, Nov 17, 2017 at 10:30 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated. > > On Thu, Nov 16, 2017 at 5:12 PM, Dave Page wrote: > >> >> >> On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wr

Build failed in Jenkins: pgadmin4-master-python26 #511

See Changes: [Dave Page] Display relevant error messages when access is denied creating a schema. -- Started by an SCM change [EnvInject] - Loading node environm

pgAdmin 4 commit: Fix support for time without timezone. Fixes #2881

Fix support for time without timezone. Fixes #2881 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25794580915c1da92c4583c2833a54ca71423698 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py

Re: [pgAdmin4][Patch]: Add support for time without time zone

Thanks, applied. On Fri, Nov 17, 2017 at 12:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to add support for time without time zone. > RM#2881 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise Postg

pgAdmin 4 commit: Allow configuration of CSV and clipboard formatting o

Allow configuration of CSV and clipboard formatting of query results. Fixes #2781 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c566f132e19ab4476f570664647683f97361cb0 Author: Khushboo Vashi Modified Files -- docs/en_US/images

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Thanks, applied. On Mon, Nov 20, 2017 at 5:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > > On Thu, Nov 16, 2017 at 7:42 PM, Dave Page wrote: > >> Hi >> >> On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi < >> khushboo.va...@

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Though whilst it worked fine when I was testing, I now get the following. Khushboo - can you investigate please? Exception in thread Thread-96: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 810, in __bootstrap_

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

On 20 Nov 2017 19:45, "Dave Page" wrote: Though whilst it worked fine when I was testing, I now get the following. Khushboo - can you investigate please? Exception in thread Thread-96: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python

Build failed in Jenkins: pgadmin4-master-python26 #512

See Changes: [Dave Page] Fix support for time without timezone. Fixes #2881 [Dave Page] Allow configuration of CSV and clipboard formatting of query results. --

Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool

Hi On Mon, Nov 20, 2017 at 7:06 AM, Neel Patel wrote: > Hi Dave, > > Ignore above debug patch. > > Can you please test this patch ? From the hang screen prospective, i have > added how many bytes downloaded to message as browser so that user can know > when download in progress with no total dat

pgAdmin 4 commit: Ensure we can download large files and keep the user

Ensure we can download large files and keep the user informed about progress. Fixes #2829. Fixes #2491. Fixes #2715 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8cc1a007b59a6a7c87b4889b6025b1e3b2f251d0 Author: Neel Patel Modified Files --

Re: [pgAdmin4][runtime][patch]: Fix for RM#2679

Hi On Mon, Nov 20, 2017 at 1:10 PM, Neel Patel wrote: > Hi, > > Please find attached patch to fix RM#2679. > > *Issue:-* > Getting started links does not open second time from "Dashboard" panel if > User close runtime tab and open any URL again. > > *Analysis:-* > As in runtime Qt application, w

Build failed in Jenkins: pgadmin4-master-python26 #513

See Changes: [Dave Page] Ensure we can download large files and keep the user informed about -- Started by an SCM change Started by an SCM change Started by an SC

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi Dave, Please find the attached patch to fix the issue. I have fixed the issue looking at the error you got as I can not reproduce the issue on Python 2.7 or Python 3.5. Thanks, Khushboo On Mon, Nov 20, 2017 at 8:05 PM, Dave Page wrote: > > > On Mon, Nov 20, 2017 at 2:20 PM, Khushboo Vashi

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi Thanks, but I'm still getting the same error. On Mon, Nov 20, 2017 at 3:23 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch to fix the issue. > I have fixed the issue looking at the error you got as I can not reproduce > the issue on P

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi Dave, Please find the attached patch. Thanks, Khushboo On Mon, Nov 20, 2017 at 8:59 PM, Dave Page wrote: > Hi > > Thanks, but I'm still getting the same error. > > On Mon, Nov 20, 2017 at 3:23 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

I still see the same error I'm afraid. I played around in another system, and if I set the delimiter to "xx", then it crashes with: Exception in thread Thread-675: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line

pgAdmin 4 commit: Decode the field separator and quote char if needed.

Decode the field separator and quote char if needed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4568fe22f7e50cc9e782839c3ca35607d651b4b3 Author: Khushboo Vashi Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py |

pgAdmin 4 commit: Prevent the Windows installer accepting paths contain

Prevent the Windows installer accepting paths containing invalid characters. Fixes #1365 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ff753deb8cd49fde8fea25b9b676a45461ba7e9 Author: Paresh More Modified Files -- Make-MinGW.ba

Re: [Patch]: Installer: pgAdmin4 should not install in special character path

Thanks, applied with minor changes to the default paths (to make them match my machine, which uses all default paths). On Fri, Nov 17, 2017 at 12:17 PM, Paresh More wrote: > Hello Team, > > I have made three changes for installer generation scripts. > > 1) Modified Make-MinGW.bat to support yarn

Re: Build failed in Jenkins: pgadmin4-master-python26 #510

Hi Dave, PFA patch to fix the issue. We will use the newer of selenium only if python 2.7 or greater else use the older version. Please note that older version of selenium & web driver will not work with latest versions (>= Chrome 61.x) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.ente

Build failed in Jenkins: pgadmin4-master-python26 #514

See Changes: [Dave Page] Decode the field separator and quote char if needed. [Dave Page] Prevent the Windows installer accepting paths containing invalid -- Sta

Re: Build failed in Jenkins: pgadmin4-master-python26 #510

Thanks, applied. On Mon, Nov 20, 2017 at 4:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch to fix the issue. > > We will use the newer of selenium only if python 2.7 or greater else use > the older version. > Please note that older version of seleniu

pgAdmin 4 commit: Stop Python 2.6 barfing on newer versions of Selenium

Stop Python 2.6 barfing on newer versions of Selenium Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce246ecce40fd97810c2120c10029ff328e66bc8 Author: Murtuza Zabuawala Modified Files -- web/regression/requirements.txt | 3 ++- 1 f

pgAdmin 4 commit: Fix /NOICONS switch in the windows installer. Fixes #

Fix /NOICONS switch in the windows installer. Fixes #1366 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a539147a0e8b4b8852289909b2bcb268d7908887 Author: Paresh More Modified Files -- pkg/win32/installer.iss.in | 3 ++- 1 file cha

Re: [pgAdmin4][Patch]: RM#1366 - NOICONS switch for windows installer.

Thanks, patch applied. On Sun, Nov 19, 2017 at 3:20 PM, Paresh More wrote: > Hi, > > This is regarding patch for RM#1366: Installer: pgadmin4-1.0-beta1.exe > /NOICONS switch issue > > This patch includes: > - It would work for both normal and commandline mode when NOICONS argument > is passed.

Build failed in Jenkins: pgadmin4-master-python34 #376

See Changes: [Dave Page] Decode the field separator and quote char if needed. [Dave Page] Prevent the Windows installer accepting paths containing invalid [Dave Page] Stop Python 2.6 barfing on newer v

Build failed in Jenkins: pgadmin4-master-python36 #384

See Changes: [Dave Page] Decode the field separator and quote char if needed. [Dave Page] Prevent the Windows installer accepting paths containing invalid [Dave Page] Stop Python 2.6 barfing on newer v

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

Hi On Mon, Nov 20, 2017 at 4:19 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > OK, that's looking better. I just found a couple of smaller issue this time: - Why can't I select a foreground colour unless I select a non-white background? Th

pgAdmin 4 commit: Add missing semicolons.

Add missing semicolons. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be8d3604fbc3cc53bf088fd06873fdfe14fc6545 Modified Files -- web/regression/requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: Build failed in Jenkins: pgadmin4-master-python34 #376

Oops, Misplaced semi colon. PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Nov 20, 2017 at 10:32 PM, pgAdmin 4 Jenkins wrote: > See 376/display/re

Re: Build failed in Jenkins: pgadmin4-master-python34 #376

Hah - committed the fix 2 minutes before I got this :-) On Mon, Nov 20, 2017 at 5:13 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Oops, Misplaced semi colon. > > PFA updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Ente

pgAdmin 4 commit: And remove the extra semicolons. Sigh.

And remove the extra semicolons. Sigh. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=182369cbab90ab7f7fe651609afa19238e8b7d73 Modified Files -- web/regression/requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Build failed in Jenkins: pgadmin4-master-python36 #385

See Changes: [Dave Page] Add missing semicolons. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Jenkins build is back to normal : pgadmin4-master-python27 #387

See

Build failed in Jenkins: pgadmin4-master-python34 #377

See Changes: [Dave Page] Add missing semicolons. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Jenkins build is back to normal : pgadmin4-master-python26 #516

See

Jenkins build is back to normal : pgadmin4-master-python33 #387

See

Jenkins build is back to normal : pgadmin4-master-python36 #386

See

Build failed in Jenkins: pgadmin4-master-python35 #385

See Changes: [Dave Page] Add missing semicolons. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Jenkins build is back to normal : pgadmin4-master-python35 #386

See

Build failed in Jenkins: pgadmin4-master-python27 #386

See Changes: [Dave Page] Prevent the Windows installer accepting paths containing invalid [Dave Page] Stop Python 2.6 barfing on newer versions of Selenium [Dave Page] Fix /NOICONS switch in the window

Build failed in Jenkins: pgadmin4-master-python33 #384

See Changes: [Dave Page] Stop Python 2.6 barfing on newer versions of Selenium [Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366 -- Started b

Build failed in Jenkins: pgadmin4-master-python33 #386

See Changes: [Dave Page] Add missing semicolons. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace

Build failed in Jenkins: pgadmin4-master-python35 #384

See Changes: [Dave Page] Stop Python 2.6 barfing on newer versions of Selenium [Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366 -- Started b

Jenkins build is back to normal : pgadmin4-master-python34 #378

See

Build failed in Jenkins: pgadmin4-master-python26 #515

See Changes: [Dave Page] Stop Python 2.6 barfing on newer versions of Selenium [Dave Page] Fix /NOICONS switch in the windows installer. Fixes #1366 -- Started b

Build failed in Jenkins: pgadmin4-master-python33 #385

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace > git re

[pgAdmin4][Patch]: Remove limit of 4000 characters from Textarea

Hi, PFA patch to fix the issue where we have hard coded limit of 4000 characters in Backform Textarea control, with new implementation we won't limit input unless and until maxlength is provided in particular field. RM#2877 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com T

[pgAdmin4][Patch]: Properly quote owner in Type definition

Hi, PFA minor patch to fix the issue where owner is not properly quoted causing Create/Update type sql to fail. RM#2787 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schem