pgAdmin 4 commit: Fix RE-SQL for triggers with a single arg. Fixes #266

Fix RE-SQL for triggers with a single arg. Fixes #2668 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52840d68a891720fb266c3ac6b58b7f407fa7553 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/tables/trigg

Re: [pgAdmin4][Patch]: Fix internal server error on Trigger module

Thanks, applied. On Wed, Aug 30, 2017 at 12:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where it was throwing internal server > error on SQL panel when trigger is of update event type. > > I have updated sample code to re-produc

pgAdmin 4 commit: Improve datamodel validations for default Validator i

Improve datamodel validations for default Validator if user (developer) do not implement validate function in datamodel. Fixes #2670 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dbf760c6e7390cc0de5cd57e3068f009a72cdf9f Author: Harshal Dhuma

Re: Fix for RM2670

Thanks, applied. On Wed, Aug 30, 2017 at 2:08 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find minor patch to improve datamodel validations for default > Validator if user (developer) do not implement validate function in > datamodel. > Without this default valid

pgAdmin 4 commit: Fix display of types in GPDB.

Fix display of types in GPDB. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eae6f0427c7c2e3350dd67aacc62a1053b2dd1a3 Author: Dave Cramer Modified Files -- .../servers/databases/schemas/tables/utils.py | 5 + .../datatyp

Re: fix get_types for GPDB

Thanks, applied. As with other GPDB patch, I couldn't test it fully, so please keep an eye out for issues. On Wed, Aug 30, 2017 at 7:29 PM, Dave Cramer wrote: > This patch allows create column to see available types in the dropdown > > > Dave Cramer > -- Dave Page Blog: http://pgsnake.blogsp

pgAdmin 4 commit: Define the proper NODE_ENV environment during running

Define the proper NODE_ENV environment during running the webpack. Using the webpack.DefinePlugin during the development build too, not just in production build. Fixes #2596. Also - passing option 'warning: false' for UglifyJsPlugin, which will not show warning messages on the console during the

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

On Tue, Aug 29, 2017 at 5:55 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Ashesh, > > Can you please review this patch please? > Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://

Build failed in Jenkins: pgadmin4-master-python35 #303

See Changes: [Dave Page] Improve datamodel validations for default Validator if user (developer) [Dave Page] Fix display of types in GPDB. [Ashesh Vashi] Define the proper NODE_ENV environment during

Array representation [pgAdmin4]

Hi Dave, Regarding RM2641 how should we represent array data types; With curly braces (like pgAdminIII) or without curly braces (only comma separated)? Currently in pgAdmin4 curly braces do not appear for text and int array data types however they do ap

pgAdmin 4 commit: 1) Fixed error in alertify.pgNotifier when server con

1) Fixed error in alertify.pgNotifier when server connection is lost. 2) Change styling of alertify.pgNotifier as we did for success, error and info. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47cf874460dd0fcd0f39af1772e4ba3913020ee1 Modi

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

Hi Ashesh, The issue is still not fixed, the reason is: In the first patch, I was setting `production` flag in `definePlugin` like: const definePlugin = new webpack.DefinePlugin({ 'process.env': { 'NODE_ENV': JSON.stringify('production'), }, }); in development mode but we had the discus

Jenkins build is back to normal : pgadmin4-master-python35 #304

See

pgAdmin 4 commit: Fix Copy so it still works after query results have b

Fix Copy so it still works after query results have been copied. Fixes #2637 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4393a7795eef18b311724f45b6c9c0dae01926d Author: Surinder Kumar Modified Files -- web/pgadmin/static/js/s

Re: [pgAdmin4][Patch]: RM_2637 - Copy functionality in Query Tool doesn't work after copying from Data Output

Thanks, applied. On Thu, Aug 31, 2017 at 6:28 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > While working on webpacking pgAdmin4, I had removed > `document.removeEventListener(...)` temporarily as it was not working in > `strict` mode, giving type error and I forgot to inc

Re: Array representation [pgAdmin4]

Hi On Thu, Aug 31, 2017 at 10:41 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Regarding RM2641 how should > we represent array data types; With curly braces (like pgAdminIII) or > without curly braces (only comma separate

Cascade styles not found 404 error

Hi, I just refreshed latest git repo and getting following error on start: INFO:pgadmin:Examining potential module: pgadmin.tools.user_management 2017-08-31 20:15:06,218: INFO pgadmin: Examining potential module: pgadmin.tools.sqleditor.command INFO:pgadmin:Examining potential module: pgadmin.tool

Error with webpack

Hi guys, I am getting following error with latest git version: Done in 1.75s. yarn run v0.21.3 $ yarn run webpack -- --config webpack.config.js yarn run v0.21.3 $ "/home/zangetsu/devel/tmp/pgadmin4/web/node_modules/.bin/webpack" --config webpack.config.js module.js:491 throw err; ^ Error:

Re: Error with webpack

Hi Ladislav, ​ After taking the latest pull from git HEAD: 1. Install all Python dependent packages `$ pip install -r requirements.txt` 2. Install all NPM packages $ cd web and run yarn install 3. Run pgAdmin4 server and browse to 'http://127.0.0.1:5050' `$ python pgAdmin4.py` Thanks,