[pgAdmin4][patch] extract generate_url function from node.js and collection.js

Hi hackers, We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached. Thanks, Violet & Sarah diff --git a/web/pgadmin/browser/static/js/collection.js b/web/pgadmin/browser/static/js/collection.js index f97edcc0..c0cb0eb4 100644 --- a/web/

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Surinder! Are you referring to the green message popup? If so, it also appears to be happening on master. We'll log a bug in our backlog and Redmine and prioritize it. We agree that it needs to be fixed, but don't think it's unrelated to this patch. Thanks! Violet & Sarah On Thu, Aug 10, 2017

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Here's the Redmine link https://redmine.postgresql.org/issues/2644 On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng wrote: > Hi Surinder! > > Are you referring to the green message popup? If so, it also appears to be > happening on master. We'll log a bug in our backlog and Redmine and > prioritiz

Is there a CLI for creating the object tree?

Hi. I want to write a tool for PG and I would like to recreate the object tree in pgadmin on the disk. For example. db schemas public tables some_table.sql I looked at the source code and it seems like you guys read the definitions from the D

[pgadmin4][patch] Fix the style of the alert when connecting/disconnecting from a server

Hi Hackers! This patch applies to RM 2644 . It fixes the styling of the checkmark area. Thanks! Sarah diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss b/web/pgadmin/static/scss/_alertify.overrides.scss index 8344956b..2c1e1d49 100644 --- a

Re: [pgAdmin4][RM2586] Cleanup feature test

Hi, Please find attached updated patch. In this patch I have removed unused imports. Regarding ajax calls on slow network/computer I have already taken care of those. Before sending first version of patch I tested this on Murtuza's machine and also tested on slow machine as well. Thanks, Harshal

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi! We fixed that issue and created a new patch . Thanks! On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng wrote: > Here's the Redmine link > > https://redmine.postgresql.org/issu

Re: [pgAdmin4][RM2586] Cleanup feature test

Great job on cleaning up the whole feature test suite! This is really going to benefit all of the developers a lot. Thanks, Matt & Sarah On Fri, Aug 11, 2017 at 12:24 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch. In this patch I have r

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: > Hi hackers, > > We tried to extract and refactor generate_url function in node.js and > collection.js. Please see the patch attached. > Khushboo, Please review this one. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise Pos

Re: [pgadmin4][patch] Fix the style of the alert when connecting/disconnecting from a server

Hi I reviewed this patch and it looks good to me. Thanks, Surinder On Fri, Aug 11, 2017 at 9:13 AM, Sarah McAlear wrote: > Hi Hackers! > > This patch applies to RM 2644 . > It fixes the styling of the checkmark area. > > Thanks! > Sarah > > >