[pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in Function, Procedure & Trigger Function modules where user was not able to update object if user changes the code definition. RM#2537 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmi

Re: Tree view icon samples

2017-07-06 Thread Anthony DeBarros
Hi, Looking forward to this and the other design updates coming! Regarding the PNG examples, I was wondering whether that is meant to show all the new icons being developed or no? When I expand the tree view in pgAdmin v1.4 I see quite a few not shown here, including Extensions, Foreign Data Wrapp

Re: Tree view icon samples

2017-07-06 Thread Dave Page
Hi On Thu, Jul 6, 2017 at 12:30 PM, Anthony DeBarros wrote: > > > Hi, > > Looking forward to this and the other design updates coming! Regarding the > PNG examples, I was wondering whether that is meant to show all the new > icons being developed or no? When I expand the tree view in pgAdmin v1.

pgAdmin 4 commit: Add some useful make targets for bundling and linting

2017-07-06 Thread Dave Page
Add some useful make targets for bundling and linting. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=592c70e6557bc8525fa426cfab3981054774fe75 Modified Files -- Makefile | 22 ++ 1 file changed, 14 insertions(+)

[pgAdmin4][Patch] Fix the issue in save password checkbox in "Create - Server" dialog.

2017-07-06 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue, where user is not able to save the password even if config.py has option "ALLOW_SAVE_PASSWORD = True". RM#2540 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_gr

pgAdmin 4 commit: Remove unused minimisation code

2017-07-06 Thread Dave Page
Remove unused minimisation code Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1291841d988050d99804e0a0f30396bee20675cf Modified Files -- Makefile | 3 --- web/tools/minimise.py | 65 --

pgAdmin 4 commit: UI tweaks for the query history.

2017-07-06 Thread Dave Page
UI tweaks for the query history. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2cbaaef7124b41be91bf34d704f0d3f61cf7b0c Author: Matthew Kleiman Modified Files -- .../jsx/history/detail/history_detail_message.jsx | 35 +- ..

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-07-06 Thread Dave Page
Thanks, applied. On Wed, Jul 5, 2017 at 4:31 PM, Matthew Kleiman wrote: > Sorry Dave. It looks like we had formatted the patch incorrectly. We have > recreated the patch. > > Matt and Sarah > > On Wed, Jul 5, 2017 at 10:49 AM, Dave Page wrote: > >> Hi >> >> On Wed, Jul 5, 2017 at 2:54 PM, Matth

pgAdmin 4 commit: In subnodes without dropdowns, the rows had smaller h

2017-07-06 Thread Dave Page
In subnodes without dropdowns, the rows had smaller height, making them appear unintentionally different than those with dropdowns. Make them the same. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5bedf088e880de8949d68f0b0564fff62f3d5a7 Au

Re: make subnode rows the same height for rows without dropdowns

2017-07-06 Thread Dave Page
Thanks, applied. On Wed, Jul 5, 2017 at 8:34 PM, George Gelashvili wrote: > Hello Hackers, > > We found that in subnodes without dropdowns, the rows had smaller height, > making them appear unintentionally different than those with dropdowns. An > example place in the app is Create Table -> > Se

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Dave Page
Hi On Thu, Jul 6, 2017 at 12:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in Function, Procedure & Trigger Function > modules where user was not able to update object if user changes the code > definition. > RM#2537 > This still doesn

pgAdmin 4 commit: Ensure the save password option is enabled when creat

2017-07-06 Thread Dave Page
Ensure the save password option is enabled when creating a server. Fixes #2540 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca7fe9a520468b7452a1efa44e1575bb0bb8c22d Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browse

Re: [pgAdmin4][Patch] Fix the issue in save password checkbox in "Create - Server" dialog.

2017-07-06 Thread Dave Page
Thanks, applied. On Thu, Jul 6, 2017 at 1:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue, where user is not able to save the > password even if config.py has option "ALLOW_SAVE_PASSWORD = True". > RM#2540 > > -- > Regards, > Murtuz

Build failed in Jenkins: pgadmin4-master-python35 #219

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add some useful make targets for bundling and linting. [Dave Page] Remove unused minimisation code [Dave Page] UI tweaks for the query history. [Dave Page] In subnodes without

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Murtuza Zabuawala
Hi Dave, This behaviour is from beginning I think and it is inherited from pgAdmin3. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 6, 2017 at 5:58 PM, Dave Page wrote: > Hi > > On Thu, Jul 6, 2017 at 12:04 PM, Murtuza Zabu

Build failed in Jenkins: pgadmin4-master-python26 #339

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add some useful make targets for bundling and linting. [Dave Page] Remove unused minimisation code [Dave Page] UI tweaks for the query history. [Dave Page] In subnodes without

Build failed in Jenkins: pgadmin4-master-python34 #209

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Remove unused minimisation code [Dave Page] UI tweaks for the query history. [Dave Page] In subnodes without dropdowns, the rows had smaller height, making them [Dave Page] E

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Dave Page
Maybe, but it's pretty clearly broken, so whilst you're fixing the template for that value, it would make sense to fix the UI too :-) On Thu, Jul 6, 2017 at 1:42 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > This behaviour is from beginning I think and it is in

Fix clear history option [pgAdmin4][RM2535]

2017-07-06 Thread Harshal Dhumal
Hi, Please find attached patch to fix clear history functionality in query tool. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/history/history_collection.js b/web/pgadmin/static/js

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-07-06 Thread Dave Page
And, Houston, we have a problem. The layout is quite broken on IE - which of course we're working to use on Windows. Can you take a look ASAP please Matt & friends? Screenshot attached. On Thu, Jul 6, 2017 at 1:08 PM, Dave Page wrote: > Thanks, applied. > > On Wed, Jul 5, 2017 at 4:31 PM, Matth

[pgadmin-hackers][pgAdmin4][Patch] Make karma test results output to browser

2017-07-06 Thread Sarah McAlear
Hi Hackers! Attached is a minor patch that enables pretty html output of our karma test results. While running yarn test:karma, visit localhost:9876/debug.html to see test output. Thanks, Matt and Sarah diff --git a/web/karma.conf.js b/web/karma.conf.js index 39697ca7..e9b0e062 100644 --- a/web/k

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-07-06 Thread Robert Eckhardt
Working on it. -- Rob On Thu, Jul 6, 2017 at 10:03 AM, Dave Page wrote: > And, Houston, we have a problem. The layout is quite broken on IE - which > of course we're working to use on Windows. Can you take a look ASAP please > Matt & friends? > > Screenshot attached. > > On Thu, Jul 6, 2017 at

Windows testing required: Updated runtime

2017-07-06 Thread Dave Page
All, I've put an interim build of pgAdmin 4 at https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe for Windows users. This build uses a work in progress patch to replace the slow Qt components with ActiveQt + the Microsoft web browser control to significantly improve performance. The versio

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Murtuza Zabuawala
Sorry, I think my last statement was misleading. No, It's not broken, I meant the behaviour is taken from pgAdmin3, It is disabled by default but once you change the value of "Returns a set?" (under Options tab) to Yes while creating new function it gets enabled. -- Regards, Murtuza Zabuawala Ent

[pgadmin-hackers][patch] delete icon width in security labels form

2017-07-06 Thread Joao De Almeida Pereira
Hello Hackers, We found a discrepancy with the width of inserted columns in some backform tables. It is at least present in Create Table -> Security [tab] -> clicking [+] for new rows under each of Privileges and Security Labels. In this case, the cell containing the delete icon is spaced differen

Re: Windows testing required: Updated runtime

2017-07-06 Thread Melvin Davidson
Dave, The good and the ugly. The good.I download and installed the patch from https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe I restarted Windows and it now starts in 15 secs, down from 20 secs. The ugly.The version is not usable. The screen/menu is incomprehensible. System Details:Windo

Re: Windows testing required: Updated runtime

2017-07-06 Thread Dave Page
Hi On Thu, Jul 6, 2017 at 4:18 PM, Melvin Davidson wrote: > *Dave,* > > *The good and the ugly.* > > *The good.* > > *I download and installed the patch from > * > *https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe >

Re: Windows testing required: Updated runtime

2017-07-06 Thread George Weaver
Hi Dave, Much improved load time - 14 seconds - Windows 10 x64. When I tried to query all the rows in a table using the context menu, the new tab is added and can be moved to a different window, but the following error was generated and the window was blank. Cheers, George On 06/07/2017 9

Re: Windows testing required: Updated runtime

2017-07-06 Thread Paolo Saudin
Much faster here too! I get the same error when trying to load all data from context menĂ¹, [image: Immagine incorporata 1] but it works if I choose Script -> SELECT Script Thanks, Paolo 2017-07-06 18:13 GMT+02:00 George Weaver : > Hi Dave, > > Much improved load time - 14 seconds - Windows 10

Re: Windows testing required: Updated runtime

2017-07-06 Thread Shira Bezalel
On Thu, Jul 6, 2017 at 7:59 AM, Dave Page wrote: > All, > > I've put an interim build of pgAdmin 4 at https://developer.pgadmin.o > rg/~dpage/pgadmin4-1.5-x86.exe for Windows users. This build uses a work > in progress patch to replace the slow Qt components with ActiveQt + the > Microsoft web br

Re: Windows testing required: Updated runtime

2017-07-06 Thread Fahar Abbas
Hi Dave! I also tested Windows installers and script error displayed and here is the RM ID: -- https://redmine.postgresql.org/issues/2542 On Thu, Jul 6, 2017 at 10:01 PM, Shira Bezalel wrote: > > > On Thu, Jul 6, 2017 at 7:59 AM, Dave Page wrote: > >> All, >> >> I've put an interim build o

pgAdmin 4 commit: Added support of Declarative Partitioning (Range, Lis

2017-07-06 Thread Akshay Joshi
Added support of Declarative Partitioning (Range, List) for PostgreSQL 10. This allows the user to create partitioned table and it's partitions. - Edit partitions, Create/Listing of constraints, rules, triggers under partitions. (Implemented by Harshal) - Updating browser tree node when crea

Build failed in Jenkins: pgadmin4-master-python26 #340

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Added support of Declarative Partitioning (Range, List) for PostgreSQL -- [...truncated 480.52 KB...] TableUpdateTest

Build failed in Jenkins: pgadmin4-master-python36 #217

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Added support of Declarative Partitioning (Range, List) for PostgreSQL -- [...truncated 486.53 KB...] ResourceGroupsD

Build failed in Jenkins: pgadmin4-master-python34 #210

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Added support of Declarative Partitioning (Range, List) for PostgreSQL -- [...truncated 486.32 KB...] SchemaPutTestCa

Build failed in Jenkins: pgadmin4-master-python33 #219

2017-07-06 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Added support of Declarative Partitioning (Range, List) for PostgreSQL -- [...truncated 486.51 KB...]