[pgAdmin4][patch]: Fixed RM #2507 : REVOKE privileges do not display in SQL tab for the function

Hi, Please find the attached patch to fix the RM #2507: REVOKE privileges do not display in SQL tab for the function Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/functi

Re: [pgadmin-hackers][patch] History Detail Pane

Hi On Fri, Jun 23, 2017 at 11:39 PM, George Gelashvili wrote: > On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar sedb.com> wrote: > >> Hi >> >> Review comments: >> >> ​1. ​ >> Can we set "message"(in message detail) style property scroll to >> ​'​ >> auto >> ​'​ >> instead of >> ​'​ >> scroll >

[pgAdmin4][Patch]: Fixed RM #1920 - [Web Based] Unexpected behaviour observed when connect server with save password option.

Hi, Please find the attached patch to fix RM #1920 - [Web Based] Unexpected behaviour observed when connect server with save password option. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py index d88363a.

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Hi Looks good, except that when I close the dashboard panel, it continues to run the queries to update the graphs until I change the selected treeview node. Can we stop it immediately? On Mon, Jun 26, 2017 at 1:56 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch for the feature

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

Thanks, patch applied. On Mon, Jun 26, 2017 at 2:05 AM, Surinder Kumar wrote: > Hi > > Changes: > > 1. Replace Jinja {{ url_for }} with js 'url_for' > > 2. While minifying JS using webpack, the code to open QueryToolPanel and > DatagridPanel wasn't working. This is fixed. > > Please find attached

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in Sqleditor module

Thanks, patch applied. On Mon, Jun 26, 2017 at 2:45 AM, Surinder Kumar wrote: > Hi > > Changes: > > 1. Replace Jinja {{ url_for }} with js 'url_for' > > 2. While minifying JS using webpack, I got couple of errors(variables > undefined) in browser for generated sqleditor.js, so declared those > va

pgAdmin 4 commit: Use client-side url_for in the sql editor and data gr

Use client-side url_for in the sql editor and data grid modules. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cfb4b115732f353bc0bf723d87968ed250af063f Author: Surinder Kumar Modified Files -- web/pgadmin/tools/datagrid/__init__

pgAdmin 4 commit: Ensure revoked public privileges are displayed in the

Ensure revoked public privileges are displayed in the RE-SQL for functions. Fixes #2507 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4e77deda466f460debbe37044d44a0c8ad456fa Author: Khushboo Vashi Modified Files -- .../databas

Re: [pgAdmin4][patch]: Fixed RM #2507 : REVOKE privileges do not display in SQL tab for the function

Thanks, patch applied. On Mon, Jun 26, 2017 at 3:25 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix the RM #2507: REVOKE privileges do not > display in SQL tab for the function > > Thanks, > Khushboo > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnak

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

I'm sorry, it needs rebasing again. If you can do it quickly, I'll make sure it's the next patch I work on in that area. Thanks. On Mon, Jun 26, 2017 at 5:16 AM, Harshal Dhumal wrote: > Hi Dave, > > Please find updated rebased patch for RM2137 > > On Fri, Jun 23, 2017 at 9:00 PM, Dave Page wrot

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

yes i'm working on that only :) -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 26, 2017 at 5:22 PM, Dave Page wrote: > I'm sorry, it needs rebasing again. If you can do it quickly, I'll > make sure it'

pgAdmin 4 commit: Ensure saved passwords are effective immediately, not

Ensure saved passwords are effective immediately, not just following a restart when first saved. Fixes #1920 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=27bc5c803f1b92dd8e498e751e2e3bf17f558d62 Author: Khushboo Vashi Modified Files -

Re: [pgAdmin4][Patch]: Fixed RM #1920 - [Web Based] Unexpected behaviour observed when connect server with save password option.

Thanks, patch applied. On Mon, Jun 26, 2017 at 5:24 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix RM #1920 - [Web Based] Unexpected > behaviour observed when connect server with save password option. > > Thanks, > Khushboo -- Dave Page Blog: http://pgsnake.blogspo

Build failed in Jenkins: pgadmin4-master-python27 #202

See Changes: [Dave Page] Ensure saved passwords are effective immediately, not just following a -- [...truncated 289.57 KB...] Update materialized view under sch

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

Hi Dave, Yes, It makes sense to use the same approach at both ends. I have modified the server file to use the same regex approach. Attached is the patch for the same. Please review. Regards, Atul On Sun, Jun 25, 2017 at 6:32 PM, Dave Page wrote: > Hi > > There are still validation issues unfo

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

Hi Dave, Due to this commit all features test cases which requires query tool are failing. Reason for this is additional dummy iframe added in panel. @@ -463,7 +501,16 @@ define([ * create new panel and add it to the dashboard panel. */ var dashboardPanel = pgBrowser.docker.findPanels(

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

Hi Please find attached patch to revert the query tool/datagrid panel changes. I found the frame assigned to panel after its creation is set to 'undefined' from somewhere in code(after webpack minify) so earlier implementation is right. I will fix and send it along webpack patch. Thanks, Surinde

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation in the datagrid module

Thanks, applied. On Mon, Jun 26, 2017 at 12:10 PM, Surinder Kumar wrote: > Hi > > Please find attached patch to revert the query tool/datagrid panel changes. > > I found the frame assigned to panel after its creation is set to 'undefined' > from somewhere in code(after webpack minify) so earlier

pgAdmin 4 commit: Un-break query tool feature tests.

Un-break query tool feature tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4781cdcbfcdf4436a71fdc9e6e1782303d1bc2 Author: Surinder Kumar Modified Files -- .../tools/datagrid/templates/datagrid/js/datagrid.js | 18 ++---

[pgAdmin4]: Webpacking of static JS/CSS

Hi All, I and Ashesh come up with following approach; *Divide the JS modules in following components:* ​1. ​ Tools ​(tools.js)​ - It will contain all JS modules under tools directory ​2. ​ Browser ​(browser.js)​ - It will contain all JS modules under browser directory ​3. ​ grid.js - It will

pgAdmin 4 commit: Add support for the hostaddr connection parameter. Th

Add support for the hostaddr connection parameter. This helps us play nicely with Kerberos/SSPI and friends. Fixes #2191 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15cb9fc35b41736a331a452b9303a79e8f13ee36 Author: Atul Sharma Modified Fi

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

Hi Awesome - that works nicely. Patch committed. Congratulations on your first feature! Regards, Dave. On Mon, Jun 26, 2017 at 8:56 AM, Atul Sharma wrote: > Hi Dave, > > Yes, It makes sense to use the same approach at both ends. I have modified > the server file to use the same regex approach.

Re: [pgadmin-hackers][patch] History Detail Pane

On Mon, Jun 26, 2017 at 10:08 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Surinder, > > You can find our answers inline and attached the patch with the change of > scrolls from "scroll" to "auto" > > On Mon, Jun 26, 2017 at 4:47 AM, Surinder Kumar > wrote: >> >> H

Jenkins build is back to normal : pgadmin4-master-python27 #203

See

Build failed in Jenkins: pgadmin4-master-python26 #319

See Changes: [Dave Page] Add support for the hostaddr connection parameter. This helps us play -- [...truncated 292.60 KB...] Update materialized view under sche

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Hi, Please find the attached updated patch. Thanks, Khushboo On Mon, Jun 26, 2017 at 5:08 PM, Dave Page wrote: > Hi > > Looks good, except that when I close the dashboard panel, it continues > to run the queries to update the graphs until I change the selected > treeview node. Can we stop it i