[opensource-dev] Review Request: STORM-323: redundant popups

2011-03-24 Thread Lance Corrimal
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/230/ --- Review request for Viewer. Summary --- Fixed the redundant "You have a

Re: [opensource-dev] Review Request: STORM-323: redundant popups

2011-03-24 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/230/ --- (Updated March 24, 2011, 4:34 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-323: redundant popups

2011-03-24 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/230/#review493 --- Ship it! - Oz On March 24, 2011, 4:34 a.m., Lance Corrimal wrot

Re: [opensource-dev] Review Request: STORM-323: redundant popups

2011-03-24 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/230/#review495 --- Ship it! Looks good. Not your fault, but I can't resist to menti

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review496 --- I think that pressing the Speak button or the fly-out button shoul

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Jonathan Yap
> On March 24, 2011, 6:04 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/default/xui/en/notifications.xml, line 6616 > > > > > > I guess you meant that *voice* is enabled by default, not microphone. > >

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Vadim ProductEngine
> On March 24, 2011, 6:04 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/default/xui/en/notifications.xml, line 6616 > > > > > > I guess you meant that *voice* is enabled by default, not microphone. > >

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/ --- (Updated March 24, 2011, 9:10 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review499 --- Looks good now. I only have one question, see below. indra/newvi

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review500 --- I deleted the line in the mouse-up speak button code that turns of

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Jonathan Yap
> On March 24, 2011, 11:04 a.m., Jonathan Yap wrote: > > I deleted the line in the mouse-up speak button code that turns off the > > speak button hint. That line was there when I incorrectly though the speak > > button might be on at viewer startup. I could not get the diff to update > > so

Re: [opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

2011-03-24 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/#review502 --- Ship it! No more objections. Thanks, Jonathan! To avoid problems

[opensource-dev] Good Job: Autobuild

2011-03-24 Thread Brandon Husbands
Compiled flawlessly. Now i can get back to helping =) Dim. -- --- This email is a private and confidential communication. Any use of email may be subject to the laws and reg

[opensource-dev] PO Build available

2011-03-24 Thread Philippe (Merov) Bossut
Hi, PO build of the day available at: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/225012/index.html Containing fixes/implementations for: * STORM-399 : Users that has chatted within chat range of the user in-world are not added to Recent tab