RFR: 8246431: java/net/httpclient/PathSubscriber tests fail due to missing FilePermission

2020-06-04 Thread Julia Boes
Hi, The tests in java/net/httpclient/PathSubscriber don't grant certain file permissions to test library classes. The tests succeed by chance when the compiled library classes are placed under ${test.classes}, but occasionally they fail, depending on which test target compiles the library fir

RFR[8246132]: 'AsynchronousSocketChannelNAPITest failing with a NotYetConnectedException'

2020-06-04 Thread Patrick Concannon
Hi, Could someone please review my patch for JDK-8246132 - 'AsynchronousSocketChannelNAPITest failing with a NotYetConnectedException' ? AsynchronousSocketChannelNAPITest sometimes fails with a NotYetConnectedException while trying to read data after connecting. This is fix changes the connect

Re: RFR: 8246431: java/net/httpclient/PathSubscriber tests fail due to missing FilePermission

2020-06-04 Thread Daniel Fuchs
Hi Julia, Thanks for taking care of this. Your propose changes look good to me. best regards, -- daniel On 04/06/2020 17:24, Julia Boes wrote: Hi, The tests in java/net/httpclient/PathSubscriber don't grant certain file permissions to test library classes. The tests succeed by chance when

Re: RFR[8246132]: 'AsynchronousSocketChannelNAPITest failing with a NotYetConnectedException'

2020-06-04 Thread Daniel Fuchs
Hi Patrick, Looks good, but for one thing. Throwing in the failed() callback will probably accomplish nothing since that is likely be called asynchronously in some background thread. So if the connect doesn't succeed immediately but fail instead at a later time, the test will block forever waiti

Re: RFR[8246132]: 'AsynchronousSocketChannelNAPITest failing with a NotYetConnectedException'

2020-06-04 Thread Alan Bateman
On 04/06/2020 22:08, Daniel Fuchs wrote: Hi Patrick, Looks good, but for one thing. Throwing in the failed() callback will probably accomplish nothing since that is likely be called asynchronously in some background thread. So if the connect doesn't succeed immediately but fail instead at a