Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

2016-02-18 Thread Michael McMahon
Hi Paul Thanks for the review. Some comments below On 17/02/16 15:26, Paul Sandoz wrote: On 4 Feb 2016, at 17:14, Michael McMahon mailto:michael.x.mcma...@oracle.com>> wrote: Hi, The following webrevs are for the initial implementation of JEP 110. Most of it is in the jdk repository with

Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

2016-02-18 Thread Paul Sandoz
> On 18 Feb 2016, at 16:37, Michael McMahon > wrote: > >> When building a request how does one set multiple values for a header? >> setHeaders overwrites, does one used headers(…) instead? >> > > headers(String, String) > and headers(String ...) both accumulate headers > What headers would

Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

2016-02-18 Thread Michael McMahon
On 18/02/16 16:06, Paul Sandoz wrote: On 18 Feb 2016, at 16:37, Michael McMahon wrote: When building a request how does one set multiple values for a header? setHeaders overwrites, does one used headers(…) instead? headers(String, String) and headers(String ...) both accumulate headers Wh

Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

2016-02-18 Thread Paul Sandoz
> On 18 Feb 2016, at 17:34, Michael McMahon > wrote: > > On 18/02/16 16:06, Paul Sandoz wrote: >>> On 18 Feb 2016, at 16:37, Michael McMahon >>> wrote: >>> When building a request how does one set multiple values for a header? setHeaders overwrites, does one used headers(…) instea

Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

2016-02-18 Thread Roger Riggs
Hi Michael, A few comments, nothing severe. Several properties are used in the implementation; is it significant that some are sun.net and others java.net? For the new package can we get away from using the "sun." prefix? Exchange.java: 89 in cancel(), exchImpl may be null since it is not