> -Original Message-
> From: Serge Hallyn [mailto:serge.hal...@ubuntu.com]
> Sent: Tuesday, July 02, 2013 5:27 PM
> To: Purcareata Bogdan-B43198
> Cc: lxc-devel@lists.sourceforge.net
> Subject: Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check
>
> Quoting Bogdan Purcareat
Quoting Purcareata Bogdan-B43198 (b43...@freescale.com):
> > -Original Message-
> > From: Serge Hallyn [mailto:serge.hal...@ubuntu.com]
> > Sent: Tuesday, July 02, 2013 5:27 PM
> > To: Purcareata Bogdan-B43198
> > Cc: lxc-devel@lists.sourceforge.net
> > Subject: Re: [lxc-devel] [PATCH] test
> -Original Message-
> From: Serge Hallyn [mailto:serge.hal...@ubuntu.com]
> Sent: Wednesday, July 03, 2013 3:46 PM
> To: Purcareata Bogdan-B43198
> Cc: lxc-devel@lists.sourceforge.net
> Subject: Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check
>
> Quoting Purcareata Bog
Quoting Purcareata Bogdan-B43198 (b43...@freescale.com):
> So lxcapi_set_cgroup_item() shouldn't return ret instead of (ret == 0)?
No. Then it would return "(bool)0 -> false", whereas currently it
returns "(ret == 0) -> true"
-serge
--
Signed-off-by: Bogdan Purcareata
---
src/lxc/lxccontainer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c
index 677fa56..4e71fb1 100644
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -1393,7 +1393,7 @@ static b
Quoting Bogdan Purcareata (bogdan.purcare...@freescale.com):
> Signed-off-by: Bogdan Purcareata
The subject was supposed to be "Serge is a blind idiot" :)
Acked-by: Serge E. Hallyn
thanks!
> ---
> src/lxc/lxccontainer.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --g
Quoting Serge Hallyn (serge.hal...@ubuntu.com):
> Quoting Purcareata Bogdan-B43198 (b43...@freescale.com):
> > So lxcapi_set_cgroup_item() shouldn't return ret instead of (ret == 0)?
>
> No. Then it would return "(bool)0 -> false", whereas currently it
> returns "(ret == 0) -> true"
>
> -serge
On 2013/4/12 5:40, Serge Hallyn wrote:
> Quoting richard -rw- weinberger (richard.weinber...@gmail.com):
>> On Thu, Apr 11, 2013 at 7:02 PM, Eric W. Biederman
>> wrote:
>>> Serge Hallyn writes:
>>>
Quoting Eric W. Biederman (ebied...@xmission.com):
After creating the /dev/ttyN we chown
