[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 346904. mbenfield added a comment. Herald added subscribers: llvm-commits, lldb-commits, kbarton, hiraditya, nemanjai. Herald added projects: LLDB, LLVM. Don't warn for reference or dependent types (fixing false positives). Also fix a few places where this

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield created this revision. Herald added subscribers: pengfei, lebedev.ri, kbarton, hiraditya, nemanjai. Herald added a reviewer: lebedev.ri. mbenfield requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This is in prepar

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield added a comment. Herald added a subscriber: JDevlieghere. Several variables I have just removed outright, including llvm/lib/Target/X86/X86FloatingPoint.cpp: STDeadDefs lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp: fp_bytes lldb/source/Interpreter/CommandInterpreter.cpp: actual_cmd_n

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield added a comment. In D102942#2774819 , @dblaikie wrote: > Sure, all sounds good - if you can, please reach out to the authors of any of > the semantics changing changes (the ones related to the `Changed` values in > transformations) to see if t

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield added a comment. I also heard via email from Amara Emerson that the change is fine for similar reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102942/new/ https://reviews.llvm.org/D102942 _

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 347111. mbenfield added a comment. Move fixes into a separate change https://reviews.llvm.org/D102942. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 Files: clan

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2792854 , @Abpostelnicu wrote: > I think there is a false positive with this @george.burgess.iv: > In this >

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2795966 , @sberg wrote: > Is it intentional that this warns about volatile variables as in Yes, volatile was intentional. Alright, I will add a test for this case. Repository: rG LLVM Github Monorepo CHANGES SIN