[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka created this revision. kubabrecka added reviewers: clayborg, jasonmolenda, jingham. kubabrecka added subscribers: lldb-commits, zaks.anna. kubabrecka set the repository for this revision to rL LLVM. kubabrecka added a project: Sanitizers. https://reviews.llvm.org/D27012 will add more re

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added a comment. Thanks for these comments, I'll have them run by more people before committing this (I'm not a native English speaker). These really need to be as user-focused as possible, so I'm really against stuff like "not owned pointer", because that's not something we should

[Lldb-commits] [lldb] r267726 - Decorate TSan tests with "@skipUnlessThreadSanitizer" which skips the tests if the selected compiler can't compile with "-fsanitize=thread".

Author: kuba.brecka Date: Wed Apr 27 10:26:27 2016 New Revision: 267726 URL: http://llvm.org/viewvc/llvm-project?rev=267726&view=rev Log: Decorate TSan tests with "@skipUnlessThreadSanitizer" which skips the tests if the selected compiler can't compile with "-fsanitize=thread". Modified: ll

[Lldb-commits] [lldb] r267894 - Provide location information (file name, line number) in TSan reports about global variables.

Author: kuba.brecka Date: Thu Apr 28 10:27:10 2016 New Revision: 267894 URL: http://llvm.org/viewvc/llvm-project?rev=267894&view=rev Log: Provide location information (file name, line number) in TSan reports about global variables. Added: lldb/trunk/packages/Python/lldbsuite/test/functiona

[Lldb-commits] [lldb] r268192 - Add thread numbers into ASan thread names.

Author: kuba.brecka Date: Sun May 1 06:23:04 2016 New Revision: 268192 URL: http://llvm.org/viewvc/llvm-project?rev=268192&view=rev Log: Add thread numbers into ASan thread names. Modified: lldb/trunk/source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp Modified: lldb/trunk/source/Plugi

[Lldb-commits] [lldb] r268193 - Improve wording and capitalization of TSan thread names.

Author: kuba.brecka Date: Sun May 1 06:26:06 2016 New Revision: 268193 URL: http://llvm.org/viewvc/llvm-project?rev=268193&view=rev Log: Improve wording and capitalization of TSan thread names. Modified: lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntim

[Lldb-commits] [lldb] r268194 - Update test for r268192.

Author: kuba.brecka Date: Sun May 1 06:32:10 2016 New Revision: 268194 URL: http://llvm.org/viewvc/llvm-project?rev=268194&view=rev Log: Update test for r268192. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py Modified: lldb/trunk/packages/Py

[Lldb-commits] [lldb] r270358 - Fix an incorrectly used locking in HistoryThread and HistoryUnwind, where unique_lock's release() was called causing the mutex to stay locked.

Author: kuba.brecka Date: Sun May 22 07:24:38 2016 New Revision: 270358 URL: http://llvm.org/viewvc/llvm-project?rev=270358&view=rev Log: Fix an incorrectly used locking in HistoryThread and HistoryUnwind, where unique_lock's release() was called causing the mutex to stay locked. Modified:

[Lldb-commits] [lldb] r270359 - Revert r270358 ("Fix an incorrectly used locking in HistoryThread and HistoryUnwind").

Author: kuba.brecka Date: Sun May 22 09:05:28 2016 New Revision: 270359 URL: http://llvm.org/viewvc/llvm-project?rev=270359&view=rev Log: Revert r270358 ("Fix an incorrectly used locking in HistoryThread and HistoryUnwind"). Modified: lldb/trunk/source/Plugins/Process/Utility/HistoryThread.

[Lldb-commits] [lldb] r270363 - A better fix of incorrectly used locking in HistoryThread and HistoryUnwind.

Author: kuba.brecka Date: Sun May 22 09:19:11 2016 New Revision: 270363 URL: http://llvm.org/viewvc/llvm-project?rev=270363&view=rev Log: A better fix of incorrectly used locking in HistoryThread and HistoryUnwind. Modified: lldb/trunk/source/Plugins/Process/Utility/HistoryThread.cpp lld

[Lldb-commits] [lldb] r270364 - Reword ThreadSanitizer message for invalid mutex reports.

Author: kuba.brecka Date: Sun May 22 09:32:45 2016 New Revision: 270364 URL: http://llvm.org/viewvc/llvm-project?rev=270364&view=rev Log: Reword ThreadSanitizer message for invalid mutex reports. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tsan/multiple/TestTsanMulti

[Lldb-commits] [lldb] r270365 - Reword ThreadSanitizer messages to use a lowercase 't' in thread names when in the middle of a sentence.

Author: kuba.brecka Date: Sun May 22 09:56:33 2016 New Revision: 270365 URL: http://llvm.org/viewvc/llvm-project?rev=270365&view=rev Log: Reword ThreadSanitizer messages to use a lowercase 't' in thread names when in the middle of a sentence. Modified: lldb/trunk/source/Plugins/Instrumenta

[Lldb-commits] [lldb] r270588 - Improve wording in TSan reports involving global variables. Don't repeat hex addresses that are the same.

Author: kuba.brecka Date: Tue May 24 12:47:23 2016 New Revision: 270588 URL: http://llvm.org/viewvc/llvm-project?rev=270588&view=rev Log: Improve wording in TSan reports involving global variables. Don't repeat hex addresses that are the same. Modified: lldb/trunk/source/Plugins/Instrumen

[Lldb-commits] [lldb] r270608 - Reword the "Happened at" TSan-reported thread to contain a thread id.

Author: kuba.brecka Date: Tue May 24 15:35:28 2016 New Revision: 270608 URL: http://llvm.org/viewvc/llvm-project?rev=270608&view=rev Log: Reword the "Happened at" TSan-reported thread to contain a thread id. Modified: lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSa

[Lldb-commits] [lldb] r274621 - In AddressSanitizer and ThreadSanitizer, let's explicitly set the language of the expression we're evaluating.

Author: kuba.brecka Date: Wed Jul 6 06:46:20 2016 New Revision: 274621 URL: http://llvm.org/viewvc/llvm-project?rev=274621&view=rev Log: In AddressSanitizer and ThreadSanitizer, let's explicitly set the language of the expression we're evaluating. Modified: lldb/trunk/source/Plugins/Instr

Re: [Lldb-commits] [PATCH] D23150: [InstrumentationRuntime] Refactor the API (Part 2/N) (NFCI)

kubabrecka accepted this revision. kubabrecka added a comment. This revision is now accepted and ready to land. LGTM. While you’re at it, could you also reformat with clang-format? I noticed that the files inconsistently use curly braces on same line or new line. https://reviews.llvm.org/D231

Re: [Lldb-commits] [PATCH] D23043: [InstrumentationRuntime] Refactor the API (Part 1/N) (NFCI)

kubabrecka accepted this revision. kubabrecka added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] r264162 - Add ThreadSanitizer debugging support.

Author: kuba.brecka Date: Wed Mar 23 10:36:22 2016 New Revision: 264162 URL: http://llvm.org/viewvc/llvm-project?rev=264162&view=rev Log: Add ThreadSanitizer debugging support. This patch adds ThreadSanitizer support into LLDB: - Adding a new InstrumentationRuntime plugin, ThreadSanitizerRuntime,

[Lldb-commits] [lldb] r264168 - Follow-up for r264162 to fix the CMake build (update LLDBDependencies.cmake).

Author: kuba.brecka Date: Wed Mar 23 11:54:23 2016 New Revision: 264168 URL: http://llvm.org/viewvc/llvm-project?rev=264168&view=rev Log: Follow-up for r264162 to fix the CMake build (update LLDBDependencies.cmake). Modified: lldb/trunk/cmake/LLDBDependencies.cmake Modified: lldb/trunk/cmak

[Lldb-commits] [lldb] r264854 - Fix the ThreadSanitizer support to avoid creating empty SBThreads and to not crash when thread_id is unavailable. Plus a whitespace fix.

Author: kuba.brecka Date: Wed Mar 30 05:50:24 2016 New Revision: 264854 URL: http://llvm.org/viewvc/llvm-project?rev=264854&view=rev Log: Fix the ThreadSanitizer support to avoid creating empty SBThreads and to not crash when thread_id is unavailable. Plus a whitespace fix. Modified: lldb/

[Lldb-commits] [lldb] r265395 - Fix ThreadSanitizer test cases to work on OS X 10.10 and older.

Author: kuba.brecka Date: Tue Apr 5 08:57:42 2016 New Revision: 265395 URL: http://llvm.org/viewvc/llvm-project?rev=265395&view=rev Log: Fix ThreadSanitizer test cases to work on OS X 10.10 and older. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBa

[Lldb-commits] [lldb] r265396 - Enabling TSan tests, they should work now.

Author: kuba.brecka Date: Tue Apr 5 08:59:45 2016 New Revision: 265396 URL: http://llvm.org/viewvc/llvm-project?rev=265396&view=rev Log: Enabling TSan tests, they should work now. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py lldb/trun

[Lldb-commits] [lldb] r265401 - Enabling AddressSanitizer tests, they should work now.

Author: kuba.brecka Date: Tue Apr 5 09:14:07 2016 New Revision: 265401 URL: http://llvm.org/viewvc/llvm-project?rev=265401&view=rev Log: Enabling AddressSanitizer tests, they should work now. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py

[Lldb-commits] [lldb] r265400 - Fixing AddressSanitizer tests (update expectations for current ASan, make it work on OS X 10.10 and older).

Author: kuba.brecka Date: Tue Apr 5 09:13:22 2016 New Revision: 265400 URL: http://llvm.org/viewvc/llvm-project?rev=265400&view=rev Log: Fixing AddressSanitizer tests (update expectations for current ASan, make it work on OS X 10.10 and older). Modified: lldb/trunk/packages/Python/lldbsui

[Lldb-commits] [lldb] r265406 - Reverting r265401 ("Enabling AddressSanitizer tests, they should work now.")

Author: kuba.brecka Date: Tue Apr 5 10:22:00 2016 New Revision: 265406 URL: http://llvm.org/viewvc/llvm-project?rev=265406&view=rev Log: Reverting r265401 ("Enabling AddressSanitizer tests, they should work now.") Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/Tes

[Lldb-commits] [lldb] r265651 - Tentative fix (add `extern "C"` declarations to expression prefix) and printing evaluation errors for AddressSanitizer (both MemoryHistoryASan.cpp and AddressSanitizerR

Author: kuba.brecka Date: Thu Apr 7 05:02:43 2016 New Revision: 265651 URL: http://llvm.org/viewvc/llvm-project?rev=265651&view=rev Log: Tentative fix (add `extern "C"` declarations to expression prefix) and printing evaluation errors for AddressSanitizer (both MemoryHistoryASan.cpp and Address

[Lldb-commits] [lldb] r265652 - Simplify the ASan expression (follow-up for the previous commit, r265651).

Author: kuba.brecka Date: Thu Apr 7 05:07:45 2016 New Revision: 265652 URL: http://llvm.org/viewvc/llvm-project?rev=265652&view=rev Log: Simplify the ASan expression (follow-up for the previous commit, r265651). Modified: lldb/trunk/source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp M

[Lldb-commits] [lldb] r265656 - Enabling AddressSanitizer tests, they should pass now (and this time I mean it).

Author: kuba.brecka Date: Thu Apr 7 06:01:05 2016 New Revision: 265656 URL: http://llvm.org/viewvc/llvm-project?rev=265656&view=rev Log: Enabling AddressSanitizer tests, they should pass now (and this time I mean it). Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan

[Lldb-commits] [lldb] r265905 - Provide more information in ThreadSanitizer's JSON data. Move remaining TSan logic from SBThread to InstrumentationRuntime plugin.

Author: kuba.brecka Date: Sun Apr 10 13:57:38 2016 New Revision: 265905 URL: http://llvm.org/viewvc/llvm-project?rev=265905&view=rev Log: Provide more information in ThreadSanitizer's JSON data. Move remaining TSan logic from SBThread to InstrumentationRuntime plugin. Modified: lldb/trunk/

[Lldb-commits] [lldb] r265906 - Add a ThreadSanitizer testcase that tests multiple reported issues.

Author: kuba.brecka Date: Sun Apr 10 14:29:40 2016 New Revision: 265906 URL: http://llvm.org/viewvc/llvm-project?rev=265906&view=rev Log: Add a ThreadSanitizer testcase that tests multiple reported issues. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tsan/multiple/ l

Re: [Lldb-commits] [PATCH] D5556: [lldb] change MemoryHistoryASan::CreateInstance to not look into all modules, but only in the executable and libclang_rt.asan dynamic library

kubabrecka abandoned this revision. kubabrecka added a comment. This already landed a long time ago. http://reviews.llvm.org/D5556 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D6272: [lldb] Add @skipIfAddressSanitizerUnsupported test decorator

kubabrecka abandoned this revision. kubabrecka added a comment. This is now done properly by 1) checking out libcxx, and compiler-rt for an LLDB build, and 2) running tests against the just-built clang. http://reviews.llvm.org/D6272 ___ lldb-commit

[Lldb-commits] [lldb] r267133 - Renumber ThreadSanitizer-provided thread IDs to match LLDB thread numbers.

Author: kuba.brecka Date: Fri Apr 22 05:40:14 2016 New Revision: 267133 URL: http://llvm.org/viewvc/llvm-project?rev=267133&view=rev Log: Renumber ThreadSanitizer-provided thread IDs to match LLDB thread numbers. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tsan/thread_n