[Lldb-commits] [PATCH] D50298: Add unit test for StringLexer

jloser added inline comments. Comment at: unittests/Utility/StringLexerTest.cpp:25 + +TEST(StringLexerTest, HasAtLest) { + StringLexer l("foo"); Nit: typo in the test case name. Repository: rLLDB LLDB https://reviews.llvm.org/D50298

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jloser added a comment. I'm +1 for the direction here; I took a brief look but will look closely either later tonight or tomorrow before I approve. Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.l

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jloser added a comment. Sorry for the delay here; this patch LGTM! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

jloser created this revision. jloser added reviewers: MaskRay, serge-sans-paille, dblaikie. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, kosarev, ayermolo, sdasgup3, wenzhicui, wrengr, foad, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerb

[Lldb-commits] [PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa288d7f93770: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides (authored by jloser). Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

jloser added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652 auto data = + llvm::MutableArrayRef(static_cast(buf), bytes_read); serge-sans-paille wrote: > random nit: This could be rewritten as > > ``` > llvm::Mutable

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

jloser added a comment. Excited to see this come together! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153073/new/ https://reviews.llvm.org/D153073 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D133501: [lldb] Use std::size instead of llvm::array_lengthof

jloser created this revision. jloser added reviewers: MaskRay, dblaikie, kazu, clayborg. Herald added subscribers: StephenFan, atanasyan, jrtc27, kbarton, nemanjai, sdardis. Herald added a project: All. jloser requested review of this revision. Herald added a project: LLDB. Herald added a subscrib

[Lldb-commits] [PATCH] D133501: [lldb] Use std::size instead of llvm::array_lengthof

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b76631e768: [lldb] Use std::size instead of llvm::array_lengthof (authored by jloser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133501/new/ https://r