[Lldb-commits] [lldb] [lldb-dap] Implement a MemoryMonitor for macOS & Linux (PR #129332)

2025-03-01 Thread John Harrison via lldb-commits
@@ -0,0 +1,114 @@ +//===-- MemoryMonitor.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Creating well defined structures for DAP messages. (PR #129155)

2025-03-01 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,231 @@ +//===-- Protocol.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-01 Thread via lldb-commits
@@ -0,0 +1,38 @@ +import { ChildProcessWithoutNullStreams, spawn } from "child_process"; +import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree"; + +export class LinuxProcessTree extends BaseProcessTree { + protected override spawnProcess(): ChildProcessWithout

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add: show return value on step out (PR #106907)

2025-03-01 Thread via lldb-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/106907 >From c5dda32e63371b3f265a209fdcd5105a7c6197dc Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Wed, 12 Feb 2025 00:16:46 + Subject: [PATCH 1/5] [lldb-dap] Add Tests: Show children for return values --- .

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks, this LGTM! https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-01 Thread via lldb-commits
@@ -146,6 +146,9 @@ "windows": { "program": "./bin/lldb-dap.exe" }, +"variables": { + "PickProcess": "lldb-dap.pickProcess" Da-Viper wrote: use camelcase https://github.com/llvm/llvm-project/pull/128943 _

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-01 Thread via lldb-commits
@@ -0,0 +1,16 @@ +import { ChildProcessWithoutNullStreams, spawn } from "child_process"; +import { LinuxProcessTree } from "./linux-process-tree"; + +function fill(prefix: string, suffix: string, length: number): string { Da-Viper wrote: you could use the `padEnd

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-01 Thread via lldb-commits
@@ -0,0 +1,52 @@ +import * as path from "path"; +import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree"; +import { ChildProcessWithoutNullStreams, spawn } from "child_process"; + +export class WindowsProcessTree extends BaseProcessTree { + protected override sp

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-01 Thread via lldb-commits
@@ -517,6 +520,16 @@ "cwd": "^\"\\${workspaceRoot}\"" } }, + { +"label": "LLDB: Attach to Process", +"description": "", +"body": { + "type": "lldb-dap", + "request": "atta

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-01 Thread via lldb-commits
Da-Viper wrote: you could also validate the pid input in package.json from https://github.com/llvm/llvm-project/blob/038731c709c665634714275996559c21f36372f2/lldb/tools/lldb-dap/package.json#L359-L364 to ```json "pid": { "anyOf": [ { "type": "number", "description": "System

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-01 Thread Jonas Devlieghere via lldb-commits
@@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory const dbgOptions = { env: { -...executable?.options?.env, ...configEnvironment, ...env, }, }; -const dbgArgs = executable?.args ?? []; JDevlieghere

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add: show return value on step out (PR #106907)

2025-03-01 Thread via lldb-commits
Da-Viper wrote: > @Da-Viper Can you rebase and merge this PR by yourself? Or do you need > somebody to merge it on your behalf? I rebased but I do not have the necessary permissions to merge https://github.com/llvm/llvm-project/pull/106907 ___ lldb-

[Lldb-commits] [lldb] 8ec0d60 - [lldb-dap] Add: show return value on step out (#106907)

2025-03-01 Thread via lldb-commits
Author: Da-Viper Date: 2025-03-01T18:21:21-06:00 New Revision: 8ec0d60e28f77149eef9c865515b79bc0a5e8f41 URL: https://github.com/llvm/llvm-project/commit/8ec0d60e28f77149eef9c865515b79bc0a5e8f41 DIFF: https://github.com/llvm/llvm-project/commit/8ec0d60e28f77149eef9c865515b79bc0a5e8f41.diff LOG:

[Lldb-commits] [lldb] Fix a bug copying the stop hooks from the dummy target. (PR #129340)

2025-03-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/129340 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement a MemoryMonitor for macOS & Linux (PR #129332)

2025-03-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/129332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding server mode support to lldb-dap VSCode extension. (PR #128957)

2025-03-01 Thread John Harrison via lldb-commits
@@ -15,13 +13,14 @@ import { DisposableContext } from "./disposable-context"; export class LLDBDapExtension extends DisposableContext { constructor() { super(); +const factory = new LLDBDapDescriptorFactory(); +this.pushSubscription(factory); ashg

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-03-01 Thread Hu Jialun via lldb-commits
https://github.com/SuibianP updated https://github.com/llvm/llvm-project/pull/121269 >From 20fbed5a080a90aabe1d3f8c316af56e91284c1e Mon Sep 17 00:00:00 2001 From: Jialun Hu Date: Mon, 24 Feb 2025 22:10:17 +0800 Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows Currently, the name

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-01 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,15 @@ +import { LinuxProcessTree } from "./linux-process-tree"; + +function fill(prefix: string, suffix: string, length: number): string { + return prefix + suffix.repeat(length - prefix.length); +} + +export class DarwinProcessTree extends LinuxProcessTree { + protec

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-03-01 Thread Hu Jialun via lldb-commits
@@ -1,11 +1,13 @@ #include #include -#include + +#include SuibianP wrote: Turns out Apple does not yet support C11 `threads.h`. https://github.com/llvm/llvm-project/blob/7e8a06cfa4a2951b8ee77e19e34926e6e535b4d1/clang/lib/Basic/Targets/OSTargets.cpp#L61-L62

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-03-01 Thread Hu Jialun via lldb-commits
https://github.com/SuibianP edited https://github.com/llvm/llvm-project/pull/121269 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding server mode support to lldb-dap VSCode extension. (PR #128957)

2025-03-01 Thread John Harrison via lldb-commits
ashgti wrote: I filed #129283 to track some of the improvements discussed in the comments so they're not lost. https://github.com/llvm/llvm-project/pull/128957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb-dap] Creating well defined structures for DAP messages. (PR #129155)

2025-03-01 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,231 @@ +//===-- Protocol.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add terminfo dependency for ncurses support (PR #126810)

2025-03-01 Thread Jordan R AW via lldb-commits
https://github.com/ajordanr-google milestoned https://github.com/llvm/llvm-project/pull/126810 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug copying the stop hooks from the dummy target. (PR #129340)

2025-03-01 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/129340 >From 02e908312518e85f1d637529c9f62e3dd9551035 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 28 Feb 2025 15:55:03 -0800 Subject: [PATCH 1/4] Fix a bug copying the stop hooks from the dummy target. We d

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add: show return value on step out (PR #106907)

2025-03-01 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. LGTM! Thank you 🙂 https://github.com/llvm/llvm-project/pull/106907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add: show return value on step out (PR #106907)

2025-03-01 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @Da-Viper Can you rebase and merge this PR by yourself? Or do you need somebody to merge it on your behalf? https://github.com/llvm/llvm-project/pull/106907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll