[Lldb-commits] [lldb] [LLDB] Add framework for Data Inspection Language (DIL) work. (PR #115666)

2024-11-12 Thread Pavel Labath via lldb-commits
labath wrote: +1 to what Jim said. You could keep `GetValueForVariableExpressionPath` as a single entry point, but then implement it as something like `if(use_dil) LegacyGetValueForVariableExpressionPath() else DILGetValueForVariableExpressionPath()` https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [LLDB] Add framework for Data Inspection Language (DIL) work. (PR #115666)

2024-11-12 Thread Pavel Labath via lldb-commits
@@ -56,8 +56,19 @@ DWARFASTParser::ParseChildArrayInfo(const DWARFDIE &parent_die, if (auto frame = exe_ctx->GetFrameSP()) { Status error; lldb::VariableSP var_sp; - auto valobj_sp = frame->GetValueForVariabl

[Lldb-commits] [lldb] 2a3c08f - [lldb] (Begin to) support discontinuous lldb_private::Functions (#115730)

2024-11-12 Thread via lldb-commits
Author: Pavel Labath Date: 2024-11-12T09:34:53+01:00 New Revision: 2a3c08f620fc89823ebf1d2af4ea0beb97671db2 URL: https://github.com/llvm/llvm-project/commit/2a3c08f620fc89823ebf1d2af4ea0beb97671db2 DIFF: https://github.com/llvm/llvm-project/commit/2a3c08f620fc89823ebf1d2af4ea0beb97671db2.diff

[Lldb-commits] [lldb] ca4cd08 - [lldb][AIX] Added XCOFF Object File Header for AIX (#111814)

2024-11-12 Thread via lldb-commits
Author: Dhruv Srivastava Date: 2024-11-12T09:34:25+01:00 New Revision: ca4cd08fb9d7a03fbd00bca05d5dbfa87cd6db4e URL: https://github.com/llvm/llvm-project/commit/ca4cd08fb9d7a03fbd00bca05d5dbfa87cd6db4e DIFF: https://github.com/llvm/llvm-project/commit/ca4cd08fb9d7a03fbd00bca05d5dbfa87cd6db4e.di

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header for AIX (PR #111814)

2024-11-12 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/111814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] (Begin to) support discontinuous lldb_private::Functions (PR #115730)

2024-11-12 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/115730 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Function::GetAddress and redirect some uses (PR #115836)

2024-11-12 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/115836 Many calls to Function::GetAddressRange() were not interested in the range itself. Instead they wanted to find the address of the function (its entry point) or the base address for relocation of function-scoped

[Lldb-commits] [lldb] [lldb] Add Function::GetAddress and redirect some uses (PR #115836)

2024-11-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Many calls to Function::GetAddressRange() were not interested in the range itself. Instead they wanted to find the address of the function (its entry point) or the base address for relocation of function-scope

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add Extension to Save a thread and N pointers deep (PR #111601)

2024-11-12 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/111601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e5ba117 - [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (#115933)

2024-11-12 Thread via lldb-commits
Author: John Harrison Date: 2024-11-12T13:19:17-08:00 New Revision: e5ba11727437456fbab7ce733c07843bf682fa0c URL: https://github.com/llvm/llvm-project/commit/e5ba11727437456fbab7ce733c07843bf682fa0c DIFF: https://github.com/llvm/llvm-project/commit/e5ba11727437456fbab7ce733c07843bf682fa0c.diff

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/115933 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

2024-11-12 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/110065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-11-12 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > I worry that in a situation like this where there's a pending task people > will go the wrong way and lose important state because they forgot that > "continue" doesn't mean "continue what I was doing" - which is what it > currently means in lldb I don't know of any other

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread Michael Buch via lldb-commits
@@ -0,0 +1,8 @@ +#include "artificial_location.h" + +int A::foo() { +#line 0 Michael137 wrote: FYI there's some discussion about this test going on in https://github.com/llvm/llvm-project/pull/107849, in case you had some thoughts on Jeremy's points https://gi

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Jonas Devlieghere via lldb-commits
@@ -288,8 +288,15 @@ Status ScriptedProcess::DoGetMemoryRegionInfo(lldb::addr_t load_addr, MemoryRegionInfo ®ion) { Status error; if (auto region_or_err = - GetInterface().GetMemoryRegionContainingAddress(load_addr, er

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap/DAP.{h, cpp} to use its own instance instead of the global instance. (PR #115948)

2024-11-12 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/115948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] Unify naming of internal pointer members in std::vector and std::__split_buffer (PR #115517)

2024-11-12 Thread Peng Liu via lldb-commits
https://github.com/winner245 updated https://github.com/llvm/llvm-project/pull/115517 >From 29ef4c6b2fae47a68bc9e59343fc18527c09fb1d Mon Sep 17 00:00:00 2001 From: Peng Liu Date: Fri, 8 Nov 2024 11:52:29 -0500 Subject: [PATCH 1/3] Unify naming of internal pointer members in std::vector and std

[Lldb-commits] [libcxx] [lldb] Unify naming of internal pointer members in std::vector and std::__split_buffer (PR #115517)

2024-11-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3431d133ccfa75d16964be455238e2a1da0c2004...6e51b126cc760188925f8925325a7a90c193451a lldb/

[Lldb-commits] [libcxx] [lldb] Unify naming of internal pointer members in std::vector and std::__split_buffer (PR #115517)

2024-11-12 Thread Peng Liu via lldb-commits
https://github.com/winner245 updated https://github.com/llvm/llvm-project/pull/115517 >From 29ef4c6b2fae47a68bc9e59343fc18527c09fb1d Mon Sep 17 00:00:00 2001 From: Peng Liu Date: Fri, 8 Nov 2024 11:52:29 -0500 Subject: [PATCH 1/3] Unify naming of internal pointer members in std::vector and std

[Lldb-commits] [lldb] fix: Target Process may crash on detaching process on windows (PR #115712)

2024-11-12 Thread via lldb-commits
anatawa12 wrote: I looked the process in suspended state with sysinternal process explorer and I found all threads have exactly one suspend count. Therefore, I added logs to calling [SuspendThread] and [ResumeThread] and I found those calls are unbalanced exactly one for each thread so I think

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/115963 >From f8f1d70d1d9eac6d36c0fa84e2a94c032385da39 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 12 Nov 2024 15:55:15 -0800 Subject: [PATCH 1/2] [lldb] Handle an empty SBMemoryRegionInfo from scripted

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Jason Molenda via lldb-commits
@@ -288,8 +288,15 @@ Status ScriptedProcess::DoGetMemoryRegionInfo(lldb::addr_t load_addr, MemoryRegionInfo ®ion) { Status error; if (auto region_or_err = - GetInterface().GetMemoryRegionContainingAddress(load_addr, er

[Lldb-commits] [lldb] [lldb][test] Fix remote Shell tests failures on Windows host (PR #115716)

2024-11-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/115716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap/DAP.{h, cpp} to use its own instance instead of the global instance. (PR #115948)

2024-11-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/115948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support true/false in ValueObject::SetValueFromCString (PR #115780)

2024-11-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/115780 >From 3450bca62abbc0e9595b61f663114cd67927ffaf Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 11 Nov 2024 14:17:17 -0800 Subject: [PATCH 1/3] [lldb] Support true/false in ValueObject::SetValue

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap/DAP.{h, cpp} to use its own instance instead of the global instance. (PR #115948)

2024-11-12 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/115948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support true/false in ValueObject::SetValueFromCString (PR #115780)

2024-11-12 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/115780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fix: Target Process may crash on detaching process on windows (PR #115712)

2024-11-12 Thread via lldb-commits
https://github.com/anatawa12 updated https://github.com/llvm/llvm-project/pull/115712 >From cabe26fc14cb4a924b2aebe6f3dd080408fed6ce Mon Sep 17 00:00:00 2001 From: anatawa12 Date: Mon, 11 Nov 2024 20:22:33 +0900 Subject: [PATCH 1/3] fix: Target Process may crash on detaching process --- .../P

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/115876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/115963 >From f8f1d70d1d9eac6d36c0fa84e2a94c032385da39 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 12 Nov 2024 15:55:15 -0800 Subject: [PATCH 1/3] [lldb] Handle an empty SBMemoryRegionInfo from scripted

[Lldb-commits] [lldb] [LLDB] Add framework for Data Inspection Language (DIL) work. (PR #115666)

2024-11-12 Thread via lldb-commits
cmtice wrote: I've updated the code as Jim and Pavel suggested. :-) https://github.com/llvm/llvm-project/pull/115666 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support true/false in ValueObject::SetValueFromCString (PR #115780)

2024-11-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/115780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes A scripted process implementation might return an SBMemoryRegionInfo object in its implementation of `get_memory_region_containing_address` which will have an address 0 and size 0, without realizing the

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/115963 A scripted process implementation might return an SBMemoryRegionInfo object in its implementation of `get_memory_region_containing_address` which will have an address 0 and size 0, without realizing the pr

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I am uncertain where I should detect an improperly formatted memory range. It could be in `Process::GetMemoryRegionInfo`, which would catch a bad gdb remote serial protocol response as well. Or it could be localized to IRMemoryMap::FindSpace if we only wanted to avoid an

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/115963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,137 @@ +import os, struct, signal + +from typing import Any, Dict + +import lldb +from lldb.plugins.scripted_process import ScriptedProcess +from lldb.plugins.scripted_process import ScriptedThread + + +class DummyStopHook: +def __init__(self, target, args): +

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM with comments. https://github.com/llvm/llvm-project/pull/115963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,137 @@ +import os, struct, signal + +from typing import Any, Dict + +import lldb +from lldb.plugins.scripted_process import ScriptedProcess +from lldb.plugins.scripted_process import ScriptedThread + + +class DummyStopHook: +def __init__(self, target, args): +

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap/DAP.{h, cpp} to use its own instance instead of the global instance. (PR #115948)

2024-11-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes The refactor will unblock us for creating multiple DAP instances. --- Full diff: https://github.com/llvm/llvm-project/pull/115948.diff 3 Files Affected: - (modified) lldb/tools/lldb-dap/DAP.cpp (+25-27) -

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-11-12 Thread via lldb-commits
jimingham wrote: > > I worry that in a situation like this where there's a pending task people > > will go the wrong way and lose important state because they forgot that > > "continue" doesn't mean "continue what I was doing" - which is what it > > currently means in lldb > > I don't know of

[Lldb-commits] [lldb] [lldb] Handle an empty SBMemoryRegionInfo from scripted process (PR #115963)

2024-11-12 Thread Jason Molenda via lldb-commits
@@ -288,8 +288,15 @@ Status ScriptedProcess::DoGetMemoryRegionInfo(lldb::addr_t load_addr, MemoryRegionInfo ®ion) { Status error; if (auto region_or_err = - GetInterface().GetMemoryRegionContainingAddress(load_addr, er

[Lldb-commits] [lldb] fix: Target Process may crash or freezes on detaching process on windows (PR #115712)

2024-11-12 Thread via lldb-commits
https://github.com/anatawa12 edited https://github.com/llvm/llvm-project/pull/115712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added new plugin AIX-DYLD (Dynamic Loader) Base Support (PR #115714)

2024-11-12 Thread Pavel Labath via lldb-commits
labath wrote: That sounds reasonable. Those three parts should be mostly independent. The dynamic loader plugin is tricky as it sort of binds everything together. Basically my criterion is: "can this code be useful (e.g. tested) without the functionality that is not implemented yet". If the an

[Lldb-commits] [lldb] ae7b5af - [lldb] Remove ConnectionFileDescriptor::child_process_inherit (#115861)

2024-11-12 Thread via lldb-commits
Author: Pavel Labath Date: 2024-11-13T08:59:42+01:00 New Revision: ae7b5af904850db71308915836f32a8d79553dd8 URL: https://github.com/llvm/llvm-project/commit/ae7b5af904850db71308915836f32a8d79553dd8 DIFF: https://github.com/llvm/llvm-project/commit/ae7b5af904850db71308915836f32a8d79553dd8.diff

[Lldb-commits] [lldb] [lldb] Remove ConnectionFileDescriptor::child_process_inherit (PR #115861)

2024-11-12 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/115861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/115933 >From db7efd17208479fb56eac01eaad1f8bcb993db04 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 12 Nov 2024 14:41:28 -0500 Subject: [PATCH 1/2] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/115933 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This refactor removes g_dap references from lldb-dap/LLDBUtils.{h,cpp} to allow us to create more than one g_dap instance in the future. --- Full diff: https://github.com/llvm/llvm-project/pull/115933.diff

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/115933 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/115876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread Jonas Devlieghere via lldb-commits
@@ -205,16 +205,20 @@ Disassembler::GetFunctionDeclLineEntry(const SymbolContext &sc) { return {}; LineEntry prologue_end_line = sc.line_entry; - FileSpec func_decl_file; + SupportFileSP func_decl_file_sp; JDevlieghere wrote: As you've noticed, `Supp

[Lldb-commits] [lldb] faaf2db - [lldb-dap] Refactoring JSONUtils to not use `g_dap` and instead passing in required arguments. (#115561)

2024-11-12 Thread via lldb-commits
Author: John Harrison Date: 2024-11-12T12:15:58-05:00 New Revision: faaf2dbf6d2c080d817c4dfe9f888e456418bc2e URL: https://github.com/llvm/llvm-project/commit/faaf2dbf6d2c080d817c4dfe9f888e456418bc2e DIFF: https://github.com/llvm/llvm-project/commit/faaf2dbf6d2c080d817c4dfe9f888e456418bc2e.diff

[Lldb-commits] [lldb] [lldb-dap] Refactoring JSONUtils to not use `g_dap` and instead passing in required arguments. (PR #115561)

2024-11-12 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/115561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 20c4e95 - [lldb][test] Fix remote Shell tests failures on Windows host (#115716)

2024-11-12 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-11-12T18:03:24+01:00 New Revision: 20c4e95b9c03a77c2e5ce5f354114752d380c591 URL: https://github.com/llvm/llvm-project/commit/20c4e95b9c03a77c2e5ce5f354114752d380c591 DIFF: https://github.com/llvm/llvm-project/commit/20c4e95b9c03a77c2e5ce5f354114752d380c59

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/115933 This refactor removes g_dap references from lldb-dap/LLDBUtils.{h,cpp} to allow us to create more than one g_dap instance in the future. >From db7efd17208479fb56eac01eaad1f8bcb993db04 Mon Sep 17 00:00:00 2001 Fr

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/115933 >From db7efd17208479fb56eac01eaad1f8bcb993db04 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 12 Nov 2024 14:41:28 -0500 Subject: [PATCH] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. Th

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/115933 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] Unify naming of internal pointer members in std::vector and std::__split_buffer (PR #115517)

2024-11-12 Thread Peng Liu via lldb-commits
https://github.com/winner245 updated https://github.com/llvm/llvm-project/pull/115517 >From 2f108fec2dc46a4242142e69cf2e189f117d6cfc Mon Sep 17 00:00:00 2001 From: Peng Liu Date: Fri, 8 Nov 2024 11:52:29 -0500 Subject: [PATCH 1/3] Unify naming of internal pointer members in std::vector and std

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap/DAP.{h, cpp} to use its own instance instead of the global instance. (PR #115948)

2024-11-12 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/115948 The refactor will unblock us for creating multiple DAP instances. >From 83a1ad1cd80c71531db6d3014fa16a8fbc38eeeb Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 12 Nov 2024 17:13:32 -0500 Subject: [PATCH

[Lldb-commits] [lldb] 4714215 - [lldb] Support true/false in ValueObject::SetValueFromCString (#115780)

2024-11-12 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-11-12T21:18:22-08:00 New Revision: 4714215efb0486682feaa3a99162e80a934be8f9 URL: https://github.com/llvm/llvm-project/commit/4714215efb0486682feaa3a99162e80a934be8f9 DIFF: https://github.com/llvm/llvm-project/commit/4714215efb0486682feaa3a99162e80a934be8f9.d

[Lldb-commits] [lldb] [lldb] Recommend Python 3.8 as the minimum Python version for LLDB (PR #114807)

2024-11-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/114807 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-11-12 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/99891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/115876 When retrieving the location of the function declaration, we were dropping the file component on the floor, which resulted in an amusingly confusing situation were we displayed the file containing the implementa

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes When retrieving the location of the function declaration, we were dropping the file component on the floor, which resulted in an amusingly confusing situation were we displayed the file containing the implemen

[Lldb-commits] [lldb] [lldb] Remove ConnectionFileDescriptor::child_process_inherit (PR #115861)

2024-11-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/115861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2a3c08f620fc89823ebf1d2af4ea0beb97671db2...7f9c959bf0ee984b3c2e93f11a96b57162b3 lldb/

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2a3c08f620fc89823ebf1d2af4ea0beb97671db2 7f9c959bf0ee984b3c2e93f11a96b57162b3 --e

[Lldb-commits] [lldb] [lldb] Fix source display for artificial locations (PR #115876)

2024-11-12 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/115876 >From 0e9fa482457c08c17c3d6b2219bb9ffd7a54d62f Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 12 Nov 2024 15:43:02 +0100 Subject: [PATCH] [lldb] Fix source display for artificial locations When retrievin

[Lldb-commits] [lldb] [lldb] Support overriding the disassembly CPU & features (PR #115382)

2024-11-12 Thread David Spickett via lldb-commits
@@ -157,6 +157,12 @@ let Definition = "target" in { DefaultEnumValue<"eX86DisFlavorDefault">, EnumValues<"OptionEnumValues(g_x86_dis_flavor_value_types)">, Desc<"The default disassembly flavor to use for x86 or x86-64 targets.">; + def DisassemblyCPU: Property<"dis

[Lldb-commits] [lldb] [lldb][test] Fix inline_sites_live.cpp Shell test on Linux remote (PR #115722)

2024-11-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. I thought maybe the test passed accidentally with this change but the backtrace must still match so LGTM. https://github.com/llvm/llvm-project/pull/115722 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] [lldb][test] Fix inline_sites_live.cpp Shell test on Linux remote (PR #115722)

2024-11-12 Thread David Spickett via lldb-commits
DavidSpickett wrote: If I understand correctly this is building the test on Linux and running it on Windows. And it seems that the output is in fact better this way? Can't complain about that. https://github.com/llvm/llvm-project/pull/115722 ___ lld

[Lldb-commits] [lldb] [lldb][test] Fix inline_sites_live.cpp Shell when run on Windows remotely from Linux (PR #115722)

2024-11-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/115722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix remote Shell tests failures on Windows host (PR #115716)

2024-11-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Thought that maybe you could just re-use the check for `system-windows`, but that's something lit adds for us by asking Python what it's running on. LGTM. https://github.com/llvm/llvm-project/pull/115716 _

[Lldb-commits] [lldb] [lldb][docs] Document Lua 5.3 as the only supported version (PR #115288)

2024-11-12 Thread David Spickett via lldb-commits
DavidSpickett wrote: Abandoning in favour of your patch, thanks! https://github.com/llvm/llvm-project/pull/115288 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] (Begin to) support discontinuous lldb_private::Functions (PR #115730)

2024-11-12 Thread Pavel Labath via lldb-commits
@@ -254,12 +254,32 @@ Function *IndirectCallEdge::GetCallee(ModuleList &images, /// @} +AddressRange CollapseRanges(llvm::ArrayRef ranges) { + if (ranges.empty()) +return AddressRange(); + if (ranges.size() == 1) +return ranges[0]; + + Address lowest_addr = ranges[

[Lldb-commits] [lldb] fix: Target Process may crash on detaching process on windows (PR #115712)

2024-11-12 Thread via lldb-commits
anatawa12 wrote: I tried to run `TestDetachResumes` but it fails (still in suspended state) so I may need some other work to them work correctly. I'll investigate more tomorrow. https://github.com/llvm/llvm-project/pull/115712 ___ lldb-commits mailing

[Lldb-commits] [lldb] 3ce0dbb - [lldb] Recommend Python 3.8 as the minimum Python version for LLDB (#114807)

2024-11-12 Thread via lldb-commits
Author: David Spickett Date: 2024-11-12T10:49:16Z New Revision: 3ce0dbb718c9df123fd1cb87623aa31b3376fb61 URL: https://github.com/llvm/llvm-project/commit/3ce0dbb718c9df123fd1cb87623aa31b3376fb61 DIFF: https://github.com/llvm/llvm-project/commit/3ce0dbb718c9df123fd1cb87623aa31b3376fb61.diff LOG

[Lldb-commits] [lldb] [lldb] Recommend Python 3.8 as the minimum Python version for LLDB (PR #114807)

2024-11-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/114807 >From fb436219e527f4de3cc4ce35eb3b884b824924a3 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 4 Nov 2024 14:41:19 + Subject: [PATCH 1/2] [lldb] Recommend Python 3.8 as the minimum Python vers

[Lldb-commits] [lldb] [lldb][docs] Document Lua 5.3 as the only supported version (PR #115288)

2024-11-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/115288 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring JSONUtils to not use `g_dap` and instead passing in required arguments. (PR #115561)

2024-11-12 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/115561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove ConnectionFileDescriptor::child_process_inherit (PR #115861)

2024-11-12 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/115861 It's never set to true. Inheritable FDs are also dangerous as they can end up processes which know nothing about them. It's better to explicitly pass a specific FD to a specific subprocess, which we already most

[Lldb-commits] [lldb] [lldb] Remove ConnectionFileDescriptor::child_process_inherit (PR #115861)

2024-11-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes It's never set to true. Inheritable FDs are also dangerous as they can end up processes which know nothing about them. It's better to explicitly pass a specific FD to a specific subprocess, which we already mo

[Lldb-commits] [lldb] fix: Target Process may crash on detaching process on windows (PR #115712)

2024-11-12 Thread via lldb-commits
https://github.com/anatawa12 edited https://github.com/llvm/llvm-project/pull/115712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fix: Target Process may crash on detaching process on windows (PR #115712)

2024-11-12 Thread via lldb-commits
anatawa12 wrote: After I changed debug-api-test, I found that calling DebugActiveProcessStop before ContinueDebugEvent will follow behavior specified by DebugSetProcessKillOnExit for some cases. This PR only fixes this behavior, which is reported on Rider issue tracker as [RIDER-99436](https:

[Lldb-commits] [lldb] fix: Target Process may crash on detaching process on windows (PR #115712)

2024-11-12 Thread via lldb-commits
https://github.com/anatawa12 edited https://github.com/llvm/llvm-project/pull/115712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits