labath wrote:
(+1 to everything that David said)
https://github.com/llvm/llvm-project/pull/106910
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Thanks. Looks good. There are a bunch of linux failures reported by the linux
precommit bot. I don't expect you'll get all of them, but you could try to get
at least those that are reported there so that there's one less post-commit
iterati
@@ -206,3 +213,29 @@ void llvm::format_provider::format(
llvm::format_provider::format(error.AsCString(), OS,
Options);
}
+
+const char *lldb_private::ExecutionResultAsCString(ExpressionResults result) {
labath
@@ -80,8 +80,9 @@ TEST_F(RemoteAwarePlatformTest,
TestResolveExecutabelOnClientByPlatform) {
static const ArchSpec process_host_arch;
EXPECT_CALL(platform, GetSupportedArchitectures(process_host_arch))
.WillRepeatedly(Return(std::vector()));
+ Status success;
--
@@ -109,6 +109,13 @@ llvm::Error Status::ToError() const {
Status::~Status() = default;
+const Status &Status::operator=(Status &&other) {
+ m_code = other.m_code;
+ m_type = other.m_type;
+ m_string = other.m_string;
labath wrote:
`std::move(other.m_stri
@@ -34,7 +34,7 @@ PythonObject SWIGBridge::ToSWIGWrapper(lldb::BreakpointSP
breakpoint_sp) {
}
PythonObject SWIGBridge::ToSWIGWrapper(const Status& status) {
labath wrote:
Maybe take the object by value and then move it into SBError, so that the
caller has
labath wrote:
> > Ah I've just noticed the other PR
>
> Do we actually have abetter solution for stacked commits than what I'm doing
> here?
This setup works fine for me, but I think it's worth calling out that you
intend it to be viewed that way, as it's not the completely typical way to use
AbdAlRahmanGad wrote:
@jimingham
This change was suggested by @adrian-prantl as good first issue for me. it's
similar to this [Pull
Request](https://github.com/llvm/llvm-project/pull/92979/).
You can read the conversation here
https://discourse.llvm.org/t/rich-disassembler-for-lldb/76952/14
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/106774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -170,12 +215,8 @@ class Status {
bool Success() const;
protected:
- Status(llvm::Error error);
- /// Status code as an integer value.
- ValueType m_code = 0;
- /// The type of the above error code.
- lldb::ErrorType m_type = lldb::eErrorTypeInvalid;
- /// A string r
@@ -37,48 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char CloneableError::ID;
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGe
@@ -174,33 +233,91 @@ const char *Status::AsCString(const char
*default_error_str) const {
// Clear the error and any cached error string that it might contain.
void Status::Clear() {
- m_code = 0;
- m_type = eErrorTypeInvalid;
- m_string.clear();
+ if (m_error)
+LLDB
@@ -26,6 +26,52 @@ class raw_ostream;
namespace lldb_private {
+/// Going a bit against the spirit of llvm::Error,
+/// lldb_private::Status need to store errors long-term and sometimes
+/// copy them. This base class defines an interface for this
+/// operation.
+class Clone
@@ -37,48 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char CloneableError::ID;
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGe
@@ -174,33 +233,91 @@ const char *Status::AsCString(const char
*default_error_str) const {
// Clear the error and any cached error string that it might contain.
void Status::Clear() {
- m_code = 0;
- m_type = eErrorTypeInvalid;
- m_string.clear();
+ if (m_error)
+LLDB
https://github.com/labath commented:
I am worried about the thread safety aspects of this, in particular for these
"long term storage" errors. I don't know if we have any users like this, but I
think it wouldn't be unreasonable for someone to expect that they can access
these errors from multi
@@ -94,26 +123,49 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-Status Status::FromError(llvm::Error error) { return Status(std::move(error));
}
+Status Status::FromExpressionError(lldb::ExpressionResults result,
+
labath wrote:
> Wasn't half as bad. @labath This update introduces a `ClonableError` base
> class. This will enable us (after a bit more refactoring) to move the various
> Error subclass declarations closer to where they are needed. Right now the
> ErrorFromEnums() method still prevents that.
labath wrote:
Also, some (unit) tests would be nice.
https://github.com/llvm/llvm-project/pull/106774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
labath wrote:
I think this file looks good now. In the interests of moving this forward, and
reducing the size of this patch, could you split it into a separate patch?
https://github.com/llvm/llvm-project/pull/104238
___
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -160,66 +95,56 @@
GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() =
default;
Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer(
-const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid,
-std::optional &por
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
@@ -160,66 +95,56 @@
GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() =
default;
Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer(
-const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid,
-std::optional &por
@@ -666,7 +756,23 @@ ConnectionStatus
ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#ifdef _WIN32
+ int64_t
@@ -25,90 +25,30 @@ namespace process_gdb_remote {
class GDBRemoteCommunicationServerPlatform
: public GDBRemoteCommunicationServerCommon {
public:
- class PortMap {
- public:
-// This class is used to restrict the range of ports that
-// platform created debugser
@@ -195,18 +195,31 @@ void ConnectToRemote(MainLoop &mainloop,
bool reverse_connect, llvm::StringRef host_and_port,
const char *const progname, const char *const subcommand,
const char *const named_pipe_path, pipe_t
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 18b8a835a3182e5be5f0dd848977333d9b8a26fa Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:08:24 +0400
Subject: [PATCH 1/3] [lldb] Removed gdbserver ports map from lldb-server
List
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
https://github.com/slydiman deleted
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -50,7 +50,8 @@ class ElaboratingDIEIterator
m_worklist.pop_back();
// And add back any items that elaborate it.
-for (dw_attr_t attr : {DW_AT_specification, DW_AT_abstract_origin}) {
+for (dw_attr_t attr :
+ {DW_AT_specification, DW_AT_abstract_origi
@@ -377,11 +378,6 @@ static void GetDeclContextImpl(DWARFDIE die,
die = spec;
continue;
}
-// To find the name of a type in a type unit, we must follow the signature.
-if (DWARFDIE spec = die.GetReferencedDIE(DW_AT_signature)) {
labath w
@@ -60,44 +60,45 @@ class DWARFDebugInfoEntry {
return attrs;
}
- dw_offset_t
- GetAttributeValue(const DWARFUnit *cu, const dw_attr_t attr,
-DWARFFormValue &formValue,
-dw_offset_t *end_attr_offset_ptr = nullptr,
-
@@ -421,97 +417,210 @@ int main_platform(int argc, char *argv[]) {
return 0;
}
- const bool children_inherit_listen_socket = false;
+ if (gdbserver_port != 0 &&
+ (gdbserver_port < LOW_PORT || gdbserver_port > HIGH_PORT)) {
+WithColor::error() << llvm::formatv
@@ -160,66 +95,56 @@
GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() =
default;
Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer(
-const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid,
-std::optional &por
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
@@ -160,66 +95,56 @@
GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() =
default;
Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer(
-const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid,
-std::optional &por
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/107241
>From 2fd6f97ed01eee17b28c1c843f0d891a460a2fb3 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 4 Sep 2024 13:36:07 +0200
Subject: [PATCH 1/2] [lldb] Recurse through DW_AT_signature when looking for
attrib
@@ -25,90 +25,30 @@ namespace process_gdb_remote {
class GDBRemoteCommunicationServerPlatform
: public GDBRemoteCommunicationServerCommon {
public:
- class PortMap {
- public:
-// This class is used to restrict the range of ports that
-// platform created debugser
@@ -195,18 +195,31 @@ void ConnectToRemote(MainLoop &mainloop,
bool reverse_connect, llvm::StringRef host_and_port,
const char *const progname, const char *const subcommand,
const char *const named_pipe_path, pipe_t
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
AaronBallman wrote:
Precommit CI test failures look related:
```
_bk;t=1725284334938 TEST 'LLVM ::
tools/sancov/symbolize.test' FAILED
_bk;t=1725284334938Exit Code: 1
_bk;t=1725284334938
_bk;t=1725284334938Command Output (stderr):
_bk;t=17252
@@ -377,11 +378,6 @@ static void GetDeclContextImpl(DWARFDIE die,
die = spec;
continue;
}
-// To find the name of a type in a type unit, we must follow the signature.
-if (DWARFDIE spec = die.GetReferencedDIE(DW_AT_signature)) {
Michael1
https://github.com/Michael137 approved this pull request.
LGTM
Wouldn't block the PR on this, but is there a way the `ElaboratingDIIterator`
changes can be tested? Maybe a unit-test where we instantiate
`elaborating_dies` on something that has `DW_AT_signature` and makes sure we
actually iter
@@ -150,12 +153,17 @@ static void
client_handle(GDBRemoteCommunicationServerPlatform &platform,
printf("Disconnected.\n");
}
-static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
-static std::mutex gdbserver_portmap_mutex;
-
static void spawn_process_rea
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/107388
This is the prerequisite for #104238.
>From 9f1612513d5feffe7c0b5b5e5b743d932d233934 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 5 Sep 2024 16:04:44 +0400
Subject: [PATCH] [lldb][NFC] Separated
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
This is the prerequisite for #104238.
---
Full diff: https://github.com/llvm/llvm-project/pull/107388.diff
2 Files Affected:
- (modified) lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cp
slydiman wrote:
I have created #107388.
Note I did not include `#include "lldb/Host/Socket.h"` and shared_fd_t using
because it requires changes in
lldb/unittests/tools/lldb-server/tests/TestClient.*
https://github.com/llvm/llvm-project/pull/104238
_
@@ -160,66 +95,56 @@
GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() =
default;
Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer(
-const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid,
-std::optional &por
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 18b8a835a3182e5be5f0dd848977333d9b8a26fa Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:08:24 +0400
Subject: [PATCH 1/4] [lldb] Removed gdbserver ports map from lldb-server
List
@@ -160,66 +95,56 @@
GDBRemoteCommunicationServerPlatform::~GDBRemoteCommunicationServerPlatform() =
default;
Status GDBRemoteCommunicationServerPlatform::LaunchGDBServer(
-const lldb_private::Args &args, std::string hostname, lldb::pid_t &pid,
-std::optional &por
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aainscow wrote:
Vote. This is affecting the Ceph project.
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309
>From f6002ad249359131be6d668036b4f17ff43e67c7 Mon Sep 17 00:00:00 2001
From: Nikita Popov
Date: Tue, 13 Aug 2024 15:11:18 +0200
Subject: [PATCH] apint only
---
clang/lib/AST/ByteCode/IntegralAP.h | 6
Author: Jacob Lalonde
Date: 2024-09-05T09:38:45-07:00
New Revision: 2ed510dc9789ca0b9172f0593527bee9d53496c4
URL:
https://github.com/llvm/llvm-project/commit/2ed510dc9789ca0b9172f0593527bee9d53496c4
DIFF:
https://github.com/llvm/llvm-project/commit/2ed510dc9789ca0b9172f0593527bee9d53496c4.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/106767
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2024-09-05T09:53:49-07:00
New Revision: 18ad98e7947502da0c8f6dcbbf485bb34fe8d204
URL:
https://github.com/llvm/llvm-project/commit/18ad98e7947502da0c8f6dcbbf485bb34fe8d204
DIFF:
https://github.com/llvm/llvm-project/commit/18ad98e7947502da0c8f6dcbbf485bb34fe8d204.diff
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/107325
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/107319
>From 70f94e152ba2a6826a3c4f8071b5e0ee2bb81d2d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 4 Sep 2024 14:06:04 -0700
Subject: [PATCH 1/7] Cherry-pick llvm only changes from minidump multiple
excepti
@@ -258,6 +258,14 @@ class TypeSummaryImpl {
virtual std::string GetDescription() = 0;
+ /// Get the name of the Type Summary Provider, either a C++ class, a summary
+ /// string, or a script function name.
+ virtual std::string GetName() = 0;
+
+ /// Get the name of th
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/107163
>From a56b0ef1e5c914a7a513f643de608f1c29aa21ef Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3 Sep 2024 15:29:25 -0700
Subject: [PATCH] [lldb] Make conversions from llvm::Error explicit with
Sta
Author: Adrian Prantl
Date: 2024-09-05T12:19:31-07:00
New Revision: a0dd90eb7dc318c9b3fccb9ba02e1e22fb073094
URL:
https://github.com/llvm/llvm-project/commit/a0dd90eb7dc318c9b3fccb9ba02e1e22fb073094
DIFF:
https://github.com/llvm/llvm-project/commit/a0dd90eb7dc318c9b3fccb9ba02e1e22fb073094.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/107163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -109,6 +109,13 @@ llvm::Error Status::ToError() const {
Status::~Status() = default;
+const Status &Status::operator=(Status &&other) {
+ m_code = other.m_code;
+ m_type = other.m_type;
+ m_string = other.m_string;
adrian-prantl wrote:
Sure, but this i
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/107170
>From 6500c9a1c2cf2812332dd66e35e625f1bc233b89 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3 Sep 2024 16:40:41 -0700
Subject: [PATCH] [lldb] Make deep copies of Status explicit (NFC)
---
lldb
Author: Adrian Prantl
Date: 2024-09-05T12:36:05-07:00
New Revision: 5515b086f35c2c1402234b9b94338f10fc9d16f7
URL:
https://github.com/llvm/llvm-project/commit/5515b086f35c2c1402234b9b94338f10fc9d16f7
DIFF:
https://github.com/llvm/llvm-project/commit/5515b086f35c2c1402234b9b94338f10fc9d16f7.diff
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/107170
>From e0a98558ed5c543e4d65c2c560e15062d82f150a Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3 Sep 2024 16:40:41 -0700
Subject: [PATCH] [lldb] Make deep copies of Status explicit (NFC)
---
lldb
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/107170
>From 8cdcc708ce0cd07445c36781cc40db04a6d94b60 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3 Sep 2024 16:40:41 -0700
Subject: [PATCH] [lldb] Make deep copies of Status explicit (NFC)
---
lldb
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/107170
>From 287735cb1a5f6ceeb55aa6fbef8b86c99583d727 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 3 Sep 2024 16:40:41 -0700
Subject: [PATCH] [lldb] Make deep copies of Status explicit (NFC)
---
lldb
Author: Adrian Prantl
Date: 2024-09-05T12:44:13-07:00
New Revision: b798f4bd50bbf0f5eb46804afad10629797c73aa
URL:
https://github.com/llvm/llvm-project/commit/b798f4bd50bbf0f5eb46804afad10629797c73aa
DIFF:
https://github.com/llvm/llvm-project/commit/b798f4bd50bbf0f5eb46804afad10629797c73aa.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/107170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 4 "build".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/5655
Here is the relevant piece of the build log
Author: Adrian Prantl
Date: 2024-09-05T12:49:16-07:00
New Revision: 7b760894f247f4fa1b27c01c767c8599c169f996
URL:
https://github.com/llvm/llvm-project/commit/7b760894f247f4fa1b27c01c767c8599c169f996
DIFF:
https://github.com/llvm/llvm-project/commit/7b760894f247f4fa1b27c01c767c8599c169f996.diff
Author: Adrian Prantl
Date: 2024-09-05T12:53:08-07:00
New Revision: 3b426a8951caa543b65f20ff265353fd79f436e5
URL:
https://github.com/llvm/llvm-project/commit/3b426a8951caa543b65f20ff265353fd79f436e5
DIFF:
https://github.com/llvm/llvm-project/commit/3b426a8951caa543b65f20ff265353fd79f436e5.diff
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 6e4559f792d692da6bb92c463e86f26382cc150b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 4 Sep 2024 12:50:37 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
llv
nico wrote:
Looks like this breaks building on windows:
http://45.33.8.238/win/93597/step_3.txt
Please take a look and revert for now if it takes a while to fix.
https://github.com/llvm/llvm-project/pull/107163
___
lldb-commits mailing list
lldb-comm
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 12bf3fba23b130455bed2a10866a37433a4b471c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 4 Sep 2024 12:50:37 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
llv
@@ -26,6 +26,52 @@ class raw_ostream;
namespace lldb_private {
+/// Going a bit against the spirit of llvm::Error,
+/// lldb_private::Status need to store errors long-term and sometimes
+/// copy them. This base class defines an interface for this
+/// operation.
+class Clone
@@ -37,48 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char CloneableError::ID;
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGe
@@ -37,48 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char CloneableError::ID;
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGe
tstellar wrote:
@felipepiovezan Are you OK if we push this as-is, or would you like smarter
logic for detecting libc++ on the system?
https://github.com/llvm/llvm-project/pull/106885
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
felipepiovezan wrote:
> @felipepiovezan Are you OK if we push this as-is, or would you like smarter
> logic for detecting libc++ on the system?
I'm fine with this; in hindsight, I think the original workaround was not good
enough.
The longer term fix would be set both "use system std library"
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/106885
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-09-05T15:09:25-07:00
New Revision: 1e98aa4730b1b3b93205af74be26e04d5f876d10
URL:
https://github.com/llvm/llvm-project/commit/1e98aa4730b1b3b93205af74be26e04d5f876d10
DIFF:
https://github.com/llvm/llvm-project/commit/1e98aa4730b1b3b93205af74be26e04d5f876d10.diff
https://github.com/JDevlieghere approved this pull request.
LGTM. I like having both options. That way we don't break existing use cases
while also supporting the more intuitive way of expressing this as a dictionary.
https://github.com/llvm/llvm-project/pull/106919
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM modulo one nit.
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -943,8 +935,20 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
}
}
}
+ return debugserver_file_spec;
+}
- if (debugserver_exists) {
+Status GDBRemoteCommunication::StartDebugserverProcess(
+const char *url, Platform *platform, ProcessLaunchInfo
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/107485
Update lldb-dap so if the user just presses return, which sends an empty
expression, it re-evaluates the most recent non-empty expression/command. Also
udpated test to test this case.
>From 15541f354decf80586d5
@@ -943,8 +935,20 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
}
}
}
+ return debugserver_file_spec;
+}
- if (debugserver_exists) {
+Status GDBRemoteCommunication::StartDebugserverProcess(
+const char *url, Platform *platform, ProcessLaunchInfo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
Update lldb-dap so if the user just presses return, which sends an empty
expression, it re-evaluates the most recent non-empty expression/command. Also
udpated test to test this case.
---
Full diff: https://github.co
1 - 100 of 109 matches
Mail list logo
