[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: I only intend to use the (soon to be) proposed new options from C++, so I'm going to land this as is, but we certainly could pursue the API route later. https://github.com/llvm/llvm-project/pull/93158 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 7cdd53d - [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (#93158)

2024-05-28 Thread via lldb-commits
Author: David Spickett Date: 2024-05-28T09:40:50+01:00 New Revision: 7cdd53dacdfd9eef3d46ecddde872c71ec4292a1 URL: https://github.com/llvm/llvm-project/commit/7cdd53dacdfd9eef3d46ecddde872c71ec4292a1 DIFF: https://github.com/llvm/llvm-project/commit/7cdd53dacdfd9eef3d46ecddde872c71ec4292a1.diff

[Lldb-commits] [lldb] [lldb][Test] Add C++ tests for DumpValueObjectOptions and enums (PR #93158)

2024-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/93158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)

2024-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/90059 >From 6344ce3feff235f6a3b1bc1d5eb1e50e5695d320 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Mar 2024 10:18:51 + Subject: [PATCH] [lldb] Add format eFormatEnumWithValues to ensure raw enum

[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)

2024-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)

2024-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add format eFormatEnumWithValues to ensure raw enum value is always shown (PR #90059)

2024-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add format eFormatEnumWithValues to ensure raw enum value is always shown (PR #90059)

2024-05-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: @clayborg I have updated this to instead use a format, inspired by `eFormatBytesWithASCII`. Which is also one value printed twice. There are examples in the added c++ tests. https://github.com/llvm/llvm-project/pull/90059 ___ lld

[Lldb-commits] [lldb] [lldb] Add format eFormatEnumWithValues to ensure raw enum value is always shown (PR #90059)

2024-05-28 Thread David Spickett via lldb-commits
@@ -195,11 +195,15 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb] Add format eFormatEnumWithValues to ensure raw enum value is always shown (PR #90059)

2024-05-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: @Endilll This being a format type now might mean you can use it from the formatters. I'm not familiar with what parts of the API you're using there. https://github.com/llvm/llvm-project/pull/90059 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] [lldb-dap] Don't call GetNumChildren on non-indexed synthetic variables (PR #93534)

2024-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/93534 A synthetic child provider might need to do considerable amount of work to compute the number of children. lldb-dap is currently calling that for all synthethic variables, but it's only actually using the value f

[Lldb-commits] [lldb] [lldb-dap] Don't call GetNumChildren on non-indexed synthetic variables (PR #93534)

2024-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes A synthetic child provider might need to do considerable amount of work to compute the number of children. lldb-dap is currently calling that for all synthethic variables, but it's only actually using the valu

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/93458 >From 824ad3beb35adb83600e3d4dbce7c6e274fca1a1 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 27 May 2024 11:02:56 + Subject: [PATCH] [lldb] Fix module name tab completion Module names can be matched

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-28 Thread David Spickett via lldb-commits
@@ -297,8 +312,9 @@ class ModuleCompleter : public Completer { void DoCompletion(SearchFilter *filter) override { filter->Search(*this); } private: - const char *m_file_name; - const char *m_dir_name; + std::optional m_file_name; DavidSpickett wrote: Unl

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-28 Thread David Spickett via lldb-commits
@@ -906,3 +906,38 @@ def test_ambiguous_command(self): def test_ambiguous_subcommand(self): """Test completing a subcommand of an ambiguous command""" self.complete_from_to("settings s ta", []) + +def test_shlib_name(self): +self.build() +

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

2024-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/93540 I've found them very useful as a rudimentary form of benchmark. >From 2f3cb04a141d39c184afcb0d59acb7ea6cbb16d9 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 28 May 2024 12:16:49 + Subject: [PATCH] [l

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

2024-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes I've found them very useful as a rudimentary form of benchmark. --- Full diff: https://github.com/llvm/llvm-project/pull/93540.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/DAP.cpp (+9-4) ``

[Lldb-commits] [lldb] [IRInterpreter] Return zero address for missing weak function (PR #93548)

2024-05-28 Thread Nikita Popov via lldb-commits
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/93548 If a weak function is missing, still return it's address (zero) rather than failing interpretation. Otherwise we have a mismatch between Interpret() and CanInterpret() resulting in failures that would not occur wit

[Lldb-commits] [lldb] [IRInterpreter] Return zero address for missing weak function (PR #93548)

2024-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Nikita Popov (nikic) Changes If a weak function is missing, still return it's address (zero) rather than failing interpretation. Otherwise we have a mismatch between Interpret() and CanInterpret() resulting in failures that would not occur

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-28 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/92014 >From a436c3faf4017b0c84b45046f6eedef9229d3e1d Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Fri, 10 May 2024 12:42:03 -0700 Subject: [PATCH] Add AddressRange to SB API Summary: This adds new SB API calls and c

[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)

2024-05-28 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/87550 >From e86d5f95f74a0b2b5f8ec334d8fd4ff519fe7b27 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Fri, 24 May 2024 09:19:12 -0400 Subject: [PATCH 1/2] [lldb]Clean up breakpoint filters - added util function for que

[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)

2024-05-28 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/87550 >From e86d5f95f74a0b2b5f8ec334d8fd4ff519fe7b27 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Fri, 24 May 2024 09:19:12 -0400 Subject: [PATCH 1/3] [lldb]Clean up breakpoint filters - added util function for que

[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)

2024-05-28 Thread Vy Nguyen via lldb-commits
oontvoo wrote: @clayborg Hi, do you have any further comments/feedback on this? Thanks! (If not, I plan to merge this in the next few days) https://github.com/llvm/llvm-project/pull/87550 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-28 Thread Nikita Popov via lldb-commits
nikic wrote: > > FYI this causes a minor compile-time improvement in stage1 builds using > > gcc: > > https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u > > While that's nice, it does s

[Lldb-commits] [lldb] cde1ae4 - [lldb][NativePDB] Fix uninitialized values found by msan.

2024-05-28 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2024-05-28T11:12:21-04:00 New Revision: cde1ae4c14eecd47215f04d4387845231021d939 URL: https://github.com/llvm/llvm-project/commit/cde1ae4c14eecd47215f04d4387845231021d939 DIFF: https://github.com/llvm/llvm-project/commit/cde1ae4c14eecd47215f04d4387845231021d939.diff LOG

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-28 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/92328 >From d6de8d9a8bc709b5c4761e9a05f9befede938734 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 15 May 2024 13:58:42 -0400 Subject: [PATCH 1/3] Reapply [lldb][DWARF] Delay struct/class/union definition DIE s

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-28 Thread Zequan Wu via lldb-commits
ZequanWu wrote: I removed the checking for DW_AT_declaration attributes when completing type from a DIE and applied https://github.com/llvm/llvm-project/pull/91808 to here to ensure we always have a definition DIE at that point. https://github.com/llvm/llvm-project/pull/92328

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 71fbbb69d63c461f391cbabf1e32cd9977c4ce68 a2442a2211e75d19db99a24c22961bdfe7c80e07 --

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-28 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/92328 >From d6de8d9a8bc709b5c4761e9a05f9befede938734 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 15 May 2024 13:58:42 -0400 Subject: [PATCH 1/4] Reapply [lldb][DWARF] Delay struct/class/union definition DIE s

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-28 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Discussed with Pavel, I applied this change to https://github.com/llvm/llvm-project/pull/92328/ so we can ensure the DIEs from the index is always definition DIEs and avoid duplicate/expensive checks later. https://github.com/llvm/llvm-project/pull/91808 ___

[Lldb-commits] [lldb] [lldb-dap] Don't call GetNumChildren on non-indexed synthetic variables (PR #93534)

2024-05-28 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. Thanks for doing this. Btw, that was a clever way of testing this functionality. https://github.com/llvm/llvm-project/pull/93534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-28 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 51dd4ea - Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (#92328)

2024-05-28 Thread via lldb-commits
Author: Zequan Wu Date: 2024-05-28T11:49:07-04:00 New Revision: 51dd4eaaa29683c16151f5168e7f8645acbd6e6c URL: https://github.com/llvm/llvm-project/commit/51dd4eaaa29683c16151f5168e7f8645acbd6e6c DIFF: https://github.com/llvm/llvm-project/commit/51dd4eaaa29683c16151f5168e7f8645acbd6e6c.diff LOG

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-28 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

2024-05-28 Thread Walter Erquinigo via lldb-commits
@@ -103,7 +103,9 @@ void DAP::SendJSON(const llvm::json::Value &json) { SendJSON(json_str); if (log) { -*log << "<-- " << std::endl +auto now = std::chrono::duration( +std::chrono::system_clock::now().time_since_epoch()); walter-erquinigo w

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/93458 >From 824ad3beb35adb83600e3d4dbce7c6e274fca1a1 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 27 May 2024 11:02:56 + Subject: [PATCH 1/2] [lldb] Fix module name tab completion Module names can be matc

[Lldb-commits] [lldb] [lldb] Adds additional fields to ProcessInfo (PR #91544)

2024-05-28 Thread Fred Grim via lldb-commits
feg208 wrote: @clayborg This pr is ready for re-review https://github.com/llvm/llvm-project/pull/91544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/92014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 42944e4 - Add SBAddressRange and SBAddressRangeList to SB API (#92014)

2024-05-28 Thread via lldb-commits
Author: Miro Bucko Date: 2024-05-28T09:29:10-07:00 New Revision: 42944e4600827738fae868f0df831fb2678be8b4 URL: https://github.com/llvm/llvm-project/commit/42944e4600827738fae868f0df831fb2678be8b4 DIFF: https://github.com/llvm/llvm-project/commit/42944e4600827738fae868f0df831fb2678be8b4.diff LO

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/92014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-28 Thread Greg Clayton via lldb-commits
@@ -254,13 +254,17 @@ bool lldb_private::formatters::LibStdcppStringSummaryProvider( } else addr_of_string = valobj.GetAddressOf(scalar_is_load_addr, &addr_type); - if (addr_of_string != LLDB_INVALID_ADDRESS) { + + // We have to check for host address here + /

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-28 Thread via lldb-commits
@@ -254,13 +254,17 @@ bool lldb_private::formatters::LibStdcppStringSummaryProvider( } else addr_of_string = valobj.GetAddressOf(scalar_is_load_addr, &addr_type); - if (addr_of_string != LLDB_INVALID_ADDRESS) { + + // We have to check for host address here + /

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-28 Thread Pavel Labath via lldb-commits
@@ -906,3 +906,38 @@ def test_ambiguous_command(self): def test_ambiguous_subcommand(self): """Test completing a subcommand of an ambiguous command""" self.complete_from_to("settings s ta", []) + +def test_shlib_name(self): +self.build() +

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-28 Thread Pavel Labath via lldb-commits
@@ -297,8 +312,9 @@ class ModuleCompleter : public Completer { void DoCompletion(SearchFilter *filter) override { filter->Search(*this); } private: - const char *m_file_name; - const char *m_dir_name; + std::optional m_file_name; labath wrote: Yeah, this

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

2024-05-28 Thread Pavel Labath via lldb-commits
@@ -103,7 +103,9 @@ void DAP::SendJSON(const llvm::json::Value &json) { SendJSON(json_str); if (log) { -*log << "<-- " << std::endl +auto now = std::chrono::duration( +std::chrono::system_clock::now().time_since_epoch()); labath wrote: for

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

2024-05-28 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. sounds good then! https://github.com/llvm/llvm-project/pull/93540 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-28 Thread Greg Clayton via lldb-commits
@@ -362,6 +363,36 @@ llvm::json::Value DebuggerStats::ReportStatistics( global_stats.try_emplace("modules", std::move(json_modules)); global_stats.try_emplace("memory", std::move(json_memory)); global_stats.try_emplace("commands", std::move(cmd_stats)); + +// Wh

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-28 Thread Jacob Lalonde via lldb-commits
@@ -254,13 +254,17 @@ bool lldb_private::formatters::LibStdcppStringSummaryProvider( } else addr_of_string = valobj.GetAddressOf(scalar_is_load_addr, &addr_type); - if (addr_of_string != LLDB_INVALID_ADDRESS) { + + // We have to check for host address here + /

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-28 Thread Greg Clayton via lldb-commits
@@ -320,10 +320,13 @@ class SBCommandInterpreter { /// Returns a list of handled commands, output and error. Each element in /// the list is a dictionary with the following keys/values: - /// - "command" (string): The command that was executed. + /// - "command" (string)

[Lldb-commits] [lldb] [lldb] Remove lldbassert in AppleObjCTypeEncodingParser (PR #93332)

2024-05-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense to me. https://github.com/llvm/llvm-project/pull/93332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d1d863c - [lldb] Remove lldbassert in AppleObjCTypeEncodingParser (#93332)

2024-05-28 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-28T10:32:09-07:00 New Revision: d1d863c012cf3d5b407ae06d23a5628ec9510b7c URL: https://github.com/llvm/llvm-project/commit/d1d863c012cf3d5b407ae06d23a5628ec9510b7c DIFF: https://github.com/llvm/llvm-project/commit/d1d863c012cf3d5b407ae06d23a5628ec9510b7c.d

[Lldb-commits] [lldb] [lldb] Remove lldbassert in AppleObjCTypeEncodingParser (PR #93332)

2024-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/93332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f69b6d2 - [lldb] Add missing semicolon (NFC)

2024-05-28 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-28T10:36:20-07:00 New Revision: f69b6d2c99a10847a2d73c7fcd656d2ae22937ce URL: https://github.com/llvm/llvm-project/commit/f69b6d2c99a10847a2d73c7fcd656d2ae22937ce DIFF: https://github.com/llvm/llvm-project/commit/f69b6d2c99a10847a2d73c7fcd656d2ae22937ce.d

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/91570 >From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001 From: Santhosh Kumar Ellendula Date: Fri, 17 Nov 2023 15:09:10 +0530 Subject: [PATCH 1/8] [lldb][test] Add the ability to extract the v

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

2024-05-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/93540 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-05-28 Thread Greg Clayton via lldb-commits
@@ -254,13 +254,17 @@ bool lldb_private::formatters::LibStdcppStringSummaryProvider( } else addr_of_string = valobj.GetAddressOf(scalar_is_load_addr, &addr_type); - if (addr_of_string != LLDB_INVALID_ADDRESS) { + + // We have to check for host address here + /

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/91570 >From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001 From: Santhosh Kumar Ellendula Date: Fri, 17 Nov 2023 15:09:10 +0530 Subject: [PATCH 1/9] [lldb][test] Add the ability to extract the v

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Santhosh Kumar Ellendula via lldb-commits
@@ -0,0 +1,146 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import lldb

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c09787b7d05083791b417c5b97a8cfd6d0874ed9 023b51e61e3e5127dc2289ea47e2e4d3e7a6db26 --

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/91570 >From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001 From: Santhosh Kumar Ellendula Date: Fri, 17 Nov 2023 15:09:10 +0530 Subject: [PATCH 01/10] [lldb][test] Add the ability to extract the

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-28 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90930 >From b72df8cf2a047ed731913609b58bdb4a3601e111 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 2 May 2024 18:12:04 -0700 Subject: [PATCH 1/5] Single thread timeout feature --- lldb/include/lldb/Targ

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-28 Thread Daniel Thornburgh via lldb-commits
mysterymath wrote: I did some brief investigation on our end. The pkg-config file for libedit includes a private dependency on libncurses, which provides the terminfo functions. The issue here seems to be one uncovered in LLVM's FindLibEdit.cmake. We're building against a static libedit, but t

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-28 Thread Alex Langford via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-28 Thread Alex Langford via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Walter Erquinigo via lldb-commits
@@ -749,9 +752,30 @@ void request_attach(const llvm::json::Object &request) { // Disable async events so the attach will be successful when we return from // the launch call and the launch will happen synchronously g_dap.debugger.SetAsync(false); -if (core_file

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Walter Erquinigo via lldb-commits
@@ -0,0 +1,142 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import lldb

[Lldb-commits] [lldb] [lldb/DWARF] Bypass the compres^Wconstruction of DIERefs in debug_names (PR #93296)

2024-05-28 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -183,27 +181,22 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( llvm::function_ref callback) { // Keep a list of incomplete types as fallback for when we don't find the // complete type. - DIEArray incomplete_types; + std::vector incomplete_types; -

[Lldb-commits] [lldb] [lldb/DWARF] Bypass the compres^Wconstruction of DIERefs in debug_names (PR #93296)

2024-05-28 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. I think this should probably be fine (perf-wise)! https://github.com/llvm/llvm-project/pull/93296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-28 Thread via lldb-commits
jimingham wrote: This patch has been causing the Darwin bots on GreenDragon to fail consistently since it was submitted. The problem is that the lldb/unitest/EditLine needs setupterm which comes from libcurses.dylib. However that was finding its way into this build line for this test, it's n

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-28 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: `LLDB_CURSES_LIBS` is scoped to lldbCore, which the EditLine unit test isn't linking. If its also necessary in Host, then we should hoist it up and link both libraries against it. Anyway, that also means my initial assessment was wrong. I looked for the header include but

[Lldb-commits] [lldb] [lldb/DWARF] Bypass the compres^Wconstruction of DIERefs in debug_names (PR #93296)

2024-05-28 Thread Greg Clayton via lldb-commits
clayborg wrote: LGTM as well. Avoiding bouncing between two different DIE representations is a good thing. https://github.com/llvm/llvm-project/pull/93296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Greg Clayton via lldb-commits
@@ -348,6 +348,17 @@ "type": "string", "description": "The time in seconds to wait for a program to stop when attaching using \"attachCommands\". Defaults to 30 seconds." }, + "port": { +"type": [ +

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/91570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Greg Clayton via lldb-commits
@@ -749,9 +752,30 @@ void request_attach(const llvm::json::Object &request) { // Disable async events so the attach will be successful when we return from // the launch call and the launch will happen synchronously g_dap.debugger.SetAsync(false); -if (core_file

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Greg Clayton via lldb-commits
@@ -348,6 +348,17 @@ "type": "string", "description": "The time in seconds to wait for a program to stop when attaching using \"attachCommands\". Defaults to 30 seconds." }, + "port": { +"type": [ +

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Just a few questions if we want to prefix these settings with `"gdb-remote"` as suggested. Please chime in if you have any opinions on the matter. https://github.com/llvm/llvm-project/pull/91570 ___ lldb-commits

[Lldb-commits] [lldb] 0380044 - Fix the EditLine unittest build on Darwin after PR 92865

2024-05-28 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2024-05-28T17:47:08-07:00 New Revision: 0380044e16a1c016e001a56c0ca7f4db649a6cae URL: https://github.com/llvm/llvm-project/commit/0380044e16a1c016e001a56c0ca7f4db649a6cae DIFF: https://github.com/llvm/llvm-project/commit/0380044e16a1c016e001a56c0ca7f4db649a6cae.diff LO

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-28 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: I have a follow up question. For case talked about here earlier: "namespace A { namespace B { struct State { class InnerState{}; }; } } A::B::State::InnerState get_state() { return A::B::State::InnerState(); }" After David fix clang generates: ``` Name 3 { Hash: 0xE0CDC6A2

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

2024-05-28 Thread Louis Dionne via lldb-commits
ldionne wrote: Can we either finish this up or close it, please? I'd like to tidy up the libc++ review queue. https://github.com/llvm/llvm-project/pull/86806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] 6abc387 - Revert "Fix the EditLine unittest build on Darwin after PR 92865"

2024-05-28 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2024-05-28T18:16:13-07:00 New Revision: 6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6 URL: https://github.com/llvm/llvm-project/commit/6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6 DIFF: https://github.com/llvm/llvm-project/commit/6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6.diff LO

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

2024-05-28 Thread via lldb-commits
https://github.com/AngryLoki closed https://github.com/llvm/llvm-project/pull/86806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

2024-05-28 Thread via lldb-commits
AngryLoki wrote: This is going nowhere, I'll close it and create a separate PR for libcxx. Also `transitive_includes.gen.py` somehow (due to automatic git conflict resolution?) got damaged indentations, so it would require new review anyways. https://github.com/llvm/llvm-project/pull/86806

[Lldb-commits] [lldb] [lldb] Update LLDB testsuite's Makefile.rules in order to support the cross builds on Windows host. (PR #93639)

2024-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka created https://github.com/llvm/llvm-project/pull/93639 These changes do the following: * avoids usage of $(findstring) within $(CC) to detect a type of specified C compiler. Also they change a way to get a counterpart C++ compiler instead of modifying the origi

[Lldb-commits] [lldb] [lldb] Wrap Unix-style path inside appropriate API test Makefiles. (PR #93643)

2024-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka created https://github.com/llvm/llvm-project/pull/93643 Some of the API tests use Makefiles with the custom rules to manipulate the source code files. This patch normalizes their file pathes to Unix-style on the Windows build host and avoids compiler/linker error

[Lldb-commits] [lldb] [lldb] Allow using a custom 'strip' tool for the API tests. (PR #93645)

2024-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka created https://github.com/llvm/llvm-project/pull/93645 Allow passing any custom 'strip' tool, such as 'llvm-strip', to use with the LLDB API tests. The tool can be provided via LLDB_TEST_COMMON_ARGS_VAR CMake variable: `..;--env STRIP=${CMAKE_STRIP};...`. Depe

[Lldb-commits] [lldb] [lldb] Allow using a custom 'strip' tool for the API tests. (PR #93645)

2024-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladimir Vereschaka (vvereschaka) Changes Allow passing any custom 'strip' tool, such as 'llvm-strip', to use with the LLDB API tests. The tool can be provided via LLDB_TEST_COMMON_ARGS_VAR CMake variable: `..;--env STRIP=${CMAKE_STRIP};.

[Lldb-commits] [lldb] [lldb][tests] Fix passing pthread library to a linker for some API tests. (PR #93648)

2024-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka created https://github.com/llvm/llvm-project/pull/93648 Specify ENABLE_THREADS := YES within test's Makefile instead passing -lpthread throuhg the compiler's CFLAGS options. Updated the following tests: * lldb/test/API/commands/register/register/aarch64_sme_z_r

[Lldb-commits] [lldb] [lldb][tests] Fix passing pthread library to a linker for some API tests. (PR #93648)

2024-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladimir Vereschaka (vvereschaka) Changes Specify ENABLE_THREADS := YES within test's Makefile instead passing -lpthread throuhg the compiler's CFLAGS options. Updated the following tests: * lldb/test/API/commands/register/register/aarch

[Lldb-commits] [lldb] [lldb][tests] Fix TestStdCXXDisassembly test when running on the remote Linux targets. (PR #93649)

2024-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka created https://github.com/llvm/llvm-project/pull/93649 The test expects 'libstdc++' SO module in the module list. Force using StdC++ by specifying USE_LIBSTDCPP := 1 in the test's Makefile. >From 741f69159b88c208ec0848b9c6d97be78f64383f Mon Sep 17 00:00:00 2001

[Lldb-commits] [lldb] [lldb][tests] Fix TestStdCXXDisassembly test when running on the remote Linux targets. (PR #93649)

2024-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladimir Vereschaka (vvereschaka) Changes The test expects 'libstdc++' SO module in the module list. Force using StdC++ by specifying USE_LIBSTDCPP := 1 in the test's Makefile. --- Full diff: https://github.com/llvm/llvm-project/pull/93649

[Lldb-commits] [lldb] [lldb][tests] Fix TestStdCXXDisassembly test when running on the remote Linux targets. (PR #93649)

2024-05-28 Thread Vladimir Vereschaka via lldb-commits
https://github.com/vvereschaka edited https://github.com/llvm/llvm-project/pull/93649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][tests] Fix TestStdCXXDisassembly test when running on the remote Linux targets. (PR #93649)

2024-05-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r cbf6e93ceee7b9de2b7c3e7e8cea3a972eda0e75...741f69159b88c208ec0848b9c6d97be78f64383f lldb/