SuperSodaSea wrote:
Ping.
https://github.com/llvm/llvm-project/pull/68485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/77428
…guments of scalar type
Initially https://reviews.llvm.org/D140996
Author: @bolshakov-a
I do not plan to work on this, but I'm trying to salvage what I can from
phabricator. This review, is completely gone. I
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
…guments of scalar type
Initially https://reviews.llvm.org/D140996
Author: @bolshakov-a
I do not plan to work on this, but I'm trying to salvage what I can from
phabricator. This rev
@@ -839,9 +839,11 @@ bool WebAssemblyFastISel::selectCall(const Instruction *I)
{
unsigned Reg;
-if (Attrs.hasParamAttr(I, Attribute::SExt))
+if (Attrs.hasParamAttr(I, Attribute::SExt) ||
+(IsDirect && Func->hasParamAttribute(I, Attribute::SExt)))
---
DavidSpickett wrote:
Surprised that no one is using that constructor, and if that's true - is this
change to support something else or just making sure we don't make a mistake in
future if we do use this class?
https://github.com/llvm/llvm-project/pull/77380
___
asb wrote:
In case anyone was wondering how this is handled in SelectionDAG, I believe
it's covered by CallLoweringInfo ultimately determining if an arg is sext/zext
through CallBase::paramHasAttr, which does indeed check both the callsite and
the called function (if it's a direct call of cour
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/77157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2574,11 +2574,12 @@ void SymbolFileDWARF::FindFunctions(const
Module::LookupInfo &lookup_info,
Module::LookupInfo no_tp_lookup_info(lookup_info);
no_tp_lookup_info.SetLookupName(ConstString(name_no_template_params));
- m_index->GetFunctions(no_tp_lookup_i
@@ -2574,11 +2574,12 @@ void SymbolFileDWARF::FindFunctions(const
Module::LookupInfo &lookup_info,
Module::LookupInfo no_tp_lookup_info(lookup_info);
no_tp_lookup_info.SetLookupName(ConstString(name_no_template_params));
- m_index->GetFunctions(no_tp_lookup_i
https://github.com/felipepiovezan approved this pull request.
LGTM! Thanks for trying out my suggestions!
https://github.com/llvm/llvm-project/pull/76111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/77121
>From b1ae660f7a7e719ff116463dd74766d7acc9207f Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 11 Dec 2023 12:42:40 -0300
Subject: [PATCH 1/5] [lldb][[DWARFDeclContext] Add function to
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
Author: Michael Buch
Date: 2024-01-09T16:02:56Z
New Revision: 4ea5c603b4c4db36b8ee7e04adf96416f4d996dc
URL:
https://github.com/llvm/llvm-project/commit/4ea5c603b4c4db36b8ee7e04adf96416f4d996dc
DIFF:
https://github.com/llvm/llvm-project/commit/4ea5c603b4c4db36b8ee7e04adf96416f4d996dc.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/75926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nour1248 created
https://github.com/llvm/llvm-project/pull/77493
None
>From 4a8855eb6b54e2e073f1ee9384ec3dfc399657a5 Mon Sep 17 00:00:00 2001
From: Nour Fouad
Date: Tue, 9 Jan 2024 18:08:45 +0200
Subject: [PATCH] [clangd] Fix typo in AST.cpp
---
clang-tools-extra/clangd/AS
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it i
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: None (Nour1248)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/77493.diff
1 Files Affected:
- (modified) clang-tools-extra/clangd/AST.cpp (+5-5)
``diff
diff --git a/clang-tools-extra/clangd/AST.cpp b/clang
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4ea5c603b4c4db36b8ee7e04adf96416f4d996dc
938019a3c34e322b6ead871dd66d973e50c084f1 --
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76983
>From f92402067fcdb6b87adcf3d727bff1888ebf4ab7 Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Thu, 4 Jan 2024 18:43:54 +0100
Subject: [PATCH 1/2] [lldb][libc++] Adds some C++20 calendar data formatters.
Thi
mordante wrote:
Thanks for the reviews!
https://github.com/llvm/llvm-project/pull/76983
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Mark de Wever
Date: 2024-01-09T17:19:10+01:00
New Revision: b5f2db940643af3837c77adde1dadb7208922211
URL:
https://github.com/llvm/llvm-project/commit/b5f2db940643af3837c77adde1dadb7208922211
DIFF:
https://github.com/llvm/llvm-project/commit/b5f2db940643af3837c77adde1dadb7208922211.diff
https://github.com/mordante closed
https://github.com/llvm/llvm-project/pull/76983
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
> Also, I noticed some error messages were different for some tests — I'm
> guessing they may have changed in newer versions of libipt.
That makes sense. In this case I'd just drop text comparisons for those tests.
Just knowing that an error was found is good enough.
>
walter-erquinigo wrote:
Just let me know when your changes are ready and only that test fails.
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
ashgti wrote:
cc @walter-erquinigo since this looks like it has similar overlap to the auto
generated summeries.
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
nmosier wrote:
Sounds good. My changes are ready -- only that `testStartPerCpuSession` test is
failing now.
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bolshakov-a wrote:
@cor3ntin, thank you! Could you please take a look and probably merge #71077?
This depends on that PR.
https://github.com/llvm/llvm-project/pull/77428
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
@@ -3,8 +3,8 @@
# Out of range immediates
## simm12
-flh ft1, -2049(a0) # CHECK: :[[@LINE]]:10: error: operand must be a symbol
with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047]
-fsh ft2, 2048(a1) # CHECK: :[[@LINE]]:10: error: operand must be a s
@@ -242,19 +254,57 @@ def do_test_scopes_variables_setVariable_evaluate(
},
"pt": {
"equals": {"type": "PointType"},
-"startswith": {
-"result": "{x:11, y:22}"
+"equals": {
+
@@ -135,6 +135,18 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
+ lldb::SBStream stream;
+ value.GetDescription(stream);
walter-erquinigo wrote:
The method `bool
@@ -0,0 +1,44 @@
+# RUN: llvm-mc -filetype=obj -triple riscv32 < %s --defsym RV32=1 |
llvm-objdump -d -M no-aliases - | FileCheck %s --check-prefixes=INST,RV32
+# RUN: llvm-mc -filetype=obj -triple riscv64 < %s | llvm-objdump -d -M
no-aliases - | FileCheck %s --check-prefixes=I
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 1/9] [libc++] Implement ranges::contains_subrange
---
libcxx/i
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/10] [libc++] Implement ranges::contains_subrange
---
libcxx
bolshakov-a wrote:
Have I understood correctly that I should open my own PR to proceed working on
this?
https://github.com/llvm/llvm-project/pull/77428
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
nmosier wrote:
@walter-erquinigo Could you merge this PR for me? I don't have commit access.
Thanks!
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
walter-erquinigo wrote:
@ashgti , for some reason I can't assign you as reviewer for this PR, but PTAL!
https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -71,6 +71,18 @@ enum Fixups {
// Used to generate an R_RISCV_ALIGN relocation, which indicates the linker
// should fixup the alignment after linker relaxation.
fixup_riscv_align,
+ // 20-bit fixup corresponding to %tlsdesc_hi(foo) for instructions like
+ // auipc
+
cor3ntin wrote:
Sure! I will close this one.
I wasn't sure you were around and honestly a bit concerned about all the
work that is going to be lost on phabricator.
On Tue, Jan 9, 2024, 18:38 Andrey Ali Khan Bolshakov <
***@***.***> wrote:
> Have I understood correctly that I should open my own
ilovepi wrote:
> The base branch can be edited if you click "Edit" near the title, which will
> help reveal the lld side changes...
hmm, I was hoping that would work, but the base branch is in my fork. I think
to make it work correctly I'd have to be using the "user" branches in the main
repo
https://github.com/EthanLuisMcDonough updated
https://github.com/llvm/llvm-project/pull/76587
>From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001
From: Ethan Luis McDonough
Date: Fri, 15 Dec 2023 20:38:38 -0600
Subject: [PATCH 1/9] Add profiling functions to libomptarget
--
bolshakov-a wrote:
Seems like I should ping reviewers more actively... Ok, thanks, I'll probably
proceed at the weekend.
https://github.com/llvm/llvm-project/pull/77428
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -959,8 +959,12 @@ void CodeGenPGO::emitCounterIncrement(CGBuilderTy
&Builder, const Stmt *S,
unsigned Counter = (*RegionCounterMap)[S];
- llvm::Value *Args[] = {FuncNameVar,
- Builder.getInt64(FunctionHash),
+ // Make sure that pointer to globa
@@ -2574,11 +2574,12 @@ void SymbolFileDWARF::FindFunctions(const
Module::LookupInfo &lookup_info,
Module::LookupInfo no_tp_lookup_info(lookup_info);
no_tp_lookup_info.SetLookupName(ConstString(name_no_template_params));
- m_index->GetFunctions(no_tp_lookup_i
Author: Adrian Prantl
Date: 2024-01-09T10:45:30-08:00
New Revision: fa9284589f111cfd3614a75bfbe0709db39a8f15
URL:
https://github.com/llvm/llvm-project/commit/fa9284589f111cfd3614a75bfbe0709db39a8f15
DIFF:
https://github.com/llvm/llvm-project/commit/fa9284589f111cfd3614a75bfbe0709db39a8f15.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/77157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/10] [libc++] Implement ranges::contains_subrange
---
libcxx
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/11] [libc++] Implement ranges::contains_subrange
---
libcxx
@@ -959,8 +959,12 @@ void CodeGenPGO::emitCounterIncrement(CGBuilderTy
&Builder, const Stmt *S,
unsigned Counter = (*RegionCounterMap)[S];
- llvm::Value *Args[] = {FuncNameVar,
- Builder.getInt64(FunctionHash),
+ // Make sure that pointer to globa
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Nicholas Mosier
Date: 2024-01-09T10:58:47-08:00
New Revision: a50ea2f76f993f65c8756067f7ad5a21e560b0c9
URL:
https://github.com/llvm/llvm-project/commit/a50ea2f76f993f65c8756067f7ad5a21e560b0c9
DIFF:
https://github.com/llvm/llvm-project/commit/a50ea2f76f993f65c8756067f7ad5a21e560b0c9.dif
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,7 +1,7 @@
{
"name": "lldb-dap",
- "displayName": "LLDB VSCode",
- "version": "0.1.0",
+ "displayName": "LLDB DAP",
ashgti wrote:
This file has a mix of tabs and spaces of various sizes, should this be
standardized one way or the
@@ -0,0 +1,57 @@
+import * as vscode from "vscode";
+import { LLDBDapOptions } from "./types";
+import { DisposableContext } from "./disposable-context";
+import { LLDBDapDescriptorFactory } from "./debug-adapter-factory";
+import * as fs from 'fs/promises'
ashgti
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,57 @@
+import * as vscode from "vscode";
+import { LLDBDapOptions } from "./types";
+import { DisposableContext } from "./disposable-context";
+import { LLDBDapDescriptorFactory } from "./debug-adapter-factory";
+import * as fs from 'fs/promises'
+
+/**
+ * This creates
jimingham wrote:
I don't understand why step 2 is necessary; what does the optional actually
add? Is there a useful distinction between "I got an optional
that was empty" and "I got a ValueObjectSP with an error"? I didn't see any
places where you use that distinction.
Returning the optio
https://github.com/mordante closed
https://github.com/llvm/llvm-project/pull/77058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mordante wrote:
Done.
https://github.com/llvm/llvm-project/pull/77058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/77380
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,123 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/adk9 updated https://github.com/llvm/llvm-project/pull/75960
>From a43ef7289cd7f5353fc4b365566011b93879e8f6 Mon Sep 17 00:00:00 2001
From: Abhishek Kulkarni
Date: Tue, 19 Dec 2023 10:50:26 -0800
Subject: [PATCH] Fix generation of python bindings for async dialect
---
.../mli
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/11] [libc++] Implement ranges::contains_subrange
---
libcxx
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/12] [libc++] Implement ranges::contains_subrange
---
libcxx
@@ -0,0 +1,171 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
@@ -0,0 +1,57 @@
+import * as vscode from "vscode";
+import { LLDBDapOptions } from "./types";
+import { DisposableContext } from "./disposable-context";
+import { LLDBDapDescriptorFactory } from "./debug-adapter-factory";
+import * as fs from 'fs/promises'
+
+/**
+ * This creates
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/77124
>From 1c774e6c6ae3c5c7be9291677651d20c8979c7f5 Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Fri, 5 Jan 2024 01:17:39 +
Subject: [PATCH 1/6] [mlir][sparse][CRunnerUtils] Add shuffle and shuffleFree
@@ -176,6 +177,14 @@ extern "C" void rtdrand(void *g) {
delete generator;
}
+extern "C" void _mlir_ciface_shuffle(StridedMemRefType *mref,
+ void *g) {
+ std::mt19937 *generator = static_cast(g);
+ uint64_t s = mref->sizes[0];
--
@@ -0,0 +1,123 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH 1/3] [lldb-dap] Updating VariableDescription to use
GetDescription(
@@ -242,19 +254,57 @@ def do_test_scopes_variables_setVariable_evaluate(
},
"pt": {
"equals": {"type": "PointType"},
-"startswith": {
-"result": "{x:11, y:22}"
+"equals": {
+
@@ -135,6 +135,18 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
+ lldb::SBStream stream;
+ value.GetDescription(stream);
ashgti wrote:
Updated `bool SBValue::GetD
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/12] [libc++] Implement ranges::contains_subrange
---
libcxx
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/13] [libc++] Implement ranges::contains_subrange
---
libcxx
Author: Kazu Hirata
Date: 2024-01-09T12:04:20-08:00
New Revision: 47605ffec8864e989905027b2f56277e2dc8b8fa
URL:
https://github.com/llvm/llvm-project/commit/47605ffec8864e989905027b2f56277e2dc8b8fa
DIFF:
https://github.com/llvm/llvm-project/commit/47605ffec8864e989905027b2f56277e2dc8b8fa.diff
L
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/13] [libc++] Implement ranges::contains_subrange
---
libcxx
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/14] [libc++] Implement ranges::contains_subrange
---
libcxx
PortalPete wrote:
> Surprised that no one is using that constructor, and if that's true - is this
> change to support something else or just making sure we don't make a mistake
> in future if we do use this class?
Me too!
I'm was working on another patch and figured out this is why I couldn't
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
@@ -0,0 +1,54 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
@@ -1149,9 +1171,11 @@ struct Proxy {
// Calling swap(Proxy{}, Proxy{}) would fail (pass prvalues)
// Compare operators are defined for the convenience of the tests
- friend constexpr bool operator==(const Proxy&, const Proxy&)
-requires (std::equality_comparable && !
PortalPete wrote:
> I don't understand why step 2 is necessary; what does the optional actually
> add? Is there a useful distinction between "I got an optional that was empty"
> and "I got a ValueObjectSP with an error"? I didn't see any places where you
> use that distinction.
>
> Returning
ilovepi wrote:
@MaskRay , do you think this is worth abandoning in favor of
https://github.com/llvm/llvm-project/pull/77516? If so, I guess I'd also need
to abandon https://github.com/llvm/llvm-project/pull/66915, which is
unfortunate.
https://github.com/llvm/llvm-project/pull/66916
_
ilovepi wrote:
@topperc @MaskRay , do either of you have strong feelings about abandoning this
in favor of https://github.com/llvm/llvm-project/pull/77515? That PR was made
w/ `spr` and should be a bit easier to understand/review (since it won't have
merge or fixup commits) and will make the L
https://github.com/Yujinmon updated
https://github.com/llvm/llvm-project/pull/77479
>From b5586e9935d30a587323699aac2213bae5d14174 Mon Sep 17 00:00:00 2001
From: Yujin <78896558+yujin...@users.noreply.github.com>
Date: Tue, 9 Jan 2024 23:14:52 +0900
Subject: [PATCH 1/2] fixed typo error about se
rnk wrote:
> > I would like some measurements so we can compare build times on Windows.
>
> I took some benchmarks with `-ftime-trace` on the parse times with and
> without this change.
> ...
> clang-cl built with this PR frontend took ~1368ms to parse. `intrin.h` took
> ~969ms to parse. Most
jimingham wrote:
> On Jan 9, 2024, at 12:29 PM, Pete Lawrence ***@***.***> wrote:
>
>
> I don't understand why step 2 is necessary; what does the optional actually
> add? Is there a useful distinction between "I got an optional that was empty"
> and "I got a ValueObjectSP with an error"? I
@@ -242,19 +254,57 @@ def do_test_scopes_variables_setVariable_evaluate(
},
"pt": {
"equals": {"type": "PointType"},
-"startswith": {
-"result": "{x:11, y:22}"
+"equals": {
+
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
just two minor things left, but otherwise LGTM
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
@@ -135,6 +135,21 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
walter-erquinigo wrote:
add a comment for this function mentioning that this returns an empty string
@@ -135,6 +135,21 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
+ lldb::SBStream stream;
+ if (!value.GetDescription(stream)) {
+return "";
+ }
walter-erquini
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/77380
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 145 matches
Mail list logo
