[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

DavidSpickett added a comment. Tests LGTM, thanks. @clayborg please approve if they look good to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/ https://reviews.llvm.org/D155256 ___ lldb-

[Lldb-commits] [PATCH] D155768: [lldb] [NFC] Remove some dead code from Watchpoint class, and a method that makes no sense

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I don't understand the logic for if the hit counter is < the number of false alarms. I'm not even sure that's possible given that a false alarm would have to come from a reported

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve added a comment. Hi @clayborg, just wanted to make sure this doesn't fall off your radar :) This fixes all outstanding DWARF 5 issues with Debug Maps, so it would be cool if we could get this in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 8ef0448 - Reland "[CUDA][HIP] Use the same default language std as C++""

Author: Yaxun (Sam) Liu Date: 2023-07-20T12:02:33-04:00 New Revision: 8ef04488d128853715a55683f0181d6398d23c61 URL: https://github.com/llvm/llvm-project/commit/8ef04488d128853715a55683f0181d6398d23c61 DIFF: https://github.com/llvm/llvm-project/commit/8ef04488d128853715a55683f0181d6398d23c61.dif

[Lldb-commits] [lldb] bbffda6 - [lldb] Skip unsupported CTF types

Author: Jonas Devlieghere Date: 2023-07-20T10:21:33-07:00 New Revision: bbffda645a1cdb5d3426b1d7eca31b0f9a312959 URL: https://github.com/llvm/llvm-project/commit/bbffda645a1cdb5d3426b1d7eca31b0f9a312959 DIFF: https://github.com/llvm/llvm-project/commit/bbffda645a1cdb5d3426b1d7eca31b0f9a312959.d

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

tom.tromey added a comment. > Apart from just implementing type system itself (which is much bigger scope > than this change) there are other non-trivial issues: > > 1. There is no "compiler-as-a-service" in Rust so getting expressions to work > is non-trivial. An interpreter of some sort needs

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/ https://reviews.llvm.org/D155256 __

[Lldb-commits] [PATCH] D155768: [lldb] [NFC] Remove some dead code from Watchpoint class, and a method that makes no sense

jasonmolenda added a comment. Thanks David, yeah I came to the same conclusion about that method. I made hacked up lldb that behaved like the MIPS case to confirm that the hit count is incremented before we decide it's a fake stop & decrement it again. Repository: rG LLVM Github Monorepo C

[Lldb-commits] [lldb] 259e3f2 - Remove IncrementFalseAlarmsAndReviseHitCount, unused ivars

Author: Jason Molenda Date: 2023-07-20T15:16:02-07:00 New Revision: 259e3f2a4fef5ff2cdc0086f432bbfd2493653f5 URL: https://github.com/llvm/llvm-project/commit/259e3f2a4fef5ff2cdc0086f432bbfd2493653f5 DIFF: https://github.com/llvm/llvm-project/commit/259e3f2a4fef5ff2cdc0086f432bbfd2493653f5.diff

[Lldb-commits] [PATCH] D155768: [lldb] [NFC] Remove some dead code from Watchpoint class, and a method that makes no sense

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG259e3f2a4fef: Remove IncrementFalseAlarmsAndReviseHitCount, unused ivars (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

aprantl added a comment. As far as I'm concerned, this doesn't look too controversial to me and it is unblocking one of the bots. I think it would be okay to tentatively land this, but be on the lookout and promptly react to any post-commit feedback from @clayborg. Repository: rG LLVM Githu

[Lldb-commits] [lldb] 49b3c33 - [lldb][x86_64] Support fs_base/gs_base register in Linux

Author: Jeffrey Tan Date: 2023-07-20T16:32:47-07:00 New Revision: 49b3c3355f9c36a023e04bba509ac89d15da6ff9 URL: https://github.com/llvm/llvm-project/commit/49b3c3355f9c36a023e04bba509ac89d15da6ff9 DIFF: https://github.com/llvm/llvm-project/commit/49b3c3355f9c36a023e04bba509ac89d15da6ff9.diff L

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49b3c3355f9c: [lldb][x86_64] Support fs_base/gs_base register in Linux (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda created this revision. jasonmolenda added reviewers: DavidSpickett, jingham, clayborg. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 542743. philnik added a comment. - Address comments - Try to fix CI - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/LanguageExtensions.r

[Lldb-commits] [lldb] e19339f - [lldb] Identify Swift-implemented ObjC classes

Author: Dave Lee Date: 2023-07-20T19:32:12-07:00 New Revision: e19339f5f8c15d4307aaed14309e38e3c87121ac URL: https://github.com/llvm/llvm-project/commit/e19339f5f8c15d4307aaed14309e38e3c87121ac DIFF: https://github.com/llvm/llvm-project/commit/e19339f5f8c15d4307aaed14309e38e3c87121ac.diff LOG:

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe19339f5f8c1: [lldb] Identify Swift-implemented ObjC classes (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [lldb] a6ff60e - [lldb] Delete unused LibcxxOptionalSummaryProvider (NFC)

Author: Dave Lee Date: 2023-07-20T19:32:58-07:00 New Revision: a6ff60ecdd061cc21383108ac092ae4a700f9143 URL: https://github.com/llvm/llvm-project/commit/a6ff60ecdd061cc21383108ac092ae4a700f9143 DIFF: https://github.com/llvm/llvm-project/commit/a6ff60ecdd061cc21383108ac092ae4a700f9143.diff LOG:

[Lldb-commits] [lldb] 8a45a54 - [lldb] Fix -Wreturn-type in RegisterInfos_x86_64_with_base_shared.cpp (NFC)

Author: Jie Fu Date: 2023-07-21T11:42:42+08:00 New Revision: 8a45a54d59fcd29f559f4f260e2c447bef498e1e URL: https://github.com/llvm/llvm-project/commit/8a45a54d59fcd29f559f4f260e2c447bef498e1e DIFF: https://github.com/llvm/llvm-project/commit/8a45a54d59fcd29f559f4f260e2c447bef498e1e.diff LOG: [

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D155117#4510512 , @ted wrote: > In D155117#4505538 , @labath wrote: > >> I am wondering if we actually nee