Author: Jason Molenda
Date: 2021-05-13T00:47:58-07:00
New Revision: afee09751d2d744a753ef4d3e8d83857dcd0f682
URL:
https://github.com/llvm/llvm-project/commit/afee09751d2d744a753ef4d3e8d83857dcd0f682
DIFF:
https://github.com/llvm/llvm-project/commit/afee09751d2d744a753ef4d3e8d83857dcd0f682.diff
DavidSpickett updated this revision to Diff 345099.
DavidSpickett added a comment.
Address all comments apart from address handling that I need
to spend some time thinking about.
It may end up that the best way to do this is have the tag manager
provide a way to remove only the tags and let the o
DavidSpickett updated this revision to Diff 345105.
DavidSpickett added a comment.
Rebase, fix missed clang-format-ing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97282/new/
https://reviews.llvm.org/D97282
Files:
lldb/include/lldb/Host/common
DavidSpickett updated this revision to Diff 345106.
DavidSpickett added a comment.
Address comments in general.
Added an assert in the loop where we call ptrace
so that we catch any unexpected condition that would
make it an infinite loop.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
DavidSpickett marked 2 inline comments as done.
DavidSpickett added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1464
+ // get all tags back.
+ while (num_tags > 0) {
+tags_vec.iov_base = dest;
omjavaid wrote:
> this
DavidSpickett updated this revision to Diff 345113.
DavidSpickett added a comment.
Rebase, fix use of SendPacketAndWaitForResponse.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95602/new/
https://reviews.llvm.org/D95602
Files:
lldb/include/lldb
DavidSpickett updated this revision to Diff 345117.
DavidSpickett added a comment.
Rebase onto earlier patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97285/new/
https://reviews.llvm.org/D97285
Files:
lldb/source/Commands/CMakeLists.txt
Author: Jonas Devlieghere
Date: 2021-05-13T10:27:22-07:00
New Revision: ce12b52de2fb3f319ff18effc4ea9ff4d369f328
URL:
https://github.com/llvm/llvm-project/commit/ce12b52de2fb3f319ff18effc4ea9ff4d369f328
DIFF:
https://github.com/llvm/llvm-project/commit/ce12b52de2fb3f319ff18effc4ea9ff4d369f328.d
Author: Jonas Devlieghere
Date: 2021-05-13T10:27:22-07:00
New Revision: f93e9c12bf482dbfe3d4d00fcf8bbc251500dd99
URL:
https://github.com/llvm/llvm-project/commit/f93e9c12bf482dbfe3d4d00fcf8bbc251500dd99
DIFF:
https://github.com/llvm/llvm-project/commit/f93e9c12bf482dbfe3d4d00fcf8bbc251500dd99.d
vsk created this revision.
vsk added reviewers: JDevlieghere, jingham, jasonmolenda.
Herald added subscribers: omjavaid, kristof.beyls.
vsk requested review of this revision.
Herald added a project: LLDB.
Upstream lldb support for summarizing BLRAx and LDRAx auth failures.
rdar://41615322
Repos
shafik created this revision.
shafik added reviewers: aprantl, teemperor, labath.
shafik requested review of this revision.
We have a bug in which using `member_clang_type.GetByteSize()` triggers record
layout and during this process since the record was not yet complete we ended
up reaching a r
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
The change itself seems good to me, I wonder what we can do to prevent a
similar mistake in the future.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102445/new/
https://reviews.ll
aprantl added a comment.
I guess we could add least add a comment like this?
// By calling member_type instead of member_clang_type, the size comes from
DWARF, which avoids premature record layout.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102445/new/
https://reviews.llvm.org/D1
13 matches
Mail list logo
