[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

labath added a comment. In D92187#2451013 , @mgorny wrote: > In D92187#2450976 , @labath wrote: > >> In D92187#2450526 , @mgorny wrote: >> >>> Another fix: we should only unl

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

mgorny updated this revision to Diff 311552. mgorny added a comment. Compare using weak_ptr to the interpreter module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.c

[Lldb-commits] [PATCH] D93225: [lldb] Add helper class for dealing with key:value; GDB responses

DavidSpickett created this revision. Herald added a subscriber: mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current handling of qHostInfo is a bunch of if-else, one for each key we think we might find. This wor

[Lldb-commits] [PATCH] D93226: [lldb] Apply KeyValueExtractorGDBRemote to qProcessInfo

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The original logic is retained. Unlike qHostInfo, qProcessInfo does not check whether at least one key was parsed correctly. This allowed me

[Lldb-commits] [PATCH] D93225: [lldb] Add helper class for dealing with key:value; GDB responses

DavidSpickett added reviewers: labath, jasonmolenda. DavidSpickett added a comment. I realise it's a lot to review but if you have any initial comments on the usability that'd be great. My main point here was to make the if-else chain a bit "safer" and more easily extended. The parsing logic its

[Lldb-commits] [lldb] d636b88 - Adapt lldb to a40db5502b2515a6f2f1676b5d7a655ae0f41179

Author: Duncan P. N. Exon Smith Date: 2020-12-14T14:41:15-08:00 New Revision: d636b881bb9214938973098a012fad453082c444 URL: https://github.com/llvm/llvm-project/commit/d636b881bb9214938973098a012fad453082c444 DIFF: https://github.com/llvm/llvm-project/commit/d636b881bb9214938973098a012fad453082

[Lldb-commits] [PATCH] D93266: [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch exposes the `Target::CreateBreakpoint` overload with the boolean argument to move to the neareast code to the

[Lldb-commits] [PATCH] D93266: [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBTarget.h:564 + lldb::SBBreakpoint + BreakpointCreateByLocation(const lldb::SBFileSpec &file_spec, uint32_t line, + uint32_t column, lldb::addr_t offset, It's unf

[Lldb-commits] [lldb] 7799ef7 - Revert "Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef"

Author: Nico Weber Date: 2020-12-14T22:05:08-05:00 New Revision: 7799ef7121aa7d59f4bd95cdf70035de724ead6f URL: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f DIFF: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f.diff LO

[Lldb-commits] [PATCH] D93266: [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload

mib updated this revision to Diff 311771. mib added a comment. Address @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93266/new/ https://reviews.llvm.org/D93266 Files: lldb/bindings/interface/SBTarget.i lldb/include/lldb

[Lldb-commits] [PATCH] D93266: [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93266/new/ https://reviews.llvm.org/D93266 _

[Lldb-commits] [lldb] 0470169 - [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload

Author: Med Ismail Bennani Date: 2020-12-15T04:24:44+01:00 New Revision: 04701698ebaff8d0c108e590a7e55c3c5bcd4d9e URL: https://github.com/llvm/llvm-project/commit/04701698ebaff8d0c108e590a7e55c3c5bcd4d9e DIFF: https://github.com/llvm/llvm-project/commit/04701698ebaff8d0c108e590a7e55c3c5bcd4d9e.

[Lldb-commits] [PATCH] D93266: [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04701698ebaf: [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload (authored by mib). Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] 1d3f1eb - Revert "[lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload"

Author: Med Ismail Bennani Date: 2020-12-15T06:18:04+01:00 New Revision: 1d3f1eb855fcfb03b6ddb92543c02694115b5739 URL: https://github.com/llvm/llvm-project/commit/1d3f1eb855fcfb03b6ddb92543c02694115b5739 DIFF: https://github.com/llvm/llvm-project/commit/1d3f1eb855fcfb03b6ddb92543c02694115b5739.

[Lldb-commits] [lldb] dc82890 - [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload

Author: Med Ismail Bennani Date: 2020-12-15T06:18:04+01:00 New Revision: dc82890a77fe894e90103f4465bb4c838617feff URL: https://github.com/llvm/llvm-project/commit/dc82890a77fe894e90103f4465bb4c838617feff DIFF: https://github.com/llvm/llvm-project/commit/dc82890a77fe894e90103f4465bb4c838617feff.