Re: [Lldb-commits] [lldb] r349397 - Remove sleep() synchronisation from teststcase and

Not that I want to defend the use of sleep, but my expectation is that this will the test even more flaky. The only thing that test does after attaching is verifying the process backtrace to check that it contains the "main" function. If the test doesn't sleep, it increases the likelyhood tha

[Lldb-commits] [lldb] r349461 - build.py: inherit environment in the gcc builder

Author: labath Date: Tue Dec 18 01:07:21 2018 New Revision: 349461 URL: http://llvm.org/viewvc/llvm-project?rev=349461&view=rev Log: build.py: inherit environment in the gcc builder Summary: This should enable the compiler to find the system linker for the link step. Reviewers: stella.stamenova,

[Lldb-commits] [PATCH] D55736: build.py: inherit environment in the gcc builder

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349461: build.py: inherit environment in the gcc builder (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D55736?vs=178356&id=178620#toc Repository: rLLDB LLD

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked 2 inline comments as done. tatyana-krasnukha added a comment. My intent was to move ARC-specific code to the architecture plugin as much as possible, but it requires to add undesired dependencies to Architecture interface. So, you are right, it seems to be better to keep

[Lldb-commits] [lldb] r349478 - Un-XFAIL TestNamespaceLookup for linux

Author: labath Date: Tue Dec 18 04:55:30 2018 New Revision: 349478 URL: http://llvm.org/viewvc/llvm-project?rev=349478&view=rev Log: Un-XFAIL TestNamespaceLookup for linux These tests are now passing on linux, at least with top-of-tree clang, clang-6 and gcc-7.3. It's possible it may still be fai

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 178643. tatyana-krasnukha added a comment. Addressed review comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/Utility/ArchSpec.h source/Plug

[Lldb-commits] [lldb] r349479 - Un-XFAIL TestExitDuringBreak.py for linux

Author: labath Date: Tue Dec 18 05:12:36 2018 New Revision: 349479 URL: http://llvm.org/viewvc/llvm-project?rev=349479&view=rev Log: Un-XFAIL TestExitDuringBreak.py for linux This test is passing now on linux, and probably has been passing since r282993. Modified: lldb/trunk/packages/Python

[Lldb-commits] [lldb] r349482 - Un-XFail TestThreadStates.test_process_interrupt

Author: labath Date: Tue Dec 18 05:32:42 2018 New Revision: 349482 URL: http://llvm.org/viewvc/llvm-project?rev=349482&view=rev Log: Un-XFail TestThreadStates.test_process_interrupt This test is passing now on linux. The same test is claimed to be flaky on darwin, so it's possible that's true on

[Lldb-commits] [lldb] r349485 - Un-XFail TestYMMRegister on linux

Author: labath Date: Tue Dec 18 05:50:38 2018 New Revision: 349485 URL: http://llvm.org/viewvc/llvm-project?rev=349485&view=rev Log: Un-XFail TestYMMRegister on linux This test was disabled in r326756 as a part of "upstreaming debugserver support for AVX-512 (zmm register set)". This looks like a

[Lldb-commits] [lldb] r349487 - Skip TestMultithreaded.test_sb_api_listener_resume on linux

Author: labath Date: Tue Dec 18 06:24:55 2018 New Revision: 349487 URL: http://llvm.org/viewvc/llvm-project?rev=349487&view=rev Log: Skip TestMultithreaded.test_sb_api_listener_resume on linux The test still fails occasionally (1/100 runs). Upgrade the xfail to skip. Modified: lldb/trunk/pa

[Lldb-commits] [lldb] r349491 - de-flake TestThreadStates.test_process_interrupt

Author: labath Date: Tue Dec 18 07:15:02 2018 New Revision: 349491 URL: http://llvm.org/viewvc/llvm-project?rev=349491&view=rev Log: de-flake TestThreadStates.test_process_interrupt the "self.assertEqual(thread.GetStopReason(), lldb.eStopReasonSignal)" was occasionally failing because the stop re

[Lldb-commits] [lldb] r349495 - Fix the "dangerous use of tempnam" warning in Host/SocketTest.cpp

Author: labath Date: Tue Dec 18 07:33:50 2018 New Revision: 349495 URL: http://llvm.org/viewvc/llvm-project?rev=349495&view=rev Log: Fix the "dangerous use of tempnam" warning in Host/SocketTest.cpp instead, create a unique temporary directory, and place the socket file there. Modified: lldb

Re: [Lldb-commits] [lldb] r349401 - [lit] Detect unexpected passes in lldbtest.

On 17/12/2018 22:40, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Mon Dec 17 13:40:37 2018 New Revision: 349401 URL: http://llvm.org/viewvc/llvm-project?rev=349401&view=rev Log: [lit] Detect unexpected passes in lldbtest. This patch will have lit report unexpected passes

[Lldb-commits] [lldb] r349498 - ELF: Don't create sections for section header index 0

Author: labath Date: Tue Dec 18 07:56:45 2018 New Revision: 349498 URL: http://llvm.org/viewvc/llvm-project?rev=349498&view=rev Log: ELF: Don't create sections for section header index 0 Summary: The first section header does not define a real section. Instead it is used for various elf extension

[Lldb-commits] [PATCH] D55757: ELF: Don't create sections for section header index 0

This revision was automatically updated to reflect the committed changes. Closed by commit rL349498: ELF: Don't create sections for section header index 0 (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55757?vs=17

[Lldb-commits] [PATCH] D55827: Update current working directory to avoid test crashes

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, zturner. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, abidh. Running `dotest.py` with a path to tests directory results in: terminate called after throwing an instance o

Re: [Lldb-commits] [lldb] r349397 - Remove sleep() synchronisation from teststcase and

> On Dec 18, 2018, at 12:11 AM, Pavel Labath wrote: > > Not that I want to defend the use of sleep, but my expectation is that this > will the test even more flaky. > > The only thing that test does after attaching is verifying the process > backtrace to check that it contains the "main" fu

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

aprantl added a comment. Can you confirm that reverting this path actually fixes the issue? I'm asking because the only test that is executing this script has a REQUIRES: system-darwin line in it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55607/new/ https://

[Lldb-commits] [PATCH] D55827: Update current working directory to avoid test crashes

labath added a comment. Hm... this seems like an important issue in the `RealFileSystem` (or our usage of it), and I'm not sure it should be papered over like that. I mean, lldb is a library, and requiring every call to `chdir` in the whole process go through "our" implementation is not very fr

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

tatyana-krasnukha updated this revision to Diff 178690. tatyana-krasnukha added a comment. Replace vector of unique pointers with vector of values, revert some API changes, remove MinidumpParser changes. I will put overridden GetMemoryRegions in a separate patch. Repository: rLLDB LLDB CHANG

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added a comment. Thanks everyone for your patience with the review. I will spare us the potential merge conflicts before Christmas and land this after the holidays. Cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ ht

[Lldb-commits] [PATCH] D55835: [dotest] Consider unexpected passes as failures.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide, jingham, clayborg. JDevlieghere added a project: LLDB. Unexpected successes should be considered failures because they can hide regressions when not addressed. When a test is fixed and not re-enabled, it can easily

Re: [Lldb-commits] [lldb] r349401 - [lit] Detect unexpected passes in lldbtest.

I understand that it's annoying to fix these tests but I strongly believe it will pay off in the long run. The motivation for this change is that we fixed tests that were XFAILED, but forgot to enable them again. Later they started failing and we didn't notice. This was especially a problem with li

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, sgraenitz, aprantl. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. Herald added a reviewer: EricWF. As discussed on IRC this morning, when building an in-tree clang for testing we have to have libc

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang

mgorny added a comment. How does this affect platforms that use other ABI library than libcxxabi? How does this affect platforms that use libstdc++ as default C++ backend? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55837/new/ https://reviews.llvm.org/D55837

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang

JDevlieghere added a comment. In D55837#1334872 , @mgorny wrote: > How does this affect platforms that use other ABI library than libcxxabi? How > does this affect platforms that use libstdc++ as default C++ backend? I'm not familiar with that use case

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang

labath added a comment. On linux libc++ is not a hard dependency for running tests (in fact, clang will not use it even if it is checked out). I guess that has something to do with the fact that libc++ is not the default c++ implementation on that platform. I think this will need to be darwin-

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS

JDevlieghere added a comment. In D55837#1334893 , @labath wrote: > On linux libc++ is not a hard dependency for running tests (in fact, clang > will not use it even if it is checked out). I guess that has something to do > with the fact that libc++ is n

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS

JDevlieghere updated this revision to Diff 178727. JDevlieghere retitled this revision from "[cmake] Make libcxx(abi) a dependency when building in-tree clang" to "[cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS". JDevlieghere added a comment. Only do this for macOS

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

tatyana-krasnukha updated this revision to Diff 178732. tatyana-krasnukha marked an inline comment as done. tatyana-krasnukha added a comment. Addressed more comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55472/new/ https://reviews.llvm.org/D55472 File

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Moved from D55472 Repository: rLLDB LLDB https://reviews.llvm.org/D55841 Files: C:/Rep

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

stella.stamenova added a comment. In D55607#1334666 , @aprantl wrote: > Can you confirm that reverting this path actually fixes the issue? I'm asking > because the only test that is executing this script has a REQUIRES: > system-darwin line in it. Remo

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

aprantl added a comment. Ah.. that's possible. REQUIRES needs to be very high up in the file, but I don't know what the exact threshold is Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55607/new/ https://reviews.llvm.org/D55607

[Lldb-commits] [lldb] r349533 - Fix REQUIRES line

Author: adrian Date: Tue Dec 18 12:28:54 2018 New Revision: 349533 URL: http://llvm.org/viewvc/llvm-project?rev=349533&view=rev Log: Fix REQUIRES line Modified: lldb/trunk/lit/Python/crashlog.test Modified: lldb/trunk/lit/Python/crashlog.test URL: http://llvm.org/viewvc/llvm-project/lldb/tr

[Lldb-commits] [lldb] r349539 - [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS

Author: jdevlieghere Date: Tue Dec 18 12:59:23 2018 New Revision: 349539 URL: http://llvm.org/viewvc/llvm-project?rev=349539&view=rev Log: [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS As discussed on IRC this morning, when building an in-tree clang for testing we ha

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349539: [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS (authored by JDevlieghere, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

stella.stamenova added a comment. A bunch of the NativePDB tests are failing on Windows now. http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2365/steps/test/logs/stdio Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS

clayborg added inline comments. Comment at: CMakeLists.txt:160 list(APPEND LLDB_TEST_DEPS clang) +if(APPLE) + list(APPEND LLDB_TEST_DEPS cxx) What if the user wants to use a different compiler for tests? cmake has LLDB_TEST_USE_CUSTOM_C_COMPILER an

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: CMakeLists.txt:160 list(APPEND LLDB_TEST_DEPS clang) +if(APPLE) + list(APPEND LLDB_TEST_DEPS cxx) clayborg wrote: > What if the user wants to use a differ

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Change looks good. We need to add a test for this. You can use the minidump file from "lldb/unittests/Process/minidump/Inputs/regions-linux-map.dmp" and copy it over into "lldb

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

aprantl added a comment. Sorry I forgot to comment: this should be fixed in r349533. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55607/new/ https://reviews.llvm.org/D55607 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D55827: Update current working directory to avoid test crashes

JDevlieghere added a comment. In D55827#1334671 , @labath wrote: > Hm... this seems like an important issue in the `RealFileSystem` (or our > usage of it), and I'm not sure it should be papered over like that. I mean, > lldb is a library, and requiring e

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

stella.stamenova added a comment. It looks like this might not be specific to your change as a few other tests are failing with a similar error. I'm looking into it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.org/D55384 _

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added a comment. See inline comments and let me know what you think. Comment at: include/lldb/Utility/ArchSpec.h:91-92 + // ARC configuration flags + enum ARCflags { eARC_rf32 = 0 /*0b00*/, eARC_rf16 = 2 /*0b10*/ }; + Since no other place needs the

[Lldb-commits] [lldb] r349546 - [CMake] Don't require libcxxabi on darwin

Author: jdevlieghere Date: Tue Dec 18 13:40:05 2018 New Revision: 349546 URL: http://llvm.org/viewvc/llvm-project?rev=349546&view=rev Log: [CMake] Don't require libcxxabi on darwin Just libcxx should suffice. Modified: lldb/trunk/CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt URL: http

[Lldb-commits] [lldb] r349550 - TestHelloWorld: Use a file on the target platform for synchronisation.

Author: adrian Date: Tue Dec 18 14:17:38 2018 New Revision: 349550 URL: http://llvm.org/viewvc/llvm-project?rev=349550&view=rev Log: TestHelloWorld: Use a file on the target platform for synchronisation. Thanks to Pavel Labath for the idea! Modified: lldb/trunk/packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D55854: Show the memory region name if there is one in the output of the "memory region" command

clayborg created this revision. clayborg added reviewers: zturner, labath, lemo, jingham. Prior to this change we would show the name of the section that a memory region belonged to but not its actual region name. Now we show this,. Added a test that reuses the regions-linux-map.dmp minidump fil

[Lldb-commits] [lldb] r349553 - Un-conditionalize use of libcompression. debugserver only builds

Author: jmolenda Date: Tue Dec 18 14:21:48 2018 New Revision: 349553 URL: http://llvm.org/viewvc/llvm-project?rev=349553&view=rev Log: Un-conditionalize use of libcompression. debugserver only builds on Darwin systems and libcompression has been in the OS for over three years. Remove use of / l

[Lldb-commits] [lldb] r349562 - [lit] Use the new build.py script in the lldb-mi tests

Author: stella.stamenova Date: Tue Dec 18 14:54:17 2018 New Revision: 349562 URL: http://llvm.org/viewvc/llvm-project?rev=349562&view=rev Log: [lit] Use the new build.py script in the lldb-mi tests This allows the tests to pass on Windows as well Modified: lldb/trunk/lit/Driver/Inputs/hello.

[Lldb-commits] [lldb] r349563 - Force libcompression calls to be enabled when building on Darwin

Author: jmolenda Date: Tue Dec 18 15:02:50 2018 New Revision: 349563 URL: http://llvm.org/viewvc/llvm-project?rev=349563&view=rev Log: Force libcompression calls to be enabled when building on Darwin systems. It has been available in the OS over over three years now. If lldb doesn't link against

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

jankratochvil created this revision. jankratochvil added reviewers: LLDB, labath. jankratochvil added a project: LLDB. Herald added subscribers: abidh, ki.stfu. Currently `spawnLldbMi` accepts both lldb-mi options and executable to debug as a single parameter. Split them. As in the next patch we

[Lldb-commits] [lldb] r349565 - [NativePDB] Correctly reconstruct DeclContext for nested enums.

Author: zturner Date: Tue Dec 18 15:12:08 2018 New Revision: 349565 URL: http://llvm.org/viewvc/llvm-project?rev=349565&view=rev Log: [NativePDB] Correctly reconstruct DeclContext for nested enums. We reconstruct the AST hierarchy by trying to hack up a mangled name for the parent type using the

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil created this revision. jankratochvil added reviewers: LLDB, labath. jankratochvil added a project: LLDB. Herald added subscribers: abidh, ki.stfu. There is already in use: lit/lit-lldb-init:settings set symbols.enable-external-lookup false packages/Python/lldbsuite/test/lldbtest

[Lldb-commits] [lldb] r349572 - Remove the zlib CFLAGS and LDFLAGS settings from the xcode project file.

Author: jmolenda Date: Tue Dec 18 15:33:42 2018 New Revision: 349572 URL: http://llvm.org/viewvc/llvm-project?rev=349572&view=rev Log: Remove the zlib CFLAGS and LDFLAGS settings from the xcode project file. We're linking against libcompression all the time now, we don't need to fall back to zlib.

[Lldb-commits] [lldb] r349573 - [lit] Rather than including stdio.h, forward-declare printf in TestConvenienceVariables.test

Author: stella.stamenova Date: Tue Dec 18 15:36:35 2018 New Revision: 349573 URL: http://llvm.org/viewvc/llvm-project?rev=349573&view=rev Log: [lit] Rather than including stdio.h, forward-declare printf in TestConvenienceVariables.test Modified: lldb/trunk/lit/Driver/Inputs/hello.c Modified

[Lldb-commits] [lldb] r349580 - Don't forget to free the libcompression scratch buffer in the dtor.

Author: jmolenda Date: Tue Dec 18 15:45:45 2018 New Revision: 349580 URL: http://llvm.org/viewvc/llvm-project?rev=349580&view=rev Log: Don't forget to free the libcompression scratch buffer in the dtor. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Modifie