aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
The only question is performance, haven't you checked how much time takes the
preprocessing on huge PDBs? Intuitively it seems that it shouldn't take
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very close, just use the layout type as mentioned in the inline comment.
Comment at: lldb/source/Core/ValueObjectVariable.cpp:70
if (var_type)
-return va
JDevlieghere updated this revision to Diff 173191.
JDevlieghere added a comment.
Update tests to use SB API.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/API/SBThreadPlan.h
include/lldb/Breakpoint/Breakpoint.h
include/lldb/Target/Target.h
include
zturner added a comment.
In https://reviews.llvm.org/D54216#1291453, @aleksandr.urakov wrote:
> Looks good, thank you!
>
> The only question is performance, haven't you checked how much time takes the
> preprocessing on huge PDBs? Intuitively it seems that it shouldn't take too
> much time (n*l
zturner updated this revision to Diff 173194.
zturner added a comment.
Use the layout type instead of the full type, along with a comment explaining
why this is necessary.
https://reviews.llvm.org/D54241
Files:
lldb/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit
lldb/lit/SymbolFile/N
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346428: Refactor
ClangASTContext::AddEnumerationValueToEnumerationType() to remove… (authored by
shafik, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
Author: shafik
Date: Thu Nov 8 10:42:00 2018
New Revision: 346428
URL: http://llvm.org/viewvc/llvm-project?rev=346428&view=rev
Log:
Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove
redundant parameter which can be calculated from other parameter.
rdar://problem/4382299
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D54216#1291852, @zturner wrote:
> I checked on clang.pdb. For my local build of LLVM this about 780MB. It's
> quite slow in debug build (14 seconds for `ParseSectionContribs` and 60
> seconds for `PreprocessTpiStream`), but in rele
Author: zturner
Date: Thu Nov 8 10:50:11 2018
New Revision: 346429
URL: http://llvm.org/viewvc/llvm-project?rev=346429&view=rev
Log:
[NativePDB] Higher fidelity reconstruction of AST from Debug Info.
In order to accurately put a type into the correct location in the AST
we construct from debug i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346429: [NativePDB] Higher fidelity reconstruction of AST
from Debug Info. (authored by zturner, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
Author: zturner
Date: Thu Nov 8 10:50:31 2018
New Revision: 346430
URL: http://llvm.org/viewvc/llvm-project?rev=346430&view=rev
Log:
Fix bug in PE/COFF plugin and ValueObjectVariable.
There are two bugs here. The first is that MSVC and clang-cl
emit their bss section under the name '.data' inst
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346430: Fix bug in PE/COFF plugin and
ValueObjectVariable. (authored by zturner, committed by ).
Herald added subscribers: teemperor, abidh.
Changed prior to commit:
https://reviews.llvm.org/D54241?v
Author: jgorbe
Date: Thu Nov 8 11:57:59 2018
New Revision: 346435
URL: http://llvm.org/viewvc/llvm-project?rev=346435&view=rev
Log:
[lldb] Fix initialization order warnings.
Moved the declaration of m_kind below the declaration of cvclass,
cvunion and cvenum. This order is necessary because in o
Zach, either this or your previous commit broke MacOS.
Can you please take a look?
Feel free to ping me (here or on IRC) if you need any help.
http://green.lab.llvm.org/green/job/lldb-cmake/12343/
--
Davide
On Thu, Nov 8, 2018 at 10:52 AM Zachary Turner via lldb-commits
wrote:
>
> Author: zturne
I’m ooo for at least 2 hours. Is it a test failure or a compilation failure?
On Thu, Nov 8, 2018 at 12:56 PM Davide Italiano
wrote:
> Zach, either this or your previous commit broke MacOS.
> Can you please take a look?
> Feel free to ping me (here or on IRC) if you need any help.
>
> http://green
On Thu, Nov 8, 2018 at 12:59 PM Zachary Turner wrote:
>
> I’m ooo for at least 2 hours. Is it a test failure or a compilation failure?
FAIL: test_with_run_command_gmodules (TestTypeCompletion.TypeCompletionTestCase)
Check that types only get completed when necessary.
+greg.
Greg, is the test wrong here or the patch? If it’s the test let’s just fix
the test, otherwise we can revert the patch until we figure it out.
It seems related to my change to use the layout type instead of the forward
type.
On Thu, Nov 8, 2018 at 1:03 PM Davide Italiano
wrote:
> On Th
Go ahead and revert to green until i get back
On Thu, Nov 8, 2018 at 1:17 PM Zachary Turner wrote:
> +greg.
>
> Greg, is the test wrong here or the patch? If it’s the test let’s just
> fix the test, otherwise we can revert the patch until we figure it out.
>
> It seems related to my change to us
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, zturner, davide.
JDevlieghere added a project: LLDB.
This moves construction of data buffers into the FileSystem class. Like some of
the previous refactorings we don't translate the path yet because the
functionality hasn'
Cool. I see several tests failing (so there might be multiple issues).
Failing Tests (9):
LLDB :: tools/lldb-mi/symbol/symbol-list-lines.test
lldb-Suite ::
functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
lldb-Suite :: functionalities/type_completion/TestTypeCompletion.
Looks like this test was testing the functionality that you changed. It it
expecting that a type won't be complete until you ask for more info about it
(like asking about a child). Since PDB is not completing the type up front, we
need to change LLDB or make your previous case work even when han
Another way to think about this is if you have a SBValue that represents a
class instances in an IDE, if no one turns it open to see the children, why do
we need to complete the type? We should have to. The type should be able to
complete itself if and when we need to know some information. This
Author: jgorbe
Date: Thu Nov 8 14:04:58 2018
New Revision: 346441
URL: http://llvm.org/viewvc/llvm-project?rev=346441&view=rev
Log:
[lldb] Silence unhandled enums warning.
The warning was introduced by r346392, which introduces new builtin
types (to support cl_intel_device_side_avc_motion_estima
Author: jmolenda
Date: Thu Nov 8 14:41:19 2018
New Revision: 346443
URL: http://llvm.org/viewvc/llvm-project?rev=346443&view=rev
Log:
Change $CURRENT_ARCH settings in xcode project file to hardcoded
"x86_64" - used for finding the llvm build directory. Newer
Xcodes do not define CURRENT_ARCH.
M
Author: davide
Date: Thu Nov 8 14:47:40 2018
New Revision: 346444
URL: http://llvm.org/viewvc/llvm-project?rev=346444&view=rev
Log:
Revert "Fix bug in PE/COFF plugin and ValueObjectVariable."
It breaks some tests on MacOS.
Removed:
lldb/trunk/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldb
Author: jdevlieghere
Date: Thu Nov 8 15:21:00 2018
New Revision: 346449
URL: http://llvm.org/viewvc/llvm-project?rev=346449&view=rev
Log:
Update FileSpec constructor signature
Modified:
lldb/trunk/source/Host/android/HostInfoAndroid.cpp
Modified: lldb/trunk/source/Host/android/HostInfoAndro
Author: adrian
Date: Thu Nov 8 16:49:18 2018
New Revision: 346456
URL: http://llvm.org/viewvc/llvm-project?rev=346456&view=rev
Log:
Fix CMake build when building with -fmodules-local-submodule-visibility.
Modified:
lldb/trunk/source/Host/CMakeLists.txt
Modified: lldb/trunk/source/Host/CMake
Author: jdevlieghere
Date: Thu Nov 8 16:50:50 2018
New Revision: 346457
URL: http://llvm.org/viewvc/llvm-project?rev=346457&view=rev
Log:
[FileSystem] Make use of FS in TildeExpressionResolver
In order to call real_path from the TildeExpressionResolver we need
access to the FileSystem. Since the
Author: zturner
Date: Thu Nov 8 17:09:10 2018
New Revision: 346459
URL: http://llvm.org/viewvc/llvm-project?rev=346459&view=rev
Log:
Fix a test whose output changed.
A previous commit fixed an issue with our AST generation where
we were outputting enum decls incorrectly. But we forgot to
update
Author: jdevlieghere
Date: Thu Nov 8 17:59:28 2018
New Revision: 346466
URL: http://llvm.org/viewvc/llvm-project?rev=346466&view=rev
Log:
Revert "[FileSystem] Make use of FS in TildeExpressionResolver"
The whole point of this change was making it possible to resolve paths
without depending on th
30 matches
Mail list logo
