Author: labath
Date: Wed Sep 26 00:31:41 2018
New Revision: 343076
URL: http://llvm.org/viewvc/llvm-project?rev=343076&view=rev
Log:
Fix a memory read bug in lldb-server
NativeProcessProtocol::ReadMemoryWithoutTrap had a bug, where it failed
to properly remove inserted breakpoint opcodes if the m
labath created this revision.
labath added reviewers: krytarowski, zturner.
This function encodes the knowledge of whether the PC points to the
breakpoint instruction of the one following it after the breakpoint is
"hit". This behavior mainly(*) depends on the architecture and not on the
OS, so it
krytarowski added a comment.
I was wondering whether we want to normalize this inside the kernel and always
advance the Program Counter.. but it's easier to manage it in userland.
https://reviews.llvm.org/D52532
___
lldb-commits mailing list
lldb-c
aleksandr.urakov updated this revision to Diff 167081.
aleksandr.urakov added a comment.
Thanks!
I just have extracted the test cases in a separate test and have specified
`-m32` key, so the test can run also on 64-bit machines.
https://reviews.llvm.org/D52501
Files:
include/lldb/Symbol/Cla
Author: aleksandr.urakov
Date: Wed Sep 26 02:03:34 2018
New Revision: 343084
URL: http://llvm.org/viewvc/llvm-project?rev=343084&view=rev
Log:
[PDB] Restore the calling convention from PDB
Summary:
This patch implements restoring of the calling convention from PDB.
It is necessary for expressions
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343084: [PDB] Restore the calling convention from PDB
(authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52501?vs=
Author: jdevlieghere
Date: Wed Sep 26 03:09:44 2018
New Revision: 343087
URL: http://llvm.org/viewvc/llvm-project?rev=343087&view=rev
Log:
[unittest] Fix NativeProcessProtocolTest.cpp (NFC)
Cast std::min's second argument to size_t to prevent conflicting types
for parameter deduction.
Modified:
JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, labath, friss.
JDevlieghere added a project: LLDB.
Herald added a subscriber: aprantl.
This patch adds locking to all the virtual entry-points in DWARFSymbolFile to
prevent corruption of its data structures as a result of
sgraenitz updated this revision to Diff 167109.
sgraenitz marked an inline comment as done.
sgraenitz added a comment.
Skip AddOSOARanges() if the OSO debug map entry has multiple compile units.
https://reviews.llvm.org/D52375
Files:
include/lldb/Symbol/Symtab.h
source/Plugins/SymbolFile/DW
sgraenitz added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:439
+die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc);
+
if (num_ranges > 0) {
clayborg wrote:
> Empty CUs won't have any children. Easy to
aprantl added inline comments.
Comment at: lldb/source/Target/StackFrameList.cpp:331
+dfs(next_callee);
+if (ambiguous)
+ return;
On what path can this happen? Aren't all paths that set `ambiguous=true`
returning immediately?
=
vsk updated this revision to Diff 167148.
vsk marked an inline comment as done.
vsk added a comment.
- Use std::make_shared(...), instead of StackFrameSP(new ...).
https://reviews.llvm.org/D50478
Files:
lldb/include/lldb/API/SBFrame.h
lldb/include/lldb/Core/FormatEntity.h
lldb/include/lld
vsk added inline comments.
Comment at: lldb/source/Target/StackFrameList.cpp:331
+dfs(next_callee);
+if (ambiguous)
+ return;
aprantl wrote:
> On what path can this happen? Aren't all paths that set `ambiguous=true`
> returning immediate
vsk added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431
const size_t num_ranges =
-die->GetAttributeAddressRanges(dwarf, this, ranges, false);
+die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc);
if (num_
teemperor created this revision.
teemperor added a reviewer: xbolva00.
Herald added a subscriber: lldb-commits.
The `ClangUserExpression::GetLanguageForExpr` method is currently a big
source of sadness, as it's name implies that it's an accessor method, but it
actually
is also initializing some v
Thanks.
On 26/09/18 12:09, Jonas Devlieghere via lldb-commits wrote:
> Author: jdevlieghere
> Date: Wed Sep 26 03:09:44 2018
> New Revision: 343087
>
> URL: http://llvm.org/viewvc/llvm-project?rev=343087&view=rev
> Log:
> [unittest] Fix NativeProcessProtocolTest.cpp (NFC)
>
> Cast std::min's sec
clayborg added a comment.
It is the SymbolVendor's job to do the locking. And in many cases it already
is. I stopped with inlined comments after a few comments as it would apply to
this entire patch.
It would be great if we can replace all of the locations where you added lock
guards with lldb
sgraenitz added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:1531
+ if (m_compile_unit_infos.size() > 1)
+return 0;
+
sgraenitz wrote:
> Skipping AddOSOARanges() here.
> Could you leave an in-source comment explain
JDevlieghere added a comment.
In https://reviews.llvm.org/D52543#1246877, @clayborg wrote:
> It is the SymbolVendor's job to do the locking. And in many cases it already
> is. I stopped with inlined comments after a few comments as it would apply to
> this entire patch.
Thanks Greg. Honestly
vsk added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:1531
+ if (m_compile_unit_infos.size() > 1)
+return 0;
+
sgraenitz wrote:
> sgraenitz wrote:
> > Skipping AddOSOARanges() here.
> > Could you leave an in-sourc
Author: tkrasnukha
Date: Wed Sep 26 12:41:57 2018
New Revision: 343134
URL: http://llvm.org/viewvc/llvm-project?rev=343134&view=rev
Log:
Fix OSX build after r343130
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
Modified: lldb/trunk/source/Plugins/Platform/MacOS
Author: tkrasnukha
Date: Wed Sep 26 13:31:39 2018
New Revision: 343141
URL: http://llvm.org/viewvc/llvm-project?rev=343141&view=rev
Log:
Fix ProcessKDP after r343130
Modified:
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
Modified: lldb/trunk/source/Plugins/Process/MacOSX-Ke
tatyana-krasnukha created this revision.
tatyana-krasnukha added reviewers: clayborg, zturner, jingham.
tatyana-krasnukha added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, JDevlieghere.
As a follow-up to https://reviews.llvm.org/D49017.
Repository:
rLLDB LLDB
https://r
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Good stuff!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
It would be nice if You could replace the logic that iterates these arrays.
We no longer need to terminate on a sentinel nullptr entry and can now use
range based for loop
On Wed, Sep 26, 2018 at 2:06 PM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg accepted this revis
zturner added a subscriber: tatyana-krasnukha.
zturner added a comment.
It would be nice if You could replace the logic that iterates these arrays.
We no longer need to terminate on a sentinel nullptr entry and can now use
range based for loop
Repository:
rLLDB LLDB
https://reviews.llvm.org/D
sgraenitz added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:468
// situation. Check the line tables and build the arange table from this.
SymbolContext sc;
sc.comp_unit = dwarf->GetCompUnitForDWARFCompUnit(this);
@cla
tatyana-krasnukha added a comment.
Hmm... There is no such logic left, isn't it?
If you mean iterating OptionValueProperties::m_properties vector, I can replace
cycles with range based for loop, but this doesn't seem to be related to these
changes.
Repository:
rLLDB LLDB
https://reviews.llv
You might be right, I’m on mobile so hard for me to review. I saw a bunch
of nullptr so assumed it was still using sentinel values for iterating. If
not, ignore my suggestion
On Wed, Sep 26, 2018 at 4:26 PM Tatyana Krasnukha via Phabricator <
revi...@reviews.llvm.org> wrote:
> tatyana-krasnukha ad
zturner added a comment.
You might be right, I’m on mobile so hard for me to review. I saw a bunch
of nullptr so assumed it was still using sentinel values for iterating. If
not, ignore my suggestion
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52572
___
tatyana-krasnukha added a comment.
It seems you are speaking about OptionDefinition, not PropertyDefinition. I was
going to create a separate revision for it. Should I add OptionDefinition
related changes to here?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52572
___
No, separate revision is fine. Thanks!
On Wed, Sep 26, 2018 at 4:40 PM Tatyana Krasnukha via Phabricator <
revi...@reviews.llvm.org> wrote:
> tatyana-krasnukha added a comment.
>
> It seems you are speaking about OptionDefinition, not PropertyDefinition.
> I was going to create a separate revision
zturner added a comment.
No, separate revision is fine. Thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: maskray
Date: Wed Sep 26 20:35:05 2018
New Revision: 343164
URL: http://llvm.org/viewvc/llvm-project?rev=343164&view=rev
Log:
llvm::sort(C.begin(), C.end(), ...) -> llvm::sort(C, ...)
The convenience wrapper in STLExtras is available since rL342102.
Modified:
lldb/trunk/source/Breakp
34 matches
Mail list logo
