Author: abidh
Date: Fri Jan 20 04:24:03 2017
New Revision: 292598
URL: http://llvm.org/viewvc/llvm-project?rev=292598&view=rev
Log:
Fix more unused variable warnings when asserts are disabled.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
abidh created this revision.
This commit adds an option to set PC to the entry point of the file loaded
using "target module load" command. In https://reviews.llvm.org/D28804, Greg
asked me to separate this part under a different option.
https://reviews.llvm.org/D28944
Files:
include/lldb/C
boris.ulasevich created this revision.
boris.ulasevich added a project: LLDB.
Here is a fix for Ubuntu tests fails after the recent change
https://reviews.llvm.org/D26497 (https://reviews.llvm.org/D26497). The cause of
those fails is in internal call to mmap fuction which destroys
completed_pla
labath added a reviewer: jingham.
labath added a comment.
Jim should probably review this change.
That said, I don't see any failures on linux currently. Can you elaborate on
which tests are failing and why? It sounds like there is an opportunity here to
write a more robust test...
Repository
Author: labath
Date: Fri Jan 20 08:17:16 2017
New Revision: 292611
URL: http://llvm.org/viewvc/llvm-project?rev=292611&view=rev
Log:
Prevent client from querying each thread's PC at each stop.
Summary:
The server was no longer sending the thread PCs the way the client
expected them.
I changed the
abidh marked an inline comment as done.
abidh added a comment.
Greg, any further comment on this patch.
https://reviews.llvm.org/D28808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just set an error when "set_pc" is true and you get no entry point back from
thee object file and this is good to go.
Comment at: source/Symbol/ObjectFile.cpp:
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See easy inline fix and this will be good to go
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4004
+// hope that data being written
boris.ulasevich added a comment.
> Jim should probably review this change.
Yes, thank you. We are in contact with Jim. And I see now I had put Jim to
Subscribers list instead of Revievers list :)
> That said, I don't see any failures on linux currently. Can you elaborate on
> which tests are f
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The restoration of the stop reason works for the most part. For instance, when
we call a user expression the stop reason is correctly restored. This was done
by saving and restor
jingham added a comment.
BTW, this shows one important difference between OS X and Linux that pops up
from time to time. On OS X, we can allocate memory in the target process
without having to call functions in the target. We don't do that by hand in
lldb (that wouldn't work for remote debugg
labath added a comment.
Thank you both for explaining the situation. The "test failure on ubuntu" part
threw me off -- I did not realize you were talking about hypothetical failure
should a different change go in. I was worried we have some very
environment-dependent tests.
Looks good from my
Author: jmolenda
Date: Fri Jan 20 19:17:36 2017
New Revision: 292696
URL: http://llvm.org/viewvc/llvm-project?rev=292696&view=rev
Log:
Add a catch-all line for detecting dyld in the inferior process
shlibs so we don't miss dyld.
Modified:
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/
13 matches
Mail list logo
