Re: [PR] KAFKA-18001: Support UpdateRaftVoterRequest in KafkaNetworkChannel (WIP) [kafka]

2024-11-13 Thread via GitHub
justinrlee commented on PR #17773: URL: https://github.com/apache/kafka/pull/17773#issuecomment-2472928978 Thanks, @ahuang98! I have updated the PR title and will look at adding tests today or tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] KAFKA-18004: Use 3.8 to run zk service for e2e [kafka]

2024-11-13 Thread via GitHub
chia7712 commented on code in PR #17790: URL: https://github.com/apache/kafka/pull/17790#discussion_r1839513727 ## tests/kafkatest/services/zookeeper.py: ## @@ -44,7 +44,7 @@ class ZookeeperService(KafkaPathResolverMixin, Service): } def __init__(self, context, num_n

Re: [PR] KAFKA-17232: MirrorCheckpointConnector does not generate task configs if initial consumer group load times out. [kafka]

2024-11-13 Thread via GitHub
Gakhramanzode commented on PR #16767: URL: https://github.com/apache/kafka/pull/16767#issuecomment-2472664603 @frankvicky @Hongten @C0urante Hello, We've encountered an issue that seems to be related to the changes in this pull request. **Context:** - **Kafka Ver

[jira] [Resolved] (KAFKA-18004) Use version 3.8 to run the ZooKeeper service for end-to-end tests

2024-11-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18004. Fix Version/s: 4.0.0 Resolution: Fixed > Use version 3.8 to run the ZooKeeper servi

[jira] [Updated] (KAFKA-18004) Use version 3.8 to run the ZooKeeper service for end-to-end tests

2024-11-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18004: --- Summary: Use version 3.8 to run the ZooKeeper service for end-to-end tests (was: Use 3.8 to

Re: [PR] [DO NOT MERGE] PoC for ProcessingExceptionHandler [kafka]

2024-11-13 Thread via GitHub
cadonna closed pull request #16137: [DO NOT MERGE] PoC for ProcessingExceptionHandler URL: https://github.com/apache/kafka/pull/16137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-17995: Large value for retention.ms could prevent remote data cleanup in Tiered Storage [kafka]

2024-11-13 Thread via GitHub
divijvaidya commented on code in PR #17794: URL: https://github.com/apache/kafka/pull/17794#discussion_r1840213747 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2765,6 +2765,34 @@ public void testDeleteRetentionMsBeingCancelledBeforeSecondDelete() thr

[jira] [Resolved] (KAFKA-17987) Remove assorted ZK-related files

2024-11-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17987. Fix Version/s: 4.0.0 Resolution: Fixed > Remove assorted ZK-related files > ---

Re: [PR] KAFKA-17885: Enable clients to rebootstrap based on timeout or error code (KIP-1102) [kafka]

2024-11-13 Thread via GitHub
rajinisivaram commented on code in PR #17720: URL: https://github.com/apache/kafka/pull/17720#discussion_r1840224877 ## core/src/test/scala/integration/kafka/api/ConsumerRebootstrapTest.scala: ## @@ -87,3 +128,17 @@ class ConsumerRebootstrapTest extends RebootstrapTest { pr

Re: [PR] MINOR Fix a few test names [kafka]

2024-11-13 Thread via GitHub
chia7712 commented on code in PR #17788: URL: https://github.com/apache/kafka/pull/17788#discussion_r1840221645 ## streams/test-utils/src/test/java/org/apache/kafka/streams/test/MockProcessorContextStateStoreTest.java: ## @@ -155,7 +155,7 @@ public static Stream parameters() {

[PR] Integrate Streams membership manager with stream thread [kafka]

2024-11-13 Thread via GitHub
cadonna opened a new pull request, #17795: URL: https://github.com/apache/kafka/pull/17795 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

Re: [PR] KAFKA-17885: Enable clients to rebootstrap based on timeout or error code (KIP-1102) [kafka]

2024-11-13 Thread via GitHub
rajinisivaram merged PR #17720: URL: https://github.com/apache/kafka/pull/17720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

Re: [PR] KAFKA-17885: Enable clients to rebootstrap based on timeout or error code (KIP-1102) [kafka]

2024-11-13 Thread via GitHub
rajinisivaram commented on PR #17720: URL: https://github.com/apache/kafka/pull/17720#issuecomment-2473551972 @apoorvmittal10 @omkreddy Thanks for the reviews. @apoorvmittal10 If you have follow-on comments, I can address those in a separate PR. Merging this to trunk. -- This is an autom

Re: [PR] KAFKA-17850: fix leaking internal exception in state manager [kafka]

2024-11-13 Thread via GitHub
cadonna commented on PR #17711: URL: https://github.com/apache/kafka/pull/17711#issuecomment-2472783813 Could you please add a description to the PR so that it is clear what it changes. Linking to the JIRA ticket is actually not really needed since the JIRA ticket number can be found in the

[jira] [Resolved] (KAFKA-17885) Enable clients to rebootstrap based on timeout or error code

2024-11-13 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-17885. Fix Version/s: 4.0.0 Reviewer: Manikumar Resolution: Fixed > Enable client

[jira] [Commented] (KAFKA-17829) Verify ShareFetch requests return a completed/erroneous future on purgatory close

2024-11-13 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897916#comment-17897916 ] Abhinav Dixit commented on KAFKA-17829: --- We also ran tests in multi-broker setup s

[jira] [Resolved] (KAFKA-17829) Verify ShareFetch requests return a completed/erroneous future on purgatory close

2024-11-13 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-17829. --- Resolution: Not A Bug > Verify ShareFetch requests return a completed/erroneous future on pu

[jira] [Commented] (KAFKA-17957) Console share consumer unable to consume all messages when using multiple brokers

2024-11-13 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897917#comment-17897917 ] Abhinav Dixit commented on KAFKA-17957: --- The way I had setup my local multi broker

[jira] [Created] (KAFKA-18005) Return metadata of sensitive config when describe config

2024-11-13 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18005: - Summary: Return metadata of sensitive config when describe config Key: KAFKA-18005 URL: https://issues.apache.org/jira/browse/KAFKA-18005 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-18005) Return metadata of sensitive config when describe config

2024-11-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-18005: -- Description: Currently, when describing config for a resource, we'll get `null` if the config is a se

Re: [PR] KAFKA-18004: Use 3.8 to run zk service for e2e [kafka]

2024-11-13 Thread via GitHub
chia7712 merged PR #17790: URL: https://github.com/apache/kafka/pull/17790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17987: Remove assorted ZK-related files [kafka]

2024-11-13 Thread via GitHub
chia7712 merged PR #17768: URL: https://github.com/apache/kafka/pull/17768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17957) Console share consumer unable to consume all messages when using multiple brokers

2024-11-13 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-17957. --- Resolution: Invalid > Console share consumer unable to consume all messages when using multi

[jira] [Commented] (KAFKA-15796) High CPU issue in Kafka Producer when Auth Failed

2024-11-13 Thread Alexandru Oiegas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897855#comment-17897855 ] Alexandru Oiegas commented on KAFKA-15796: -- Hi, we have the same issue. Can thi

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-11-13 Thread via GitHub
frankvicky commented on PR #17373: URL: https://github.com/apache/kafka/pull/17373#issuecomment-2472887781 Hello @mimaison,@showuon, Since this PR modifies a large number of files, particularly `build.gradle`, it’s highly susceptible to conflicts with other PRs, making it rather exha

[PR] KAFKA-17593; [6/N] Add new record to GroupCoordinatorRecordSerde [kafka]

2024-11-13 Thread via GitHub
dajac opened a new pull request, #17791: URL: https://github.com/apache/kafka/pull/17791 This patch extends `GroupCoordinatorRecordSerde` to support the `ConsumerGroupRegularExpression` record. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implement

Re: [PR] KAFKA-18004: Use 3.8 to run zk service for e2e [kafka]

2024-11-13 Thread via GitHub
FrankYang0529 commented on code in PR #17790: URL: https://github.com/apache/kafka/pull/17790#discussion_r1839920307 ## tests/kafkatest/services/zookeeper.py: ## @@ -44,7 +44,7 @@ class ZookeeperService(KafkaPathResolverMixin, Service): } def __init__(self, context,

[jira] [Commented] (KAFKA-15895) Move DynamicBrokerConfig to server module

2024-11-13 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897938#comment-17897938 ] Nikolay Izhikov commented on KAFKA-15895: - Hello, [~omnia_h_ibrahim]. Are you w

[PR] KAFKA-18006: Add 3.9.0 to end-to-end test [kafka]

2024-11-13 Thread via GitHub
frankvicky opened a new pull request, #17797: URL: https://github.com/apache/kafka/pull/17797 JIRA: KAFKA-18006 Since 3.9 is released, we should add it to the e2e-test. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Ver

[jira] [Assigned] (KAFKA-15895) Move DynamicBrokerConfig to server module

2024-11-13 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-15895: --- Assignee: Nikolay Izhikov (was: Omnia Ibrahim) > Move DynamicBrokerConfig to serve

[jira] [Commented] (KAFKA-14588) Move ConfigCommand to tools

2024-11-13 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897944#comment-17897944 ] Nikolay Izhikov commented on KAFKA-14588: - [~loganzhu] Currently, this ticket i

Re: [PR] KAFKA-17995: Large value for retention.ms could prevent remote data cleanup in Tiered Storage [kafka]

2024-11-13 Thread via GitHub
FrankYang0529 commented on code in PR #17794: URL: https://github.com/apache/kafka/pull/17794#discussion_r1840306519 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2765,6 +2765,34 @@ public void testDeleteRetentionMsBeingCancelledBeforeSecondDelete() t

Re: [PR] MINOR: remove LogDirFailureTest.testZkBrokerWithOldInterBrokerProtocolShouldHaltOnLogDirFailure [kafka]

2024-11-13 Thread via GitHub
chia7712 merged PR #17785: URL: https://github.com/apache/kafka/pull/17785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-14585) Move StorageTool to tools

2024-11-13 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-14585: --- Assignee: Nikolay Izhikov > Move StorageTool to tools > - >

[jira] [Resolved] (KAFKA-15718) KRaft support in UncleanLeaderElectionTest

2024-11-13 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge resolved KAFKA-15718. --- Fix Version/s: 3.8.0 Resolution: Fixed > KRaft support in UncleanLeaderElecti

Re: [PR] KAFKA-10532: Handle state updater failed tasks [kafka]

2024-11-13 Thread via GitHub
eduwercamacaro commented on PR #17761: URL: https://github.com/apache/kafka/pull/17761#issuecomment-2473986471 Pinging @cadonna @mjsax @ableegoldman for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-17648: AsyncKafkaConsumer#unsubscribe swallow TopicAuthorizationException and GroupAuthorizationException [kafka]

2024-11-13 Thread via GitHub
FrankYang0529 commented on code in PR #17516: URL: https://github.com/apache/kafka/pull/17516#discussion_r1840722461 ## core/src/test/scala/integration/kafka/api/GroupAuthorizerIntegrationTest.scala: ## @@ -132,6 +133,84 @@ class GroupAuthorizerIntegrationTest extends BaseReque

[jira] [Commented] (KAFKA-14588) Move ConfigCommand to tools

2024-11-13 Thread Logan Zhu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897969#comment-17897969 ] Logan Zhu commented on KAFKA-14588: --- [~nizhikov]  Thank you for the update! I apprecia

Re: [PR] KAFKA-17948: Potential issue during tryComplete and onComplete simultaneous calls to access global variables [kafka]

2024-11-13 Thread via GitHub
adixitconfluent commented on code in PR #17739: URL: https://github.com/apache/kafka/pull/17739#discussion_r1840737488 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1602,8 +1602,6 @@ protected void updateFetchOffsetMetadata(Optional fetchOffset prote

[PR] MINOR: Update javadoc on split to mention first matching [kafka]

2024-11-13 Thread via GitHub
bbejeck opened a new pull request, #17799: URL: https://github.com/apache/kafka/pull/17799 Clarify the functionality of `split` matching on first predicate ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage an

[jira] [Created] (KAFKA-18008) Flaky testMultiConsumerSessionTimeoutOnStopPolling

2024-11-13 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-18008: -- Summary: Flaky testMultiConsumerSessionTimeoutOnStopPolling Key: KAFKA-18008 URL: https://issues.apache.org/jira/browse/KAFKA-18008 Project: Kafka Issue

Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]

2024-11-13 Thread via GitHub
frankvicky commented on code in PR #17797: URL: https://github.com/apache/kafka/pull/17797#discussion_r1840779166 ## tests/kafkatest/services/zookeeper.py: ## @@ -45,7 +45,7 @@ class ZookeeperService(KafkaPathResolverMixin, Service): # After 4.0, zookeeper service is remo

Re: [PR] MINOR: Update javadoc on split to mention first matching [kafka]

2024-11-13 Thread via GitHub
bbejeck merged PR #17799: URL: https://github.com/apache/kafka/pull/17799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]

2024-11-13 Thread via GitHub
frankvicky commented on PR #17797: URL: https://github.com/apache/kafka/pull/17797#issuecomment-2474156464 Run `client_compatibility_produce_consume_test.py` for validate purpose, and get following fails: ``` FAILED TEST SYMBOLS Pass the test symbols below to your ducktape run '

Re: [PR] MINOR: Update javadoc on split to mention first matching [kafka]

2024-11-13 Thread via GitHub
bbejeck commented on PR #17799: URL: https://github.com/apache/kafka/pull/17799#issuecomment-2474163159 Merged #17799 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[PR] KAFKA-18006: Add 3.9.0 to end-to-end test (streams) [kafka]

2024-11-13 Thread via GitHub
frankvicky opened a new pull request, #17800: URL: https://github.com/apache/kafka/pull/17800 JIRA: KAFKA-18006 Since 3.9 is released, we should add it to the e2e-test. Follow-up of #17797 ### Committer Checklist (excluded from commit message) - [ ] Verify design and impl

[PR] KAFKA-17278: Add FetchRequest compatibility tests for KafkaRaftClient [kafka]

2024-11-13 Thread via GitHub
kevin-wu24 opened a new pull request, #17801: URL: https://github.com/apache/kafka/pull/17801 Adding unit tests for KafkaRaftClient to catch the case discussed here: https://github.com/apache/kafka/pull/16235#discussion_r1672760435 Makes sure that an older quorum controller can handle

Re: [PR] MINOR: Update javadoc on split to mention first matching [kafka]

2024-11-13 Thread via GitHub
bbejeck commented on PR #17799: URL: https://github.com/apache/kafka/pull/17799#issuecomment-2474217154 Cherry picked to 3.9, 3.8, and 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-17593; [6/N] Add new record to GroupCoordinatorRecordSerde [kafka]

2024-11-13 Thread via GitHub
dajac merged PR #17791: URL: https://github.com/apache/kafka/pull/17791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-17917) Convert Kafka core system tests to use KRaft

2024-11-13 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897990#comment-17897990 ] Kevin Wu commented on KAFKA-17917: -- Hey [~yx9o], are you still planning to take on this

[jira] [Created] (KAFKA-18009) Remove spurious public constructor for KafkaShareConsumer

2024-11-13 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18009: Summary: Remove spurious public constructor for KafkaShareConsumer Key: KAFKA-18009 URL: https://issues.apache.org/jira/browse/KAFKA-18009 Project: Kafka

Re: [PR] KAFKA-17972: Default all JUnit tests to KRaft [kafka]

2024-11-13 Thread via GitHub
cmccabe commented on PR #17727: URL: https://github.com/apache/kafka/pull/17727#issuecomment-2474335828 Convert SaslClientsWithInvalidCredentialsTest.scala to KRaft https://github.com/apache/kafka/pull/17803 -- This is an automated message from the Apache Git Service. To respond to the me

[PR] MINOR: convert SaslClientsWithInvalidCredentialsTest.scala to KRaft [kafka]

2024-11-13 Thread via GitHub
cmccabe opened a new pull request, #17803: URL: https://github.com/apache/kafka/pull/17803 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] KAFKA-17850: fix leaking internal exception in state manager [kafka]

2024-11-13 Thread via GitHub
sebastienviale commented on code in PR #17711: URL: https://github.com/apache/kafka/pull/17711#discussion_r1839932320 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -538,13 +539,16 @@ public void flush() {

[PR] [WIP] KAFKA-17928: Make remote log manager thread-pool configs dynamic [kafka]

2024-11-13 Thread via GitHub
peterxcli opened a new pull request, #17793: URL: https://github.com/apache/kafka/pull/17793 ### Description Add ability to dynamically update remote storage thread pool sizes and implement partition readiness check: - Add methods to RemoteLogManager to update thread pool si

[PR] KAFKA-17995: Large value for retention.ms could prevent remote data cleanup in Tiered Storage [kafka]

2024-11-13 Thread via GitHub
FrankYang0529 opened a new pull request, #17794: URL: https://github.com/apache/kafka/pull/17794 If a user has configured value of `retention.ms` to a value > current unix timestamp epoch, then `cleanupUntilMs` becomes negative. https://github.com/apache/kafka/blob/5a5239770ff3565233

Re: [PR] KAFKA-17648: AsyncKafkaConsumer#unsubscribe swallow GroupAuthorizationException [kafka]

2024-11-13 Thread via GitHub
FrankYang0529 commented on code in PR #17516: URL: https://github.com/apache/kafka/pull/17516#discussion_r1839957439 ## core/src/test/scala/integration/kafka/api/GroupAuthorizerIntegrationTest.scala: ## @@ -132,6 +133,84 @@ class GroupAuthorizerIntegrationTest extends BaseReque

Re: [PR] KAFKA-17850: fix leaking internal exception in state manager [kafka]

2024-11-13 Thread via GitHub
sebastienviale commented on code in PR #17711: URL: https://github.com/apache/kafka/pull/17711#discussion_r1839930318 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -538,13 +539,16 @@ public void flush() {

Re: [PR] KAFKA-17885: Enable clients to rebootstrap based on timeout or error code (KIP-1102) [kafka]

2024-11-13 Thread via GitHub
omkreddy commented on code in PR #17720: URL: https://github.com/apache/kafka/pull/17720#discussion_r1839870397 ## core/src/test/scala/integration/kafka/api/ConsumerRebootstrapTest.scala: ## @@ -87,3 +128,17 @@ class ConsumerRebootstrapTest extends RebootstrapTest { produce

[jira] [Updated] (KAFKA-17993) reassign partition tool stuck with uncaught exception: 'value' field is too long to be serialized

2024-11-13 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-17993: -- Description: Running the reassignment script when a topic had 5000 partitions, with both thro

[jira] [Comment Edited] (KAFKA-17993) reassign partition tool stuck with uncaught exception: 'value' field is too long to be serialized

2024-11-13 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897624#comment-17897624 ] Edoardo Comar edited comment on KAFKA-17993 at 11/13/24 9:58 AM: -

Re: [PR] [Don't Merge] Test [kafka]

2024-11-13 Thread via GitHub
TaiJuWu commented on code in PR #16463: URL: https://github.com/apache/kafka/pull/16463#discussion_r1839868916 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -1023,20 +1038,29 @@ public long nextExpiryTimeMs() { }

[PR] Add Kraft migration revert cleanup steps [kafka]

2024-11-13 Thread via GitHub
nicolasguyomar opened a new pull request, #17792: URL: https://github.com/apache/kafka/pull/17792 Some cleanup is needed before attempting a new migration ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

Re: [PR] KAFKA-14588 Tests for ConfigCommand of DynamicBrokerReconfigurationTest rewritten in java [kafka]

2024-11-13 Thread via GitHub
nizhikov closed pull request #15848: KAFKA-14588 Tests for ConfigCommand of DynamicBrokerReconfigurationTest rewritten in java URL: https://github.com/apache/kafka/pull/15848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Comment Edited] (KAFKA-15796) High CPU issue in Kafka Producer when Auth Failed

2024-11-13 Thread Alexandru Oiegas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897855#comment-17897855 ] Alexandru Oiegas edited comment on KAFKA-15796 at 11/13/24 8:40 AM: --

Re: [PR] KAFKA-17850: fix leaking internal exception in state manager [kafka]

2024-11-13 Thread via GitHub
cadonna commented on code in PR #17711: URL: https://github.com/apache/kafka/pull/17711#discussion_r1839727730 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -538,13 +539,16 @@ public void flush() { } catc

[jira] [Resolved] (KAFKA-17985) Set default value for share.auto.offset.reset in ShareRoundTripWorker.

2024-11-13 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R resolved KAFKA-17985. -- Resolution: Fixed > Set default value for share.auto.offset.reset in ShareRoundTripWorker. > -

Re: [PR] KAFKA-17648: AsyncKafkaConsumer#unsubscribe swallow GroupAuthorizationException [kafka]

2024-11-13 Thread via GitHub
FrankYang0529 commented on code in PR #17516: URL: https://github.com/apache/kafka/pull/17516#discussion_r1839785185 ## core/src/test/scala/integration/kafka/api/GroupAuthorizerIntegrationTest.scala: ## @@ -132,6 +133,84 @@ class GroupAuthorizerIntegrationTest extends BaseReque

Re: [PR] KAFKA-17648: AsyncKafkaConsumer#unsubscribe swallow GroupAuthorizationException [kafka]

2024-11-13 Thread via GitHub
FrankYang0529 commented on code in PR #17516: URL: https://github.com/apache/kafka/pull/17516#discussion_r1839785185 ## core/src/test/scala/integration/kafka/api/GroupAuthorizerIntegrationTest.scala: ## @@ -132,6 +133,84 @@ class GroupAuthorizerIntegrationTest extends BaseReque

Re: [PR] KAFKA-17109: Reduce log message load for failed locking [kafka]

2024-11-13 Thread via GitHub
cadonna merged PR #16705: URL: https://github.com/apache/kafka/pull/16705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Assigned] (KAFKA-17993) reassign partition tool stuck with uncaught exception: 'value' field is too long to be serialized

2024-11-13 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar reassigned KAFKA-17993: - Assignee: Edoardo Comar > reassign partition tool stuck with uncaught exception: 'value

Re: [PR] MINOR Fix a few test names [kafka]

2024-11-13 Thread via GitHub
mumrah merged PR #17788: URL: https://github.com/apache/kafka/pull/17788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] Add Kraft migration revert cleanup steps [kafka]

2024-11-13 Thread via GitHub
cmccabe commented on code in PR #17792: URL: https://github.com/apache/kafka/pull/17792#discussion_r1840929276 ## docs/ops.html: ## @@ -4182,6 +4182,14 @@ Reverting to ZooKeeper mode During the Migration If you did not fully complete any step, back out whatever you have don

Re: [PR] MINOR Fix a few test names [kafka]

2024-11-13 Thread via GitHub
mumrah commented on PR #17788: URL: https://github.com/apache/kafka/pull/17788#issuecomment-2474400495 No worries, @bbejeck. Thanks for taking a look 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] KAFKA-15995: Adding KIP-877 support to Connect [kafka]

2024-11-13 Thread via GitHub
mimaison opened a new pull request, #17804: URL: https://github.com/apache/kafka/pull/17804 Built on top of #17511, the 2nd commit adds KIP-877 support to Connect ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test cove

[PR] KAFKA-17992: Remove `getUnderlying` and `isKRaftTest` from ClusterInstance [kafka]

2024-11-13 Thread via GitHub
Yunyung opened a new pull request, #17802: URL: https://github.com/apache/kafka/pull/17802 As title, - Since ZK will be removed in version 4.0, `isKRaftTest` is no longer required. - To avoid directly exposing or returning the underlying object through interface `getUnderlying

Re: [PR] KAFKA-18001: Support UpdateRaftVoterRequest in KafkaNetworkChannel (WIP) [kafka]

2024-11-13 Thread via GitHub
cmccabe commented on code in PR #17773: URL: https://github.com/apache/kafka/pull/17773#discussion_r1841009664 ## raft/src/main/java/org/apache/kafka/raft/KafkaNetworkChannel.java: ## @@ -187,6 +189,8 @@ static AbstractRequest.Builder buildRequest(ApiMessag return

Re: [PR] KAFKA-18001: Support UpdateRaftVoterRequest in KafkaNetworkChannel (WIP) [kafka]

2024-11-13 Thread via GitHub
ahuang98 commented on code in PR #17773: URL: https://github.com/apache/kafka/pull/17773#discussion_r1841016340 ## raft/src/main/java/org/apache/kafka/raft/KafkaNetworkChannel.java: ## @@ -187,6 +189,8 @@ static AbstractRequest.Builder buildRequest(ApiMessag return

Re: [PR] KAFKA-17783: Adding listeners to remove share partition on partition changes [kafka]

2024-11-13 Thread via GitHub
apoorvmittal10 commented on PR #17796: URL: https://github.com/apache/kafka/pull/17796#issuecomment-2474212658 Thanks @AndrewJSchofield for review and good points. > Can the partition become a leader after it has previously become a follower? I just wonder whether the state machine is

[jira] [Commented] (KAFKA-17917) Convert Kafka core system tests to use KRaft

2024-11-13 Thread Azhar Ahmed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898023#comment-17898023 ] Azhar Ahmed commented on KAFKA-17917: - Hi [~kevinwu2412] , I would like to participa

Re: [PR] MINOR Fix a few test names [kafka]

2024-11-13 Thread via GitHub
mumrah commented on PR #17788: URL: https://github.com/apache/kafka/pull/17788#issuecomment-2474414294 Here's what the catalog diff will be with this PR: ``` diff --git a/test-catalog/clients/tests.yaml b/test-catalog/clients/tests.yaml index 4b39d4f069..51d7850671 100644 ---

Re: [PR] KAFKA-17747: Trigger rebalance on rack topology changes [kafka]

2024-11-13 Thread via GitHub
jeffkbkim commented on code in PR #17444: URL: https://github.com/apache/kafka/pull/17444#discussion_r1840991727 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java: ## @@ -526,12 +527,12 @@ public void testReplayConsumerGroupPart

Re: [PR] MINOR: convert GssapiAuthenticationTest to KRaft [kafka]

2024-11-13 Thread via GitHub
mjsax commented on code in PR #17786: URL: https://github.com/apache/kafka/pull/17786#discussion_r1841030801 ## core/src/test/scala/integration/kafka/server/GssapiAuthenticationTest.scala: ## @@ -109,7 +110,8 @@ class GssapiAuthenticationTest extends IntegrationTestHarness with

Re: [PR] MINOR: convert GssapiAuthenticationTest to KRaft [kafka]

2024-11-13 Thread via GitHub
mjsax commented on code in PR #17786: URL: https://github.com/apache/kafka/pull/17786#discussion_r1841029706 ## core/src/test/scala/integration/kafka/server/GssapiAuthenticationTest.scala: ## @@ -92,15 +92,16 @@ class GssapiAuthenticationTest extends IntegrationTestHarness with

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-13 Thread via GitHub
lianetm merged PR #16686: URL: https://github.com/apache/kafka/pull/16686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-17518) AsyncKafkaConsumer cannot reliably leave group when closed with small timeout

2024-11-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-17518. Resolution: Fixed > AsyncKafkaConsumer cannot reliably leave group when closed with small

[jira] [Commented] (KAFKA-17519) Define and validate correctness of Consumer.close() and its timeout when thread is interrupted

2024-11-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898032#comment-17898032 ] Lianet Magrans commented on KAFKA-17519: [~kirktrue] what exactly do we want to

Re: [PR] KAFKA-17648: AsyncKafkaConsumer#unsubscribe swallow TopicAuthorizationException and GroupAuthorizationException [kafka]

2024-11-13 Thread via GitHub
lianetm commented on code in PR #17516: URL: https://github.com/apache/kafka/pull/17516#discussion_r1840374672 ## core/src/test/scala/integration/kafka/api/GroupAuthorizerIntegrationTest.scala: ## @@ -132,6 +133,136 @@ class GroupAuthorizerIntegrationTest extends BaseRequestTes

[jira] [Commented] (KAFKA-12469) The topic names in the metrics do not retain their format when extracting through JMX.

2024-11-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898033#comment-17898033 ] Apoorv Mittal commented on KAFKA-12469: --- [~chia7712] [~junrao] If we need this the

Re: [PR] KAFKA-17783: Adding listeners to remove share partition on partition changes [kafka]

2024-11-13 Thread via GitHub
mumrah commented on PR #17796: URL: https://github.com/apache/kafka/pull/17796#issuecomment-2474632453 @apoorvmittal10 what is the purpose of this listener? Is is so that SPM can clean up its in-memory state when it is no longer the leader for a partition? If that's the main use case,

[jira] [Assigned] (KAFKA-18006) add 3.9.0 to end-to-end test

2024-11-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18006: -- Assignee: TengYao Chi (was: Chia-Ping Tsai) > add 3.9.0 to end-to-end test > ---

[jira] [Created] (KAFKA-18006) add 3.9.0 to end-to-end test

2024-11-13 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18006: -- Summary: add 3.9.0 to end-to-end test Key: KAFKA-18006 URL: https://issues.apache.org/jira/browse/KAFKA-18006 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-15995: Initial API + make Producer/Consumer plugins Monitorable [kafka]

2024-11-13 Thread via GitHub
mimaison commented on PR #17511: URL: https://github.com/apache/kafka/pull/17511#issuecomment-2473712965 I rebased on trunk to resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-18006) add 3.9.0 to end-to-end test

2024-11-13 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897928#comment-17897928 ] TengYao Chi commented on KAFKA-18006: - Hi [~chia7712]  I would like to have this is

[jira] [Commented] (KAFKA-18001) KafkaNetworkChannel missing UpdateRaftVoterRequestData logic

2024-11-13 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897954#comment-17897954 ] Omnia Ibrahim commented on KAFKA-18001: --- Hi [~gnarula] and [~alyssahuang] I believ

Re: [PR] MINOR Fix a few test names [kafka]

2024-11-13 Thread via GitHub
mumrah commented on PR #17788: URL: https://github.com/apache/kafka/pull/17788#issuecomment-2473827213 @chia7712 I'm not sure it's preventable. It doesn't seem to be a widespread issue though, so hopefully fixing these will prevent copy/paste propagation of the issue. We should proba

[jira] [Created] (KAFKA-18007) MirrorCheckpointConnector fails with “Timeout while loading consumer groups” after upgrading to Kafka 3.9.0

2024-11-13 Thread Asker (Jira)
Asker created KAFKA-18007: - Summary: MirrorCheckpointConnector fails with “Timeout while loading consumer groups” after upgrading to Kafka 3.9.0 Key: KAFKA-18007 URL: https://issues.apache.org/jira/browse/KAFKA-18007

Re: [PR] KAFKA-17593; [5/N] Include resolved regular expressions into target assignment computation [kafka]

2024-11-13 Thread via GitHub
dajac merged PR #17750: URL: https://github.com/apache/kafka/pull/17750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16985: Ensure consumer attempts to send leave request on close even if interrupted [kafka]

2024-11-13 Thread via GitHub
kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1840505903 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -549,31 +578,40 @@ public CompletableFuture leaveGroup() {

Re: [PR] KAFKA-18001: Support UpdateRaftVoterRequest in KafkaNetworkChannel (WIP) [kafka]

2024-11-13 Thread via GitHub
OmniaGM commented on code in PR #17773: URL: https://github.com/apache/kafka/pull/17773#discussion_r1840517434 ## raft/src/main/java/org/apache/kafka/raft/KafkaNetworkChannel.java: ## @@ -187,6 +189,8 @@ static AbstractRequest.Builder buildRequest(ApiMessag return

  1   2   3   >