[jira] [Created] (KAFKA-16430) The group-metadata-manager thread is always in a loading state and occupies one CPU, unable to end.

2024-03-27 Thread Gao Fei (Jira)
Gao Fei created KAFKA-16430: --- Summary: The group-metadata-manager thread is always in a loading state and occupies one CPU, unable to end. Key: KAFKA-16430 URL: https://issues.apache.org/jira/browse/KAFKA-16430

[jira] [Assigned] (KAFKA-15715) KRaft support in UpdateFeaturesTest

2024-03-27 Thread johndoe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] johndoe reassigned KAFKA-15715: --- Assignee: (was: johndoe) > KRaft support in UpdateFeaturesTest > --

Re: [PR] MINOR: Improve logging in AssignmentsManager [kafka]

2024-03-27 Thread via GitHub
showuon commented on PR #15522: URL: https://github.com/apache/kafka/pull/15522#issuecomment-2022115723 Will check it this week or next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-16365: AssignmentsManager callback handling issues [kafka]

2024-03-27 Thread via GitHub
showuon commented on PR #15521: URL: https://github.com/apache/kafka/pull/15521#issuecomment-2022115867 Will try to review it this week or next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-15558) Determine if Timer should be used elsewhere in PrototypeAsyncConsumer.updateFetchPositions()

2024-03-27 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831197#comment-17831197 ] Andrew Schofield commented on KAFKA-15558: -- I was referring to the way that the

[PR] [MINOR] Renaming the `Abortable_Transaction` error to `Transaction_Abortable` [kafka]

2024-03-27 Thread via GitHub
sjhajharia opened a new pull request, #15609: URL: https://github.com/apache/kafka/pull/15609 This is a follow-up to [this](https://github.com/apache/kafka/pull/15486) PR which introduced the new `ABORTABLE_TRANSACTION` error as a part of KIP-890 efforts. However on further discussion, we s

[jira] [Commented] (KAFKA-16403) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testCountListOfWords

2024-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831201#comment-17831201 ] Matthias J. Sax commented on KAFKA-16403: - Sound like an env issue but not a bug

[jira] [Commented] (KAFKA-16404) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testGetStreamsConfig

2024-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831202#comment-17831202 ] Matthias J. Sax commented on KAFKA-16404: - Sounds like an env issue to me. I wou

Re: [PR] [MINOR] Renaming the `Abortable_Transaction` error to `Transaction_Abortable` [kafka]

2024-03-27 Thread via GitHub
sjhajharia commented on PR #15609: URL: https://github.com/apache/kafka/pull/15609#issuecomment-2022175562 Requesting review from @jolshan (reviewer of the parent PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022177651 @chia7712 Conflicts resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831208#comment-17831208 ] Matthias J. Sax commented on KAFKA-16382: - An application reset, does not touch

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on code in PR #15075: URL: https://github.com/apache/kafka/pull/15075#discussion_r1540643481 ## server/src/main/java/org/apache/kafka/server/config/ZkConfig.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] MINOR: Add retry mechanism to EOS example [kafka]

2024-03-27 Thread via GitHub
showuon merged PR #15561: URL: https://github.com/apache/kafka/pull/15561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
chia7712 commented on code in PR #15075: URL: https://github.com/apache/kafka/pull/15075#discussion_r1540685634 ## server/src/main/java/org/apache/kafka/server/config/ZkConfig.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831228#comment-17831228 ] Stanislav Spiridonov commented on KAFKA-16382: -- Wait, why is it not a bug?

Re: [PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
urbandan commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1540691777 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when} import java.util

Re: [PR] KAFKA-16148: Implement GroupMetadataManager#onUnloaded [kafka]

2024-03-27 Thread via GitHub
dajac commented on PR #15446: URL: https://github.com/apache/kafka/pull/15446#issuecomment-2022239076 @jeffkbkim There are failed tests that look related. Could you check them please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831230#comment-17831230 ] Stanislav Spiridonov commented on KAFKA-16382: -- BTW if you take the wrong s

[jira] [Comment Edited] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831228#comment-17831228 ] Stanislav Spiridonov edited comment on KAFKA-16382 at 3/27/24 8:55 AM: ---

[jira] [Comment Edited] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-03-27 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831228#comment-17831228 ] Stanislav Spiridonov edited comment on KAFKA-16382 at 3/27/24 8:57 AM: ---

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-27 Thread via GitHub
dajac merged PR #15492: URL: https://github.com/apache/kafka/pull/15492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-16353) Offline protocol migration integration tests

2024-03-27 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16353. - Resolution: Fixed > Offline protocol migration integration tests > -

[jira] [Resolved] (KAFKA-16403) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testCountListOfWords

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez resolved KAFKA-16403. - Resolution: Not A Bug > Flaky test > org.apache.kafka.streams.examples.wordcount.WordCountDemoT

[jira] [Commented] (KAFKA-16403) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testCountListOfWords

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831244#comment-17831244 ] Igor Soarez commented on KAFKA-16403: - The test only failed the one time. I agree it

[jira] [Resolved] (KAFKA-16404) Flaky test org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testGetStreamsConfig

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez resolved KAFKA-16404. - Resolution: Not A Bug Same as KAFKA-16403, this only failed once. It was likely the result of a

[jira] [Updated] (KAFKA-16297) Race condition while promoting future replica can lead to partition unavailability.

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16297: Fix Version/s: 3.7.1 > Race condition while promoting future replica can lead to partition > unav

[jira] [Updated] (KAFKA-16297) Race condition while promoting future replica can lead to partition unavailability.

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16297: Affects Version/s: 3.7.0 > Race condition while promoting future replica can lead to partition >

[jira] [Updated] (KAFKA-16297) Race condition while promoting future replica can lead to partition unavailability.

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16297: Component/s: jbod > Race condition while promoting future replica can lead to partition > unavail

[jira] [Updated] (KAFKA-16365) AssignmentsManager mismanages completion notifications

2024-03-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16365: Priority: Critical (was: Major) > AssignmentsManager mismanages completion notifications > --

Re: [PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1540748533 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when} import java.uti

Re: [PR] MINOR: Preventing running the :core tests twice when testing with coverage [kafka]

2024-03-27 Thread via GitHub
viktorsomogyi merged PR #15580: URL: https://github.com/apache/kafka/pull/15580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

Re: [PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
viktorsomogyi commented on PR #15605: URL: https://github.com/apache/kafka/pull/15605#issuecomment-2022430965 @akatona84 I think this one exceeds the "minor" commit, I think you should create a jira ticket for this. Also, please add a description of your change that reveals the thinking beh

[jira] [Assigned] (KAFKA-16103) Review client logic for triggering offset commit callbacks

2024-03-27 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-16103: -- Assignee: Lucas Brutschy (was: Lianet Magrans) > Review client logic for triggering

Re: [PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
soarez commented on PR #15605: URL: https://github.com/apache/kafka/pull/15605#issuecomment-2022452207 I think there is a JIRA already for this flaky test: [KAFKA-15915](https://issues.apache.org/jira/browse/KAFKA-15915) If this is correct, then you should update the PR title to refer to

[jira] [Commented] (KAFKA-16323) Failing test: fix testRemoteFetchExpiresPerSecMetric

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831291#comment-17831291 ] Chia-Ping Tsai commented on KAFKA-16323: It seems to me the root cause could be

Re: [PR] KAFKA-15517: Improve MirrorMaker logging in case of authorization errors [kafka]

2024-03-27 Thread via GitHub
mimaison commented on code in PR #15558: URL: https://github.com/apache/kafka/pull/15558#discussion_r1540866456 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java: ## @@ -320,4 +322,19 @@ static void createCompactedTopic(String topicName, short par

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-27 Thread via GitHub
lucasbru commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1540879732 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java: ## @@ -25,22 +25,15 @@ import java.util.Map; /** - * Event for r

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-27 Thread via GitHub
lucasbru commented on PR #15525: URL: https://github.com/apache/kafka/pull/15525#issuecomment-2022475971 > @lucasbru - Thanks again for reviewing the PR. Sorry about the misinterpretation on short circuting logic so here I updated the beginningOrEndOffsets API. It seems like the right thing

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-27 Thread via GitHub
lucasbru merged PR #15576: URL: https://github.com/apache/kafka/pull/15576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
mimaison commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540885105 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] [MINOR] Renaming the `Abortable_Transaction` error to `Transaction_Abortable` [kafka]

2024-03-27 Thread via GitHub
sjhajharia commented on PR #15609: URL: https://github.com/apache/kafka/pull/15609#issuecomment-2022517844 Thanks for the review @soarez I have updated the variable names in the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540968019 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540992038 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-27 Thread via GitHub
jeqo commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022623732 Sorry for also being later with the review. Changes look good to me overall, though I'd also add a mention on these configs that: `log.roll` configs are ignored (as well as the mentioned

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1540968019 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on PR #15575: URL: https://github.com/apache/kafka/pull/15575#issuecomment-2022624611 @OmniaGM Can you, please, merge with latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-27 Thread via GitHub
brandboat commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022630053 Thank you @showuon , @jeqo . I will address the comments in the new JIRA https://issues.apache.org/jira/browse/KAFKA-16429 -- This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-03-27 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831324#comment-17831324 ] Jorge Esteban Quilcate Otoya commented on KAFKA-16414: -- As well, I'

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-03-27 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831327#comment-17831327 ] Jorge Esteban Quilcate Otoya commented on KAFKA-16414: -- Just got th

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022645115 @chia7712 CI are ready and seems OK for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S import

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541032203 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S import

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S import

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S import

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-27 Thread via GitHub
chia7712 commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022675724 @jeqo I should merge code after getting your reviews :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S import

[PR] refactor: improve the output information during partition directory m… [kafka]

2024-03-27 Thread via GitHub
KevinZTW opened a new pull request, #15610: URL: https://github.com/apache/kafka/pull/15610 Currently, when we using `kafka-reassign-partitions` to move the log directory, the output only indicates which replica's movement has successfully started. This PR propose to show more detai

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
mimaison commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1541117312 ## core/src/main/scala/kafka/server/ZkAdminManager.scala: ## @@ -49,6 +49,7 @@ import org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S impor

[jira] [Commented] (KAFKA-15265) Remote copy/fetch quotas for tiered storage.

2024-03-27 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831383#comment-17831383 ] Satish Duggana commented on KAFKA-15265: KIP-956 is approved. [~abhijeetkumar] i

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
chia7712 commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022937094 ``` ./gradlew cleanTest :tools:test --tests GetOffsetShellTest.testTopicPatternArgWithPartitionsArg :trogdor:test --tests CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated :con

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-27 Thread via GitHub
chia7712 merged PR #15075: URL: https://github.com/apache/kafka/pull/15075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-16432) KStreams: Joining KStreams and GlobalKTable requires a state store

2024-03-27 Thread Matej Sprysl (Jira)
Matej Sprysl created KAFKA-16432: Summary: KStreams: Joining KStreams and GlobalKTable requires a state store Key: KAFKA-16432 URL: https://issues.apache.org/jira/browse/KAFKA-16432 Project: Kafka

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-27 Thread via GitHub
mjsax commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1541286490 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -58,6 +61,8 @@ public class AbstractConfig { private final ConfigDef definition;

[PR] MINOR: Remove redundant ApiVersionsResponse#filterApis [kafka]

2024-03-27 Thread via GitHub
brandboat opened a new pull request, #15611: URL: https://github.com/apache/kafka/pull/15611 The method `ApiVersionsResponse#filterApis(RecordVersion, ApiMessageType.ListenerType)` is only used in test, we can remove it and invoke the other one. ### Committer Checklist (excluded from

[jira] [Updated] (KAFKA-16432) KStreams: Joining KStreams and GlobalKTable requires a state store

2024-03-27 Thread Matej Sprysl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Sprysl updated KAFKA-16432: - Description: h2.  Code: {code:java} final StreamsBuilder builder = new StreamsBuilder(); final

[jira] [Commented] (KAFKA-16432) KStreams: Joining KStreams and GlobalKTable requires a state store

2024-03-27 Thread Matej Sprysl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831415#comment-17831415 ] Matej Sprysl commented on KAFKA-16432: -- Update: The issue was probably caused by c

[jira] [Assigned] (KAFKA-15915) Flaky test - testUnrecoverableError - ProducerIdManagerTest

2024-03-27 Thread Andras Katona (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Katona reassigned KAFKA-15915: - Assignee: Andras Katona > Flaky test - testUnrecoverableError - ProducerIdManagerTest >

[jira] [Resolved] (KAFKA-16432) KStreams: Joining KStreams and GlobalKTable requires a state store

2024-03-27 Thread Matej Sprysl (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Sprysl resolved KAFKA-16432. -- Resolution: Fixed Fixed by using the same StreamsBuilder for both streams. > KStreams: Joinin

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1541313630 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1502,13 +1502,23 @@ public static Map filterMap(final Map map, final Predicate propsToMap(Pro

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1541293009 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -580,8 +601,15 @@ private Map instantiateConfigProviders(Map providerClassName = Op

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1541328444 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -925,10 +926,13 @@ static Map adminConfigs(String connName, // Ignore conf

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541357369 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when} import java.uti

Re: [PR] KAFKA-16406 [2] : Split consumer commit tests [kafka]

2024-03-27 Thread via GitHub
lianetm commented on PR #15612: URL: https://github.com/apache/kafka/pull/15612#issuecomment-2023088189 @lucasbru this is one more last split that I find would make sense. With this, all the tests left in the `PlainTextConsumer` do not seem to belong to any sensible group other than the gen

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
soarez commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541375369 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import java.util.c

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-27 Thread via GitHub
chia7712 commented on PR #15489: URL: https://github.com/apache/kafka/pull/15489#issuecomment-2023109755 @Owen-CH-Leung The `printUsageAndExit` call `exit(1)` so `KRAFT` and `CO_KRAFT` will stop the JVM. `ZK` can capture the exit code to throw exception so it does not terminate the JVM.

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541378249 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import java.uti

[PR] KAFKA-16103: commitSync should await pending async commits [kafka]

2024-03-27 Thread via GitHub
lucasbru opened a new pull request, #15613: URL: https://github.com/apache/kafka/pull/15613 The javadoc for `KafkaConsumer.commitSync` says: > Note that asynchronous offset commits sent previously with the {@link #commitAsync(OffsetCommitCallback)} > (or similar) are guaranteed to

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541384909 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import java.uti

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541384909 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import java.uti

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541382798 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-16323: fix testRemoteFetchExpiresPerSecMetric [kafka]

2024-03-27 Thread via GitHub
johnnychhsu commented on code in PR #15463: URL: https://github.com/apache/kafka/pull/15463#discussion_r1541419703 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4164,16 +4164,13 @@ class ReplicaManagerTest { mock(classOf[FetchDataInfo])

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-27 Thread via GitHub
gharris1727 commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1541420383 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -580,8 +601,15 @@ private Map instantiateConfigProviders(Map

[jira] [Commented] (KAFKA-15265) Remote copy/fetch quotas for tiered storage.

2024-03-27 Thread Henry Cai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831438#comment-17831438 ] Henry Cai commented on KAFKA-15265: --- Thanks.  [~abhijeetkumar] Do you have a rough tim

Re: [PR] KAFKA-16217: Stop the abort transaction try loop when closing producers [kafka]

2024-03-27 Thread via GitHub
CalvinConfluent commented on PR #15541: URL: https://github.com/apache/kafka/pull/15541#issuecomment-2023173614 @kirktrue @jolshan Anything else we need to address for this ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-03-27 Thread via GitHub
clolov commented on PR #14716: URL: https://github.com/apache/kafka/pull/14716#issuecomment-2023192543 Hello @cadonna! This ought to be one of the last PRs for the migration. I will circle back tomorrow morning to rebase it since it has been out for a long time -- This is an automated me

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-03-27 Thread via GitHub
mimaison commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2023212508 Now that https://github.com/apache/kafka/pull/15075 got merged, this needs rebasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16406 [2] : Split consumer commit tests [kafka]

2024-03-27 Thread via GitHub
lianetm commented on code in PR #15612: URL: https://github.com/apache/kafka/pull/15612#discussion_r1541452355 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541471761 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541472627 ## server/src/main/java/org/apache/kafka/security/CredentialProvider.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541475816 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends IntegrationTestH

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831460#comment-17831460 ] Johnny Hsu commented on KAFKA-16310: The update is in below section:   ## When the

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
ijuma commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541483681 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends IntegrationTestHarn

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-27 Thread via GitHub
philipnee commented on PR #15525: URL: https://github.com/apache/kafka/pull/15525#issuecomment-2023293507 @lucasbru - If I'm not mistaken, the current implementation for both beginningOrEndOffsets and OffsetsForTimes both need to send out a request upon getting ZERO duration. Seems like bo

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541492785 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831463#comment-17831463 ] Chia-Ping Tsai commented on KAFKA-16310: @johnnyhsu thanks for offers the descri

[jira] [Created] (KAFKA-16433) beginningOffsets and offsetsForTimes don't behave consistently when providing a zero timeout

2024-03-27 Thread Philip Nee (Jira)
Philip Nee created KAFKA-16433: -- Summary: beginningOffsets and offsetsForTimes don't behave consistently when providing a zero timeout Key: KAFKA-16433 URL: https://issues.apache.org/jira/browse/KAFKA-16433

[jira] [Updated] (KAFKA-16433) beginningOffsets and offsetsForTimes don't behave consistently when providing a zero timeout

2024-03-27 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16433: --- Labels: consumer-threading-refactor (was: ) > beginningOffsets and offsetsForTimes don't behave con

[jira] [Comment Edited] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831464#comment-17831464 ] Johnny Hsu edited comment on KAFKA-16310 at 3/27/24 5:01 PM: -

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-27 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831464#comment-17831464 ] Johnny Hsu commented on KAFKA-16310: {quote}[~chia7712] thanks for the help! This r

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

2024-03-27 Thread via GitHub
nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541508048 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends IntegrationTestH

  1   2   >