[GitHub] [kafka] dajac commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

dajac commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655911095 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -29,9 +32,9 @@ */ @InterfaceStability.Evolving

[GitHub] [kafka] hachikuji commented on a change in pull request #10814: KAFKA-12888; Add transaction tool from KIP-664

hachikuji commented on a change in pull request #10814: URL: https://github.com/apache/kafka/pull/10814#discussion_r655631267 ## File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655408049 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,112 @@ public in

[GitHub] [kafka] cmccabe commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

cmccabe commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655616706 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void writeLeaderChangeMessag

[GitHub] [kafka] chia7712 commented on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

chia7712 commented on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865056585 > there is a behavior difference between the ZK-based KRaft controllers. Do we explicitly acknowledge and accept this difference? that is a good point. -- This is an a

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

dongjinleekr commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655162053 ## File path: core/src/test/scala/kafka/tools/ReplicaVerificationToolTest.scala ## @@ -17,14 +17,40 @@ package kafka.tools +import kafka.tools.R

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655642933 ## File path: core/src/test/scala/unit/kafka/server/FetchRequestTest.scala ## @@ -116,61 +122,85 @@ class FetchRequestTest extends BaseRequestTest { va

[GitHub] [kafka] kkonstantine commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kkonstantine commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r653815012 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -210,6 +211,15 @@ public void onDeletion(Conn

[GitHub] [kafka] dajac commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

dajac commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655911095 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -29,9 +32,9 @@ */ @InterfaceStability.Evolving

[GitHub] [kafka] cadonna commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

cadonna commented on a change in pull request #10740: URL: https://github.com/apache/kafka/pull/10740#discussion_r655626428 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java ## @@ -85,14 +87,11 @@ private TimeWindows(final long sizeMs, final

[GitHub] [kafka] jolshan commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-865491775 Hi @dengziming thanks for the update. There are a few more minor changes to the KIP. One is that after some discussion with people more familiar with clients, it makes sense to

[GitHub] [kafka] ijuma commented on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

ijuma commented on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865176496 > there is a behavior difference between the ZK-based KRaft controllers. Do we explicitly acknowledge and accept this difference? I think we should, but happy to consider ot

[GitHub] [kafka] izzyacademy commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

izzyacademy commented on a change in pull request #10740: URL: https://github.com/apache/kafka/pull/10740#discussion_r655661049 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java ## @@ -84,17 +86,14 @@ private SessionWindows(final long gap

[GitHub] [kafka] junrao commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

junrao commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r654568852 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2390,16 +2390,23 @@ object Log extends Logging { produc

[GitHub] [kafka] dongjinleekr commented on pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

dongjinleekr commented on pull request #10678: URL: https://github.com/apache/kafka/pull/10678#issuecomment-864781801 Rebased onto the latest trunk. cc/ @ijuma @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] hachikuji merged pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version

hachikuji merged pull request #10377: URL: https://github.com/apache/kafka/pull/10377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655511645 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void writeLeaderChangeMes

[GitHub] [kafka] dongjinleekr commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-864782996 Rebased onto the latest trunk. cc/ @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] rondagostino commented on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

rondagostino commented on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865055596 Sorry to come to this party a bit late. It is likely that the code had a mistake and broker.id=0 should have been broker.id=1. But even with the mistake, I wonder if this

[GitHub] [kafka] kowshik commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

kowshik commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655768001 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,15 +834,50 @@ class ProducerStateManager(val topicPartition: TopicParti

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

skaundinya15 commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r655133582 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -0,0 +1,156 @@ +/* + * Lice

[GitHub] [kafka] dongjinleekr commented on pull request #10472: KAFKA-12613: Inconsistencies between Kafka Config and Log Config

dongjinleekr commented on pull request #10472: URL: https://github.com/apache/kafka/pull/10472#issuecomment-864783895 Rebased onto the latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ryannedolan commented on a change in pull request #10652: KAFKA-9726 IdentityReplicationPolicy

ryannedolan commented on a change in pull request #10652: URL: https://github.com/apache/kafka/pull/10652#discussion_r655712378 ## File path: connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/IdentityReplicationPolicy.java ## @@ -0,0 +1,101 @@ +/* + * License

[GitHub] [kafka] dengziming commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

dengziming commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r655833840 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -359,6 +360,150 @@ public void testResignWillCompleteFetchPurgato

[GitHub] [kafka] mattwong949 commented on pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

mattwong949 commented on pull request #10914: URL: https://github.com/apache/kafka/pull/10914#issuecomment-865452418 @junrao @hachikuji Could you help take a review pass? I know Jun has reviewed before, but since we've rebased several times I think it would be helpful to look over again

[GitHub] [kafka] mattwong949 commented on pull request #9915: [KAKFA-8522] Streamline tombstone and transaction marker removal

mattwong949 commented on pull request #9915: URL: https://github.com/apache/kafka/pull/9915#issuecomment-865450989 I've rebased this PR on trunk again. I had to open a new PR to push up the changes. Thanks @ConcurrencyPractitioner for all of the work on this so far! https://github.com/apac

[GitHub] [kafka] C0urante commented on pull request #10907: KAFKA-10000: Exactly-once support for source connectors

C0urante commented on pull request #10907: URL: https://github.com/apache/kafka/pull/10907#issuecomment-865396213 There was a small misunderstanding of the rebalance logic for distributed workers. It turns out that they already preemptively stop reconfigured tasks before (re)joining the gr

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r655732329 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 6

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r655561404 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -471,16 +504,19 @@ class IncrementalFetchContext(private val time: Time, if (s

[GitHub] [kafka] hachikuji commented on a change in pull request #10900: KAFKA-12967; KRaft broker should forward DescribeQuorum to controller

hachikuji commented on a change in pull request #10900: URL: https://github.com/apache/kafka/pull/10900#discussion_r66345 ## File path: core/src/test/java/kafka/test/annotation/Type.java ## @@ -28,7 +28,7 @@ * The type of cluster config being requested. Used by {@link ka

[GitHub] [kafka] kowshik commented on pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-865332690 @junrao @dhruvilshah3 I ran a perf test against a Broker build with and without this PR. The test involved the following: 1. Created a test topic with 1 partition and repl

[GitHub] [kafka] jsancio commented on a change in pull request #10899: KAFKA-12952 Adding Delimeters to Metadata Snapshot File

jsancio commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r655536129 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -664,4 +666,55 @@ private static void writeLeaderChangeMessag

[GitHub] [kafka] kkonstantine commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kkonstantine commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r655880156 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -497,6 +476,37 @@ static void validateHeaderCon

[GitHub] [kafka] ccding commented on pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

ccding commented on pull request #10763: URL: https://github.com/apache/kafka/pull/10763#issuecomment-865468006 @dhruvilshah3 @junrao This PR is ready for review. Please take a look https://github.com/apache/kafka/blob/f914ed73e9de028d2e6bb1353cec02bcc2275c19/core/src/test/scala/unit

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-865419554 Hey @ableegoldman, just a remind. Please take a look, when you have time. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] dajac commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

dajac commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r655535240 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4296,28 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] rondagostino edited a comment on pull request #10908: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexi…

rondagostino edited a comment on pull request #10908: URL: https://github.com/apache/kafka/pull/10908#issuecomment-865055596 Sorry to come to this party a bit late. It is likely that the code had a mistake and broker.id=0 should have been broker.id=1. But even with the mistake, I wonder

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-864784408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For qu

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r655505767 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4314,18 @@ void handleFailure(Throwable thr

[GitHub] [kafka] dongjinleekr commented on pull request #10862: KAFKA-12928: Add a check whether the Task's statestore is actually a directory

dongjinleekr commented on pull request #10862: URL: https://github.com/apache/kafka/pull/10862#issuecomment-864785044 Rebased onto the latest trunk cc/ @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] gardnervickers commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

gardnervickers commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r655545444 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,12 +834,41 @@ class ProducerStateManager(val topicPartition: Top

[GitHub] [kafka] tombentley commented on a change in pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

tombentley commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r655154960 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -73,53 +74,61 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] rhauch commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

rhauch commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r655658286 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,112 @@ public int gene

[GitHub] [kafka] dajac commented on a change in pull request #10814: KAFKA-12888; Add transaction tool from KIP-664

dajac commented on a change in pull request #10814: URL: https://github.com/apache/kafka/pull/10814#discussion_r655969341 ## File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

showuon commented on pull request #10884: URL: https://github.com/apache/kafka/pull/10884#issuecomment-865746830 All failed tests are unrelated. ``` Build / JDK 16 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions() Buil

[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

showuon commented on pull request #10884: URL: https://github.com/apache/kafka/pull/10884#issuecomment-865747301 @vvcephei @mjsax , could you help review? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mdedetrich commented on pull request #10839: KAFKA-12913: Make case class's final

mdedetrich commented on pull request #10839: URL: https://github.com/apache/kafka/pull/10839#issuecomment-865776830 @mjsax @vvcephei @guozhangwang Sorry for directly pinging you guys but this PR has been sitting here for 2 weeks so I was wondering if you guys could look/comment on it (appa

[jira] [Assigned] (KAFKA-10587) Rename kafka-mirror-maker CLI command line arguments for KIP-629

[ https://issues.apache.org/jira/browse/KAFKA-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-10587: - Assignee: Omnia Ibrahim (was: Xavier Léauté) > Rename kafka-mirror-maker CLI command l

[jira] [Updated] (KAFKA-8733) Offline partitions occur when leader's disk is slow in reads while responding to follower fetch requests.

[ https://issues.apache.org/jira/browse/KAFKA-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-8733: -- Affects Version/s: 2.8.0 > Offline partitions occur when leader's disk is slow in reads while r

[GitHub] [kafka] cadonna commented on pull request #10911: MINOR: Remove log warning for RocksDB 6+ upgrade

cadonna commented on pull request #10911: URL: https://github.com/apache/kafka/pull/10911#issuecomment-865894634 Test failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false Build

[GitHub] [kafka] cadonna merged pull request #10911: MINOR: Remove log warning for RocksDB 6+ upgrade

cadonna merged pull request #10911: URL: https://github.com/apache/kafka/pull/10911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (KAFKA-12629) Failing Test: RaftClusterTest

[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367235#comment-17367235 ] Bruno Cadonna commented on KAFKA-12629: --- Failed again: https://ci-builds.apache.o

[jira] [Commented] (KAFKA-12786) Getting SslTransportLayerTest error

[ https://issues.apache.org/jira/browse/KAFKA-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367263#comment-17367263 ] Bruno Cadonna commented on KAFKA-12786: --- Failed again under JDK 11: https://ci-bu

[jira] [Commented] (KAFKA-12629) Failing Test: RaftClusterTest

[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367264#comment-17367264 ] Bruno Cadonna commented on KAFKA-12629: --- Failed again: https://ci-builds.apache.o

[GitHub] [kafka] cadonna merged pull request #10912: MINOR: Remove obsolete variables for metric sensors

cadonna merged pull request #10912: URL: https://github.com/apache/kafka/pull/10912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r656165498 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4296,28 @@ void handleFailure(Throwable thr

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r656166220 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4296,28 @@ void handleFailure(Throwable thr

[GitHub] [kafka] dajac commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

dajac commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r656222177 ## File path: core/src/test/scala/unit/kafka/server/LogOffsetTest.scala ## @@ -93,16 +87,52 @@ class LogOffsetTest extends BaseRequestTest { } @Test

[GitHub] [kafka] rhauch merged pull request #10335: KAFKA-12484: Enable Connect's connector log contexts by default (KIP-721)

rhauch merged pull request #10335: URL: https://github.com/apache/kafka/pull/10335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] rhauch merged pull request #10336: KAFKA-12483: Enable client overrides in connector configs by default (KIP-722)

rhauch merged pull request #10336: URL: https://github.com/apache/kafka/pull/10336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Resolved] (KAFKA-12483) Enable client overrides in connector configs by default

[ https://issues.apache.org/jira/browse/KAFKA-12483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-12483. --- Resolution: Fixed Merged to the `trunk` branch for inclusion in 3.0.0. > Enable client over

[jira] [Resolved] (KAFKA-12484) Enable Connect's connector log contexts by default

[ https://issues.apache.org/jira/browse/KAFKA-12484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-12484. --- Reviewer: Konstantine Karantasis Resolution: Fixed Merged to the `trunk` branch for in

[GitHub] [kafka] rhauch merged pull request #10834: KAFKA-12904: Corrected the timeout for config validation REST API resource

rhauch merged pull request #10834: URL: https://github.com/apache/kafka/pull/10834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] vvcephei commented on pull request #10869: KAFKA-10546: Deprecate old PAPI

vvcephei commented on pull request #10869: URL: https://github.com/apache/kafka/pull/10869#issuecomment-866022136 Thanks, @guozhangwang ! Yes, that's the area of the code I was looking for a double-check on. I switched the KOut/VOut parameters to Void/Void as you suggested. -- This is a

[GitHub] [kafka] vvcephei merged pull request #10869: KAFKA-10546: Deprecate old PAPI

vvcephei merged pull request #10869: URL: https://github.com/apache/kafka/pull/10869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kpatelatwork commented on a change in pull request #10841: URL: https://github.com/apache/kafka/pull/10841#discussion_r656285001 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -497,6 +476,37 @@ static void validateHeaderCon

[GitHub] [kafka] kpatelatwork commented on pull request #10841: KAFKA-12482 Remove deprecated rest.host.name and rest.port configs

kpatelatwork commented on pull request #10841: URL: https://github.com/apache/kafka/pull/10841#issuecomment-866040282 @kkonstantine Thanks a lot for the review comments, I have resolved all of them. Could you please review to see if it looks better now? -- This is an automated message fr

[GitHub] [kafka] gardnervickers commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

gardnervickers commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r656291670 ## File path: core/src/test/scala/unit/kafka/log/LogLoaderTest.scala ## @@ -1535,4 +1534,122 @@ class LogLoaderTest { assertTrue(onlySegment.l

[GitHub] [kafka] gardnervickers commented on a change in pull request #10896: KAFKA-12964: Collect and rename snapshot files prior to async deletion.

gardnervickers commented on a change in pull request #10896: URL: https://github.com/apache/kafka/pull/10896#discussion_r656296678 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -828,15 +834,50 @@ class ProducerStateManager(val topicPartition: Top

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656348082 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java ## @@ -208,6 +209,21 @@ public static Stri

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656356700 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/StartAndStopCounterSnapshot.java ## @@ -0,0 +1,37 @@ +/* + * Licens

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656356999 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,132 @@ public in

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656357635 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartPlan.java ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656358121 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -357,6 +367,62 @@ public void validateConnect

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r656358424 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -357,6 +367,62 @@ public void validateConnect

[GitHub] [kafka] ryannedolan commented on pull request #10629: BlockingConnectorTest improvements to verify Connectors and Tasks are successfully deleted

ryannedolan commented on pull request #10629: URL: https://github.com/apache/kafka/pull/10629#issuecomment-866147667 @C0urante do you mind reviewing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-12978) Kafka Health is returning returning DOWN: org.apache.kafka.common.errors.TimeoutException: Aborted due to timeout.

Shaun Wackerly created KAFKA-12978: -- Summary: Kafka Health is returning returning DOWN: org.apache.kafka.common.errors.TimeoutException: Aborted due to timeout. Key: KAFKA-12978 URL: https://issues.apache.org/jir

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656402618 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1914,8 +1917,7 @@ private long pollLeader(long currentTimeMs) {

[GitHub] [kafka] hachikuji merged pull request #10814: KAFKA-12888; Add transaction tool from KIP-664

hachikuji merged pull request #10814: URL: https://github.com/apache/kafka/pull/10814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Resolved] (KAFKA-12888) Add transaction tool

[ https://issues.apache.org/jira/browse/KAFKA-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12888. - Resolution: Fixed > Add transaction tool > > > Key:

[jira] [Created] (KAFKA-12979) Implement --find-hanging API in transaction tool

Jason Gustafson created KAFKA-12979: --- Summary: Implement --find-hanging API in transaction tool Key: KAFKA-12979 URL: https://issues.apache.org/jira/browse/KAFKA-12979 Project: Kafka Issue

[GitHub] [kafka] jsancio commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

jsancio commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656397806 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -143,6 +144,7 @@ public static final int MAX_BATCH_SIZE_BYTES = 8 *

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656424358 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -359,6 +360,150 @@ public void testResignWillCompleteFetchPurgator

[GitHub] [kafka] hachikuji commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

hachikuji commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656431145 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Fou

[jira] [Created] (KAFKA-12980) Allow consumers to return from poll when position advances

Chris Egerton created KAFKA-12980: - Summary: Allow consumers to return from poll when position advances Key: KAFKA-12980 URL: https://issues.apache.org/jira/browse/KAFKA-12980 Project: Kafka

[jira] [Updated] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-12980: -- Summary: Allow consumers to return from poll when position advances due to aborted transaction

[jira] [Commented] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367556#comment-17367556 ] Chris Egerton commented on KAFKA-12980: --- CC [~hachikuji]--thoughts on this? > All

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656446168 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -143,6 +144,7 @@ public static final int MAX_BATCH_SIZE_BYTES = 8

[jira] [Commented] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367563#comment-17367563 ] Chris Egerton commented on KAFKA-12980: --- [~guozhang] would you also like to weigh

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656448517 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2250,7 +2252,34 @@ private Long append(int epoch, List records, boole

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r656452042 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1914,8 +1917,7 @@ private long pollLeader(long currentTimeMs) {

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656472684 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -233,41 +232,41 @@ default DeleteTopicsResult deleteTopics(Collection

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656472986 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -233,41 +232,41 @@ default DeleteTopicsResult deleteTopics(Collection

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656473894 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656474094 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -233,41 +232,41 @@ default DeleteTopicsResult deleteTopics(Collection

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r656478396 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/TopicCollection.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r656483156 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1049,6 +1052,7 @@ object KafkaConfig { .defineInternal(BrokerHeartbeatInter

[GitHub] [kafka] hachikuji merged pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

hachikuji merged pull request #10883: URL: https://github.com/apache/kafka/pull/10883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Created] (KAFKA-12981) Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

Tom Scott created KAFKA-12981: - Summary: Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync Key: KAFKA-12981 URL: https://issues.apache.org/jira/browse/KAFKA-12981

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r656527325 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1316,6 +1316,16 @@ class Log(@volatile private var _dir: File, val latestEpoch

  1   2   >