showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-837956607
Failed tests are un-related. Thanks.
```
Build / JDK 15 and Scala 2.13 /
org.apache.kafka.common.record.MemoryRecordsBuilderTest.[6] magic=2,
bufferOffset=0, compressi
vitojeng opened a new pull request #10668:
URL: https://github.com/apache/kafka/pull/10668
In the PR #9821, @mjsax 's
[comment](https://github.com/apache/kafka/pull/9821#discussion_r556200365)
> We should use a try-with-resources clause to make sure close() is called.
>
> Seems
jlprat opened a new pull request #10669:
URL: https://github.com/apache/kafka/pull/10669
…lding SslTransportLayer
This is a cherry picked commit of https://github.com/apache/kafka/pull/10059
to branch 2.8
Original commit message:
This patch moves the `peerHost` helper defin
DuongPTIT opened a new pull request #10670:
URL: https://github.com/apache/kafka/pull/10670
@rhauch Hi, please review this PR for me. Many thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342374#comment-17342374
]
Angelos Kaltsikis commented on KAFKA-12635:
---
Hello [~yangguo1220],
Thanks for
chia7712 opened a new pull request #10671:
URL: https://github.com/apache/kafka/pull/10671
for https://github.com/apache/kafka/pull/10637#issuecomment-837691327
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test cover
chia7712 commented on pull request #10637:
URL: https://github.com/apache/kafka/pull/10637#issuecomment-837994346
> Is it possible to set up the gitignore to automatically ignore anything
under a generated/ subdirectory?
please take a look at #10671
--
This is an automated message
DuongPTIT closed pull request #10670:
URL: https://github.com/apache/kafka/pull/10670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
jlprat opened a new pull request #10672:
URL: https://github.com/apache/kafka/pull/10672
…lding SslTransportLayer
This is a cherry picked commit of #10059 to branch 2.7
This patch moves the `peerHost` helper defined in `SslChannelBuilder` into
`SslFactor`. `SaslChannelBuilder`
jlprat commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838046575
cc @vvcephei as mentioned on the mailing list, here there is a backport to
2.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jlprat commented on pull request #10672:
URL: https://github.com/apache/kafka/pull/10672#issuecomment-838046744
cc @vvcephei as mentioned on the mailing list, here there is a backport to
2.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
cadonna commented on a change in pull request #10646:
URL: https://github.com/apache/kafka/pull/10646#discussion_r629968874
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -128,8 +129,7 @@ public void setGlobal
cadonna commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838118603
For the next time, I would recommend to open smaller PRs. Almost 2000
additions is a lot even for docs. In my experience smaller PRs tend to be
merged faster.
--
This is an a
cadonna edited a comment on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838118603
Thank for the PR!
For the next time, I would recommend to open smaller PRs. Almost 2000
additions is a lot even for docs. In my experience smaller PRs tend to be
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629988069
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -40,6 +39,7 @@
private static fina
cadonna commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838119727
Do not worry about the test failures. First of all, your PR does not touch
any code, so there is no reason a test would fail due to your PR. Additionally,
the failing tests are
jlprat commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838120807
@cadonna I'll do it next time. I was doubting between providing a PR per
file or a PR per folder. (ended up doing PR for the Streams folder).
--
This is an automated message fr
jlprat commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838123810
Most of the changes are purely cosmetic:
- using the right tags for for embedding a code snippet
- escaping `<` and `>` characters to HTML encoded strings so they are
proper
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629990096
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -106,9 +104,9 @@ private boolean allSub
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629990802
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -428,14 +372,18 @@ private boolean allS
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629991853
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -469,73 +426,184 @@ private boolean all
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629991853
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -469,73 +426,184 @@ private boolean all
jlprat edited a comment on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838123810
Most of the changes are purely cosmetic:
- using the right tags for for embedding a code snippet
- escaping `<` and `>` characters to HTML encoded strings so they are
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629994499
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -469,73 +426,184 @@ private boolean all
showuon commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-838136488
@ableegoldman , I've done the code refinement and refactor. Basically is
what we've discussed in constrained Assignor PR. Please take a look when
available. Thanks.
--
This
showuon edited a comment on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-838136488
@ableegoldman , I've done the code refinement and refactor. Basically is
what we've discussed in constrained Assignor PR. Please take a look when
available.
cc @guozh
jlprat commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838186948
Test failure was:
`Build / JDK 8 and Scala 2.12 /
kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()`
This flaky test is already fixed
(https://issues.ap
DuongPTIT commented on pull request #10670:
URL: https://github.com/apache/kafka/pull/10670#issuecomment-838210303
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jlprat commented on pull request #10672:
URL: https://github.com/apache/kafka/pull/10672#issuecomment-838221652
Test failure was:
`Build / JDK 8 and Scala 2.12 /
kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()`
This flaky test is already fixed
(https://issues.ap
dengziming commented on pull request #10667:
URL: https://github.com/apache/kafka/pull/10667#issuecomment-838294186
Hello @guozhangwang ,PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-838339697
I saw there are cooperative sticky tests failed. I'll update it, and add
more tests into it tomorrow or later. Thanks.
--
This is an automated message from the Apache Git Serv
[
https://issues.apache.org/jira/browse/KAFKA-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342571#comment-17342571
]
zhangzhisheng commented on KAFKA-9826:
--
we have same problems，kafka version 2.12_2.4
vitojeng commented on pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#issuecomment-838538304
@mjsax , @ableegoldman
Please take a look. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
chia7712 opened a new pull request #10673:
URL: https://github.com/apache/kafka/pull/10673
related to #10532
the default value of `replication.factor` was changed from `1` to `-1`. The
old broker (< 2.4) does not support such configuration so this PR sets the
`replication.factor` to
chia7712 commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r630238771
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -553,141 +552,152 @@ public void
testInitializesAndDestroysMetr
omkreddy commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838656757
@jlprat Thanks for PR. I will directly push the original commit to 2.8 and
2.7 branches. We can close this PR.
--
This is an automated message from the Apache Git Service.
To
omkreddy commented on pull request #10672:
URL: https://github.com/apache/kafka/pull/10672#issuecomment-838657103
@jlprat Thanks for PR. I will directly push the original commit to 2.8 and
2.7 branches. We can close this PR.
--
This is an automated message from the Apache Git Ser
[
https://issues.apache.org/jira/browse/KAFKA-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-8562:
-
Fix Version/s: 2.8.1
2.7.2
> SASL_SSL still performs reverse DNS lookup despite KAFKA-
jlprat closed pull request #10669:
URL: https://github.com/apache/kafka/pull/10669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
jlprat closed pull request #10672:
URL: https://github.com/apache/kafka/pull/10672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
jlprat commented on pull request #10672:
URL: https://github.com/apache/kafka/pull/10672#issuecomment-838708838
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
jlprat commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838708152
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
mumrah commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r630302538
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
mumrah commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r630302538
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName = "kafka-server-common"
junrao merged pull request #10647:
URL: https://github.com/apache/kafka/pull/10647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ijuma commented on a change in pull request #10647:
URL: https://github.com/apache/kafka/pull/10647#discussion_r630330236
##
File path: build.gradle
##
@@ -1003,10 +1003,6 @@ project(':core') {
from(project(':connect:mirror').configurations.runtimeClasspath) {
into("libs/
dejan2609 commented on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-838776681
> Looks like there is a change in behavior in Gradle 7 related to resource
files that's causing a bunch of tests to fail
Indeed... on my local machine I received around
jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r628546403
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -242,85 +246,116 @@ final class KafkaMetadataLog private (
}
override de
jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r628546403
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -242,85 +246,116 @@ final class KafkaMetadataLog private (
}
override de
jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r628550053
##
File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java
##
@@ -104,18 +105,29 @@ public static Path createTempFile(Path logDir,
OffsetA
junrao merged pull request #10638:
URL: https://github.com/apache/kafka/pull/10638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/KAFKA-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-12758.
-
Fix Version/s: 3.0.0
Resolution: Fixed
merged the PR to trunk
> Create a new `server-common` mod
Jose Armando Garcia Sancio created KAFKA-12773:
--
Summary: Use UncheckedIOException when wrapping IOException
Key: KAFKA-12773
URL: https://issues.apache.org/jira/browse/KAFKA-12773
Project
jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r630364576
##
File path:
raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotReader.java
##
@@ -54,8 +54,12 @@ public Records records() {
}
@Ove
[
https://issues.apache.org/jira/browse/KAFKA-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342739#comment-17342739
]
Moses Nakamura commented on KAFKA-3539:
---
We've been wrestling with this problem for
jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r630367487
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -161,19 +162,24 @@ final class KafkaMetadataLog private (
override def trun
jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r630369703
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -242,85 +248,116 @@ final class KafkaMetadataLog private (
}
override de
jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r630369878
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -242,85 +248,116 @@ final class KafkaMetadataLog private (
}
override de
jsancio commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r630370013
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -242,85 +248,116 @@ final class KafkaMetadataLog private (
}
override de
dejan2609 edited a comment on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-838776681
> Looks like there is a change in behavior in Gradle 7 related to resource
files that's causing a bunch of tests to fail
Indeed... on my local machine I received
dejan2609 commented on pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#issuecomment-838902447
Changing status to draft (until test CLI, as mentioned in a comments above),
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mingaliu opened a new pull request #10674:
URL: https://github.com/apache/kafka/pull/10674
This is to help monitor the 'real' fetch latency by removing the waitTime
when FetchRequest is in purgatory.
The changes include:
1. Add waitTimeMs in FetchResponse()
2. In Kafka API handler
[
https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342778#comment-17342778
]
Ming Liu commented on KAFKA-12713:
--
Here is PR [https://github.com/apache/kafka/pull/10
Boojapho commented on pull request #10642:
URL: https://github.com/apache/kafka/pull/10642#issuecomment-838928359
> Also, we override the netty version, so I am not sure the ZK version needs
to be bumped at all.
So long as only one verson of netty remains in the release, that should
[
https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12766:
---
Labels: newbie newbie++ (was: )
> Consider Disabling WAL-related Options in
[
https://issues.apache.org/jira/browse/KAFKA-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-12682:
--
Assignee: Justine Olshan
> Kraft MetadataPartitionsBuilder _localChanged and _localRe
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r630523305
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Softwar
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r630539285
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r630539763
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r630542548
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java
##
@@ -125,6 +126,27 @@ public UUIDSerde() {
}
}
+
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r630542548
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java
##
@@ -125,6 +126,27 @@ public UUIDSerde() {
}
}
+
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r630550102
##
File path:
clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java
##
@@ -106,6 +110,190 @@ public void stringSerdeShouldSupp
ableegoldman commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r630552512
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -525,6 +525,11 @@ private TransactionManager
configu
ableegoldman commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r630553249
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java
##
@@ -179,10 +179,18 @@ public void beginTransaction() thro
ijuma commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r630556204
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -525,6 +525,11 @@ private TransactionManager
configureTrans
cmccabe commented on a change in pull request #10504:
URL: https://github.com/apache/kafka/pull/10504#discussion_r630569991
##
File path:
clients/src/main/resources/common/message/AllocateProducerIdsResponse.json
##
@@ -0,0 +1,32 @@
+// Licensed to the Apache Software Foundati
[
https://issues.apache.org/jira/browse/KAFKA-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342904#comment-17342904
]
Jun Rao commented on KAFKA-9826:
[~zhangzs] : The issue was fixed in 2.4.2. Could you try
cmccabe commented on a change in pull request #10504:
URL: https://github.com/apache/kafka/pull/10504#discussion_r630587756
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -2376,6 +2375,82 @@ class KafkaController(val config: KafkaConfig,
}
ableegoldman commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r630593372
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java
##
@@ -179,10 +179,18 @@ public void beginTransaction() thro
cmccabe commented on pull request #10504:
URL: https://github.com/apache/kafka/pull/10504#issuecomment-839261742
We need to gate the new behavior behind an IBP bump, right? Otherwise we
won't have access to new producer IDs while rolling a cluster.
--
This is an automated message from t
mjsax commented on a change in pull request #10673:
URL: https://github.com/apache/kafka/pull/10673#discussion_r630595939
##
File path: tests/kafkatest/services/streams.py
##
@@ -466,6 +466,15 @@ def __init__(self, test_context, kafka, processingMode):
cmccabe commented on a change in pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#discussion_r630598753
##
File path: tests/kafkatest/services/kafka/kafka.py
##
@@ -863,7 +878,7 @@ def kafka_configs_cmd_with_optional_security_settings(self,
node, force_use_
cmccabe commented on a change in pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#discussion_r630601127
##
File path: tests/kafkatest/services/security/kafka_acls.py
##
@@ -66,17 +67,46 @@ def add_cluster_acl(self, kafka, principal,
force_use_zk_connection=
ableegoldman opened a new pull request #10675:
URL: https://github.com/apache/kafka/pull/10675
Minor followup to [#10573](https://github.com/apache/kafka/pull/10573), see
in particular [this comment
thread](https://github.com/apache/kafka/pull/10573#discussion_r628777848).
Removes this in
mjsax commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r630601302
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -491,25 +493,23 @@ public void testStateThreadClose() throws Except
ableegoldman commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r630601449
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -525,6 +525,11 @@ private TransactionManager
configu
mjsax commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r630601702
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -525,14 +525,13 @@ public void testStateGlobalThreadClose() throws
ableegoldman commented on a change in pull request #10673:
URL: https://github.com/apache/kafka/pull/10673#discussion_r630601750
##
File path: tests/kafkatest/services/streams.py
##
@@ -466,6 +466,15 @@ def __init__(self, test_context, kafka, processingMode):
vitojeng commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r630602092
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -553,141 +552,152 @@ public void
testInitializesAndDestroysMetr
mjsax commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r630602355
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -553,141 +552,152 @@ public void
testInitializesAndDestroysMetrics
cmccabe commented on a change in pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#discussion_r630602650
##
File path: core/src/main/scala/kafka/server/MetadataSupport.scala
##
@@ -91,28 +93,42 @@ case class ZkSupport(adminManager: ZkAdminManager,
override
cmccabe commented on a change in pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#discussion_r630603137
##
File path: core/src/main/scala/kafka/server/MetadataSupport.scala
##
@@ -91,28 +93,42 @@ case class ZkSupport(adminManager: ZkAdminManager,
override
vitojeng commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r630603389
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -491,25 +493,23 @@ public void testStateThreadClose() throws Exc
vitojeng commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r630603482
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -525,14 +525,13 @@ public void testStateGlobalThreadClose() thro
cmccabe commented on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-839281487
Thanks for working on this, @rondagostino , and sorry about the delays in
reviewing.
> We forward the Create/Remove operations to the controller, but this patch
actually
mjsax commented on pull request #10675:
URL: https://github.com/apache/kafka/pull/10675#issuecomment-839282578
\cc @abbccdda and @guozhangwang to make sure we don't to anything bad
removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
ableegoldman commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r630605834
##
File path:
clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java
##
@@ -106,6 +110,190 @@ public void stringSerdeShoul
mjsax commented on a change in pull request #10673:
URL: https://github.com/apache/kafka/pull/10673#discussion_r630610600
##
File path: tests/kafkatest/services/streams.py
##
@@ -466,6 +466,15 @@ def __init__(self, test_context, kafka, processingMode):
ijuma commented on a change in pull request #10675:
URL: https://github.com/apache/kafka/pull/10675#discussion_r630612053
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/TxnOffsetCommitRequest.java
##
@@ -88,26 +84,13 @@ public Builder(final String transac
ableegoldman commented on a change in pull request #10673:
URL: https://github.com/apache/kafka/pull/10673#discussion_r630612173
##
File path: tests/kafkatest/services/streams.py
##
@@ -466,6 +466,15 @@ def __init__(self, test_context, kafka, processingMode):
1 - 100 of 119 matches
Mail list logo
