[jira] [Commented] (KAFKA-10182) Change number of partitions of __consumer_offsets

2020-06-18 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139155#comment-17139155 ] huxihx commented on KAFKA-10182: You could use `Admin.createPartitions` API to increase

[GitHub] [kafka] mimaison commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-06-18 Thread GitBox
mimaison commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-645861700 I think it's a useful fix but it's worth noting it will break all existing links. These links were only added a couple of releases ago too, so it's probably acceptable. ---

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-06-18 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-645868566 Another thought I had about improving the docs (though not for this PR) would be to have an index of links in alphabetical order at the start of each section (e.g. after "Broke

[jira] [Assigned] (KAFKA-9509) Fix flaky test MirrorConnectorsIntegrationTest.testReplication

2020-06-18 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-9509: Assignee: Luke Chen (was: Sanjana Kaundinya) > Fix flaky test MirrorConnectorsIntegrationTest.tes

[jira] [Commented] (KAFKA-9509) Fix flaky test MirrorConnectorsIntegrationTest.testReplication

2020-06-18 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139217#comment-17139217 ] Luke Chen commented on KAFKA-9509: -- [https://builds.apache.org/blue/rest/organizations/j

[jira] [Commented] (KAFKA-9509) Fix flaky test MirrorConnectorsIntegrationTest.testReplication

2020-06-18 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139218#comment-17139218 ] Luke Chen commented on KAFKA-9509: -- I take it over since it failed quite often recently,

[GitHub] [kafka] d8tltanc commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-18 Thread GitBox
d8tltanc commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-645877170 Thanks @abbccdda for the suggestions on the utility class. @skaundinya15 @ijuma I've opened this new PR for KIP-580 exponential retry backoff implementation. I've finalized

[GitHub] [kafka] d8tltanc edited a comment on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-18 Thread GitBox
d8tltanc edited a comment on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-645877170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] showuon opened a new pull request #8894: KAFKA-9509: Add retries for mirrorClient consume records to fix flaky test

2020-06-18 Thread GitBox
showuon opened a new pull request #8894: URL: https://github.com/apache/kafka/pull/8894 The test MirrorConnectorsIntegrationTest.testReplication failed too often recently. It failed on the build at least 6 times (I didn't check all failed builds) in today's(6/18) trunk build, and also fail

[GitHub] [kafka] showuon commented on pull request #8894: KAFKA-9509: Add retries for mirrorClient consume records to fix flaky test

2020-06-18 Thread GitBox
showuon commented on pull request #8894: URL: https://github.com/apache/kafka/pull/8894#issuecomment-645886831 @ryannedolan @skaundinya15 @kkonstantine , could you review this PR to fix flaky test? Thanks. This is an automat

[GitHub] [kafka] mimaison commented on pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-06-18 Thread GitBox
mimaison commented on pull request #8604: URL: https://github.com/apache/kafka/pull/8604#issuecomment-645910843 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] gunnarmorling opened a new pull request #8895: KAFKA-8398 Avoiding NPE in ByteBufferUnmapper#unmap()

2020-06-18 Thread GitBox
gunnarmorling opened a new pull request #8895: URL: https://github.com/apache/kafka/pull/8895 Regularly seeing this NPE when shutting down the broker in our tests. I *think* simply returning early in this case should suffice. Hey @ijuma, could you take a a look at this one perhaps? T

[jira] [Created] (KAFKA-10183) MirrorMaker creates duplicate messages in target cluster

2020-06-18 Thread Liraz Sharaby (Jira)
Liraz Sharaby created KAFKA-10183: - Summary: MirrorMaker creates duplicate messages in target cluster Key: KAFKA-10183 URL: https://issues.apache.org/jira/browse/KAFKA-10183 Project: Kafka Is

[GitHub] [kafka] ryannedolan commented on a change in pull request #8894: KAFKA-9509: Add retries for mirrorClient consume records to fix flaky test

2020-06-18 Thread GitBox
ryannedolan commented on a change in pull request #8894: URL: https://github.com/apache/kafka/pull/8894#discussion_r442313614 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -207,23 +212,45 @@ public void cl

[GitHub] [kafka] ryannedolan commented on a change in pull request #8894: KAFKA-9509: Add retries for mirrorClient consume records to fix flaky test

2020-06-18 Thread GitBox
ryannedolan commented on a change in pull request #8894: URL: https://github.com/apache/kafka/pull/8894#discussion_r442314691 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -207,23 +212,45 @@ public void cl

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-18 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r442330606 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala ## @@ -106,12 +107,29 @@ class GroupCoordinatorConcurre

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-18 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r442337184 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala ## @@ -106,12 +107,29 @@ class GroupCoordinatorConcur

[GitHub] [kafka] hachikuji commented on pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-18 Thread GitBox
hachikuji commented on pull request #8850: URL: https://github.com/apache/kafka/pull/8850#issuecomment-646125726 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-18 Thread GitBox
hachikuji commented on pull request #8850: URL: https://github.com/apache/kafka/pull/8850#issuecomment-646125880 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-18 Thread GitBox
hachikuji commented on pull request #8850: URL: https://github.com/apache/kafka/pull/8850#issuecomment-646126053 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] ijuma commented on pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-06-18 Thread GitBox
ijuma commented on pull request #7929: URL: https://github.com/apache/kafka/pull/7929#issuecomment-646140719 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (KAFKA-10005) Decouple RestoreListener from RestoreCallback and not enable bulk loading for RocksDB

2020-06-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139533#comment-17139533 ] Guozhang Wang commented on KAFKA-10005: --- So just to have a quick summary, my propo

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442354307 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442355123 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[jira] [Updated] (KAFKA-10184) Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2020-06-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10184: -- Priority: Minor (was: Major) > Flaky > HighAvailabilityTaskAssignorIntegrationTest.shouldSca

[jira] [Created] (KAFKA-10184) Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2020-06-18 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10184: - Summary: Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores Key: KAFKA-10184 URL: https://issues.apache.org/jira/browse/KAFKA-101

[jira] [Updated] (KAFKA-10184) Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2020-06-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10184: -- Issue Type: Test (was: Bug) > Flaky > HighAvailabilityTaskAssignorIntegrationTest.shouldScal

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442355123 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442355123 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442355123 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442362673 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -103,6 +103,12 @@ Utils.join(SecurityProtocol.names()

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442363632 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -678,7 +696,11 @@ public Node leastLoadedNode(long now) {

[jira] [Commented] (KAFKA-10184) Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2020-06-18 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139543#comment-17139543 ] Sophie Blee-Goldman commented on KAFKA-10184: - Yeah, it's failing on the set

[GitHub] [kafka] edoardocomar commented on pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

2020-06-18 Thread GitBox
edoardocomar commented on pull request #4204: URL: https://github.com/apache/kafka/pull/4204#issuecomment-646162106 After @hachikuji fixes in https://github.com/apache/kafka/pull/8586 the metrics are no longer ticked at the end of a DelayedFetch, so the time window for topic deletion is

[jira] [Commented] (KAFKA-10184) Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2020-06-18 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139546#comment-17139546 ] Sophie Blee-Goldman commented on KAFKA-10184: - [~vvcephei] Could we maybe do

[jira] [Commented] (KAFKA-10184) Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2020-06-18 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139548#comment-17139548 ] Sophie Blee-Goldman commented on KAFKA-10184: - Or instead (or in addition to

[GitHub] [kafka] hachikuji commented on pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-18 Thread GitBox
hachikuji commented on pull request #8822: URL: https://github.com/apache/kafka/pull/8822#issuecomment-646168538 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-18 Thread GitBox
hachikuji commented on pull request #8672: URL: https://github.com/apache/kafka/pull/8672#issuecomment-646173735 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442372873 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -103,6 +103,12 @@ Utils.join(SecurityProtocol.names()

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442375424 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -786,6 +808,29 @@ private void handleAbortedSends(List responses) {

[GitHub] [kafka] cmccabe commented on a change in pull request #8891: KAFKA-10143; Restore ability to change throttle of active reassignment

2020-06-18 Thread GitBox
cmccabe commented on a change in pull request #8891: URL: https://github.com/apache/kafka/pull/8891#discussion_r442378048 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -930,6 +935,38 @@ object ReassignPartitionsCommand extends Logging {

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442382471 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java ## @@ -149,6 +155,16 @@

[jira] [Created] (KAFKA-10185) Streams should log summarized restoration information at info level

2020-06-18 Thread John Roesler (Jira)
John Roesler created KAFKA-10185: Summary: Streams should log summarized restoration information at info level Key: KAFKA-10185 URL: https://issues.apache.org/jira/browse/KAFKA-10185 Project: Kafka

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442387660 ## File path: clients/src/test/java/org/apache/kafka/common/utils/GeometricProgressionTest.java ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] vvcephei opened a new pull request #8896: KAFKA-10185: Restoration info logging

2020-06-18 Thread GitBox
vvcephei opened a new pull request #8896: URL: https://github.com/apache/kafka/pull/8896 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrad

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442389711 ## File path: clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442394058 ## File path: clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] hachikuji commented on pull request #8891: KAFKA-10143; Restore ability to change throttle of active reassignment

2020-06-18 Thread GitBox
hachikuji commented on pull request #8891: URL: https://github.com/apache/kafka/pull/8891#issuecomment-646209534 Had some discussion offline with @cmccabe . The intention in KIP-455 is to use --additional to resubmit the reassignment and change the quota. I found that this did not work as

[GitHub] [kafka] vvcephei commented on a change in pull request #8896: KAFKA-10185: Restoration info logging

2020-06-18 Thread GitBox
vvcephei commented on a change in pull request #8896: URL: https://github.com/apache/kafka/pull/8896#discussion_r442397523 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -415,19 +418,20 @@ public void restore()

[GitHub] [kafka] d8tltanc commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-18 Thread GitBox
d8tltanc commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-646217062 Thanks, @dajac for the comments. I've modified the PR per your suggestions. @rajinisivaram Do you think we can start testing?

[GitHub] [kafka] guozhangwang merged pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-18 Thread GitBox
guozhangwang merged pull request #8876: URL: https://github.com/apache/kafka/pull/8876 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-18 Thread GitBox
guozhangwang commented on pull request #8876: URL: https://github.com/apache/kafka/pull/8876#issuecomment-646234217 Cherry-pick to 2.6. This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (KAFKA-10005) Decouple RestoreListener from RestoreCallback and not enable bulk loading for RocksDB

2020-06-18 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139916#comment-17139916 ] Sophie Blee-Goldman commented on KAFKA-10005: - I've been thinking about this

[jira] [Commented] (KAFKA-10005) Decouple RestoreListener from RestoreCallback and not enable bulk loading for RocksDB

2020-06-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139919#comment-17139919 ] Guozhang Wang commented on KAFKA-10005: --- I think even if we only move standbys to

[jira] [Comment Edited] (KAFKA-10005) Decouple RestoreListener from RestoreCallback and not enable bulk loading for RocksDB

2020-06-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139533#comment-17139533 ] Guozhang Wang edited comment on KAFKA-10005 at 6/18/20, 6:58 PM: -

[jira] [Commented] (KAFKA-10005) Decouple RestoreListener from RestoreCallback and not enable bulk loading for RocksDB

2020-06-18 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139925#comment-17139925 ] Sophie Blee-Goldman commented on KAFKA-10005: - Yeah, I didn't mean to imply

[jira] [Commented] (KAFKA-10179) State Store Passes Wrong Changelog Topic to Serde for Optimized Source Tables

2020-06-18 Thread Rohan Desai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139926#comment-17139926 ] Rohan Desai commented on KAFKA-10179: - I'm not sure it's correct to use the same "to

[GitHub] [kafka] skaundinya15 commented on a change in pull request #8894: KAFKA-9509: Add retries for mirrorClient consume records to fix flaky test

2020-06-18 Thread GitBox
skaundinya15 commented on a change in pull request #8894: URL: https://github.com/apache/kafka/pull/8894#discussion_r442445728 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -207,23 +212,45 @@ public void c

[GitHub] [kafka] dajac commented on pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-18 Thread GitBox
dajac commented on pull request #8672: URL: https://github.com/apache/kafka/pull/8672#issuecomment-646271944 @hachikuji I just rebased and fixed the build issue. Could you re-trigger jenkins please? This is an automated mess

[jira] [Commented] (KAFKA-10185) Streams should log summarized restoration information at info level

2020-06-18 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139955#comment-17139955 ] Boyang Chen commented on KAFKA-10185: - Could we add the context to this ticket? > S

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-18 Thread Mateusz Jadczyk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139963#comment-17139963 ] Mateusz Jadczyk commented on KAFKA-9891: LGTM thanks for looking into it and maki

[jira] [Assigned] (KAFKA-10160) Kafka MM2 consumer configuration

2020-06-18 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sats reassigned KAFKA-10160: Assignee: sats > Kafka MM2 consumer configuration > > >

[GitHub] [kafka] vvcephei commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-06-18 Thread GitBox
vvcephei commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-646303241 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-06-18 Thread GitBox
vvcephei commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r442497609 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -148,27 +150,35 @@ private f

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8881: KIP-557: Add emit on change support to Kafka Streams

2020-06-18 Thread GitBox
ConcurrencyPractitioner commented on pull request #8881: URL: https://github.com/apache/kafka/pull/8881#issuecomment-646304787 @vvcephei Think you have time to look at this? This is an automated message from the Apache Git Se

[GitHub] [kafka] dajac opened a new pull request #8897: MINOR; Use the automated protocol for the Consumer Protocol's subscriptions and assignments

2020-06-18 Thread GitBox
dajac opened a new pull request #8897: URL: https://github.com/apache/kafka/pull/8897 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] vinothchandar opened a new pull request #8898: KAFKA-10138: Prefer --bootstrap-server for reassign_partitions command in ducktape tests

2020-06-18 Thread GitBox
vinothchandar opened a new pull request #8898: URL: https://github.com/apache/kafka/pull/8898 http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-06-17--001.1592453352--vinothchandar--KC342-ducktape--e64cc463b/report.html Both ThrottlingTest

[GitHub] [kafka] vvcephei commented on a change in pull request #8896: KAFKA-10185: Restoration info logging

2020-06-18 Thread GitBox
vvcephei commented on a change in pull request #8896: URL: https://github.com/apache/kafka/pull/8896#discussion_r442529975 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -496,8 +539,9 @@ private void bufferChang

[GitHub] [kafka] cmccabe commented on pull request #8891: KAFKA-10143; Restore ability to change throttle of active reassignment

2020-06-18 Thread GitBox
cmccabe commented on pull request #8891: URL: https://github.com/apache/kafka/pull/8891#issuecomment-646334265 The refactors to the tool generally look good. I thought we always allowed throttles to be set to 0 for some reason, though? Looks like this change removes that ability which we

[GitHub] [kafka] cmccabe commented on a change in pull request #8891: KAFKA-10143; Restore ability to change throttle of active reassignment

2020-06-18 Thread GitBox
cmccabe commented on a change in pull request #8891: URL: https://github.com/apache/kafka/pull/8891#discussion_r442533488 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -1685,10 +1702,9 @@ object ReassignPartitionsCommand extends Logging {

[GitHub] [kafka] vvcephei commented on a change in pull request #8896: KAFKA-10185: Restoration info logging

2020-06-18 Thread GitBox
vvcephei commented on a change in pull request #8896: URL: https://github.com/apache/kafka/pull/8896#discussion_r442531300 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java ## @@ -223,6 +227,7 @@ public void shouldI

[jira] [Assigned] (KAFKA-10169) KafkaException: Failing batch since transaction was aborted

2020-06-18 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10169: --- Assignee: Sophie Blee-Goldman > KafkaException: Failing batch since transac

[jira] [Created] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-06-18 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10186: --- Summary: Aborting transaction with pending data should throw non-fatal exception Key: KAFKA-10186 URL: https://issues.apache.org/jira/browse/KAFKA-10186

[GitHub] [kafka] cmccabe commented on a change in pull request #8891: KAFKA-10143; Restore ability to change throttle of active reassignment

2020-06-18 Thread GitBox
cmccabe commented on a change in pull request #8891: URL: https://github.com/apache/kafka/pull/8891#discussion_r442535630 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -647,8 +647,14 @@ class KafkaController(val config: KafkaConfig, inf

[jira] [Updated] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-06-18 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10186: Labels: needs-kip newbie newbie++ (was: needs-kip) > Aborting transaction with pe

[GitHub] [kafka] mumrah commented on pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-18 Thread GitBox
mumrah commented on pull request #8822: URL: https://github.com/apache/kafka/pull/8822#issuecomment-646338829 @hachikuji yea that's the check I was referring to (where we disregard the fetch response, errors included). Do you think any of the errors we handle besides OOOR are worth handlin

[GitHub] [kafka] ijuma opened a new pull request #8899: MINOR: Gate test coverage plugin behind Gradle property

2020-06-18 Thread GitBox
ijuma opened a new pull request #8899: URL: https://github.com/apache/kafka/pull/8899 Most builds don't require test coverage output, so it's wasteful to spend cycles tracking coverage information for each method invoked. I ran a quick test in a fast desktop machine, the absolut

[GitHub] [kafka] hachikuji commented on pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-18 Thread GitBox
hachikuji commented on pull request #8822: URL: https://github.com/apache/kafka/pull/8822#issuecomment-646348733 @mumrah Hmm, I think I like the current approach of discarding the response if we're no longer in the same state in which the fetch state was sent. Mainly because it's simple. A

[jira] [Resolved] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10167. --- Resolution: Fixed > Streams EOS-Beta should not try to get end-offsets as read-committed > -

[GitHub] [kafka] ableegoldman opened a new pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-18 Thread GitBox
ableegoldman opened a new pull request #8900: URL: https://github.com/apache/kafka/pull/8900 If there's any pending data and we haven't flushed the producer when we abort a transaction, a KafkaException is returned for the previous `send`. This is a bit misleading, since the situation is n

[GitHub] [kafka] vinothchandar commented on pull request #8898: KAFKA-10138: Prefer --bootstrap-server for reassign_partitions command in ducktape tests

2020-06-18 Thread GitBox
vinothchandar commented on pull request #8898: URL: https://github.com/apache/kafka/pull/8898#issuecomment-646360446 @cmccabe Please take a pass when you can.. This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] mumrah commented on pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-18 Thread GitBox
mumrah commented on pull request #8822: URL: https://github.com/apache/kafka/pull/8822#issuecomment-646361035 Sounds good to me This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

2020-06-18 Thread GitBox
mjsax commented on pull request #8871: URL: https://github.com/apache/kafka/pull/8871#issuecomment-646365697 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-06-18 Thread GitBox
mjsax commented on pull request #8752: URL: https://github.com/apache/kafka/pull/8752#issuecomment-646367241 @sneakyburro Any update on this PR? This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Commented] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-06-18 Thread Arun R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140069#comment-17140069 ] Arun R commented on KAFKA-10186: I would love to take a look if no one else is looking a

[GitHub] [kafka] hachikuji commented on pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-18 Thread GitBox
hachikuji commented on pull request #8850: URL: https://github.com/apache/kafka/pull/8850#issuecomment-646368944 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-18 Thread GitBox
hachikuji commented on pull request #8850: URL: https://github.com/apache/kafka/pull/8850#issuecomment-646369171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-10114) Kafka producer stuck after broker crash

2020-06-18 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140073#comment-17140073 ] Jason Gustafson commented on KAFKA-10114: - [~ibinyami] Hmm, this is still not ve

[jira] [Commented] (KAFKA-10179) State Store Passes Wrong Changelog Topic to Serde for Optimized Source Tables

2020-06-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140075#comment-17140075 ] Matthias J. Sax commented on KAFKA-10179: - {quote}I'm not sure it's correct to u

[jira] [Comment Edited] (KAFKA-10179) State Store Passes Wrong Changelog Topic to Serde for Optimized Source Tables

2020-06-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140075#comment-17140075 ] Matthias J. Sax edited comment on KAFKA-10179 at 6/19/20, 12:42 AM: --

[GitHub] [kafka] mjsax commented on a change in pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-18 Thread GitBox
mjsax commented on a change in pull request #8887: URL: https://github.com/apache/kafka/pull/8887#discussion_r442574113 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -741,29 +741,23 @@ void shutdown(final boolean clean)

[GitHub] [kafka] mjsax commented on a change in pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-18 Thread GitBox
mjsax commented on a change in pull request #8887: URL: https://github.com/apache/kafka/pull/8887#discussion_r442574574 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1048,4 +1042,28 @@ public String toString(final Stri

[GitHub] [kafka] mjsax commented on pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-18 Thread GitBox
mjsax commented on pull request #8886: URL: https://github.com/apache/kafka/pull/8886#issuecomment-646376402 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-18 Thread GitBox
mjsax commented on pull request #8886: URL: https://github.com/apache/kafka/pull/8886#issuecomment-646376357 Java 8 passed. Java 11: ``` kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup ```

[jira] [Issue Comment Deleted] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

2020-06-18 Thread Arun R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun R updated KAFKA-10186: --- Comment: was deleted (was: I would love to take a look if no one else is looking at it.) > Aborting transac

[jira] [Commented] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-06-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140082#comment-17140082 ] Matthias J. Sax commented on KAFKA-8266: The other ticket is resolved, but I just

[GitHub] [kafka] hachikuji merged pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-18 Thread GitBox
hachikuji merged pull request #8822: URL: https://github.com/apache/kafka/pull/8822 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10113) LogTruncationException sets fetch offsets incorrectly

2020-06-18 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10113. - Fix Version/s: 2.6.0 Resolution: Fixed > LogTruncationException sets fetch offset

[jira] [Updated] (KAFKA-10113) LogTruncationException sets fetch offsets incorrectly

2020-06-18 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10113: Affects Version/s: 2.5.0 2.4.1 > LogTruncationException sets fetch

[jira] [Commented] (KAFKA-10184) Flaky HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

2020-06-18 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140088#comment-17140088 ] John Roesler commented on KAFKA-10184: -- What in the world... How can we not have pr

  1   2   >