[GitHub] [kafka] chia7712 commented on pull request #8783: KAFKA-10063 UnsupportedOperation when querying cleaner metrics after …

2020-06-03 Thread GitBox
chia7712 commented on pull request #8783: URL: https://github.com/apache/kafka/pull/8783#issuecomment-638001504 @hachikuji Could you take a look? This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (KAFKA-9887) failed-task-count JMX metric not updated if task fails during startup

2020-06-03 Thread Michael Carter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124683#comment-17124683 ] Michael Carter commented on KAFKA-9887: --- This similarly applies to connectors that

[jira] [Comment Edited] (KAFKA-9887) failed-task-count JMX metric not updated if task fails during startup

2020-06-03 Thread Michael Carter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124683#comment-17124683 ] Michael Carter edited comment on KAFKA-9887 at 6/3/20, 7:19 AM: ---

[jira] [Assigned] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2020-06-03 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-9320: -- Assignee: Nikolay Izhikov > Enable TLSv1.3 by default and disable some of the older pr

[jira] [Resolved] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2020-06-03 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov resolved KAFKA-9320. Resolution: Fixed Fixed with the https://github.com/apache/kafka/commit/8b22b8159673bfe22d

[GitHub] [kafka] dajac commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-03 Thread GitBox
dajac commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r434360661 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -391,6 +404,54 @@ class ControllerContext { partitionsForTopic(topic).fi

[GitHub] [kafka] dajac commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-03 Thread GitBox
dajac commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r434360795 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -391,6 +404,54 @@ class ControllerContext { partitionsForTopic(topic).fi

[jira] [Comment Edited] (KAFKA-9887) failed-task-count JMX metric not updated if task fails during startup

2020-06-03 Thread Michael Carter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124683#comment-17124683 ] Michael Carter edited comment on KAFKA-9887 at 6/3/20, 7:25 AM: ---

[GitHub] [kafka] dajac commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-03 Thread GitBox
dajac commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r434361213 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -391,6 +404,54 @@ class ControllerContext { partitionsForTopic(topic).fi

[jira] [Created] (KAFKA-10089) The stale ssl engine factory is not closed after reconfigure

2020-06-03 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10089: -- Summary: The stale ssl engine factory is not closed after reconfigure Key: KAFKA-10089 URL: https://issues.apache.org/jira/browse/KAFKA-10089 Project: Kafka

[GitHub] [kafka] chia7712 opened a new pull request #8792: KAFKA-10089 The stale ssl engine factory is not closed after reconfigure

2020-06-03 Thread GitBox
chia7712 opened a new pull request #8792: URL: https://github.com/apache/kafka/pull/8792 https://issues.apache.org/jira/browse/KAFKA-10089 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build statu

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-03 Thread Mateusz Jadczyk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124787#comment-17124787 ] Mateusz Jadczyk commented on KAFKA-9891: [~bchen225242] well, it shouldn't occur

[jira] [Created] (KAFKA-10090) Misleading warnings: The configuration was supplied but isn't a known config

2020-06-03 Thread Robert Wruck (Jira)
Robert Wruck created KAFKA-10090: Summary: Misleading warnings: The configuration was supplied but isn't a known config Key: KAFKA-10090 URL: https://issues.apache.org/jira/browse/KAFKA-10090 Project:

[GitHub] [kafka] chia7712 commented on a change in pull request #8783: KAFKA-10063 UnsupportedOperation when querying cleaner metrics after …

2020-06-03 Thread GitBox
chia7712 commented on a change in pull request #8783: URL: https://github.com/apache/kafka/pull/8783#discussion_r434456891 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -112,9 +112,19 @@ class LogCleaner(initialConfig: CleanerConfig, private[log] val c

[GitHub] [kafka] kowshik commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-03 Thread GitBox
kowshik commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r434344257 ## File path: clients/src/main/java/org/apache/kafka/common/feature/BaseVersionRange.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (KAFKA-10090) Misleading warnings: The configuration was supplied but isn't a known config

2020-06-03 Thread Robert Wruck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124823#comment-17124823 ] Robert Wruck commented on KAFKA-10090: -- The "new HashMap" leak was introduced by KA

[GitHub] [kafka] astubbs commented on pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-03 Thread GitBox
astubbs commented on pull request #8771: URL: https://github.com/apache/kafka/pull/8771#issuecomment-638105979 > Checkstyle error: ah dag nammit, sorry guys This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac commented on a change in pull request #8666: KAFKA-9479: Describe consumer group --state --all-groups show header once

2020-06-03 Thread GitBox
dajac commented on a change in pull request #8666: URL: https://github.com/apache/kafka/pull/8666#discussion_r434554562 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -291,14 +291,21 @@ object ConsumerGroupCommand extends Logging { }

[GitHub] [kafka] dajac opened a new pull request #8793: KAFKA-9514; The protocol generator generated useless condition when afield is made nullable and flexible version is used

2020-06-03 Thread GitBox
dajac opened a new pull request #8793: URL: https://github.com/apache/kafka/pull/8793 The protocol generator generates useless conditions when a field of type string is made nullable after the request has been converted to using optional fields. As an example, we have make the field

[GitHub] [kafka] chia7712 commented on pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-03 Thread GitBox
chia7712 commented on pull request #8782: URL: https://github.com/apache/kafka/pull/8782#issuecomment-638228671 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] ijuma commented on pull request #8751: MINOR: Update to Gradle 6.5 and tweak build jvm config

2020-06-03 Thread GitBox
ijuma commented on pull request #8751: URL: https://github.com/apache/kafka/pull/8751#issuecomment-638255192 @omkreddy Updated the PR description and made a few more changes. This is an automated message from the Apache Git S

[GitHub] [kafka] abbccdda commented on pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-06-03 Thread GitBox
abbccdda commented on pull request #8549: URL: https://github.com/apache/kafka/pull/8549#issuecomment-638285212 @guozhangwang Actually my previous response was not correct. By making the `InvalidProducerEpoch` to extend a `RetriableException`, we could bypass the `sender#canRetry` check to

[GitHub] [kafka] jsancio closed pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-06-03 Thread GitBox
jsancio closed pull request #8639: URL: https://github.com/apache/kafka/pull/8639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] jsancio commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-06-03 Thread GitBox
jsancio commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-638286953 The bug report in [KAFKA-9962](https://issues.apache.org/jira/browse/KAFKA-9962) is for `describeCluster`. This

[jira] [Assigned] (KAFKA-9962) Admin client throws UnsupportedVersion exception when talking to old broker

2020-06-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-9962: - Assignee: (was: Jose Armando Garcia Sancio) > Admin client t

[GitHub] [kafka] hachikuji commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-03 Thread GitBox
hachikuji commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-638294334 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-03 Thread GitBox
hachikuji commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-638294449 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] vvcephei commented on pull request #8785: KAFKA-10084: Fix EosTestDriver end offset

2020-06-03 Thread GitBox
vvcephei commented on pull request #8785: URL: https://github.com/apache/kafka/pull/8785#issuecomment-638298913 All test failures were unrelated (looks like some new flaky tests) ``` kafka.server.GssapiAuthenticationTest.testServerAuthenticationFailure org.apache.kafka.clie

[GitHub] [kafka] guozhangwang commented on a change in pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-03 Thread GitBox
guozhangwang commented on a change in pull request #8782: URL: https://github.com/apache/kafka/pull/8782#discussion_r434688366 ## File path: core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala ## @@ -86,6 +90,70 @@ class Transaction

[GitHub] [kafka] vvcephei merged pull request #8785: KAFKA-10084: Fix EosTestDriver end offset

2020-06-03 Thread GitBox
vvcephei merged pull request #8785: URL: https://github.com/apache/kafka/pull/8785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] dajac commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-06-03 Thread GitBox
dajac commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-638300527 @mimaison Are you going to rebase this one? I could take a look at it once done. This is an automated message from

[GitHub] [kafka] hachikuji commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-03 Thread GitBox
hachikuji commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r434687347 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1310,16 +1313,23 @@ private CompletedFetch initializ

[GitHub] [kafka] hachikuji commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-03 Thread GitBox
hachikuji commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-638305368 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-03 Thread GitBox
hachikuji commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-638305947 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-03 Thread GitBox
hachikuji commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-638306026 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Resolved] (KAFKA-8338) Improve consumer offset expiration logic to take subscription into account

2020-06-03 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-8338. Resolution: Duplicate This has been done as part of KAFKA-8730 (KIP-496). > Improve consumer offse

[GitHub] [kafka] dajac commented on pull request #6737: KAFKA-8338: consumer offset expiration should consider subscription.

2020-06-03 Thread GitBox
dajac commented on pull request #6737: URL: https://github.com/apache/kafka/pull/6737#issuecomment-638311288 This has been done as part of KAFKA-8730 (KIP-496). We can close it. This is an automated message from the Apache Gi

[GitHub] [kafka] vvcephei commented on pull request #8785: KAFKA-10084: Fix EosTestDriver end offset

2020-06-03 Thread GitBox
vvcephei commented on pull request #8785: URL: https://github.com/apache/kafka/pull/8785#issuecomment-638313567 cherry-picked to 2.6 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (KAFKA-9988) Connect incorrectly logs that task has failed when one takes too long to shutdown

2020-06-03 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-9988: - Summary: Connect incorrectly logs that task has failed when one takes too long to shutdown (was:

[GitHub] [kafka] hachikuji commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-03 Thread GitBox
hachikuji commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r434725093 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -822,19 +822,25 @@ public void onSuccess(OffsetForEpoc

[GitHub] [kafka] ijuma commented on pull request #8751: MINOR: Update to Gradle 6.5 and tweak build jvm config

2020-06-03 Thread GitBox
ijuma commented on pull request #8751: URL: https://github.com/apache/kafka/pull/8751#issuecomment-638340086 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma edited a comment on pull request #8751: MINOR: Update to Gradle 6.5 and tweak build jvm config

2020-06-03 Thread GitBox
ijuma edited a comment on pull request #8751: URL: https://github.com/apache/kafka/pull/8751#issuecomment-638340086 JDK 8/Scala 2.12 had an out of memory issue. This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugs and spotbugsPlugin

2020-06-03 Thread GitBox
ijuma commented on pull request #8790: URL: https://github.com/apache/kafka/pull/8790#issuecomment-638340962 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] hachikuji merged pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-03 Thread GitBox
hachikuji merged pull request #8782: URL: https://github.com/apache/kafka/pull/8782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-10080) IllegalStateException after duplicate CompleteCommit append to transaction log

2020-06-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125181#comment-17125181 ] Jason Gustafson commented on KAFKA-10080: - Note that this seems to have been int

[jira] [Resolved] (KAFKA-10080) IllegalStateException after duplicate CompleteCommit append to transaction log

2020-06-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10080. - Fix Version/s: 2.6.0 Resolution: Fixed > IllegalStateException after duplicate Co

[jira] [Resolved] (KAFKA-9777) Purgatory locking bug can lead to hanging transaction

2020-06-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9777. Fix Version/s: 2.6.0 Resolution: Fixed > Purgatory locking bug can lead to hanging t

[GitHub] [kafka] rajinisivaram merged pull request #8792: KAFKA-10089 The stale ssl engine factory is not closed after reconfigure

2020-06-03 Thread GitBox
rajinisivaram merged pull request #8792: URL: https://github.com/apache/kafka/pull/8792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-03 Thread GitBox
hachikuji commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r434702023 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -391,6 +404,90 @@ class ControllerContext { partitionsForTopic(topic

[jira] [Resolved] (KAFKA-10089) The stale ssl engine factory is not closed after reconfigure

2020-06-03 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-10089. Fix Version/s: 2.6.0 Reviewer: Rajini Sivaram Resolution: Fixed > The stal

[GitHub] [kafka] hachikuji commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-03 Thread GitBox
hachikuji commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r434761114 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -827,14 +827,15 @@ public void onSuccess(OffsetForEpoc

[GitHub] [kafka] omkreddy commented on pull request #8715: KAFKA-10033: AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existing

2020-06-03 Thread GitBox
omkreddy commented on pull request #8715: URL: https://github.com/apache/kafka/pull/8715#issuecomment-638386016 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] kowshik commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-03 Thread GitBox
kowshik commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r434428173 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java ## @@ -113,14 +127,44 @@ public static ApiVersionsResponse fr

[GitHub] [kafka] cmccabe commented on pull request #8793: KAFKA-9514; The protocol generator generated useless condition when a field is made nullable and flexible version is used

2020-06-03 Thread GitBox
cmccabe commented on pull request #8793: URL: https://github.com/apache/kafka/pull/8793#issuecomment-638404260 LGTM. Thanks, @dajac This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] hachikuji commented on pull request #8784: KAFKA-9788: Use distinct names for transaction and group load time se…

2020-06-03 Thread GitBox
hachikuji commented on pull request #8784: URL: https://github.com/apache/kafka/pull/8784#issuecomment-638419527 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugs and spotbugsPlugin

2020-06-03 Thread GitBox
ijuma commented on pull request #8790: URL: https://github.com/apache/kafka/pull/8790#issuecomment-638437924 One job failed for unrelated reasons. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] ijuma commented on pull request #8751: MINOR: Update to Gradle 6.5 and tweak build jvm config

2020-06-03 Thread GitBox
ijuma commented on pull request #8751: URL: https://github.com/apache/kafka/pull/8751#issuecomment-638438813 Build passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma merged pull request #8790: MINOR: Upgrade spotbugs and spotbugsPlugin

2020-06-03 Thread GitBox
ijuma merged pull request #8790: URL: https://github.com/apache/kafka/pull/8790 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma merged pull request #8751: MINOR: Update to Gradle 6.5 and tweak build jvm config

2020-06-03 Thread GitBox
ijuma merged pull request #8751: URL: https://github.com/apache/kafka/pull/8751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #8751: MINOR: Update to Gradle 6.5 and tweak build jvm config

2020-06-03 Thread GitBox
ijuma commented on pull request #8751: URL: https://github.com/apache/kafka/pull/8751#issuecomment-638439407 Cherry picked this to 2.6 as well since it's low risk and fixes a compilation speed regression. This is an automate

[jira] [Updated] (KAFKA-9313) Set default for client.dns.lookup to use_all_dns_ips

2020-06-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-9313: --- Fix Version/s: 2.6.0 > Set default for client.dns.lookup to use_all_dns_ips > ---

[jira] [Updated] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2020-06-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-9320: --- Fix Version/s: 2.6.0 > Enable TLSv1.3 by default and disable some of the older protocols > --

[jira] [Created] (KAFKA-10091) Improve task idling

2020-06-03 Thread John Roesler (Jira)
John Roesler created KAFKA-10091: Summary: Improve task idling Key: KAFKA-10091 URL: https://issues.apache.org/jira/browse/KAFKA-10091 Project: Kafka Issue Type: Task Components: st

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-06-03 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-638444641 @dajac Thank for your interest. I want to merge https://github.com/apache/kafka/pull/8311 and https://github.com/apache/kafka/pull/8312 first. I'll take a look at them tomorrow

[jira] [Created] (KAFKA-10095) In LogCleanerManagerTest replace get().nonEmpty call with contains

2020-06-03 Thread Jakob Homan (Jira)
Jakob Homan created KAFKA-10095: --- Summary: In LogCleanerManagerTest replace get().nonEmpty call with contains Key: KAFKA-10095 URL: https://issues.apache.org/jira/browse/KAFKA-10095 Project: Kafka

[jira] [Created] (KAFKA-10093) Replace iteration with call to addAll in Utils

2020-06-03 Thread Jakob Homan (Jira)
Jakob Homan created KAFKA-10093: --- Summary: Replace iteration with call to addAll in Utils Key: KAFKA-10093 URL: https://issues.apache.org/jira/browse/KAFKA-10093 Project: Kafka Issue Type: Impr

[jira] [Created] (KAFKA-10094) In MirrorSourceConnector replace two-step assignment with single call

2020-06-03 Thread Jakob Homan (Jira)
Jakob Homan created KAFKA-10094: --- Summary: In MirrorSourceConnector replace two-step assignment with single call Key: KAFKA-10094 URL: https://issues.apache.org/jira/browse/KAFKA-10094 Project: Kafka

[jira] [Created] (KAFKA-10092) Remove unnecessary enum modifier in NioEchoServer

2020-06-03 Thread Jakob Homan (Jira)
Jakob Homan created KAFKA-10092: --- Summary: Remove unnecessary enum modifier in NioEchoServer Key: KAFKA-10092 URL: https://issues.apache.org/jira/browse/KAFKA-10092 Project: Kafka Issue Type: I

[GitHub] [kafka] guozhangwang commented on pull request #8786: KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests

2020-06-03 Thread GitBox
guozhangwang commented on pull request #8786: URL: https://github.com/apache/kafka/pull/8786#issuecomment-638463385 Cherry-picked back to 2.4 This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (KAFKA-10093) Replace iteration with call to addAll in Utils

2020-06-03 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125330#comment-17125330 ] Ismael Juma commented on KAFKA-10093: - Thanks for the JIRA. Using `addAll` here is n

[GitHub] [kafka] afalko opened a new pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-06-03 Thread GitBox
afalko opened a new pull request #8794: URL: https://github.com/apache/kafka/pull/8794 NioEchoServer the enum has its constructor declared as private, which is redundant. There is also an unused exception throws and unused method. Reviewers: Jakob Homan This is a newbie ticke

[GitHub] [kafka] afalko commented on pull request #8794: KAFKA-10092: Remove unused code branches in NioEchoServer

2020-06-03 Thread GitBox
afalko commented on pull request #8794: URL: https://github.com/apache/kafka/pull/8794#issuecomment-638478890 @jghoman This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Created] (KAFKA-10096) Remove unnecessary String.format call in VersionConditionalTest.java

2020-06-03 Thread Can Cecen (Jira)
Can Cecen created KAFKA-10096: - Summary: Remove unnecessary String.format call in VersionConditionalTest.java Key: KAFKA-10096 URL: https://issues.apache.org/jira/browse/KAFKA-10096 Project: Kafka

[jira] [Assigned] (KAFKA-10096) Remove unnecessary String.format call in VersionConditionalTest.java

2020-06-03 Thread Jakob Homan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan reassigned KAFKA-10096: --- Assignee: Can Cecen > Remove unnecessary String.format call in VersionConditionalTest.java

[GitHub] [kafka] sarahgonsalves223 opened a new pull request #8795: KAFKA-10095: Simplify calls in LogCleanerManagerTest

2020-06-03 Thread GitBox
sarahgonsalves223 opened a new pull request #8795: URL: https://github.com/apache/kafka/pull/8795 In kafka.log.LogCleanerManagerTest we have two calls to .get(something).nonEmpty, which is equivalent to .contains(something). Making changes to simplify these calls. Reviewers: Jakob H

[GitHub] [kafka] sarahgonsalves223 commented on pull request #8795: KAFKA-10095: Simplify calls in LogCleanerManagerTest

2020-06-03 Thread GitBox
sarahgonsalves223 commented on pull request #8795: URL: https://github.com/apache/kafka/pull/8795#issuecomment-638481270 @jghoman This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (KAFKA-10096) Remove unnecessary String.format call in VersionConditionalTest.java

2020-06-03 Thread Can Cecen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Cecen updated KAFKA-10096: -- Description: n.b. This is a newbie ticket designed to be an introduction to contributing for the assi

[jira] [Updated] (KAFKA-10096) Remove unnecessary String.format call in VersionConditionalTest.java

2020-06-03 Thread Can Cecen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Cecen updated KAFKA-10096: -- Description: n.b. This is a newbie ticket designed to be an introduction to contributing for the assi

[jira] [Updated] (KAFKA-10096) Remove unnecessary String.format call in VersionConditionalTest.java

2020-06-03 Thread Can Cecen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Cecen updated KAFKA-10096: -- Description: n.b. This is a newbie ticket designed to be an introduction to contributing for the assi

[jira] [Updated] (KAFKA-10096) Remove unnecessary String.format call in VersionConditionalTest.java

2020-06-03 Thread Can Cecen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Cecen updated KAFKA-10096: -- Description: n.b. This is a newbie ticket designed to be an introduction to contributing for the assi

[jira] [Updated] (KAFKA-10096) Remove unnecessary String.format call in VersionConditionalTest.java

2020-06-03 Thread Can Cecen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Cecen updated KAFKA-10096: -- Description: n.b. This is a newbie ticket designed to be an introduction to contributing for the assi

[GitHub] [kafka] cancecen opened a new pull request #8796: KAFKA-10096: Remove unnecessary String.format call.

2020-06-03 Thread GitBox
cancecen opened a new pull request #8796: URL: https://github.com/apache/kafka/pull/8796 https://issues.apache.org/jira/browse/KAFKA-10096 Since format is not provided in VersionConditionalTest::assertEquals, we can just pass the string into StringBuilder::append. This is a ne

[GitHub] [kafka] mtillu opened a new pull request #8797: Fixing KAFKA-10094

2020-06-03 Thread GitBox
mtillu opened a new pull request #8797: URL: https://github.com/apache/kafka/pull/8797 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing st

[GitHub] [kafka] mtillu commented on pull request #8797: Fixing KAFKA-10094

2020-06-03 Thread GitBox
mtillu commented on pull request #8797: URL: https://github.com/apache/kafka/pull/8797#issuecomment-638485010 PTAL @jghoman This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Resolved] (KAFKA-10096) Remove unnecessary String.format call in VersionConditionalTest.java

2020-06-03 Thread Can Cecen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Cecen resolved KAFKA-10096. --- Resolution: Won't Fix Realized that String.format is used to create line separators. > Remove unne

[GitHub] [kafka] cancecen closed pull request #8796: KAFKA-10096: Remove unnecessary String.format call.

2020-06-03 Thread GitBox
cancecen closed pull request #8796: URL: https://github.com/apache/kafka/pull/8796 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] hachikuji commented on pull request #8784: KAFKA-9788: Use distinct names for transaction and group load time se…

2020-06-03 Thread GitBox
hachikuji commented on pull request #8784: URL: https://github.com/apache/kafka/pull/8784#issuecomment-638492720 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Resolved] (KAFKA-9161) Close gaps in Streams configs documentation

2020-06-03 Thread Jakob Homan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan resolved KAFKA-9161. Resolution: Fixed > Close gaps in Streams configs documentation > -

[GitHub] [kafka] guozhangwang commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-03 Thread GitBox
guozhangwang commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434892254 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -493,28 +549,45 @@ public void closeAndRecycleS

[GitHub] [kafka] vvcephei commented on a change in pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-03 Thread GitBox
vvcephei commented on a change in pull request #8775: URL: https://github.com/apache/kafka/pull/8775#discussion_r434892857 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/ClientStateTest.java ## @@ -300,20 +302,71 @@ public void sho

[GitHub] [kafka] vvcephei commented on pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-03 Thread GitBox
vvcephei commented on pull request #8775: URL: https://github.com/apache/kafka/pull/8775#issuecomment-638494568 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Created] (KAFKA-10097) Avoid getting null map for task checkpoint

2020-06-03 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10097: --- Summary: Avoid getting null map for task checkpoint Key: KAFKA-10097 URL: https://issues.apache.org/jira/browse/KAFKA-10097 Project: Kafka Issue Type: Improvem

[jira] [Updated] (KAFKA-10097) Avoid getting null map for task checkpoint

2020-06-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10097: Component/s: streams > Avoid getting null map for task checkpoint > --

[jira] [Created] (KAFKA-10098) Remove unnecessary escaping in regular expression in SaslAuthenticatorTest.java

2020-06-03 Thread Can Cecen (Jira)
Can Cecen created KAFKA-10098: - Summary: Remove unnecessary escaping in regular expression in SaslAuthenticatorTest.java Key: KAFKA-10098 URL: https://issues.apache.org/jira/browse/KAFKA-10098 Project: Ka

[jira] [Updated] (KAFKA-10098) Remove unnecessary escaping in regular expression in SaslAuthenticatorTest.java

2020-06-03 Thread Can Cecen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Cecen updated KAFKA-10098: -- Description: n.b. This is a newbie ticket designed to be an introduction to contributing for the assi

[GitHub] [kafka] cancecen opened a new pull request #8798: KAFKA-10098: Remove unnecessary escaping in regular expression.

2020-06-03 Thread GitBox
cancecen opened a new pull request #8798: URL: https://github.com/apache/kafka/pull/8798 '<' or '>' do not need to be escaped. This is a newbie PR to learn the contribution flow. Reviewer: @jghoman This is an a

[jira] [Assigned] (KAFKA-10098) Remove unnecessary escaping in regular expression in SaslAuthenticatorTest.java

2020-06-03 Thread Can Cecen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Cecen reassigned KAFKA-10098: - Assignee: Can Cecen > Remove unnecessary escaping in regular expression in > SaslAuthenticator

[GitHub] [kafka] mjsax commented on pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-03 Thread GitBox
mjsax commented on pull request #8771: URL: https://github.com/apache/kafka/pull/8771#issuecomment-638511478 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8759: KAFKA-10066: TestOutputTopic should pass record headers into deserializers

2020-06-03 Thread GitBox
mjsax commented on pull request #8759: URL: https://github.com/apache/kafka/pull/8759#issuecomment-638512007 Java 11: ``` kafka.api.TransactionsBounceTest.testWithGroupMetadata org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testReassignmentWithRandomSubscriptionsAn

[GitHub] [kafka] hachikuji commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-03 Thread GitBox
hachikuji commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-638511962 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   >