Re: [PHP-DEV] [PATCH] Add apache uptime to phpinfo() FR #31391

2005-01-07 Thread Joe Orton
On Thu, Jan 06, 2005 at 09:49:49PM +0100, Magnus MÃÃttà wrote: > Hi, > > This patch adds apache uptime to phpinfo() page for apache, > apache2filter and apache2handler SAPIs. > > Should I commit, throw it away, change something ? I don't think there's any need to duplicate more of mod_status in

Re: [PHP-DEV] Patch to PHP mail() function

2005-01-07 Thread Olivier Beyssac
On Tue, Dec 28, 2004, Olivier Beyssac wrote: > Please find attached a small patch to the PHP mail() function. I'm sorry but I would like to know if I did something wrong with this patch submission? Please let me know if I submitted it to a wrong address or in a wrong format. -- Olivier Beyssac

Re: [PHP-DEV] [PATCH] 3rd Resend: Add posix_access() FR #14924

2005-01-07 Thread Jani Taskinen
Just commit it? :) --Jani On Thu, 6 Jan 2005, Magnus Määttä wrote: Hello, This patch adds posix_access() to the posix extension. access(2) will report correct permission on systems using ACL for example. This is useful when running, for example, SELinux. I've updated it to include both open

[PHP-DEV] use of curly braces with string interpolation.

2005-01-07 Thread Jochem Maas
hi guys, I always use curly braces around vars placed in double quoted strings, I do this for 2 reasons: 1. I believe It helps the engine because the var delimitation is explicit, and this means the interpolation is (should be?) faster. 2. it looks nice (easier to read!) I have tried to test th

Re: [PHP-DEV] [PATCH] Add apache uptime to phpinfo() FR #31391

2005-01-07 Thread Lester Caine
Magnus MÃÃttà wrote: What's it useful for..? To see if a user really _did_ restart apache after doing changes to php.ini I guess.. That's what the report said. Can't come up with any other reason myself. =) This patch adds apache uptime to phpinfo() page for apache, apache2filter and apache2

Re: [PHP-DEV] [PATCH] Add apache uptime to phpinfo() FR #31391

2005-01-07 Thread Magnus Määttä
On Friday 07 January 2005 07.44, Jani Taskinen wrote: > What's it useful for..? To see if a user really _did_ restart apache after doing changes to php.ini I guess.. That's what the report said. Can't come up with any other reason myself. =) > On Thu, 6 Jan 2005, Magnus MÃÃttà wrote: > > H

[PHP-DEV] duplicate sapi inclusion

2005-01-07 Thread Mikael Fern
maybe this is not an important note, but i notice that in ext/standard/head.c, SAPI.h is included twice. the duplicate inclusion can be found for all branches and head. File: ext/standard/head.c #include "php.h" #include "ext/standard/php_standard.h" #include "SAPI.h" #include "php_main.h" #inclu

[PHP-DEV] [PATCH] Resend with modifications: inet_getaddrfam()

2005-01-07 Thread Nicolas Bérard Nault
Hi, This patch adds a function for getting the family of the address in $Address. If $Address is not of any family, false is returned. I, myself, need this function to verify that an ip provided by an user is a real ip. Then, to use this address with, in exemple, socket_create() and later bind it,