Re: [PATCH] zfs: fix compilation failure with clang due to alignment

Go ahead On 07.07.2015 19:17, Leif Lindholm wrote: > On Fri, Jul 03, 2015 at 10:05:47PM +0300, Andrei Borzenkov wrote: >> I do not claim I understand why clang complains, but this patch does >> fix it. >> >> fs/xfs.c:452:25: error: cast from 'struct grub_xfs_btree_node *' to >> 'grub_uint64_t

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

On 03.07.2015 21:05, Andrei Borzenkov wrote: > I do not claim I understand why clang complains, but this patch does > fix it. > > fs/xfs.c:452:25: error: cast from 'struct grub_xfs_btree_node *' to > 'grub_uint64_t *' (aka 'unsigned long long *') increases required > alignment from 1

Re: [PATCH v2 0/3] arm64: Add multiboot support (via fdt) for Xen boot

On 13.07.2015 10:53, fu@linaro.org wrote: > From: Fu Wei > > - This adds support for the Xen boot on ARM specification for arm64. > > - The implementation for Xen is following : > http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot > and xen/docs/misc/arm/d

Re: [PATCH v2 1/3] arm64: Add Xen boot support file

On 13.07.2015 10:53, fu@linaro.org wrote: > From: Fu Wei > > This patch adds Xen boot support file: > grub-core/loader/arm64/xen_boot.c > include/grub/arm64/xen_boot.h > > This patch also adds commands register code and hearder file into > grub-core/loader/arm64/linux.c > > - This adds su

Re: [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

On 14.07.2015 15:09, Fu Wei wrote: > Hi Andrei, > > Great thanks for your review. > > So Are you suggesting this: > (1) in util/grub.d/20_linux_xen.in, we only use xen_hypervisor/xen_module. > (2) in xen_boot.c, we only register command xen_hypervisor/xen_module. > (3) in grub-core/loader/i386/xe

Re: CentOS 7 - gfxterm does not work during Kernel boot

On 02.07.2015 16:55, Abdelghani Ouchabane wrote: > Hallo, > my system is installed with CentOS 7 (7.1.1503), and it has: > > 1. grub2-2.02-0.16.el7.centos.x86_64 > 2. kernel-3.10.0-229.1.2.el7.x86_64 > 3. xorg-x11-drv-catalyst-14.4-1.eldel7.2.3r.1.x86_64 > > I want to configure grub2 to use GRU

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

On 30.06.2015 20:28, Andrei Borzenkov wrote: > В Tue, 30 Jun 2015 15:05:46 -0300 > Paulo Flabiano Smorigo пишет: > >> On 2015-06-30 11:33, Vladimir 'phcoder' Serbinenko wrote: >>> What about clang? >> >> Not good news about clang support. This is what the toolchain team said >> about it: >> >> T

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

On 04.07.2015 08:46, Andrei Borzenkov wrote: > В Tue, 30 Jun 2015 21:34:10 +0200 > "Vladimir 'phcoder' Serbinenko" пишет: > >> I think those flags disable only runtime libraries, not the code generation > > Yes, you are right. Clang seems to be built for the whole family, i.e. > PowerPC, which s

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

> It is possible to compile using "--target=powerpc -Wl,-EB" - this works > on all three ppc, ppc64 and ppc64le, but this means hardcoding GNU ld > dependency. > Thanks for this info. See attached patch > So I'd rather try to produce patch for proper support of > -mbig-endian/-mlittle-endian (inc

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

On 15.07.2015 18:52, Leif Lindholm wrote: > On Wed, Jul 15, 2015 at 05:47:50PM +0200, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> Go ahead > > The below was more of an RFC than something committable - are you OK > with me splitting the types.h changes out as

Re: [PATCH 3/5] i386/relocator: Remove unused avoid_efi_bootservices argument

On 30.05.2015 07:25, Andrei Borzenkov wrote: > В Fri, 29 May 2015 22:58:43 +0200 > Daniel Kiper пишет: > >> Another questions is why grub_relocator_alloc_chunk_addr() does not consult >> EFI >> memory map if grub_relocator_alloc_chunk_align() does. Should not we fix it? > > My best guess is tha

Re: [RFD] diskfilter stale RAID member detection vs. lazy scanning

On 28.06.2015 20:06, Andrei Borzenkov wrote: > I was looking at implementing detection of outdated RAID members. > Unfortunately it appears to be fundamentally incompatible with lazy > scanning as implemented currently by GRUB. We simply cannot stop > scanning for other copies of metadata once "eno

Re: [RFD] diskfilter stale RAID member detection vs. lazy scanning

On 15.07.2015 20:05, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 28.06.2015 20:06, Andrei Borzenkov wrote: >> I was looking at implementing detection of outdated RAID members. >> Unfortunately it appears to be fundamentally incompatible with lazy >> scanning a

Re: [RFD] diskfilter stale RAID member detection vs. lazy scanning

On 16.07.2015 05:42, Andrei Borzenkov wrote: > В Wed, 15 Jul 2015 20:05:56 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> On 28.06.2015 20:06, Andrei Borzenkov wrote: >>> I was looking at implementing detection of outdated RAID members. >>> U

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

On 16.07.2015 05:46, Andrei Borzenkov wrote: > В Wed, 15 Jul 2015 17:49:30 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> >> On 03.07.2015 21:05, Andrei Borzenkov wrote: >>> I do not claim I understand why clang complains, but this patch does &g

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

On 15.07.2015 18:52, Leif Lindholm wrote: > On Wed, Jul 15, 2015 at 05:47:50PM +0200, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> Go ahead > > The below was more of an RFC than something committable - are you OK > with me splitting the types.h changes out as

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

On 15.07.2015 18:52, Leif Lindholm wrote: > On Wed, Jul 15, 2015 at 05:47:50PM +0200, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> Go ahead > > The below was more of an RFC than something committable - are you OK > with me splitting the types.h changes out as

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

On 16.07.2015 20:55, Andrei Borzenkov wrote: > В Wed, 15 Jul 2015 19:42:39 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> >>> It is possible to compile using "--target=powerpc -Wl,-EB" - this works >>> on all three ppc

Re: On MIPS clang default to different arch than GNU

On 19.07.2015 09:33, Andrei Borzenkov wrote: > clang -cc1 version 3.8.0 based upon LLVM 3.8.0svn default target > x86_64-unknown-linux-gnu > ignoring nonexistent directory "/include" > #include "..." search starts here: > #include <...> search starts here: > /usr/local/include > /home/bor/build/

Re: GRUB release schedule?

On 20.07.2015 21:25, Vladimir 'phcoder' Serbinenko wrote: > I'll do next beta tomorrow and will assess current open bugs to see how > far we're from release > Fixing tests takes longer than expected. I'll continue tomorrow. > Le 20 juil. 2015 20:23, "Peter Jones" > a écr

Re: ELF check: GRUB_ERR_BAD_FILE_TYPE vs. GRUB_ERR_BAD_OS

On 24.07.2015 20:50, Andrei Borzenkov wrote: > There are two places using GRUB_ERR_BAD_FILE_TYPE and other are using > GRUB_ERR_BAD_OS when EFL class check fails. I am not sure about exact > semantics of either but probably they should be the same? > BAD_FILE_TYPE is only for errors like EISDIR an

Re: cryptodisk: teach grub_cryptodisk_insert() about partitions (bug #45889)

On 06.09.2015 21:10, TJ wrote: > https://savannah.gnu.org/bugs/index.php?45889 > > Boot disk with 3 LUKS/dm-crypt GPT partitions > > (hd0,gpt3) (hd0,gpt4) (hd0,gpt5) > > grub is in (hd0,gpt3). The others have a LVM VG each. > > Using GRUB_ENABLE_CRYPTODISK=y I deliberately fail the first pass-p

Re: [PATCH] Remove unconditional disablement of the watchdog

On 01.09.2015 07:51, Arthur Mesh wrote: > Starting with d9a0c9413e81d3c0affc6383693bdd28dc863a5c, GRUB unconditionally > disables watchdog on EFI platforms. This opens up a window (starting at GRUB's > grub_efi_init(), until OS re-enables it) when EFI system operates w/o > watchdog. > If an EFI sy

Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI.

On 23.08.2015 23:50, Mark H Weaver wrote: > Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile > code for the O32 ABI when targetting MIPS, since the MIPS assembly code > in GRUB assumes this. Could you be more precise where we assume this? Why not fix the assembly instead? > Th

GNU GRUB maintenance

Hello, all. I'm sorry for not being available to do enough maintenance for GRUB in last time but I was overbooked. Yet there is a good news. At Google there is a 20% project and GRUB has been approved as 20% project for me. The goal is to have 2.02 released before the end of this year. Other than t

Re: GNU GRUB maintenance

On 07.10.2015 23:36, SevenBits wrote: > > > On Wednesday, October 7, 2015, Vladimir 'φ-coder/phcoder' Serbinenko > mailto:phco...@gmail.com>> wrote: > > Hello, all. I'm sorry for not being available to do enough maintenance > for GRUB in last

Re: [PATCH] sparc64: boot performance improvements

On 06.10.2015 19:39, Eric Snowberg wrote: > Keep of devices open. This can save 6 - 7 seconds per open call and > can decrease boot times from over 10 minutes to 29 seconds on > larger SPARC systems. The open/close calls with some vendors' > SAS controllers cause the entire card to be reinitializ

Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI.

On 13.09.2015 08:32, Andrei Borzenkov wrote: > 08.09.2015 20:11, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >> On 23.08.2015 23:50, Mark H Weaver wrote: >>> Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile >>> code for the O32 ABI

Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI.

On 09.10.2015 23:14, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 13.09.2015 08:32, Andrei Borzenkov wrote: >> 08.09.2015 20:11, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >>> On 23.08.2015 23:50, Mark H Weaver wrote: >>>> Include -ma

Re: GNU GRUB maintenance

On 08.10.2015 21:34, Konrad Rzeszutek Wilk wrote: > On October 8, 2015 10:52:25 AM EDT, Andrei Borzenkov > wrote: >> On Thu, Oct 8, 2015 at 12:14 AM, Vladimir 'φ-coder/phcoder' Serbinenko >> wrote: >>> Hello, all. I'm sorry for not being available t

Re: GNU GRUB maintenance

On 08.10.2015 16:52, Andrei Borzenkov wrote: > On Thu, Oct 8, 2015 at 12:14 AM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> Hello, all. I'm sorry for not being available to do enough maintenance >> for GRUB in last time but I was overbooked. Yet there is a g

Re: Add check when store disk cache

On 19.09.2015 09:00, Andrei Borzenkov wrote: > 18.09.2015 12:07, Arch Stack пишет: >> I want to use the part of the filesystem codes in GRUB to read different >> filesystems on Windows. I have almost completed it and I will release >> it in >> a few days. >> But it crash sometimes because of the wr

Re: Keyboard not working with QEMU and coreboot and GRUB payload

On 18.08.2015 14:11, Andrei Borzenkov wrote: > On Tue, Aug 18, 2015 at 12:41 AM, Paul Menzel > wrote: >> Dear GRUB folks, >> >> >> just a note that using QEMU with coreboot and GRUB payload, I am unable >> to enter anything. >> >> Using libpayload based payloads, the keyboard works, so I think it’

Re: [PATCH] sparc64: boot performance improvements

On 11.10.2015 18:49, Eric Snowberg wrote: > >> On Oct 10, 2015, at 1:35 AM, Vladimir 'phcoder' Serbinenko >> wrote: >> >> >> Le 10 oct. 2015 3:31 AM, "Eric Snowberg" a écrit : >>> >>> On Oct 9, 2015, at 12:50 AM, Andrei Borzenkov wrote: On Thu, Oct 8, 2015 at 2:20 AM, Eric Snowb

Re: [PATCH] Make CTRL and ALT keys work as expected on EFI systems (version 5).

On 25.02.2014 23:12, Peter Jones wrote: > This is version 4. > > Changes from version 1: > - handles SHIFT as a modifier > - handles F11 and F12 keys > - uses the handle provided by the system table to find our _EX protocol. > > Changes from version 2: > - eliminate duplicate keycode translation.

Re: [PATCH v2] Suport for bi-endianess in elf file

On 23.07.2015 16:10, Paulo Flabiano Smorigo wrote: > Updated version with the suggestions from Andrei Borzenkov. > > * grub-core/kern/elf.c: check and switch endianess with grub_{be,le}_to > cpu functions. > * grub-core/kern/elfXX.c: Likewise. Applied after fixing following problems: * Since you a

Re: [PATCH 3/3] ieee1275: ofdisk - don't continue to query block-size after we have it

On 26.10.2015 22:43, Eric Snowberg wrote: > Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue > to query block-size if disk doesn't have it.” Disks that returned 0 to the > block-size query, still get queried every time. > > Fix logic in grub_ofdisk_get_block_size so the b

Re: [PATCH 1/3] ieee1275: ofdisk dangling pointer

On 26.10.2015 22:43, Eric Snowberg wrote: > Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - > "Don't continue to query block-size if disk doesn't have it.” > a dangling pointer was introduced. > > Fix dangling pointer issue in grub_ofdisk_open where devpath is freed > and then used again

Re: [PATCH 2/3] ieee1275: ofdisk memory leak

On 26.10.2015 22:43, Eric Snowberg wrote: > Fix memory leak added within commit: > 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue to > query block-size if disk doesn't have it.” > Committed, thanks > Signed-off-by: Eric Snowberg > --- > grub-core/disk/ieee1275/ofdisk.c |6 +-

Re: [PATCH v3 1/4] arm64: Add and export some accessor functions for xen boot

On 23.07.2015 07:16, fu@linaro.org wrote: > From: Fu Wei > > Add accessor functions of "loaded" flag in > grub-core/loader/arm64/linux.c. > > Export accessor functions of "loaded" flag and > grub_linux_get_fdt function in include/grub/arm64/linux.h. > > Purpose: Reuse the existing code of d

Re: [PATCH v3 2/4] arm64: Add xen_boot module file

Committed without the xen_module command. Its argument parsing was non-trivial and I don't quite get what its intent is. Can you resubmit? On 23.07.2015 07:16, fu@linaro.org wrote: > From: Fu Wei > > grub-core/loader/arm64/xen_boot.c > > - This adds support for the Xen boot on ARM specific

Re: [edk2] [grub PATCH] efinet: disable MNP background polling

On 14.10.2015 17:39, Seth Goldberg wrote: > > >> On Oct 14, 2015, at 4:08 AM, Daniel Kiper wrote: >> >>> On Wed, Oct 14, 2015 at 05:19:32AM +, Ye, Ting wrote: >>> Hi all, >>> >>> If I understand the issue correctly, I don't quite agree that UEFI >>> spec is imprecise about SNP constraints de

Re: Be File System identified as bfs

> As you can see, it thinks /dev/sda6 a 'bfs' partition, causing script > 83haiku to fail. > 12 befs|befs_be) debug "$partition is a BeFS partition" ;; Looks like this is a simple one-line change. befs|befs_be is a name used by old driver which had to be removed signature.asc Description

Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64

> +if [ "x$machine" != xaarch64 ]; then > + multiboot_cmd="multiboot" > + module_linux_cmd="module" > + module_initrd_cmd="module --nounzip" > +else > + multiboot_cmd="xen_hypervisor" > + module_linux_cmd="xen_linux" > + module_initrd_cmd="xen_initrd" > +fi > + Please do not

Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64

On 30.10.2015 09:44, Fu Wei wrote: > Hi Vladimir, > > Great thanks for your suggestion! :-) > > On 29 October 2015 at 23:25, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >>> +if [ "x$machine" != xaarch64 ]; then >>> + mult

Re: Anonymous commit (empty Author and Committer)

On 30.10.2015 15:26, Andrei Borzenkov wrote: > See > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > > I was not even aware that this is possible. Is there anything on server > side that can prevent it? > > Would be good if commit were amended an

Re: Anonymous commit (empty Author and Committer)

On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 15:26, Andrei Borzenkov wrote: >> See >> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >> >> >> I was not even aware that th

Re: [PATCH] mkimage: zero fill alignment space

On 30.10.2015 16:49, Andrei Borzenkov wrote: > This did not cause real problem but is good for reproducible builds. I hit > it with recent bootinfoscript that displays embedded config; I was puzzled > by random garbage at the end. > > Also remove redundant zeroing code where we fill in the whole m

Re: Anonymous commit (empty Author and Committer)

On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 30.10.2015 15:26, Andrei Borzenkov wrote: >>> See >>> http://git.savannah.gnu.org/cgit/grub.git/comm

Re: [PATCH] ofdisk: allocate space for vscsi table

On 09.11.2015 02:33, Paulo Flabiano Smorigo wrote: > + /* 64 entries should be enough */ > + table_size = sizeof (grub_uint64_t) * 64; Can we do something better than assuming a particular upper limit? You don't even pass this limit to the function in any way. You basically get a buffer o

Re: [PATCH] Use UEFI Time Service to calibrate TSC

On 09.11.2015 09:03, Michael Chang wrote: > On Mon, Nov 09, 2015 at 10:29:55AM +0300, Andrei Borzenkov wrote: >> On Mon, Nov 9, 2015 at 10:07 AM, Michael Chang wrote: >>> This patch tries to detect PIT timer is broken and use UEFI Time Service >>> to calibrate TSC. >> >> Second try :) >> >> https:

Re: [PATCH] Use UEFI Time Service to calibrate TSC

On 09.11.2015 14:23, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 09.11.2015 09:03, Michael Chang wrote: >> On Mon, Nov 09, 2015 at 10:29:55AM +0300, Andrei Borzenkov wrote: >>> On Mon, Nov 9, 2015 at 10:07 AM, Michael Chang wrote: >>>> This patch tri

Re: [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files

On 09.11.2015 16:29, Daniel Kiper wrote: > On Wed, Nov 04, 2015 at 01:03:56PM +0100, Vladimir 'phcoder' Serbinenko wrote: >> Le 12 août 2015 11:04 AM, "Ian Campbell" a écrit : >>> >>> >>> (Having written the below I see too late that this is a grub patch not a >>> Xen one, a tag in the subject for

Re: [PATCH v2 2/6] relocator: Do not use memory region if its starta is smaller than size

On 21.07.2015 08:42, Andrei Borzenkov wrote: > On Mon, Jul 20, 2015 at 5:35 PM, Daniel Kiper wrote: >> malloc_in_range() should not use memory region if its starta is smaller >> than size. Otherwise target wraps around and points to region which is >> usually not a RAM, e.g.: >> >> loader/multiboo

Fwd: Re: [PATCH v2 6/6] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

Forwarded Message Subject:Re: [PATCH v2 6/6] multiboot2: Do not pass memory maps to image if EFI boot services are enabled Date: Mon, 9 Nov 2015 20:07:23 +0100 From: Vladimir 'phcoder' Serbinenko To: Daniel Kiper This one is good to go. But the main reason

Fwd: Re: [PATCH v2 6/6] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

Forwarded Message Subject:Re: [PATCH v2 6/6] multiboot2: Do not pass memory maps to image if EFI boot services are enabled Date: Mon, 9 Nov 2015 20:08:38 +0100 From: Vladimir 'phcoder' Serbinenko To: Daniel Kiper And you also need to adjust loader code to r

Re: [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator

On 20.07.2015 16:35, Daniel Kiper wrote: > Add grub_relocator64_efi relocator. It will be used on EFI 64-bit platforms > when multiboot2 compatible image requests MULTIBOOT_TAG_TYPE_EFI_BS. Relocator > will set lower parts of %rax and %rbx accordingly to multiboot2 specification. > On the other han

Re: [PATCH v2 4/6] multiboot2: Add tags used to pass ImageHandle to loaded image

On 09.11.2015 20:15, Vladimir 'phcoder' Serbinenko wrote: > Lgtm > > Le 20 juil. 2015 4:36 PM, "Daniel Kiper" > a écrit : > > Add tags used to pass ImageHandle to loaded image. It is used > by at least ExitBootServices() function. > > Signed-off-by: D

Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

On 20.07.2015 16:35, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper What is handling the actual relocation? Why doesn't this patch include support for ELF relocations? > --- > grub-core/loader/i386/multiboot_mbi.c |6 ++-- > grub-core/loader/multiboot.c | 12 +-- > grub-core

Re: [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files

On 09.11.2015 16:39, Daniel Kiper wrote: > On Mon, Nov 09, 2015 at 04:34:20PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> On 09.11.2015 16:29, Daniel Kiper wrote: >>> On Wed, Nov 04, 2015 at 01:03:56PM +0100, Vladimir 'phcoder' Serbinenko

Re: [PATCH] broken ESC navigation if authentication is used

On 11.06.2015 05:55, Andrei Borzenkov wrote: > В Wed, 10 Jun 2015 21:35:51 +0200 > "Vladimir 'phcoder' Serbinenko" пишет: > >> This patch may allow to escape to shell if menu was called from context >> without menu entries. This may happen inadvertently I.a. when using >> configfile. You need to

Re: [PATCH v4] ofdisk: add sas disks to the device list

On 11.11.2015 14:14, Paulo Flabiano Smorigo wrote: > + ptr = (grub_uint64_t *) (table + sizeof (grub_uint64_t) * i); > + grub_snprintf (bufptr, 32, "/disk@%" PRIxGRUB_UINT64_T, *ptr); Please declare table as being grub_uint64_t * and then just use table[i]. This code violates cast

Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64

On 10.11.2015 08:01, Andrei Borzenkov wrote: > Not really, although this is a good observation. Actually I think that > xen_initrd should indeed have behavior 1, because what it does is > provide initrd image to Linux kernel, and - although not often used - > initrd image may be constructed by conc

[PATCH GRUB] Allow initrd concatenation on ARM64

While on it also change "xen_linux" to "xen_kernel" to be vendor-neutral Could someone test please? I only compile-tested it diff --git a/docs/grub.texi b/docs/grub.texi index 1df3db2..112b42b 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -3859,7 +3859,7 @@ you forget a command, you can run t

Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

On 12.11.2015 14:15, Daniel Kiper wrote: > On Tue, Nov 10, 2015 at 04:23:46PM +0100, Vladimir 'phcoder' Serbinenko wrote: >> Le 10 nov. 2015 3:52 PM, "Daniel Kiper" a écrit : >>> On Mon, Nov 09, 2015 at 09:08:35PM +0100, Vladimir 'φ-coder/phcoder

Uniform commands for booting xen

Hello, all. I'd like to have set of commands that would boot xen on all platforms. I thought of following set: xen_hypervisor FILE XEN_OPTIONS xen_kernel FILE KERNEL_OPTIONS xen_initrd INITRD INITRD INITRD all initrds are concatenated. xen_xsm ??? On arm64 it would use the arm64 xen FDT protocol

Re: [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator

On 10.11.2015 15:38, Daniel Kiper wrote: >>> - if (entry_specified) >>> > > + if (keep_bs && efi_entry_specified) >>> > > +grub_multiboot_payload_eip = efi_entry; >>> > > + else if (entry_specified) >>> > > grub_multiboot_payload_eip = entry; >>> > > >> > This seems redundant. > What is

Re: [Xen-devel] [PATCH GRUB] Allow initrd concatenation on ARM64

On 12.11.2015 14:27, Ian Campbell wrote: > On Thu, 2015-11-12 at 14:08 +0100, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> While on it also change "xen_linux" to "xen_kernel" to be vendor-neutral >> Could someone test please? I only compile-test

Re: grub causing NVDIMMs to be treated as normal memory

What about this patch for the passing of pram? diff --git a/grub-core/mmap/efi/mmap.c b/grub-core/mmap/efi/mmap.c index 900a4d6..0c03c5d 100644 --- a/grub-core/mmap/efi/mmap.c +++ b/grub-core/mmap/efi/mmap.c @@ -118,6 +118,12 @@ grub_efi_mmap_iterate (grub_memory_hook_t hook, void *hook_data,

Re: flex version

Andrei, could you please commit this patch? On 15.11.2015 07:26, Andrei Borzenkov wrote: > 14.11.2015 19:22, Peter Cheung пишет: >> hi >> my flex in mac is installed using macports. >> >> $flex --version >> flex 2.5.35 Apple(flex-31) >> >> And the line in configure fail >> >> version=`$LEX --ve

Re: grub causing NVDIMMs to be treated as normal memory

New version attached >> GRUB_MEMORY_COREBOOT_TABLES = 16, >> GRUB_MEMORY_CODE = 20, >> /* This one is special: it's used internally but is never reported > Note (b): The internal GRUB_MEMORY_CODE (20) value is > leaking through to the E820 table. > > That appears to

Re: Grub get and set efi variables

On 14.11.2015 05:03, Andrei Borzenkov wrote: > 13.11.2015 22:42, Ignat Korchagin пишет: > +static enum efi_var_type > +parse_efi_var_type (const char *type) > +{ > + if (!grub_strncmp (type, "string", sizeof("string"))) > +return EFI_VAR_STRING; > + I thi

Re: [PATCH 1/3] mkstandalone: add argument --fixed-time to override mtime of files

On 04.12.2015 17:10, Alexander Couzens wrote: > mkstandalone adds several files to an archive. Doing this it uses the > mtime to give these files a timestamp. > --fixed-time overrides these timestamps with a given. > > Replacing all timestamps with a specific one is required > to get reproducible

Re: [PATCH 3/3] Makefile: use FIXED_TIMESTAMP for mkstandalone if set

On 04.12.2015 17:10, Alexander Couzens wrote: > mkstandalone sets timestamps for files which can be overriden by a > fixed_timestamp. > This makes it possible to build reproducible builds for coreboot. > > To build a reproducible build of grub for coreboot do: > make default_payload.elf FIXED_TIM

Re: [PATCH v3 1/3] mkstandalone: add argument --fixed-time to override mtime of files

> + fixed_time = -1; -1 is actually perfectly valid. Can we have a second boolean to avoid special-casing -1? signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/g

Re: [PATCH v3 3/3] Makefile/coreboot use SOURCE_DATE_EPOCH as time source if set

Looks good On 04.12.2015 19:32, Alexander Couzens wrote: > mkstandalone sets timestamps for files which can be overriden by a > fixed_timestamp. > This makes it possible to build reproducible builds for coreboot. > > To build a reproducible build of grub for coreboot do: > export SOURCE_DATE_EPOC

Re: [PATCH v3 2/3] mkrescue: add argument --fixed-time to get reproducible uuids

On 04.12.2015 19:32, Alexander Couzens wrote: > The uuid generation is based on the time. > --- > util/grub-mkrescue.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > This breaks uniqueness assumptions for UUID and we use UUID to find the right disk, as it's not possibl

Re: Each grub-mkrescue run leaves a file in /tmp/

On 28.12.2015 04:40, Andrei Borzenkov wrote: > 27.12.2015 23:48, Thomas Schmitt пишет: >> Hi, >> >> when running grub-mkrescue from Debian Sid, i get a >> growing collection of files in /tmp. One per run. >> >> Names are like: >> /tmp/grub.00529W >> >> Content is always the same: >> insmod part

Re: grub causing NVDIMMs to be treated as normal memory

On 28.11.2015 07:41, Elliott, Robert (Persistent Memory) wrote: > If you can define a standard meaning for 16 and 20, that'd be more > useful than marking them as OEM defined. There will always be a mix > of software that interprets it as unusable vs. follows this new > advice. 16 would be "RAM ho

Re: [PATCH] normal: fix get_logical_num_lines

On 28.12.2015 05:09, Michael Chang wrote: > On Thu, Dec 24, 2015 at 02:48:34PM +0300, Andrei Borzenkov wrote: >> On Wed, Dec 23, 2015 at 7:45 AM, Michael Chang wrote: >>> In menu editing mode, grub2 shows bogus line if the character being >>> edited is at last column of entry. This patch fixes the

Re: [PATCH] 30_os-prober: derive --class from os-prober generated label

Go ahead On 26.12.2015 08:09, Andrey Borzenkov wrote: > Currently only Windows gets distinguished icons, everything else is displayed > using the same generic one. Add additional --class based on os-prober returned > label, which usually is expected to match primary distribution name. > > Also use

Re: [PATCH] arm64: build with -mcmodel=large

On 25.12.2015 19:18, Leif Lindholm wrote: > On Thu, Dec 24, 2015 at 04:20:29AM +, Colin Watson wrote: >> On Thu, Dec 24, 2015 at 04:14:20AM +, Colin Watson wrote: >>> This fixes a build failure with very current GCC versions, such as the one >>> in Ubuntu xenial. Leif (or anyone with suita

Re: [PATCH] arm64: build with -mcmodel=large

On 25.12.2015 19:18, Leif Lindholm wrote: > On Thu, Dec 24, 2015 at 04:20:29AM +, Colin Watson wrote: >> On Thu, Dec 24, 2015 at 04:14:20AM +, Colin Watson wrote: >>> This fixes a build failure with very current GCC versions, such as the one >>> in Ubuntu xenial. Leif (or anyone with suita

Re: util/bin2h.c?

On 01.01.2016 09:01, Andrei Borzenkov wrote: > Do still need it? It is not used since 2 years. > Feel free to remove it > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > signature.asc Descript

Re: enable_progress_indicator

On 06.01.2016 12:27, Andrei Borzenkov wrote: > Do we really need yet another magic variable? Tests already set > "grubshell", and in normal case why would one load progress but then > disable it? > > Why progress gets loaded in the first place? Can we somehow omit it? > emu loads all the modules.

ARM*-EFI timers

Hello, all. In my automated tests I found out that on ARM64-EFI sleep 10 actually sleeps for 100s. The culprit is that EFI doesn't call our timer every 1ms but every 10ms. I propose time1.diff to correct: request EFI to call us every 10ms and increment timer variable by 10. For arm64 I propose to u

Re: ARM*-EFI timers

On 07.01.2016 19:59, Andrei Borzenkov wrote: > 07.01.2016 21:08, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >> Hello, all. In my automated tests I found out that on ARM64-EFI sleep 10 >> actually sleeps for 100s. The culprit is that EFI doesn't call our timer

Re: [Xen-devel] Uniform commands for booting xen

On 13.11.2015 10:50, Ian Campbell wrote: > On Fri, 2015-11-13 at 12:04 +0300, Andrei Borzenkov wrote: >>> How do you express modules other than kernel+initrd in that >>> scheme, without grub needing to be aware of any new addition we >>> may find necessary going forward? >>> >> >> Are modules used

Re: [Xen-devel] Uniform commands for booting xen

On 11.01.2016 15:32, Jan Beulich wrote: On 11.01.16 at 15:06, wrote: >> On 13.11.2015 10:50, Ian Campbell wrote: >>> On Fri, 2015-11-13 at 12:04 +0300, Andrei Borzenkov wrote: > How do you express modules other than kernel+initrd in that > scheme, without grub needing to be aware of a

Re: [Xen-devel] Uniform commands for booting xen

On 18.01.2016 11:28, Ian Campbell wrote: > On Mon, 2016-01-11 at 15:06 +0100, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> On 13.11.2015 10:50, Ian Campbell wrote: >>> On Fri, 2015-11-13 at 12:04 +0300, Andrei Borzenkov wrote: >>>>> How do you ex

Re: test command (in-)compatibility

On 08.12.2015 17:36, Andrei Borzenkov wrote: > `test' in GRUB implicitly assumes `and' operation between consecutive > terms and does not enforce proper syntax like UNIX (bash) `test' does. Both > > test x y z > test x = y z = w > > result in error in Linux and are silently accepted by GRUB with

Re: [Xen-devel] [BUG] XEN domU crash when PV grub chainloads 32-bit domU grub

On 22.09.2015 10:53, Ian Campbell wrote: > Hi Vladimir & grub-devel, > > Do you have any thoughts on this issue with i386 pv-grub2? > Is it still an issue? If so I'll try to replicate it. From stack dump I see that it has jumped to NULL. GRUB has no threads so it's not a race condition with itsel

Re: PV-Grub2 works here but doesnt work their...

On 10.09.2015 20:46, Shaun Reitan wrote: > I posted this to the Xen Mailing Lists too but figured i should post > here as well. > > We are experiencing a odd issue after we built grub2 support. The image > we built works fine on some hosts and then just hangs on others. > > I built grub2 as f

Re: [PATCH V2] net: fix ipv6 routing

Were Andrey's comments ever adressed? Other than his comments the patch looks good. On 20.09.2015 11:50, Andrei Borzenkov wrote: > 28.08.2015 18:24, Josef Bacik пишет: >> ipv6 routing in grub2 is broken, we cannot talk to anything outside >> our local >> network or anything that doesn't route in ou

Re: [Xen-devel] [BUG] XEN domU crash when PV grub chainloads 32-bit domU grub

On 22.01.2016 14:01, Andrew Cooper wrote: > On 22/01/16 12:56, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 22.09.2015 10:53, Ian Campbell wrote: >>> Hi Vladimir & grub-devel, >>> >>> Do you have any thoughts on this issue with i386 pv-gru

Re: [PATCH] arm64: build with -mcmodel=large

On 22.01.2016 03:14, Colin Watson wrote: > On Fri, Dec 25, 2015 at 06:18:55PM +, Leif Lindholm wrote: >> So, it seems this toolchain generates the HI21/LO12 relocation combo: >> - R_AARCH64_ADR_PREL_PG_HI21/R_AARCH64_ADR_PREL_PG_HI21_NC >> - R_AARCH64_LDST16_ABS_LO12_NC >> - R_AARCH64_LDST32_AB

Re: [PATCH] [RFC] Add exitcode support

On 18.08.2015 21:17, Ben Hildred wrote: > Let's assume for a minute that I have compiled grub as a multiboot image > and have called it from another bootloader, say iPXE.Now iPXE assumes > that any false return is an error. What happens when grub returns with > exit next, does iPXE get a true or fa

Re: [PATCH v2 3/6] xen: factor out allocation of page tables into separate function

On 11.02.2016 13:53, Juergen Gross wrote: > On 11/02/16 13:27, Daniel Kiper wrote: >> On Thu, Feb 11, 2016 at 08:53:23AM +0100, Juergen Gross wrote: >>> Do the allocation of page tables in a separate function. This will >>> allow to do the allocation at different times of the boot preparations >>>

Re: [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

On 11.02.2016 15:13, Juergen Gross wrote: > On 11/02/16 13:33, Daniel Kiper wrote: >> On Thu, Feb 11, 2016 at 08:53:24AM +0100, Juergen Gross wrote: >>> Modern pvops linux kernels support an initrd not covered by the initial >>> mapping. This capability is flagged by an elf-note. >>> >>> In case th

Re: [PATCH] efidisk: prevent errors from diskfilter scan of removable drives

On 05.02.2016 17:56, Andrei Borzenkov wrote: > Map EFI_NO_MEDIA to GRUB_ERR_OUT_OF_RANGE that is ignored by diskfilter. This > actually matches pretty close (we obviously attempt to read outside of media) > and avoids adding more error codes. > > This affects only internally initiated scans. If re

  1   2   3   4   5   6   7   8   9   10   >