[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
ling issues and ensure correct video duration. Signed-off-by: Jack Lau --- doc/examples/transcoding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcoding.c b/doc/examples/transcoding.c index 013f89fc7d..847bdb7e1a 100644 --- a/doc/examples/transcod

[FFmpeg-devel] [PATCHv3] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
--- Begin Message --- From bfd5500a5448ad468d32994816e8a55c0d4a2428 Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Tue, 4 Feb 2025 21:39:20 +0800 Subject: [PATCH] examples/transcoding: Fix time_base handling X-Unsent: 1 To: ffmpeg-devel@ffmpeg.org The `dec_ctx->time_base` was incorrectly defa

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
fix-time-base-handling.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubs

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
> > AVCodecContext.time_base is not used for decoding. Thank you for your reply. I understand that time_base is not used during decoding, but the transcoding code calls av_packet_rescale_ts twice, once before decoding and once after encoding, as shown below: 540 if (filter_ctx[stream_

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
> > AVCodecContext.time_base is not used for decoding. Thank you for your reply. I understand that time_base is not used during decoding, but the transcoding code calls av_packet_rescale_ts twice, once before decoding and once after encoding, as shown below: 540 if (filter_ctx[stream_

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
sues and ensure correct video duration. Signed-off-by: Jack Lau --- doc/examples/transcoding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcoding.c b/doc/examples/transcoding.c index 013f89fc7d..847bdb7e1a 100644 --- a/doc/examples/transcoding.c +++

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
The `dec_ctx->time_base` was incorrectly default set to 0/60, while `enc_ctx->time_base` was derived from `dec_ctx->framerate`. This mismatch could cause incorrect video duration in the output. This patch aligns `enc_ctx->time_base` with `dec_ctx->time_base` to prevent rescaling issues and ensu

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
tb: 60 output pkt in_tb: 30 out_tb: 15360 so i get one 20s duration and 15fps video(audio duration is normal because the input's audio sample ratio is 44100) So i think the problem is that the enc_ctx->time_base shouldn't set to av_inv_q(dec_ctx->frame

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-05 Thread Jack Lau
. Could any one give me some advice please so that i can fix it? On Wed, Feb 5, 2025 at 11:25 AM Jack Lau wrote: > To be clear, i want to give an example, i use a 10s duration, 30fps video. > The ifmt_ctx->streams[stream_index]->time_base is same as > ofmt_ctx->streams[stream

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
rtant patches. Best wishes Jack > On Feb 10, 2025, at 08:54, Soft Works > wrote: > > > >> -Original Message- >> From: ffmpeg-devel > <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of >> Jack Lau via ffmpeg-devel >> Sent: Monday,

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
> On Feb 10, 2025, at 11:08, Marth64 wrote: > > I don't think its fair to shoot this down, its a simple but valid tidy up > work. > I find typos and such when browsing code distracting and readability > important down the road. > Not everyone's first language is English and grammar correction

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
> On Feb 10, 2025, at 09:36, Soft Works > wrote: > > > >> -Original Message- >> From: ffmpeg-devel > <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of >> Jack Lau >> Sent: Monday, February 10, 2025 2:13 AM >> To: FFmp

Re: [FFmpeg-devel] Captions SCC

2025-02-06 Thread Jack Lau
> I have been absent from the list for a few years, so I would appreciate it > if someone could catch me up a bit. I am needing to extract and embed scc > files with 608 captions. I am pleased to see that transcoding without > frame rate changes now preserves 608 intact, and there appear to be

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Jack Lau
> > Hi Jack, > > "paying attention next time"? That's not the right answer. > > Please make sure that there won't be a next time. > > The big evil with LLVMs is not the fact they are making mistakes but the > extreme level of confidence at which they are presenting these mistakes - > like n

Re: [FFmpeg-devel] Captions SCC

2025-02-06 Thread Jack Lau
> > > Hi Zack, > > that message from "Jack" had confused me for a moment, but on re-reading it > appears to be an AI response. > The content is total nonsense. There is no "SCC" encoder in ffmpeg, and if > there was one, it wouldn't help much because the CC data needs to get into > the video

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Jack Lau
Hi softworkz, Thank you very much for your patient reply and kind suggestions. I am new to the FFmpeg devel mailing list, and English is not my native language, so there is still a lot for me to learn. May I ask a question? How long does it usually take for a patch to be reviewed? A few days a

[FFmpeg-devel] avoption: make the avoption like seekable more general

2025-02-11 Thread Jack Lau
Hi everyone, I’m trying to solve this issue https://trac.ffmpeg.org/ticket/11394. This ticket shows that we need use `-seekable` and `-http_seekable` to control the range header if send. Because these options belong to different file(hls.c and http.c) So I try to modify the http_seekable to se

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau
> On Mar 2, 2025, at 15:47, Jack Lau via ffmpeg-devel > wrote: > > fix ticket: 10786 > parse the SPS from extradata and get profile_compatibility, tier, constraints > which was been hard code before. > > HEVC CODECS Attribute reference to: ISO/IEC14496-15 &

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau
> On Mar 3, 2025, at 09:08, Steven Liu wrote: > > Jack Lau via ffmpeg-devel <mailto:ffmpeg-devel@ffmpeg.org>> 于2025年3月2日周日 21:31写道: >> >> fix ticket: 10786 >> parse the SPS from extradata and get profile_compatibility, tier, >> constraints which was

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: calculate bitrate for segments with duration < 0.5

2025-03-23 Thread Jack Lau
> On Mar 24, 2025, at 08:11, Steven Liu wrote: > > Jack Lau via ffmpeg-devel <mailto:ffmpeg-devel@ffmpeg.org>> 于2025年3月24日周一 07:13写道: >> >> The previous code sets the bitrate to be calculated only when duration>0.5, >> which is obviously not general e

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: add hevc codec attributes parse

2025-03-27 Thread Jack Lau
> On Mar 12, 2025, at 15:06, Jack Lau via ffmpeg-devel > wrote: > > fix ticket: 11316 > add set_hevc_codec_str function refer to hlsenc.c but do some necessary > changes > Signed-off-by: Jack Lau > --- > libavformat/dashenc.c | 81 +

[FFmpeg-devel] WHIP Feature latest patch Preparation Notes

2025-05-16 Thread Jack Lau
Hi everyone, I’m excited to be a GSoC student this year, working on supporting the WHIP feature in FFmpeg with my mentors Steven Liu and Zhao Jun. Two years ago, my mentor Steven Liu sent a whip patch(https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230529115039.17409-1...@chinaffmpeg.org/) a

Re: [FFmpeg-devel] [PATCH] avformat/whip: mark as experimental

2025-06-20 Thread Jack Lau
> On Jun 10, 2025, at 17:26, Jack Lau via ffmpeg-devel > wrote: > > > From: Jack Lau > Subject: [PATCH] avformat/whip: mark as experimental > Date: June 10, 2025 at 17:26:13 GMT+8 > To: ffmpeg-devel@ffmpeg.org > Cc: Jack Lau > > > This muxer has been

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING

2025-06-20 Thread Jack Lau
> On Jun 13, 2025, at 16:56, Jack Lau via ffmpeg-devel > wrote: > > > From: Jack Lau > Subject: [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to > ENCODING > Date: June 13, 2025 at 16:56:03 GMT+8 > To: ffmpeg-devel@ffmpeg.org > Cc: Jack La

Re: [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-20 Thread Jack Lau
> On Jun 17, 2025, at 22:07, Jack Lau wrote: > > > >> On Jun 15, 2025, at 23:54, Andreas Rheinhardt >> wrote: >> >> Jack Lau via ffmpeg-devel: >>> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c >>> index 86e8935fee.

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING

2025-06-23 Thread Jack Lau
> On Jun 21, 2025, at 12:58, Zhao Zhili > wrote: > > > >> On Jun 21, 2025, at 10:15, Jack Lau >> wrote: >> >> >> >>> On Jun 13, 2025, at 16:56, Jack Lau via ffmpeg-devel >>> wrote: >>> >

Re: [FFmpeg-devel] [PATCH v3] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-17 Thread Jack Lau
> On Jun 15, 2025, at 23:54, Andreas Rheinhardt > wrote: > > Jack Lau via ffmpeg-devel: >> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c >> index 86e8935fee..2a3905891d 100644 >> --- a/libavformat/tls_openssl.c >> +++ b/libavforma

Re: [FFmpeg-devel] [PATCH 2/2] avformat/whip: check the exchange sdp url is start with http

2025-06-08 Thread Jack Lau
> On Jun 6, 2025, at 11:02, Steven Liu wrote: > > Make sure the WHIP protocol performs the SDP offer/answer > exchange with the WebRTC peer over HTTP. > > Signed-off-by: Steven Liu > --- > libavformat/whip.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavformat/whip.c b

Re: [FFmpeg-devel] [PATCH] avformat/whip: set this muxer as experimental

2025-06-05 Thread Jack Lau
> On Jun 5, 2025, at 22:56, James Almer wrote: > > On 6/5/2025 11:54 AM, Jack Lau via ffmpeg-devel wrote: >> Signed-off-by: Jack Lau >> --- >> libavformat/whip.c | 6 ++ >> 1 file changed, 6 insertions(+) >> diff --git a/libavformat/whip.c b

Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-12 Thread Jack Lau
> On Jun 8, 2025, at 08:25, Jack Lau via ffmpeg-devel > wrote: > > api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem > > In higher versions (openssl 1.0.2 and higher), > the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), > so passing a co

Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-15 Thread Jack Lau
> On Jun 15, 2025, at 11:38, Andreas Rheinhardt > wrote: > > Jack Lau via ffmpeg-devel: >> api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem >> >> In higher versions (openssl 1.0.2 and higher), >> the function signature is BIO *BIO_new_mem_buf(const

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/whip: Add WHIP muxer support for subsecond latency streaming

2025-06-04 Thread Jack Lau
> On Jun 4, 2025, at 22:05, Martin Storsjö wrote: > > On Wed, 4 Jun 2025, Jack Lau wrote: > >> ffmpeg | branch: master | Jack Lau | Fri May 16 >> 20:15:05 2025 +0800| [167e343bbe75515a80db8ee72ffa0c607c944a00] | committer: >> Steven Liu >> >>

Re: [FFmpeg-devel] [PATCH v3] avformat/whip: Add WHIP muxer support for subsecond latency streaming

2025-06-04 Thread Jack Lau
> On Jun 5, 2025, at 06:20, Kieran Kunhya via ffmpeg-devel > wrote: > > On Wed, 4 Jun 2025, 12:46 Steven Liu, wrote: > >> Kieran Kunhya via ffmpeg-devel 于2025年6月4日周三 >> 19:35写道: >> Hi Kieran, >> >>> >>> @Andreas Rheinhardt >>> Should we revert this? >> >> I believe it would be better to

Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix build error when openssl version < 3

2025-06-06 Thread Jack Lau
> On Jun 5, 2025, at 19:20, Martin Storsjö wrote: > > On Thu, 5 Jun 2025, Jack Lau wrote: > >>> On Jun 5, 2025, at 15:02, Martin Storsjö wrote: >>> On Thu, 5 Jun 2025, Jack Lau via ffmpeg-devel wrote: >>>> fix the missing data structure pkey in th

Re: [FFmpeg-devel] [PATCH v2] avformat/format: make experimental flag works for muxer

2025-06-07 Thread Jack Lau
> On Jun 6, 2025, at 12:44, Zhao Zhili > wrote: > > From: Zhao Zhili > > --- > libavformat/avformat.h | 3 +-- > libavformat/format.c | 2 ++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 2034d2aecc..441e31bc2f 10

Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix build error when openssl version < 3

2025-06-05 Thread Jack Lau
> On Jun 5, 2025, at 15:02, Martin Storsjö wrote: > > On Thu, 5 Jun 2025, Jack Lau via ffmpeg-devel wrote: > >> fix the missing data structure pkey in the tls_context >> >> Signed-off-by: Jack Lau >> --- >> libavformat/tls_openssl.c | 30 ++

Re: [FFmpeg-devel] [PATCH 2/2] avformat/whip: Constify arguments in is_rtp_rtcp/is_rtcp

2025-06-05 Thread Jack Lau
> On Jun 5, 2025, at 17:41, Zhao Zhili > wrote: > > From: Zhao Zhili > > Fix warning of -Wincompatible-pointer-types-discards-qualifiers. > --- > libavformat/whip.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index 0

Re: [FFmpeg-devel] [PATCH 1/2] avformat/tls: Fix integer overflow with option mtu

2025-06-05 Thread Jack Lau
> On Jun 5, 2025, at 17:41, Zhao Zhili > wrote: > > From: Zhao Zhili > > --- > libavformat/tls.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/tls.h b/libavformat/tls.h > index cb626f1977..2f381acc04 100644 > --- a/libavformat/tls.h > +++ b/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-08 Thread Jack Lau
> On Jun 8, 2025, at 04:04, Andreas Rheinhardt > wrote: > > Jack Lau via ffmpeg-devel: >> In higher versions (like openssl 1.1.1 and higher), >> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), >> so passing a const string doesn'

Re: [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental

2025-06-09 Thread Jack Lau
> On Jun 9, 2025, at 21:19, Tristan Matthews wrote: > > Hi, > > > On Mon, Jun 9, 2025 at 6:25 AM Jack Lau via ffmpeg-devel > wrote: >> >> >> >> >> ------ Forwarded message -- >> From: Jack Lau >> To: ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 02/14] avformat/tls_openssl: force dtls handshake to be blocking

2025-07-15 Thread Jack Lau
> On Jul 14, 2025, at 03:24, Timo Rothenpieler wrote: > > There is no sensible way to handle this otherwise anyway, one just has > to loop over this function until it succeeds. > --- > libavformat/tls_openssl.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH v5 3/3] avformat/whip: fix typos

2025-06-28 Thread Jack Lau
Hi Timo, > On Jun 29, 2025, at 06:49, Timo Rothenpieler wrote: > > I've actually cleaned this up a bit while trying to implement DTLS via > schannel, and effectively removed the whole section: > >> https://github.com/BtbN/FFmpeg/commit/b6794f1373fb07b791cfacd2189c7efc4d6bdbcc > > There's also

Re: [FFmpeg-devel] [PATCH v5 3/3] avformat/whip: fix typos

2025-06-28 Thread Jack Lau
> On Jun 29, 2025, at 11:11, Jack Lau wrote: > > Hi Timo, >> On Jun 29, 2025, at 06:49, Timo Rothenpieler wrote: >> >> I've actually cleaned this up a bit while trying to implement DTLS via >> schannel, and effectively removed the whole section: >>

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 candidates

2025-06-27 Thread Jack Lau
> On Jun 27, 2025, at 22:03, Marvin Scholz > wrote: > > On 13 Jun 2025, at 10:56, Jack Lau via ffmpeg-devel wrote: > >> mark this ignore_ipv6 flag could ignore any ipv6 ICE candidate, >> preventing “No route to host” errors on devices without IPv6 connectivity. >

Re: [FFmpeg-devel] [PATCH v5 3/3] avformat/whip: fix typos

2025-06-29 Thread Jack Lau
> On Jun 29, 2025, at 19:47, Timo Rothenpieler wrote: > > On 29.06.2025 05:14, Jack Lau wrote: >>> On Jun 29, 2025, at 11:11, Jack Lau wrote: >>> >>> Hi Timo, >>>> On Jun 29, 2025, at 06:49, Timo Rothenpieler wrote: >>>> >&g

Re: [FFmpeg-devel] [PATCH v2 2/8] avformat/udp: make recv addr of each packet available

2025-07-07 Thread Jack Lau
> On Jul 7, 2025, at 19:28, Timo Rothenpieler wrote: > > On 07/07/2025 10:03, Jack Lau wrote: >>> On Jul 7, 2025, at 02:36, Timo Rothenpieler wrote: >>> >>> --- >>> libavformat/network.h | 2 ++ >>> libavformat/udp.c | 25

Re: [FFmpeg-devel] [PATCH v2 1/8] avformat/tls: move whip specific init out of generic tls code

2025-07-07 Thread Jack Lau
> On Jul 7, 2025, at 19:26, Timo Rothenpieler wrote: > > On 07/07/2025 08:30, Jack Lau wrote: >>> On Jul 7, 2025, at 02:36, Timo Rothenpieler wrote: >>> >>> --- >>> libavformat/tls.c | 9 - >>> libavformat/tls_openssl.

Re: [FFmpeg-devel] [PATCH v2 2/8] avformat/udp: make recv addr of each packet available

2025-07-07 Thread Jack Lau
> On Jul 7, 2025, at 02:36, Timo Rothenpieler wrote: > > --- > libavformat/network.h | 2 ++ > libavformat/udp.c | 25 + > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/libavformat/network.h b/libavformat/network.h > index ca214087fc..48bb75a758

Re: [FFmpeg-devel] [PATCH v2 1/8] avformat/tls: move whip specific init out of generic tls code

2025-07-06 Thread Jack Lau
> On Jul 7, 2025, at 02:36, Timo Rothenpieler wrote: > > --- > libavformat/tls.c | 9 - > libavformat/tls_openssl.c | 12 > libavformat/whip.c| 5 + > 3 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/libavformat/tls.c b/libavformat/tls

[FFmpeg-devel] [PATCH 0/4] Fix some issues in tls_openssl and udp

2025-07-09 Thread Jack Lau
ll in progressing 2. udp server mode haven't dest_addr so we need set it through last_recv_addr 3. some code cleanup This patchset depends Timo's latest schannel patchset More details: https://github.com/BtbN/FFmpeg/pull/3 Jack Lau (4): avformat/tls_openssl: add record trace function avfor

[FFmpeg-devel] [PATCH 2/4] avformat/tls_openssl: fix dtls_handshake return code

2025-07-09 Thread Jack Lau
If the handshake is still in progress, dtls_handshake should return a positive status code. Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 8639ac9758

[FFmpeg-devel] [PATCH 3/4] avformat/tls_openssl: remove all redundant "TLS: " in log with AVClass

2025-07-09 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index ffd9cd51d2..a519c8c880 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat

[FFmpeg-devel] [PATCH 4/4] avformat/udp: fix udp server mode haven't dest_addr

2025-07-09 Thread Jack Lau
If udp is in server mode(init local addr and port through url), then it maybe haven't dest_addr, so we should set it after udp_read get the client addr and port Signed-off-by: Jack Lau --- libavformat/udp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/udp.c b/libavf

[FFmpeg-devel] [PATCH 1/4] avformat/tls_openssl: add record trace function

2025-07-09 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 51 +-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a01fb387d..8639ac9758 100644 --- a/libavformat/tls_openssl.c +++ b

Re: [FFmpeg-devel] [PATCH 2/4] avformat/tls_openssl: fix dtls_handshake return code

2025-07-09 Thread Jack Lau
> On Jul 9, 2025, at 22:14, Timo Rothenpieler wrote: > > On 09/07/2025 15:36, Jack Lau wrote: >> If the handshake is still in progress, dtls_handshake should >> return a positive status code. > > Shouldn't dtls_open/start also be calling it in a loop then? &g

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: fix udp server mode haven't dest_addr

2025-07-09 Thread Jack Lau
> On Jul 9, 2025, at 22:16, Timo Rothenpieler wrote: > > On 09/07/2025 15:36, Jack Lau wrote: >> If udp is in server mode(init local addr and port through url), >> then it maybe haven't dest_addr, so we should set it after udp_read >> get the client addr and po

Re: [FFmpeg-devel] [PATCH 1/4] avformat/tls_openssl: add record trace function

2025-07-09 Thread Jack Lau
> On Jul 10, 2025, at 06:16, Michael Niedermayer wrote: > > On Wed, Jul 09, 2025 at 09:36:26PM +0800, Jack Lau wrote: >> Signed-off-by: Jack Lau >> --- >> libavformat/tls_openssl.c | 51 +-- >> 1 file changed, 49 insertio

[FFmpeg-devel] [PATCH v3 5/6] avformat/whip: implement NACK and RTX suppport

2025-07-12 Thread Jack Lau
Garcia Murillo Signed-off-by: Jack Lau --- libavformat/whip.c | 206 - 1 file changed, 202 insertions(+), 4 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index f1f8d1b4ad..d954e80830 100644 --- a/libavformat/whip.c +++ b

[FFmpeg-devel] [PATCH v3 6/6] avformat/whip: reindent whip options

2025-07-12 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/whip.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index d954e80830..f7eb6e1323 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -2089,13 +2089,13 @@ static int

[FFmpeg-devel] [PATCH v3 1/6] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-07-12 Thread Jack Lau
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavformat/whip.c b

[FFmpeg-devel] [PATCH v3 0/6] avformat/whip: Add NACK and RTX support

2025-07-12 Thread Jack Lau
Version 3 of https://ffmpeg.org/pipermail/ffmpeg-devel/2025-July/346052.html This patchset rebase latest commit Jack Lau (5): avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates avformat/whip: fix typos avformat/whip: fix H264 profile_iop bit map for SDP avformat/whip

[FFmpeg-devel] [PATCH v3 3/6] avformat/whip: fix H264 profile_iop bit map for SDP

2025-07-12 Thread Jack Lau
AVCodecParameters::profile only contains constraint_set1_flag (AV_PROFILE_H264_CONSTRAINED 1<<9). So add H264 constraints flag fully parse refer to hlsenc write_codec_attr Signed-off-by: Jack Lau --- libavformat/whip.c | 47 -- 1 file chang

[FFmpeg-devel] [PATCH v3 2/6] avformat/whip: fix typos

2025-07-12 Thread Jack Lau
Remove redundant "WHIP: " prefix in log context since it already add whip context. Fix grammers in whip options descriptions Signed-off-by: Jack Lau --- libavformat/whip.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/whip.c b/libavformat/wh

[FFmpeg-devel] [PATCH v3 4/6] WHIP: X509 cert serial number should be positive.

2025-07-12 Thread Jack Lau
From: winlin See RFC5280 4.1.2.2 Co-authored-by: Jack Lau Signed-off-by: winlin --- libavformat/tls_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a01fb387d..285ea166ac 100644 --- a/libavformat

[FFmpeg-devel] [PATCH v2 2/4] avformat/tls_openssl: fix dtls_handshake return code

2025-07-11 Thread Jack Lau
If the handshake is still in progress, dtls_handshake should return a positive status code. Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 8639ac9758

[FFmpeg-devel] [PATCH v2 1/4] avformat/tls_openssl: add record trace function

2025-07-11 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 51 +-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a01fb387d..8639ac9758 100644 --- a/libavformat/tls_openssl.c +++ b

[FFmpeg-devel] [PATCH v2 0/4] Fix some issues in tls_openssl and udp

2025-07-11 Thread Jack Lau
: 1. dtls_handshake can't return positive code when it still in progressing 2. udp server mode haven't dest_addr so we need set it through last_recv_addr 3. some code cleanup This patchset depends on Timo's latest schannel patchset More details: https://github.com/BtbN/FFmpeg/pull

[FFmpeg-devel] [PATCH v2 4/4] avformat/udp: fix udp server mode haven't dest_addr

2025-07-11 Thread Jack Lau
If udp is in server mode(init local addr and port through url), then it maybe haven't dest_addr, so we should set it after udp_read get the client addr and port This feature only enable when the new udp option autodetect_dest is specified Signed-off-by: Jack Lau --- libavformat/udp.

[FFmpeg-devel] [PATCH v2 3/4] avformat/tls_openssl: remove all redundant "TLS: " in log with AVClass

2025-07-11 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index ffd9cd51d2..a519c8c880 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/tls_openssl: fix dtls_handshake return code

2025-07-11 Thread Jack Lau
> On Jul 11, 2025, at 23:05, Steven Liu > wrote: > > Jack Lau <mailto:jacklau1222gm-at-gmail@ffmpeg.org>> 于2025年7月11日周五 21:22写道: >> >> If the handshake is still in progress, dtls_handshake should >> return a positive status code. >> >

[FFmpeg-devel] [PATCH v3 8/9] avformat/tls_openssl: auto set the dest addr when dtls in listen mode

2025-07-13 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 1c4d114205..344b152902 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -465,6 +465,8

[FFmpeg-devel] [PATCH v3 9/9] avformat/tls_openssl: init DTLS context with explicit method

2025-07-13 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 344b152902..4874260b6b 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -787,7 +787,7

[FFmpeg-devel] [PATCH v3 5/9] avformat/whip: free udp socket after dtls free

2025-07-13 Thread Jack Lau
the SSL_shutdown in tls_close need call the url_bio_bwrite so we should keep udp still alive Signed-off-by: Jack Lau --- libavformat/whip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index e272254a6f..17a3cd0ea8 100644 --- a

[FFmpeg-devel] [PATCH v3 7/9] avformat/tls_openssl: remove requirement for dtls must init cert and key

2025-07-13 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 8 1 file changed, 8 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 4f950a2fde..1c4d114205 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -731,10 +731,6 @@ static

[FFmpeg-devel] [PATCH v3 6/9] avformat/tls_openssl: replace 1 to TLS_ST_OK to be more clear

2025-07-13 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 3ed4585ecf..4f950a2fde 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -695,7 +695,7

[FFmpeg-devel] [PATCH v3 1/9] avformat/tls: add trace function for log TLS/DTLS record

2025-07-13 Thread Jack Lau
Refer to RFC 5246, RFC 6347 Signed-off-by: Jack Lau --- libavformat/tls.c | 56 +++ libavformat/tls.h | 2 ++ libavformat/tls_openssl.c | 8 -- 3 files changed, 64 insertions(+), 2 deletions(-) diff --git a/libavformat/tls.c b

[FFmpeg-devel] [PATCH v3 0/9] Fix some issues in tls_openssl

2025-07-13 Thread Jack Lau
dtls_handshake can't return positive code when it still in progressing 2. udp server mode haven't dest_addr so we need set it through last_recv_addr 3. some code cleanup This patchset depends on Timo's latest schannel patchset More details: https://github.com/BtbN/FFmpeg/pull/3 Jac

[FFmpeg-devel] [PATCH v3 3/9] avformat/tls_openssl: remove all redundant "TLS: " in log with AVClass

2025-07-13 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 25318d5fca..c824c5452b 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat

[FFmpeg-devel] [PATCH v3 4/9] avformat/tls_openssl: make tls and dtls use one close function

2025-07-13 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index c824c5452b..3ed4585ecf 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat

[FFmpeg-devel] [PATCH v3 2/9] avformat/tls_openssl: fix dtls_handshake return code

2025-07-13 Thread Jack Lau
If the handshake is still in progress, dtls_handshake should return a status code. init ret=AVERROR(EAGAIN) to match most of FFmpeg code Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b

Re: [FFmpeg-devel] [PATCH 08/18] avformat/tls: move openssl specific init out of generic code

2025-07-03 Thread Jack Lau
> On Jul 3, 2025, at 22:24, Timo Rothenpieler wrote: > > On 03.07.2025 03:07, Jack Lau wrote: >>> On Jul 3, 2025, at 00:56, Timo Rothenpieler wrote: >>> >>> --- >>> libavformat/tls.c | 9 - >>> libavformat/tls_openssl.c | 3

Re: [FFmpeg-devel] [PATCH 08/18] avformat/tls: move openssl specific init out of generic code

2025-07-02 Thread Jack Lau
> On Jul 3, 2025, at 00:56, Timo Rothenpieler wrote: > > --- > libavformat/tls.c | 9 - > libavformat/tls_openssl.c | 3 +++ > 2 files changed, 3 insertions(+), 9 deletions(-) > > diff --git a/libavformat/tls.c b/libavformat/tls.c > index 5ec4cca58a..f888970969 100644 > --- a/lib

[FFmpeg-devel] [PATCH v3 5/6] avformat/whip: implement NACK and RTX suppport

2025-07-02 Thread Jack Lau
Garcia Murillo Signed-off-by: Jack Lau --- libavformat/whip.c | 206 - 1 file changed, 202 insertions(+), 4 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index e287a3062f..b86e343419 100644 --- a/libavformat/whip.c +++ b

Re: [FFmpeg-devel] [PATCH 08/18] avformat/tls: move openssl specific init out of generic code

2025-07-05 Thread Jack Lau
> On Jul 4, 2025, at 00:41, Timo Rothenpieler wrote: > > On 03.07.2025 17:22, Jack Lau wrote: >>> On Jul 3, 2025, at 22:24, Timo Rothenpieler wrote: >>> >>> On 03.07.2025 03:07, Jack Lau wrote: >>>>> On Jul 3, 2025, at 00:56, Timo Rothenpiel

Re: [FFmpeg-devel] [PATCH 11/18] avformat/udp: make recv addr of each packet available

2025-07-05 Thread Jack Lau
> On Jul 3, 2025, at 00:56, Timo Rothenpieler wrote: > > --- > libavformat/network.h | 2 ++ > libavformat/udp.c | 25 + > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/libavformat/network.h b/libavformat/network.h > index ca214087fc..48bb75a758

Re: [FFmpeg-devel] [PATCH v2 5/6] avformat/whip: implement NACK and RTX suppport

2025-07-02 Thread Jack Lau
Hi > On Jul 2, 2025, at 21:46, Steven Liu > wrote: > > Jack Lau <mailto:jacklau1222gm-at-gmail@ffmpeg.org>> 于2025年7月2日周三 20:09写道: >> >> RTP retransmission described in RFC4588 (RTX) is an effective packet >> loss recovery technique for real-time

[FFmpeg-devel] [PATCH 6/6] avformat/whip: implement NACK and RTX suppport

2025-07-01 Thread Jack Lau
Garcia Murillo Signed-off-by: Jack Lau --- libavformat/whip.c | 198 - 1 file changed, 195 insertions(+), 3 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 15d1de691e..a32177e0b4 100644 --- a/libavformat/whip.c +++ b

[FFmpeg-devel] [PATCH 3/6] avformat/whip: fix typos

2025-07-01 Thread Jack Lau
Remove redundant "WHIP: " prefix in log context since it already add whip context. Fix grammers in whip options descriptions Signed-off-by: Jack Lau --- libavformat/whip.c | 152 ++--- 1 file changed, 76 insertions(+), 76 deletions(-) di

[FFmpeg-devel] [PATCH 4/6] avformat/whip: fix H264 profile_iop bit map for SDP

2025-07-01 Thread Jack Lau
AVCodecParameters::profile only contains constraint_set1_flag (AV_PROFILE_H264_CONSTRAINED 1<<9). So add H264 constraints flag fully parse refer to hlsenc write_codec_attr Signed-off-by: Jack Lau --- libavformat/whip.c | 47 -- 1 file chang

[FFmpeg-devel] [PATCH 1/6] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-07-01 Thread Jack Lau
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/whip.c b/libavformat/whip.c

[FFmpeg-devel] [PATCH 2/6] avformat/whip: reindent whip options

2025-07-01 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/whip.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index be6ee9c951..8d1be90f32 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1904,13 +1904,20 @@ static

[FFmpeg-devel] [PATCH 0/6] avformat/whip: avformat/whip: Add NACK and RTX support (depends on ignore_ipv6 patchset)

2025-07-01 Thread Jack Lau
testing that patchset until it can really work. I've been test this patch with Pion, Janus and it works well. Jack Lau (5): avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates avformat/whip: reindent whip options avformat/whip: fix typos avformat/whip: fix H264 profil

[FFmpeg-devel] [PATCH 5/6] WHIP: X509 cert serial number should be positive.

2025-07-01 Thread Jack Lau
From: winlin See RFC5280 4.1.2.2 Co-authored-by: winlin Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a3905891d..4733faec9c 100644 --- a/libavformat

[FFmpeg-devel] [PATCH v2 1/6] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-07-02 Thread Jack Lau
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavformat/whip.c b

[FFmpeg-devel] [PATCH v2 0/6] avformat/whip: Add NACK and RTX support (depends on ignore_ipv6 patchset)

2025-07-02 Thread Jack Lau
to avoid misunderstanding * add rtx_history_size option which can set the size of rtp packet history buffer Jack Lau (5): avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates avformat/whip: fix typos avformat/whip: fix H264 profile_iop bit map for SDP avformat/whip: implem

[FFmpeg-devel] [PATCH v2 2/6] avformat/whip: fix typos

2025-07-02 Thread Jack Lau
Remove redundant "WHIP: " prefix in log context since it already add whip context. Fix grammers in whip options descriptions Signed-off-by: Jack Lau --- libavformat/whip.c | 152 ++--- 1 file changed, 76 insertions(+), 76 deletions(-) di

[FFmpeg-devel] [PATCH v2 5/6] avformat/whip: implement NACK and RTX suppport

2025-07-02 Thread Jack Lau
Garcia Murillo Signed-off-by: Jack Lau --- libavformat/whip.c | 198 - 1 file changed, 195 insertions(+), 3 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index e287a3062f..fa6e3855d3 100644 --- a/libavformat/whip.c +++ b

[FFmpeg-devel] [PATCH v2 6/6] avformat/whip: reindent whip options

2025-07-02 Thread Jack Lau
Signed-off-by: Jack Lau --- libavformat/whip.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index fa6e3855d3..0c44ef6c73 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -2081,13 +2081,13 @@ static int

[FFmpeg-devel] [PATCH v2 3/6] avformat/whip: fix H264 profile_iop bit map for SDP

2025-07-02 Thread Jack Lau
AVCodecParameters::profile only contains constraint_set1_flag (AV_PROFILE_H264_CONSTRAINED 1<<9). So add H264 constraints flag fully parse refer to hlsenc write_codec_attr Signed-off-by: Jack Lau --- libavformat/whip.c | 47 -- 1 file chang

[FFmpeg-devel] [PATCH v2 4/6] WHIP: X509 cert serial number should be positive.

2025-07-02 Thread Jack Lau
From: winlin See RFC5280 4.1.2.2 Co-authored-by: winlin Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a3905891d..4733faec9c 100644 --- a/libavformat

  1   2   >