Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-17 Thread Anton Khirnov
Quoting Paul B Mahol (2023-06-17 08:35:21) > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov wrote: > > > Make sure we don't repeatedly try to decode the same packet, making no > > progress and possibly causing an infinite loop. > > > > Doesn't all error paths, bellow goto label in function, needs

Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 9:16 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2023-06-17 08:35:21) > > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov wrote: > > > > > Make sure we don't repeatedly try to decode the same packet, making no > > > progress and possibly causing an infinite loop. > > >

Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-17 Thread Anton Khirnov
Quoting Paul B Mahol (2023-06-17 09:39:24) > On Sat, Jun 17, 2023 at 9:16 AM Anton Khirnov wrote: > > > Quoting Paul B Mahol (2023-06-17 08:35:21) > > > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov wrote: > > > > > > > Make sure we don't repeatedly try to decode the same packet, making no > > >

Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 9:47 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2023-06-17 09:39:24) > > On Sat, Jun 17, 2023 at 9:16 AM Anton Khirnov wrote: > > > > > Quoting Paul B Mahol (2023-06-17 08:35:21) > > > > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov > wrote: > > > > > > > > > Make s

[FFmpeg-devel] [PATCH] doc/ffmpeg: improve -stats_*_fmt documentation

2023-06-17 Thread Anton Khirnov
--- doc/ffmpeg.texi | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index c0fa90f381..6769f8d305 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -2145,8 +2145,8 @@ Input frame number. Index of the inpu

[FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode

2023-06-17 Thread Thilo Borgmann
While the yuvj pixel formats are deprecated lots of code still relies on them to be set. Without setting a yuvj420p pixel format VP9 decoding ends up incorrectly due to auto conversion. suggested-by: ffm...@meta.com --- libavcodec/vp9.c | 20 1 file changed, 20 insertions(+)

[FFmpeg-devel] [PATCH v1 2/2] lavc/libvpxenc: support creating full range output

2023-06-17 Thread Thilo Borgmann
suggested-by: ffm...@meta.com --- libavcodec/libvpxenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 8833df2d68..6e8a0d07c3 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -799,21 +799,25 @@ static int

Re: [FFmpeg-devel] [RFC] [PATCH] avfilter/avfilter: add flag to signal filters that support w/h change

2023-06-17 Thread Anton Khirnov
Quoting Paul B Mahol (2023-06-17 08:52:33) > On Wed, Jun 14, 2023 at 7:33 PM Nicolas George wrote: > > > Paul B Mahol (12023-06-14): > > > To flag filters that can work with variable frame size changes > > > all the time in graph. So no rescalers are need to be inserted or > > > filtergraph reset

Re: [FFmpeg-devel] [RFC] [PATCH] avfilter/avfilter: add flag to signal filters that support w/h change

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 10:27 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2023-06-17 08:52:33) > > On Wed, Jun 14, 2023 at 7:33 PM Nicolas George wrote: > > > > > Paul B Mahol (12023-06-14): > > > > To flag filters that can work with variable frame size changes > > > > all the time in graph.

Re: [FFmpeg-devel] [RFC] [PATCH] avfilter/avfilter: add flag to signal filters that support w/h change

2023-06-17 Thread Gyan Doshi
On 2023-06-17 01:58 pm, Paul B Mahol wrote: On Sat, Jun 17, 2023 at 10:27 AM Anton Khirnov wrote: Quoting Paul B Mahol (2023-06-17 08:52:33) On Wed, Jun 14, 2023 at 7:33 PM Nicolas George wrote: Paul B Mahol (12023-06-14): To flag filters that can work with variable frame size changes a

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2023 at 08:16:04AM +0200, Paul B Mahol wrote: > Please no more pseudo demuxers. > > Use libavfilter API. sdrdemux takes a single linear stream of numbers containing multiple radio stations and demuxes it into individual streams (the stream can come from a file or a hardware devic

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 10:46 AM Michael Niedermayer wrote: > On Sat, Jun 17, 2023 at 08:16:04AM +0200, Paul B Mahol wrote: > > Please no more pseudo demuxers. > > > > Use libavfilter API. > > sdrdemux takes a single linear stream of numbers containing multiple radio > stations and demuxes it int

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode

2023-06-17 Thread Paul B Mahol
NAK, there is color_range that should not be ignored. Fix finally scale filter. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode

2023-06-17 Thread Thilo Borgmann
Am 17.06.23 um 13:40 schrieb Paul B Mahol: NAK, there is color_range that should not be ignored. In patch 1/2 color_range is used in the condition for the switch. if (avctx->color_range == AVCOL_RANGE_JPEG) { Or I don't understand. What shall be done with color_range? Fix finally scale fil

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 1:47 PM Thilo Borgmann wrote: > Am 17.06.23 um 13:40 schrieb Paul B Mahol: > > NAK, there is color_range that should not be ignored. > > In patch 1/2 color_range is used in the condition for the switch. > > if (avctx->color_range == AVCOL_RANGE_JPEG) { > > Or I don't under

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode

2023-06-17 Thread Thilo Borgmann
Am 17.06.23 um 13:53 schrieb Paul B Mahol: On Sat, Jun 17, 2023 at 1:47 PM Thilo Borgmann wrote: Am 17.06.23 um 13:40 schrieb Paul B Mahol: NAK, there is color_range that should not be ignored. In patch 1/2 color_range is used in the condition for the switch. if (avctx->color_range == AVCO

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
Hi On Sat, Jun 17, 2023 at 01:08:45PM +0200, Paul B Mahol wrote: [...] > But the biggest issue is your claim of demultiplexing, which your code does > not do, its done by called library. libsoapy is used just as a thin and common interface to the SDR hardware If you comment all uses of libsoapy

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Leo Izen
This is a nitpick, but can the commit message be something like: avformat: add Software Defined Radio support Upon casual glance, it could be confused for SDR as in Standard Dynamic Range, when browsing the tree. Ultimately up2u, just my initial thoughts. - Leo Izen __

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode

2023-06-17 Thread Leo Izen
On 6/17/23 04:11, Thilo Borgmann wrote: While the yuvj pixel formats are deprecated lots of code still relies on them to be set. Without setting a yuvj420p pixel format VP9 decoding ends up incorrectly due to auto conversion. I oppose this on principle. If there's code that relies on YUVJ bein

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode

2023-06-17 Thread Thilo Borgmann
Am 17.06.23 um 16:02 schrieb Leo Izen: On 6/17/23 04:11, Thilo Borgmann wrote: While the yuvj pixel formats are deprecated lots of code still relies on them to be set. Without setting a yuvj420p pixel format VP9 decoding ends up incorrectly due to auto conversion. I oppose this on principle.

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode

2023-06-17 Thread Leo Izen
On 6/17/23 10:26, Thilo Borgmann wrote: Am 17.06.23 um 16:02 schrieb Leo Izen: On 6/17/23 04:11, Thilo Borgmann wrote: While the yuvj pixel formats are deprecated lots of code still relies on them to be set. Without setting a yuvj420p pixel format VP9 decoding ends up incorrectly due to auto co

[FFmpeg-devel] [PATCH 1/3] avcodec/evc_frame_merge: use av_fast_realloc()

2023-06-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/evc_frame_merge_bsf.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/libavcodec/evc_frame_merge_bsf.c b/libavcodec/evc_frame_merge_bsf.c index 7cc701f5c5..827f114f0b 100644 --- a/libavcodec/evc_frame_merge_bs

[FFmpeg-devel] [PATCH 2/3] avcodec/evc_frame_merge_bsf: use av_new_packet()

2023-06-17 Thread James Almer
This ensures the buffer is padded as required by the AVPacket API. Signed-off-by: James Almer --- libavcodec/evc_frame_merge_bsf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/evc_frame_merge_bsf.c b/libavcodec/evc_frame_merge_bsf.c index 827f114f0b..540

[FFmpeg-devel] [PATCH 3/3] fate/lavf-container: add a test to remux raw evc into mp4

2023-06-17 Thread James Almer
Signed-off-by: James Almer --- tests/fate/lavf-container.mak | 2 ++ tests/ref/lavf-fate/evc.mp4 | 3 +++ 2 files changed, 5 insertions(+) create mode 100644 tests/ref/lavf-fate/evc.mp4 diff --git a/tests/fate/lavf-container.mak b/tests/fate/lavf-container.mak index 93740475b4..0d4a224601 100

[FFmpeg-devel] [PATCH] avcodec: use sRGB to stringify gbr/bt709/iec61966-2-1 instead

2023-06-17 Thread Leo Izen
The sRGB color space uses RGB matrix (i.e. identity), BT.709 primaries, and the ISO/IEC 61966-2-1 transfer function (unique to sRGB). This set of tags is very common, so printing it as "sRGB" instead of the current form "gbr/bt709/iec61966-2-1" is preferable. Signed-off-by: --- libavcodec/avcode

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Paul B Mahol
On Sat, Jun 17, 2023 at 2:48 PM Michael Niedermayer wrote: > Hi > > On Sat, Jun 17, 2023 at 01:08:45PM +0200, Paul B Mahol wrote: > [...] > > > But the biggest issue is your claim of demultiplexing, which your code > does > > not do, its done by called library. > > libsoapy is used just as a thin

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2023 at 09:30:09AM -0400, Leo Izen wrote: > This is a nitpick, but can the commit message be something like: > > avformat: add Software Defined Radio support > > Upon casual glance, it could be confused for SDR as in Standard Dynamic > Range, when browsing the tree. Ultimately up2

Re: [FFmpeg-devel] [PATCH] swresample: reuse DSP functions from avutil

2023-06-17 Thread Paul B Mahol
Gonna apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: [...] > Which library handles compressed stuff? For digital stuff like DAB/DVB/... sdrdemux in libavformat will demodulate, do error correction then return AVPacket with H.264 / Mpeg2 video or AAC or wahetever That then will get pas

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2023 at 08:37:23PM +0200, Michael Niedermayer wrote: > On Sat, Jun 17, 2023 at 08:08:11PM +0200, Paul B Mahol wrote: > [...] > > > Which library handles compressed stuff? > > For digital stuff like DAB/DVB/... > > sdrdemux in libavformat will demodulate, do error correction then

Re: [FFmpeg-devel] [PATCH] swresample: reuse DSP functions from avutil

2023-06-17 Thread Michael Niedermayer
On Mon, Jun 12, 2023 at 06:08:47PM +0200, Paul B Mahol wrote: > On Wed, Jun 7, 2023 at 10:17 PM Michael Niedermayer > wrote: > > > On Wed, Jun 07, 2023 at 07:29:13PM +0200, Paul B Mahol wrote: > > > On Wed, Jun 7, 2023 at 6:01 PM Michael Niedermayer < > > mich...@niedermayer.cc> > > > wrote: > >

[FFmpeg-devel] [PATCH 04/10] avcodec/evc_parse: split off Parameter Set parsing into its own file

2023-06-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/Makefile | 2 +- libavcodec/evc_frame_merge_bsf.c | 4 +- libavcodec/evc_parse.c | 371 +- libavcodec/evc_parse.h | 198 +--- libavcodec/evc_parser.c | 2 +- libavcode

[FFmpeg-devel] [PATCH 05/10] avcodec/evc_parser: stop exporting delay and gop_size

2023-06-17 Thread James Almer
The former is a property a decoder may export, and the latter is only used in encoding scenarios. Signed-off-by: James Almer --- libavcodec/evc_parse.c | 6 -- libavcodec/evc_parse.h | 6 -- libavcodec/evc_parser.c | 2 -- 3 files changed, 14 deletions(-) diff --git a/libavcodec/evc_p

[FFmpeg-devel] [PATCH 06/10] avcodec/evc_parse: split off deriving PoC

2023-06-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/evc_parse.c | 142 + libavcodec/evc_parse.h | 5 ++ 2 files changed, 79 insertions(+), 68 deletions(-) diff --git a/libavcodec/evc_parse.c b/libavcodec/evc_parse.c index 1fe58c8050..262ef5aa39 100644 --- a/libavc

[FFmpeg-devel] [PATCH 07/10] avcodec/evc_parser: make ff_evc_parse_nal_unit() local to the parser

2023-06-17 Thread James Almer
This is in preparation for the following commits. Signed-off-by: James Almer --- libavcodec/evc_parse.c | 17 +-- libavcodec/evc_parse.h | 3 + libavcodec/evc_parser.c | 222 ++-- 3 files changed, 202 insertions(+), 40 deletions(-) diff --git a/libavcode

[FFmpeg-devel] [PATCH 08/10] avcodec/evc_parser: remove write only variable

2023-06-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/evc_parser.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/evc_parser.c b/libavcodec/evc_parser.c index d22922d1c9..c30da6846e 100644 --- a/libavcodec/evc_parser.c +++ b/libavcodec/evc_parser.c @@ -211,7 +211,6 @@ static int parse_nal_un

[FFmpeg-devel] [PATCH 09/10] avcodec/evc_frame_merge_bsf: make ff_evc_parse_nal_unit() local to the filter

2023-06-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/evc_frame_merge_bsf.c | 114 +-- 1 file changed, 92 insertions(+), 22 deletions(-) diff --git a/libavcodec/evc_frame_merge_bsf.c b/libavcodec/evc_frame_merge_bsf.c index f497780afb..817136a551 100644 --- a/libavcodec/evc_frame

[FFmpeg-devel] [PATCH 10/10] avcodec/evc_parse: remove ff_evc_parse_nal_unit()

2023-06-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/evc_parse.c | 156 libavcodec/evc_parse.h | 42 --- libavcodec/evc_parser.c | 7 ++ 3 files changed, 7 insertions(+), 198 deletions(-) diff --git a/libavcodec/evc_parse.c b/libavcodec/evc_parse.c inde

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-17 Thread Michael Niedermayer
On Fri, Jun 16, 2023 at 09:10:19PM -0400, Brad Smith wrote: > > --- > configure | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/configure b/configure > index 0c77d8e1fe..653aafb1ea 100755 > --- a/configure > +++ b/configure > @@ -7009,8 +7009,7 @@ enabled alsa && { che

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-06-17 Thread Brad Smith
On Sun, Jun 18, 2023 at 12:01:14AM +0200, Michael Niedermayer wrote: > > this breaks a plain configure > here on ubuntu > > ./configure > ERROR: sndio not found using pkg-config > > If you think configure made a mistake, make sure you are using the latest > version from Git. If the latest versi

Re: [FFmpeg-devel] [PATCH v1 2/2] lavc/libvpxenc: support creating full range output

2023-06-17 Thread James Zern
On Sat, Jun 17, 2023 at 1:11 AM Thilo Borgmann wrote: > > suggested-by: ffm...@meta.com > --- > libavcodec/libvpxenc.c | 12 > 1 file changed, 12 insertions(+) > Looks like there's some discussion on the parent patch about the correctness of adding this. This wrapper does set the co