[FFmpeg-devel] Possibly a little bug in af_loudnorm.c

2022-08-20 Thread jagad hariseno
Hi All, at af_loudnorm.c in line number 188: double this, next, max_peak; max_peak is not initialized with 0. and could be contains any value or noise. I could be wrong but I think init with 0. should be better: double this, next, max_peak=0.; Best Regards jagad. __

Re: [FFmpeg-devel] Possibly a little bug in af_loudnorm.c

2022-08-20 Thread Jack Waller
Please check the code:line 209 if (c == 0 || fabs(buf[index + c]) > max_peak) max_peak = fabs(buf[index + c]); 'max_peak' is initialized. On Sat, Aug 20, 2022 at 5:39 PM jagad hariseno wrote: > Hi All, > > at af_loudnorm.c in line number 188: > doub

Re: [FFmpeg-devel] Possibly a little bug in af_loudnorm.c

2022-08-20 Thread jagad hariseno
yes you're right. Thanks for your fast response Best Regards jagad On Sat, Aug 20, 2022 at 4:53 PM Jack Waller wrote: > Please check the code:line 209 > > if (c == 0 || fabs(buf[index + c]) > max_peak) > max_peak = fabs(buf[index + c]); > > 'max_peak

[FFmpeg-devel] framepool width and potential patch for bug 9873

2022-08-20 Thread Brendan Hack
Hi, I reported https://trac.ffmpeg.org/ticket/9873 last week and have since been digging into the code to see if I can get a patch together. I've found the underlying issue in ff_frame_pool_video_init at line 77 of libavfilter/framepool.c:     ret = av_image_fill_linesizes(pool->linesize

Re: [FFmpeg-devel] framepool width and potential patch for bug 9873

2022-08-20 Thread Timo Rothenpieler
On 20.08.2022 13:21, Brendan Hack wrote: Hi, I reported https://trac.ffmpeg.org/ticket/9873 last week and have since been digging into the code to see if I can get a patch together. I've found the underlying issue in ff_frame_pool_video_init at line 77 of libavfilter/framepool.c:     r

Re: [FFmpeg-devel] framepool width and potential patch for bug 9873

2022-08-20 Thread Timo Rothenpieler
On 20.08.2022 14:27, Brendan Hack wrote: Oh, I think I've got the wrong end of the stick here in regards to what align does in ff_frame_pool_video_init. Frei0r only needs the start of the buffer to be aligned to 16 bytes. It doesn't need each _line_ to be explicitly aligned to 16 bytes since it

Re: [FFmpeg-devel] framepool width and potential patch for bug 9873

2022-08-20 Thread Paul B Mahol
On Sat, Aug 20, 2022 at 2:30 PM Timo Rothenpieler wrote: > On 20.08.2022 14:27, Brendan Hack wrote: > > Oh, I think I've got the wrong end of the stick here in regards to what > > align does in ff_frame_pool_video_init. Frei0r only needs the start of > > the buffer to be aligned to 16 bytes. It d

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-20 Thread Thilo Borgmann
On 18 Aug 2022, at 12:58, Gyan Doshi wrote: On 2022-08-17 05:55 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-08-17 12:53:11) On 2022-08-17 02:35 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-08-17 10:50:43) On 2022-08-17 01:48 pm, Anton Khirnov wrote: Quoting Thilo Borgmann (202

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-20 Thread Nicolas George
Thilo Borgman (12022-08-20): > suggestion with a parser for SVG-style (new syntax) is not backup up by > s.o. else. I feel it was somewhat drowned by the rest of the discussion. Do YOU like it? Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-20 Thread Thilo Borgmann
Am 20.08.22 um 15:39 schrieb Nicolas George: Thilo Borgman (12022-08-20): suggestion with a parser for SVG-style (new syntax) is not backup up by s.o. else. I feel it was somewhat drowned by the rest of the discussion. Do YOU like it? My two cents about it that the a=b:c=d syntax from AVDic

[FFmpeg-devel] [PATCH 1/1] lavf/dashdec: Multithreaded DASH initialization

2022-08-20 Thread Lukas Fellechner
This patch adds multithreading support to DASH initialization. Initializing DASH streams is currently slow, because each individual stream is opened and probed sequentially. With DASH streams often having somewhere between 10-20 substreams, this can easily take up to half a minute on slow connec

Re: [FFmpeg-devel] [PATCH 1/1] lavf/dashdec: Multithreaded DASH initialization

2022-08-20 Thread Lukas Fellechner
Trying with inline PATCH since attached file was not showing up... --- From: Lukas Fellechner Subject: [PATCH 1/1] lavf/dashdec: Multithreaded DASH initialization Initializing DASH streams is currently slow, because each individual stream is opened and probed sequentially. With DASH streams of

[FFmpeg-devel] [PATCH 1/4] avcodec/pngdec: Fix APNG_DISPOSE_OP_BACKGROUND

2022-08-20 Thread Andreas Rheinhardt
APNG works with a single reference frame and an output frame. According to the spec, decoding APNG works by decoding the current IDAT/fdAT chunks (which decodes to a rectangular subregion of the whole image region), followed by either overwriting the region of the output frame with the newly decode

[FFmpeg-devel] [PATCH 2/4] avcodec/pngdec: Use internal AVBPrint string when parsing chunks

2022-08-20 Thread Andreas Rheinhardt
One saves an allocation in case the string fits into the buffer. Signed-off-by: Andreas Rheinhardt --- libavcodec/pngdec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 8a197d038d..189c3eee89 100644 --- a/libavcodec/pn

[FFmpeg-devel] [PATCH 3/4] avcodec/pngdec: Use char* instead of uint8_t* for text

2022-08-20 Thread Andreas Rheinhardt
Also stop casting const away. Signed-off-by: Andreas Rheinhardt --- libavcodec/pngdec.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 189c3eee89..132ad40dc9 100644 --- a/libavcodec/pngdec.c +++ b/libavcode

[FFmpeg-devel] [PATCH 4/4] avcodec/pngdec: Improve decoding text chunks

2022-08-20 Thread Andreas Rheinhardt
By checking immediately whether the first allocation was successfull one can simplify the cleanup code in case of errors. Signed-off-by: Andreas Rheinhardt --- libavcodec/pngdec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c

Re: [FFmpeg-devel] [PATCH 1/1] lavf/dashdec: Multithreaded DASH initialization

2022-08-20 Thread Steven Liu
Lukas Fellechner 于2022年8月21日周日 05:54写道: > > Trying with inline PATCH since attached file was not showing up... > > --- > > From: Lukas Fellechner > Subject: [PATCH 1/1] lavf/dashdec: Multithreaded DASH initialization > > Initializing DASH streams is currently slow, because each individual stream