Re: [FFmpeg-devel] [PATCH 5/6] avformat/asfdec: Fix DoS due to lack of eof check

2017-08-25 Thread Paul B Mahol
On 8/25/17, Michael Niedermayer wrote: > From: ** and *(**) > > Fixes: loop.asf > > Found-by: Xiaohei and Wangchu from Alibaba Security Team > Signed-off-by: Michael Niedermayer > --- > libavformat/asfdec_f.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > di

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: Enable VBR mode

2017-08-25 Thread Jun Zhao
From 483204cf7c25077d556c86b9e70f591fc2c0d4a3 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Fri, 25 Aug 2017 03:50:37 -0400 Subject: [PATCH] lavc/vaapi_encode_h265: Enable VBR mode Follow vaapi_h264 style, enable the VBR mode. Signed-off-by: Jun Zhao --- libavcodec/vaapi_encode_h265.c | 15 ++

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread wm4
On Thu, 24 Aug 2017 20:43:11 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > The deprecation seems to have been imported from libav but never made > effective. > > libavcodec/imgconvert.c | 2 -- > libavcodec/version.h| 3 --- > 2 files changed, 5 deletions(-) > > diff --gi

Re: [FFmpeg-devel] Autotools full recompilation

2017-08-25 Thread wm4
On Fri, 25 Aug 2017 02:19:00 +0300 Yan wrote: > And after each time the whole project got recompiled. I guess you cook > autotools wrong. (Personally I hate this build system cause it's ugly > and slw) As it was mentioned, FFmpeg doesn't use autotools, just somewhat similar conventions. A fu

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread wm4
On Fri, 25 Aug 2017 01:15:32 +0200 Michael Niedermayer wrote: > Fixes: loop.m3u > > The max iteration count of 1 is arbitrary and ideas for a better solution > are welcome > > Found-by: Xiaohei and Wangchu from Alibaba Security Team > Signed-off-by: Michael Niedermayer > --- > libavforma

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread Paul B Mahol
On 8/25/17, wm4 wrote: > On Thu, 24 Aug 2017 20:43:11 -0300 > James Almer wrote: > >> Signed-off-by: James Almer >> --- >> The deprecation seems to have been imported from libav but never made >> effective. >> >> libavcodec/imgconvert.c | 2 -- >> libavcodec/version.h| 3 --- >> 2 files cha

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 10:08:23AM +0200, wm4 wrote: > On Fri, 25 Aug 2017 01:15:32 +0200 > Michael Niedermayer wrote: > > > Fixes: loop.m3u > > > > The max iteration count of 1 is arbitrary and ideas for a better > > solution are welcome > > > > Found-by: Xiaohei and Wangchu from Alibaba

[FFmpeg-devel] [PATCH] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
Fixes: loop.m3u The default max iteration count of 1000 is arbitrary and ideas for a better solution are welcome Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavfor

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 08:23:32AM +0800, Steven Liu wrote: > 2017-08-25 7:15 GMT+08:00 Michael Niedermayer : > > Fixes: loop.m3u > > > > The max iteration count of 1 is arbitrary and ideas for a better > > solution are welcome > Why not give a option to user for set the reload_count and limit

Re: [FFmpeg-devel] [PATCH 5/6] avformat/asfdec: Fix DoS due to lack of eof check

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 08:52:22AM +0200, Paul B Mahol wrote: > On 8/25/17, Michael Niedermayer wrote: > > From: ** and *(**) > > > > Fixes: loop.asf > > > > Found-by: Xiaohei and Wangchu from Alibaba Security Team > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/a

[FFmpeg-devel] [PATCH] avformat/asfdec: Fix DoS due to lack of eof check

2017-08-25 Thread Michael Niedermayer
From: "wangchu@alibaba-inc.com" Fixes: loop.asf Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/asfdec_f.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c i

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread wm4
On Fri, 25 Aug 2017 11:59:54 +0200 Michael Niedermayer wrote: > On Fri, Aug 25, 2017 at 10:08:23AM +0200, wm4 wrote: > > On Fri, 25 Aug 2017 01:15:32 +0200 > > Michael Niedermayer wrote: > > > > > Fixes: loop.m3u > > > > > > The max iteration count of 1 is arbitrary and ideas for a bette

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread wm4
On Fri, 25 Aug 2017 10:15:05 +0200 Paul B Mahol wrote: > On 8/25/17, wm4 wrote: > > On Thu, 24 Aug 2017 20:43:11 -0300 > > James Almer wrote: > > > >> Signed-off-by: James Almer > >> --- > >> The deprecation seems to have been imported from libav but never made > >> effective. > >> > >> lib

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread Ronald S. Bultje
Hi, On Thu, Aug 24, 2017 at 7:43 PM, James Almer wrote: > Signed-off-by: James Almer > --- > The deprecation seems to have been imported from libav but never made > effective. Hm, but do we really want this function? Shouldn't all users be ported to the function this wraps? Ronald __

[FFmpeg-devel] V4L2 M2M version 6

2017-08-25 Thread Jorge Ramirez-Ortiz
This patch-set adds support for dynamically reconfiguring the video stream. The set was rebased on top of [1]. The fate suite was run successfully and the encoders/decoders have been tested (including a fix for vp8 encoding). Simultaneous encoding/decoding was also validated and the build system

[FFmpeg-devel] [PATCHv6 1/4] Move lavd/v4l2-common.* to lavc

2017-08-25 Thread Jorge Ramirez-Ortiz
From: Alexis Ballier In preparation to support the integation of the V4L2 API for encoding and decoding, move v4l2 related files to libavcodec. v4l2-common was renamed to v4l2_fmt for clarity (v4l2-common.h belongs to the V4L2 API) Signed-off-by: Alexis Ballier Reviewed-by: Jorge Ramirez-Ortiz

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

2017-08-25 Thread Jean-Yves Avenard
Note that that it's also not correct for other codecs when the sampling rate is greater than 65536. Right now it stores 0. If in quicktime mode, it could use a SoundDescription v2 box, but in mp4 that doesn't exist. Per ISO 14496-12 , it should be using a AudioSampleEntryV1 along a SamplingRateBox

[FFmpeg-devel] [PATCHv6 3/4] libavcodec: v4l2: add codec formats

2017-08-25 Thread Jorge Ramirez-Ortiz
In addition, enable the multi planar raw formats. Reviewed-by: Jorge Ramirez Tested-by: Jorge Ramirez --- libavcodec/v4l2_fmt.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/libavcodec/v4l2_fmt.c b/libavcodec/v4l2_fmt.c index 855cc64.

[FFmpeg-devel] [PATCHv6 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-25 Thread Jorge Ramirez-Ortiz
This patchset enhances Alexis Ballier's original patch and validates it using Qualcomm's Venus hardware (driver recently landed upstream [1]). This has been tested on Qualcomm's DragonBoard 410c and 820c Configure/make scripts have been validated on Ubuntu 10.04 and 16.04.

[FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

2017-08-25 Thread Jean-Yves Avenard
From 9baa7166fa96ed6beac9146c7e3b4dcf425a67d0 Mon Sep 17 00:00:00 2001 From: Jean-Yves Avenard Date: Fri, 25 Aug 2017 13:11:28 +0200 Subject: [PATCH] Properly store sampling rate for FLAC in mp4 Fixes ticket #6609 Signed-off-by: Jean-Yves Avenard --- libavformat/movenc.c | 28 +

[FFmpeg-devel] [PATCHv6 2/4] libavcodec: v4l2: add pack_flags to the conversion tables

2017-08-25 Thread Jorge Ramirez-Ortiz
From: Alexis Ballier Extend the mapping function to use the v4l2 conversion tables. Reviewed-by: Jorge Ramirez Tested-by: Jorge Ramirez --- libavcodec/v4l2_fmt.c | 63 ++- libavcodec/v4l2_fmt.h | 17 +- libavdevice/v4l2.c| 2 +-

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-25 Thread Michael Niedermayer
On Mon, Jul 31, 2017 at 04:42:20PM -0700, Dale Curtis wrote: > I'm not convinced my original patch catches all cases. So here's an updated > one which explicitly verifies the contract. > > - dale > > On Mon, Jul 31, 2017 at 2:40 PM, Dale Curtis > wrote: > > > [mov] Bail when invalid sample data

Re: [FFmpeg-devel] [PATCHv6 1/4] Move lavd/v4l2-common.* to lavc

2017-08-25 Thread Paul B Mahol
On 8/25/17, Jorge Ramirez-Ortiz wrote: > From: Alexis Ballier > > In preparation to support the integation of the V4L2 API for encoding > and decoding, move v4l2 related files to libavcodec. > > v4l2-common was renamed to v4l2_fmt for clarity (v4l2-common.h belongs > to the V4L2 API) > > Signed-o

Re: [FFmpeg-devel] [PATCH v2] mjpeg: Add support for ICC side data

2017-08-25 Thread Derek Buitenhuis
On 8/25/2017 1:37 AM, Michael Niedermayer wrote: > should be ok Pushed, with an extra check added for duplicate sequence numbers. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread James Almer
On 8/25/2017 8:10 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Aug 24, 2017 at 7:43 PM, James Almer wrote: > >> Signed-off-by: James Almer >> --- >> The deprecation seems to have been imported from libav but never made >> effective. > > > Hm, but do we really want this function? Shouldn't al

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread Ronald S. Bultje
Hi, On Fri, Aug 25, 2017 at 10:04 AM, James Almer wrote: > On 8/25/2017 8:10 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Thu, Aug 24, 2017 at 7:43 PM, James Almer wrote: > > > >> Signed-off-by: James Almer > >> --- > >> The deprecation seems to have been imported from libav but never made >

Re: [FFmpeg-devel] (no subject)

2017-08-25 Thread Ivan Kalvachev
On 8/22/17, Rodrigo Severo wrote: > Hi, > > > My company does some video recording and internal streaming. > > Our current solution (on Ubuntu 16.10 servers) uses ffmpeg and > ffserver (versions 3.0.7). It works great. > > Unfortunately, on Ubuntu 17.04, it stopped working. I believe the > problem

[FFmpeg-devel] [PATCH] avcodec: make the avcodec_get_chroma_sub_sample deprecation effective

2017-08-25 Thread James Almer
--- libavcodec/avcodec.h | 16 libavcodec/version.h | 6 +++--- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c594993766..65092a 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -5665,22 +5665,

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

2017-08-25 Thread James Almer
On 8/25/2017 11:39 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Aug 25, 2017 at 10:04 AM, James Almer wrote: > >> On 8/25/2017 8:10 AM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Thu, Aug 24, 2017 at 7:43 PM, James Almer wrote: >>> Signed-off-by: James Almer --- The deprecation

[FFmpeg-devel] Offer paid job to maintain ffserver: seeking interested developers

2017-08-25 Thread Rodrigo Severo
Hi, I'm resending this email, now with a proper subject line, as per Ivan Kalvachev suggestion. My company does some video recording and internal streaming. Our current solution (on Ubuntu 16.10 servers) uses ffmpeg and ffserver (versions 3.0.7). It works great. Unfortunately, on Ubuntu 17.04,

Re: [FFmpeg-devel] [PATCH] avcodec: make the avcodec_get_chroma_sub_sample deprecation effective

2017-08-25 Thread Ronald S. Bultje
Hi, On Fri, Aug 25, 2017 at 11:09 AM, James Almer wrote: > --- > libavcodec/avcodec.h | 16 > libavcodec/version.h | 6 +++--- > 2 files changed, 7 insertions(+), 15 deletions(-) Thanks :) Ronald ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] (no subject)

2017-08-25 Thread Rodrigo Severo
2017-08-25 11:58 GMT-03:00 Ivan Kalvachev : > On 8/22/17, Rodrigo Severo wrote: >> >> I would like to know if there is any developer(s) interested in >> assuming a paid job to maintain ffserver making it compatible with >> present and future ffmpeg versions (most important part) and >> eventually

Re: [FFmpeg-devel] [PATCH] avcodec: make the avcodec_get_chroma_sub_sample deprecation effective

2017-08-25 Thread James Almer
On 8/25/2017 12:16 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Aug 25, 2017 at 11:09 AM, James Almer wrote: > >> --- >> libavcodec/avcodec.h | 16 >> libavcodec/version.h | 6 +++--- >> 2 files changed, 7 insertions(+), 15 deletions(-) > > > Thanks :) > > Ronald Pushed.

Re: [FFmpeg-devel] [PATCHv6 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-25 Thread wm4
That looks generally OK. Is there any chance a hwaccel approach would be possible instead? If I've learned anything about hardware decoding, then that hwaccel is vastly superior to vendor-implemented full stream decoders. I don't think I like the attempt of sharing the v4l helper functions between

[FFmpeg-devel] [PATCH] opus_pvq_search.asm: Handle zero vector input differently.

2017-08-25 Thread Ivan Kalvachev
Instead of returning all zeroes as result and Syy=1.0, place all the K pulses in the first element y[0] and return Syy=K*K. This is how the original opus function handles the case. This is how the existing pvq_search_c handles the case. Also, according to Rostislav, the encoded all zeros vector w

Re: [FFmpeg-devel] Offer paid job to maintain ffserver: seeking interested developers

2017-08-25 Thread wm4
On Fri, 25 Aug 2017 12:09:24 -0300 Rodrigo Severo wrote: > Hi, > > > I'm resending this email, now with a proper subject line, as per Ivan > Kalvachev suggestion. > > My company does some video recording and internal streaming. > > Our current solution (on Ubuntu 16.10 servers) uses ffmpeg an

Re: [FFmpeg-devel] Offer paid job to maintain ffserver: seeking interested developers

2017-08-25 Thread James Almer
On 8/25/2017 12:43 PM, wm4 wrote: > On Fri, 25 Aug 2017 12:09:24 -0300 > Rodrigo Severo wrote: > >> Hi, >> >> >> I'm resending this email, now with a proper subject line, as per Ivan >> Kalvachev suggestion. >> >> My company does some video recording and internal streaming. >> >> Our current solu

Re: [FFmpeg-devel] [PATCH] opus_pvq_search.asm: Handle zero vector input differently.

2017-08-25 Thread Rostislav Pehlivanov
On 25 August 2017 at 16:38, Ivan Kalvachev wrote: > Instead of returning all zeroes as result and Syy=1.0, > place all the K pulses in the first element y[0] > and return Syy=K*K. > > This is how the original opus function handles the case. > This is how the existing pvq_search_c handles the case

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 01:03:35PM +0200, wm4 wrote: > On Fri, 25 Aug 2017 11:59:54 +0200 > Michael Niedermayer wrote: > > > On Fri, Aug 25, 2017 at 10:08:23AM +0200, wm4 wrote: > > > On Fri, 25 Aug 2017 01:15:32 +0200 > > > Michael Niedermayer wrote: > > > > > > > Fixes: loop.m3u > > > > >

Re: [FFmpeg-devel] [PATCH] avcodec: make the avcodec_get_chroma_sub_sample deprecation effective

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 12:09:53PM -0300, James Almer wrote: > --- > libavcodec/avcodec.h | 16 > libavcodec/version.h | 6 +++--- > 2 files changed, 7 insertions(+), 15 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index c594993766..65092a 1006

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-25 Thread Michael Niedermayer
On Thu, Aug 24, 2017 at 05:06:16PM -0700, Dale Curtis wrote: > On Thu, Aug 24, 2017 at 2:27 AM, Michael Niedermayer > wrote: > > > > > can the insertions be done in groups instead of one at a time ? > > so that it basically merges 2 lists (O(n)) instead of inserting > > one at a time O(n^2) > > ?

[FFmpeg-devel] [PATCH] libavformat/mov: Always use av_realloc() for AVCodecParameters.extradata

2017-08-25 Thread John Rummell
Chromium uses tcmalloc which doesn't like mixing calls to posix_memalign() and realloc(). This change updates mov.c to only use av_realloc() when allocating memory for AVCodecParameters.extradata. --- libavformat/mov.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) d

[FFmpeg-devel] [PATCH] avfilter/af_join: detect EOF immediately

2017-08-25 Thread Paul B Mahol
Prevents hang. Signed-off-by: Paul B Mahol --- libavfilter/af_join.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c index f8af0a1..7fbab47 100644 --- a/libavfilter/af_join.c +++ b/libavfilter/af_join.c @@ -24,6 +24,9

Re: [FFmpeg-devel] [PATCH] avcodec/dvbsubdec: Check for duplicate regions in dvbsub_parse_page_segment()

2017-08-25 Thread Michael Niedermayer
On Tue, Aug 22, 2017 at 03:56:41AM +0200, Michael Niedermayer wrote: > Fixes: OOM > Fixes: 3051/clusterfuzz-testcase-minimized-5745818336231424 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCHv6 1/4] Move lavd/v4l2-common.* to lavc

2017-08-25 Thread Jorge Ramirez
On 08/25/2017 02:50 PM, Paul B Mahol wrote: On 8/25/17, Jorge Ramirez-Ortiz wrote: From: Alexis Ballier In preparation to support the integation of the V4L2 API for encoding and decoding, move v4l2 related files to libavcodec. v4l2-common was renamed to v4l2_fmt for clarity (v4l2-common.h be

Re: [FFmpeg-devel] [PATCHv6 1/4] Move lavd/v4l2-common.* to lavc

2017-08-25 Thread Paul B Mahol
On 8/25/17, Jorge Ramirez wrote: > On 08/25/2017 02:50 PM, Paul B Mahol wrote: >> On 8/25/17, Jorge Ramirez-Ortiz wrote: >>> From: Alexis Ballier >>> >>> In preparation to support the integation of the V4L2 API for encoding >>> and decoding, move v4l2 related files to libavcodec. >>> >>> v4l2-co

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-25 Thread Dale Curtis
On Fri, Aug 25, 2017 at 5:43 AM, Michael Niedermayer wrote: > > This patch breaks: > http://samples.ffmpeg.org/mov/mp4/discont-frag.mp4 > > Hmm, indeed it does. The reason is that we read the sample count from the stsz box and then read the trun box. I don't think this block of code has ever been

Re: [FFmpeg-devel] [PATCH] opus_pvq_search.asm: Handle zero vector input differently.

2017-08-25 Thread Ivan Kalvachev
On 8/25/17, Rostislav Pehlivanov wrote: > On 25 August 2017 at 16:38, Ivan Kalvachev wrote: > >> Instead of returning all zeroes as result and Syy=1.0, >> place all the K pulses in the first element y[0] >> and return Syy=K*K. >> >> This is how the original opus function handles the case. >> This

Re: [FFmpeg-devel] [PATCH] opus_pvq_search.asm: Handle zero vector input differently.

2017-08-25 Thread Ivan Kalvachev
On 8/25/17, Rostislav Pehlivanov wrote: > On 25 August 2017 at 16:38, Ivan Kalvachev wrote: > >> Instead of returning all zeroes as result and Syy=1.0, >> place all the K pulses in the first element y[0] >> and return Syy=K*K. >> >> This is how the original opus function handles the case. >> This

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-25 Thread Michael Niedermayer
On Thu, Aug 24, 2017 at 11:10:49PM +0200, pkv.stream wrote: > Thanks a lot Martin !!! all sorted out thanks to your kind help. > I had run fate previously but obviously missed something; so re-run > and it's ok. > > I created two tests per your advice testing for a third channel in a > stereo file

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Steven Liu
2017-08-25 18:14 GMT+08:00 Michael Niedermayer : > Fixes: loop.m3u > > The default max iteration count of 1000 is arbitrary and ideas for a better > solution are welcome > > Found-by: Xiaohei and Wangchu from Alibaba Security Team > Signed-off-by: Michael Niedermayer > --- > libavformat/hls.c |

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-25 Thread Kv Pham
Thanks a lot Michael. (and for spotting the avfree I missed) Le 25 août 2017 11:44 PM, "Michael Niedermayer" a écrit : On Thu, Aug 24, 2017 at 11:10:49PM +0200, pkv.stream wrote: > Thanks a lot Martin !!! all sorted out thanks to your kind help. > I had run fate previously but obviously missed s

[FFmpeg-devel] [PATCH] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
Fixes: loop.m3u The default max iteration count of 1000 is arbitrary and ideas for a better solution are welcome Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- doc/demuxers.texi | 18 ++ libavformat/hls.c | 7 +++ 2 files ch

Re: [FFmpeg-devel] [PATCH] Properly store sampling rate for FLAC in mp4

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 01:25:23PM +0200, Jean-Yves Avenard wrote: > From 9baa7166fa96ed6beac9146c7e3b4dcf425a67d0 Mon Sep 17 00:00:00 2001 > From: Jean-Yves Avenard > Date: Fri, 25 Aug 2017 13:11:28 +0200 > Subject: [PATCH] Properly store sampling rate for FLAC in mp4 > > Fixes ticket #6609 > >

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fix DoS due to infinite loop

2017-08-25 Thread Michael Niedermayer
On Sat, Aug 26, 2017 at 06:49:00AM +0800, Steven Liu wrote: > 2017-08-25 18:14 GMT+08:00 Michael Niedermayer : > > Fixes: loop.m3u > > > > The default max iteration count of 1000 is arbitrary and ideas for a better > > solution are welcome > > > > Found-by: Xiaohei and Wangchu from Alibaba Securit

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 04:20:28PM -0700, Dale Curtis wrote: > Saves ~12kb of binary size and seems like a good use of > CONFIG_SMALL. I've only converted some of the largest > tables in this patch, there's way more to do if this is a > reasonable direction. [...] > -{"dump_separator", "set infor

[FFmpeg-devel] [PATCH] avcodec/snowenc: fix setting motion_est option

2017-08-25 Thread James Almer
Remove usage of FF_MPV_COMMON_OPTS, and set SnowContext.motion_est directly. Based on code from svq1enc.c Signed-off-by: James Almer --- libavcodec/snow.h| 3 ++- libavcodec/snowenc.c | 9 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/snow.h b/libavcodec

Re: [FFmpeg-devel] [PATCH]lavc/put_bits: Remove usage of BITSTREAM_WRITER_LE.

2017-08-25 Thread Ivan Kalvachev
On 8/24/17, Carl Eugen Hoyos wrote: > 2017-08-23 0:56 GMT+02:00 Ivan Kalvachev : >> On 8/22/17, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Mon, Aug 21, 2017 at 11:16 AM, Carl Eugen Hoyos >>> wrote: >>> Hi! Attached patch tries to slightly simplify and clean up the usage of pu

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 11:59:51AM -0700, Dale Curtis wrote: > On Fri, Aug 25, 2017 at 5:43 AM, Michael Niedermayer > wrote: > > > > > This patch breaks: > > http://samples.ffmpeg.org/mov/mp4/discont-frag.mp4 > > > > > Hmm, indeed it does. The reason is that we read the sample count from the > st