[PATCH] staging: iio: ad9832:

Commit a98461d79ba5 ("staging: iio: ad9832: add DVDD regulator") and commit 43a07e48af44 ("staging: iio: ad9832: clean-up regulator 'reg'") add some dereference of 'st' which is an un-initialized pointer at this point. Re-order code and tweak error handling in order to allocate memory and have 'st

Re: [PATCH] staging: iio: ad9832:

On 19/11/16 11:08, Christophe JAILLET wrote: > Commit a98461d79ba5 ("staging: iio: ad9832: add DVDD regulator") and > commit 43a07e48af44 ("staging: iio: ad9832: clean-up regulator 'reg'") add > some dereference of 'st' which is an un-initialized pointer at this point. > > Re-order code and tweak

Re: [PATCH] staging: iio: ad9832:

On Sat, Nov 19, 2016 at 12:08:34PM +0100, Christophe JAILLET wrote: > Commit a98461d79ba5 ("staging: iio: ad9832: add DVDD regulator") and > commit 43a07e48af44 ("staging: iio: ad9832: clean-up regulator 'reg'") add > some dereference of 'st' which is an un-initialized pointer at this point. > > R

Re: [PATCH v4] staging: slicoss: fix different address space warnings

On Fri, Nov 18, 2016 at 06:57:18PM +0100, Sergio Paracuellos wrote: > Remove incorrect __iomem annotation. > > This patch fix the following sparse warnings in slicoss driver: > warning: incorrect type in assignment (different address spaces) > > Signed-off-by: Sergio Paracuellos > --- > drivers

[PATCH 0/3]: staging: speakup: refactor to make room for serial comms changes

Hi, Following set of patches introduces serial_out() method which will point to spk_serial_out() for other drivers and spk_serial_out2() for speakup_dummy. Intention is to allow changing implementation of serial_out() for speakup_dummy while allowing other drivers to continue unaffected. Thanks,

[PATCH 1/3] staging: speakup: add serial_out() method to spk_synth

This does two things: 1. add serial_out() method to spk_synth 2. replace calls to spk_serial_out() in spk_do_catch_up() and spk_synth_flush() with calls to serial_out() spk_do_catch_up() and spk_synth_flush() are the only functions through which speakup_dummy calls into spk_serial_out().

[PATCH 3/3] staging: speakup: initialise serial_out() method in drivers

Initialise serial_out() to spk_serial_out() in all drivers except speakup_dummy which uses spk_serial_out2() instead. Signed-off-by: Okash Khawaja --- drivers/staging/speakup/speakup_acntpc.c | 1 + drivers/staging/speakup/speakup_acntsa.c | 1 + drivers/staging/speakup/speakup_apollo.c | 1 + d

[PATCH 2/3] staging: speakup: add spk_serial_out2()

spk_serial_out2() simply delegates to spk_serial_out() for now. Signed-off-by: Okash Khawaja --- drivers/staging/speakup/serialio.c | 6 ++ drivers/staging/speakup/spk_priv.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/s

Re: [PATCH 0/3]: staging: speakup: refactor to make room for serial comms changes

On Sat, Nov 19, 2016 at 03:43:28PM +, Okash Khawaja wrote: > Hi, > > Following set of patches introduces serial_out() method which will point to > spk_serial_out() for other drivers and spk_serial_out2() for speakup_dummy. What does out2 do differently? That's a horrid name, please make it m

Re: [PATCH 1/3] staging: speakup: add serial_out() method to spk_synth

On Sat, Nov 19, 2016 at 03:46:04PM +, Okash Khawaja wrote: > This does two things: > > 1. add serial_out() method to spk_synth > 2. replace calls to spk_serial_out() in spk_do_catch_up() and > spk_synth_flush() with calls to serial_out() > > spk_do_catch_up() and spk_synth_flush() are t

[PATCH v3 1/4] staging: dgnc: dgnc_tty.c Space preferred around

Make suggested checkpatch modification for CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- v3 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc

[PATCH v3 4/4] staging: dgnc: dgnc_tty.c Spelling corrections

Make spelling corrections for 'transitions' and 'satisfy' Signed-off-by: Walt Feasel --- v2 resubmitted without behaviour v3 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_tty.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/d

[PATCH v3 2/4] staging: dgnc: dgnc_tty.c Align on parenthesis

Make suggested checkpatch modification for CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- v3 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_tty.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a

[PATCH v3 3/4] staging: dgnc: dgnc_tty.c comment style modifications

Make modifications to comment style Signed-off-by: Walt Feasel --- v3 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_tty.c | 229 +++- 1 file changed, 86 insertions(+), 143 deletions(-) diff --git a/drivers/staging/dgnc/

[PATCH v3 0/4] staging: dgnc: dgnc_tty.c checkpatch modifications

Linux kernel coding style modifications for dgnc_tty.c to include: Space perferred around Align on parenthesis Comment style modifications Spelling corrections Walt Feasel (4): staging: dgnc: dgnc_tty.c Space preferred around staging: dgnc: dgnc_tty.c Align on parenthesis staging: dgnc: dgn

[PATCH v2 0/2] staging: dgnc: digi.h checkpatch modifications

Make Linux kernel coding style modificationsvfor digi.h to include: Comment style modifications Spelling correction Walt Feasel (2): staging: dgnc: digi.h Comment style modifications staging: dgnc: digi.h Spelling correction drivers/staging/dgnc/digi.h | 97 ++---

[PATCH v2 1/2] staging: dgnc: digi.h Comment style modifications

Make modifications to comment style Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/digi.h | 95 ++--- 1 file changed, 47 insertions(+), 48 deletions(-) diff --git a/drivers/staging/dgnc/d

[PATCH v2 2/2] staging: dgnc: digi.h Spelling correction

Make spelling correction for 'regular' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/digi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/digi.h b/drivers/staging/dgnc/digi.h index 6b8

[PATCH v2 3/3] staging: speakup: TODO Correct email

Make email correction for k...@reisers.ca Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/TODO b/drivers/staging/speakup/TODO ind

[PATCH v2 2/3] staging: speakup: varhandlers.c Align parenthesis

Make suggested checkpatch modification for CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/varhandlers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driv

[PATCH v2 0/3] staging: speakup: checkpatch modifications

Make Linux kernel style modifications for speakup to include: Comment style modifications Align parenthesis Correct email in TODO Walt Feasel (3): staging: speakup: varhandlers.c Comment style modifications staging: speakup: varhandlers.c Align parenthesis staging: speakup: TODO Correct ema

[PATCH v2 1/3] staging: speakup: varhandlers.c Comment style modifications

Make modifications to comment style Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/varhandlers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/s

[PATCH v2] staging: skein: threefish_block.c Remove blank lines

Make suggested checkpatch modification for CHECK: Please don't use multiple blank lines Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/skein/threefish_block.c | 16 1 file changed, 16 deletions(-) diff --git a/driv

[PATCH v2 0/2] staging: speakup: thread.c checkpatch modifications

Make Linux kernel style modifications for speakup to include comment style modifications align parenthesis Walt Feasel (2): staging: speakup: thread.c Comment modifications staging: speakup: thread.c align on parenthesis drivers/staging/speakup/thread.c | 5 +++-- 1 file changed, 3 insertio

[PATCH v2 1/2] staging: speakup: thread.c Comment modifications

Make comment style modifications Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/thread.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/thread.c b/drivers/staging/speakup/thread.

[PATCH v2 2/2] staging: speakup: thread.c align on parenthesis

Make suggested checkpatch modification for CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH v2 3/5] staging: speakup: synth.c Logical continuation

Make suggested checkpatch modification for CHECK: Logical continuations should be on the previous line Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/synth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

[PATCH v2 4/5] staging: speakup: synth.c Comment modifications

Make modifications to comment style Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/synth.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/syn

[PATCH v2 1/5] staging: speakup: synth.c Spaces around operators

Make suggested checkpatch modification for CHECK: spaces preferred around that '+,|,-,/' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/synth.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/

[PATCH v2 0/5] staging: speakup: synth.c checkpatch modifications

Make Linux kernel coding style modifications for XGI_main_26.c to include: Spaces around operators Blank lines before } Logical continuation Comment modifications Align on parenthesis Walt Feasel (5): staging: speakup: synth.c Spaces around operators staging: speakup: synth.c Blank line befor

[PATCH v2 2/5] staging: speakup: synth.c Blank line before }

Make suggested checkpatch modification for CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/synth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging

[PATCH v2 5/5] staging: speakup: synth.c Align parenthesis

Make suggested checkpatch modification for CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/speakup/synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stag

Re: [PATCH v2 1/5] staging: speakup: synth.c Spaces around operators

Hi Walt, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.9-rc5 next-20161117] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Walt-Feasel/staging-speakup-synth-c-c

[PATCH v2 0/4] staging: speakup: refactor to make room for serial comms changes

Hi, This set of patches introduces serial_out() method which will point to spk_serial_out() for other drivers and spk_serial_out_tty() for speakup_dummy. Intention is to allow changing implementation of serial_out() for speakup_dummy while allowing other drivers to continue unaffected. spk_serial_

[PATCH v2 1/4] staging: speakup: add serial_out() method to spk_synth

This adds serial_out() method to spk_synth struct. Signed-off-by: Okash Khawaja --- drivers/staging/speakup/spk_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h index e8ff5d7..56dc7df 100644 --- a/drivers/stagi

[PATCH v2 2/4] staging: speakup: add spk_serial_out_tty()

spk_serial_out_tty() simply delegates to spk_serial_out() for now. Signed-off-by: Okash Khawaja --- drivers/staging/speakup/serialio.c | 6 ++ drivers/staging/speakup/spk_priv.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speaku

[PATCH v2 3/4] staging: speakup: initialise serial_out() method in drivers

Initialise serial_out() to spk_serial_out() in all drivers except speakup_dummy which uses spk_serial_out_tty() instead. Signed-off-by: Okash Khawaja --- drivers/staging/speakup/speakup_acntpc.c | 1 + drivers/staging/speakup/speakup_acntsa.c | 1 + drivers/staging/speakup/speakup_apollo.c | 1 +

[PATCH v2 4/4] staging: speakup: replace spk_serial_out() calls with serial_out()

This replaces calls to spk_serial_out() in spk_do_catch_up() and spk_synth_flush() with calls to serial_out(). spk_do_catch_up() and spk_synth_flush() are the only functions through which speakup_dummy calls into spk_serial_out(). Calls to spk_serial_out() in other drivers can stay for now. Signe

Re: [PATCH v2 1/5] staging: speakup: synth.c Spaces around operators

Hi Walt, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.9-rc5 next-20161117] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Walt-Feasel/staging-speakup-synth-c-c

[PATCH v3 1/5] staging: speakup: synth.c Spaces around operators

Make suggested checkpatch modification for CHECK: spaces preferred around that '|,+,-,/' Signed-off-by: Walt Feasel --- v3 fixes erroneous w added in v2 drivers/staging/speakup/synth.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/synth.c

Re: [PATCH v2 0/4] staging: speakup: refactor to make room for serial comms changes

Hello, Just looking over the patch, it looks good. I don't think it needs to be split in 4 pieces though, I'd say merge patches 1, 3, and 4 together, where patch 3 would be modified to make dummy use spk_serial_out too, to get a patch which does just one complete thing: make serial_out a method.

Re: [PATCH 0/3]: staging: speakup: refactor to make room for serial comms changes

Hello, Greg KH, on Sat 19 Nov 2016 17:08:09 +0100, wrote: > > Intention is to allow changing implementation of serial_out() for > > speakup_dummy while allowing other drivers to continue unaffected. > > Why is that needed? Why not post the whole series that implements what > you wish to have hap

Re: [PATCH v2 3/3] staging: speakup: TODO Correct email

Walt Feasel writes: > Make email correction for k...@reisers.ca > > Signed-off-by: Walt Feasel Acked-by: Chris Brannon > --- > v2 makes changes to correct for email format patch submission > > drivers/staging/speakup/TODO | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Possible corrupt file or patch

I have a few files that look perfectly fine in nano and gedit but the patch file that gets made shows the columns out of alignment. I have remade them several times to the same effect. I have also made sure that there isnt a tab and space mix. Is this a bug that happens sometimes or do I need to do