On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote:
> The IO configuration was not used to configure the board. It was only
> read from the configuration file. Stop reading it and also remove the
> other related variables defined for it.
>
> Signed-off-by: Sudip Mukherjee
But say so
On Mon, Oct 05, 2015 at 12:46:43PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote:
> > The IO configuration was not used to configure the board. It was only
> > read from the configuration file. Stop reading it and also remove the
> > other related var
This patch changes the parameter names in send_config_pkt function as
the followings:
- u8Mode to mode
- pstrWIDs to wids
- u32WIDsCount to count
- drvHandler to drv
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 41 ++---
drivers/staging/wilc1
This patch removes 4th parameter, bool bRespRequired from the
send_config_pkt function because it is not used inside the funcntion.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_
From: Leo Kim
This patch removes useless local variable, s32Error and returns directly
zero from wilc_wfi_cfgoperations.c and also removes incorrect break in
switch-case statement. The break is not useless which is being called right
after return statement.
Signed-off-by: Leo Kim
Signed-off-by:
From: Leo Kim
This patch renames drvHandler of struct host_if_msg to drv.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 168 +++---
1 file changed, 84 insertions(+), 84 deletions(-)
diff --git a/drivers/staging/wilc1000
From: Leo Kim
This patch removes typedef from the struct tstrWILC_WFIDrv and
rename it to host_if_drv.
This patch includes the removal of the comment for tstrWILC_WFIDrv as well.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 362 +++
From: Leo Kim
This patch removes unused local variables from host_interface.c.
The unused local variable, s32Error is used just to return zero, so this
patch calls "returns 0" instead of "return s32Error" after removing
s32Error.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/stag
This patch changes return type of host_int_set_operation_mode from s32
to int. s32Error gets return value from wilc_mq_send that has return
type of int. It should be changed return type by int as well as data
type of s32Error.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interfa
This patch replaces s32Error with result to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interfa
This patch replaces s32Error with result to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interfa
This patch changes return type of host_int_set_wfi_drv_handler from s32
to int. s32Error gets return value from wilc_mq_send that has return
type of int. It should be changed return type by int as well as data
type of s32Error.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interf
This patch replaces u32address with address to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/host_int
This patch removes multiple blank lines found by checkpatch
CHECK: Please don't use multiple blank lines
FILE: drivers/staging/wilc1000/host_interface.c:5343:
FILE: drivers/staging/wilc1000/host_interface.c:5372:
FILE: drivers/staging/wilc1000/host_interface.c:5389:
Signed-off-by: Chaehyun Lim
-
This patch replaces hWFIDrv with wfi_drv that is first argument of
host_int_set_operation_mode to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-
This patch replaces u32mode with mode that is second argument of
host_int_set_operation_mode to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
This function is defined but never used anywhere,
so just delete it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 43 ---
1 file changed, 43 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000
This function is defined but never used anywhere,
so just delete it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 31 ---
drivers/staging/wilc1000/host_interface.h | 16
2 files changed, 47 deletions(-)
diff --git a/dri
This patch deletes multiple blank lines found by checkpatch
CHECK: Please don't use multiple blank lines
FILE: drivers/staging/wilc1000/host_interface.c:5393:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/sta
This patch changes return type of host_int_remove_wep_key from s32 to
int. s32Error gets return value from wilc_mq_send that has return type
of int. It should be changed return type by int as well as data type of
s32Error.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c
This function is defined but never used anywhere,
so just delete it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 35 ---
drivers/staging/wilc1000/host_interface.h | 25 --
2 files changed, 60 deletions(-)
diff --git
This patch removes multiple blank in host_int_remove_wep_key found by
checkpatch.
CHECK: Please don't use multiple blank lines
FILE: drivers/staging/wilc1000/host_interface.c:4299:
FILE: drivers/staging/wilc1000/host_interface.c:4309:
FILE: drivers/staging/wilc1000/host_interface.c:4315:
Signed-o
This patch remove pstrWFIDrv in host_int_remove_key. There is no need to
make another variable to check if first argument is NULL or not.
It is able to use wfi_drv directly that is first argument of this
function.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 5 ++--
This patch fixes NULL comparison style in host_int_remove_wep_key found
by checkpatch.
CHECK: Comparison to NULL could be written "!wfi_drv"
FILE: drivers/staging/wilc1000/host_interface.c:4300
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 i
This patch replaces u8keyIdx with index that is secondard argument of
host_int_remove_wep_key to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
This patch replaces hWFIDrv with wfi_drv that is first argument of
host_int_remove_wep_key to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
This patch replaces s32Error with result in host_int_remove_wep_key to
avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/
This patch removes unnecessary parentheses in host_int_remove_wep_key
found by checkpatch.
CHECK: Unnecessary parentheses around wfi_drv->hSemTestKeyBlock
FILE: drivers/staging/wilc1000/host_interface.c:4320:
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 fi
On 01/10/15 19:05, H Hartley Sweeten wrote:
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/8255.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255.h
b/drivers/staging/comed
On 01/10/15 19:59, H Hartley Sweeten wrote:
Some minor cleanup to the comedi pcm3724 PC/104 legacy driver.
H Hartley Sweeten (3):
staging: comedi: pcm3724: tidy up multi-line comments
staging: comedi: pcm3724: tidy up register map defines
staging: comedi: pcm3724: update the MODULE_DESC
Use memdup_user to handle OOM.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
abstraction')
Signed-off-by: Olaf Hering
---
drivers/hv/hv_utils_transport.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/hv/hv_utils_transport.c b/drive
Currently hv_fcopy_onchannelcallback is called from interrupts and also
via the ->write function of hv_utils. Since the used global variables to
maintain state are not thread safe the state can get out of sync.
This affects the variable state as well as the channel inbound buffer.
As suggested by
HV_FCOPY is already used as identifier in syslog.
Signed-off-by: Olaf Hering
---
tools/hv/hv_fcopy_daemon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
index f1d7426..fdc9ca4 100644
--- a/tools/hv/hv_fcopy_daemon
Various hyperv changes, based on v4.3-rc4 linux.git
Olaf
Olaf Hering (5):
Drivers: hv: utils: run polling callback always in interrupt context
tools: hv: report ENOSPC errors in hv_fcopy_daemon
tools: hv: remove repeated HV_FCOPY string
Drivers: hv: util: catch allocation errors
Drive
Currently some "Unspecified error 0x80004005" is reported on the Windows
side if something fails. Handle the ENOSPC case and return
ERROR_DISK_FULL, which allows at least Copy-VMFile to report a meaning
full error.
Signed-off-by: Olaf Hering
---
include/uapi/linux/hyperv.h | 1 +
tools/hv/hv_fc
Catch allocation errors in hvutil_transport_send.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
abstraction')
Signed-off-by: Olaf Hering
---
drivers/hv/hv_utils_transport.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/hv/hv_utils_
On 02/10/15 01:23, H Hartley Sweeten wrote:
According to the users manual, the conversion timing (scanrate) is fixed
to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan.
Currently this driver tries to fake other conversion speeds by always
sampling the inputs at 100 kHz and
On 03/10/15 01:30, H Hartley Sweeten wrote:
Encoders are not a "normal" subdevice in comedi. For aesthetics, tidy
up this function and add a couple comments to clarify the function.
Remove the strange munging of the data. The encoder data is decoded
in quadrature and used to increment or decreme
On Monday, October 05, 2015 8:54 AM, Ian Abbott wrote:
> On 02/10/15 01:23, H Hartley Sweeten wrote:
>> According to the users manual, the conversion timing (scanrate) is fixed
>> to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan.
>>
>> Currently this driver tries to fake oth
On 05/10/15 17:17, Hartley Sweeten wrote:
On Monday, October 05, 2015 8:54 AM, Ian Abbott wrote:
On 02/10/15 01:23, H Hartley Sweeten wrote:
According to the users manual, the conversion timing (scanrate) is fixed
to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan.
Curren
Correct errors reported by checkpatch.pl because space prohibited
before ','.
Also split one line into two as it was longer than
80 characters
Signed-off-by: Iban Rodriguez
---
drivers/staging/rtl8188eu/hal/odm.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/driver
This board has 4 digital outputs not 1. Fix the subdevice init.
The digital output lines are used for the external channel selection
when the expansion mode is enabled. Add a comment about this.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/
Following is the cleanup series for the comedi quatech_daqp_cs PCMCIA
driver.
v2: fix patch 08/17 as pointed out by the kbuild test robot
daqp_ai_get_sample() should be static
v3: drop the patch that changed the ai cmd timing (patch 03/17)
rebase the remaining patches and split up the pat
Use the comedi_offset_munge() helper to do the offset binary to two's
complement conversion when writing a new analog output value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 8 +++-
1 file changed, 3 insert
This board has 4 digital inputs not 1. Fix the subdevice init.
The digital input lines are shared with other functions. Add a
comment about this.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 13 -
1 f
Introduce a helper function to get a two's complement sample from
the FIFO and munge it to the offset binary format that comedi uses.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 23 ---
1 file
Introduce a helper function for the common code used to clear any
pending interrupts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 50
1 file changed, 25 insertions(+), 25 deletions(-)
di
Fix the checkpatch.pl issues about:
CHECK: spaces preferred around that '<<' (ctx:VxV)
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/s
The data link between the D/A data port and the D/A converter is a serial
link. The serial link requires about 8ms to complete a transfer. Use the
comedi_timeout() helper to ensure that there is not a previous transfer
still happening before trying to write new data to the channel.
For aesthetics,
For aesthetics, define a macro for the pacer clock options and rename
the CamelCase.
Remove the unnecessary local variables used to set the control register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 28 ++
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 84 +++-
1 file changed, 38 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
For aesthetics, rename the register map defines and convert the
values to hex. Also, move the private data definition and
DAQP_FIFO_SIZE define after the register definitions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp
For aesthetics, move the bit defines for this register and use the
BIT macro to define the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
di
For aesthetics, move the bit defines for this register and use the
BIT macro to define the bits. Rename the defines to match the
register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 39 +++-
For aesthetics, move the bit defines for this register and use the
BIT macro to define the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 23 +--
1 file changed, 13 insertions(+), 10 deleti
For aesthetics, move the bit defines for this register and use the
BIT macro to define the bits. Define a macro for the scanrate bits
and use it to remove the CamelCase. Rename the defines to match the
register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
All the registers are 8-bit except for the analog output and timer
registers. For clarity, add some comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Interrupts are only needed by this driver to support the analog input async
commands. Don't hook up the command support if pcmcia_request_irq() fails
instead of completely failing the (*auto_attach).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
For aesthetics, and use the BIT macro to define the bits and
define some macros for the timer mode and d/a update bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 48
1 file changed, 24
The comedi (*insn_read) functions are supposed to do simple one-shot
reading of an analog input channel. Currently this driver enables
interrupts and uses wait_for_completion_interruptible() to allow the
interrupt routine to let the analog input (*insn_read) know that
the end-of-conversion has occu
The interrupt handler is now only used for the ai async command.
Remove the unnecessary 'interrupt_mode' from the private data and
tidy up the interrupt handler.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 66 +++
The ai (*do_cmd) assumes that either the convert_src is TRIG_TIMER or
the scan_begin_src is TRIG_TIMER and always programs the pacer clock
with the appropriate trigger argument.
Add a Step 2b check to the (*do_cmdtest) to ensure that at least one
of the triggers is TRIG_TIMER.
Signed-off-by: H Ha
This is a PCMCIA driver and interrupts are always shared. Detect if
the hardware did not produce the interrupt and return IRQ_NONE so
that other drivers might handle it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c
Make sure interrupts are disabled and the event flags are cleared when
an analog input async command is canceled.
Remove the unnecessary calls to stop any running conversions in the
(*insn_read) and (*do_cmd) functions. The comedi core will only call
these functions if the subdevice is not busy (i
Step 3 of the (*do_cmdtest) trivially validates the async command arguments.
The validations also modify the arguments if they are invalid so that the
user gets valid values if the test fails.
Reorder the checks so that if any of the checks fail proper values are
used for subsequent checks.
Signe
The pacer will either be used to trigger each conversion or to start each
scan. Modify the (*do_cmdtest) so that one one divisor calculation is needed.
Save the divisor value in the private data so that the (*do_cmd) does not
have to do the calculation again.
Signed-off-by: H Hartley Sweeten
Cc:
On Monday, October 05, 2015 9:12 AM, Ian Abbott wrote:
> On 03/10/15 01:30, H Hartley Sweeten wrote:
>> Encoders are not a "normal" subdevice in comedi. For aesthetics, tidy
>> up this function and add a couple comments to clarify the function.
>>
>> Remove the strange munging of the data. The enco
For aesthetics, use the proper symbol when reading the A/D data register
to get the 16-bit sample data.
Use the comedi_offset_munge() to do the 2's complement to offset binary
munging of the sample data.
Tidy up the function a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah
For aesthetics, add some whitespace to the subdevice init and rearrange
the initialization a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 77
1 file changed, 38 insertions(+), 39 dele
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 54 +++-
1 file changed, 32 insertions(+), 22 deletions(-)
diff --git a/drivers/staging
Cleanup this driver a bit and add support for the 8254 counter/timer.
v2: Fix patch 11/14, Ian Abbott pointed out that the odd munging
of the encoder data does make sense. Add a comment about it.
H Hartley Sweeten (14):
staging: comedi: multiq3: tidy up multi-line comments
staging: comedi
For auesthetics, rename the register map defines. Convert the offset
values to hex and add some whitespace.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 70
1 file changed, 35 insertions(+
For aesthetics, move these defines closer to the register define and
use the BIT macro to define the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --g
Currently this driver resets all the encoder channels when the driver
is first attached. Add a (*insn_config) to the subdevice to allow the
use to reset the channels manually.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c |
According to the programming manual. the 'SH' and 'CLK' bits in the
control register need to be kept high at all times. Clarify this by
introducing a helper function to set the control register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/d
Add some comments to document the commands that are sent to the
encoder chips.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/
For aesthetics, move these defines closer to the register define and
use the BIT macro to define the bits.
Add macros to set the bits needed to select the channel for the analog
output, analog input, and encoder (counter) subdevices as well as the
realtime clock registers.
Signed-off-by: H Hartle
This define is not needed. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/multiq3.c
b/drivers/staging/comedi/drivers/multiq3.c
in
This driver does not use interrupts. Remove the include.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/multiq3.c
b/drivers/s
The board has an 8254 timer/counter. Add support for this subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 147 ++-
1 file changed, 146 insertions(+), 1 deletion(-)
diff --git a/drivers
Encoders are not a "normal" subdevice in comedi. For aesthetics, tidy
up this function and add a couple comments to clarify the function and
explain the strange munging of the data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq
Change the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/multiq3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
Some minor cleanup to fix the checkpatch.pl issues.
H Hartley Sweeten (2):
staging: comedi: pcl818: prefer using the BIT macro
staging: comedi: pcl818: remove unused "boards constants"
drivers/staging/comedi/drivers/pcl818.c | 40 +
1 file changed, 15 insertio
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/driv
These defines are not used. Remove them to get rid of the
checkpatch.pl issue about avoiding CamelCase.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging
Some minor cleanup to fix the checkpatch.pl issues.
H Hartley Sweeten (3):
staging: comedi: pcl816: tidy up multi-line comments
staging: comedi: pcl816: prefer using the BIT macro
staging: comedi: pcl816: remove #if 0'ed out code
drivers/staging/comedi/drivers/pcl816.c | 109 ++
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 38 +++--
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl816.c
b/dr
Remove the #if 0'ed out code that would initialize an analog output
subdevice.
The hardware does not normally support an analog output subdevice.
Analog outputs are only supported with additional "piggyback" modules.
Support for these modules is not included in the driver.
Signed-off-by: H Hartle
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 57 -
1 file changed, 27 insertions(+), 30 deletions(-)
diff --git a/drivers/staging
For aesthetics, convert these defines into an enum and rename the
CamelCase. Fix the switch() code to use the enum without warnings.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 135 ++--
1 file
Some minor cleanup to fix the checkpatch.pl issues.
H Hartley Sweeten (3):
staging: comedi: pcl812: convert hardware type defines into an enum
staging: comedi: pcl812: prefer using the BIT macro
staging: comedi: pcl812: rename private data 'IRQbits'
drivers/staging/comedi/drivers/pcl812.c
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/come
Rename this CamelCase symbol.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 34 -
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/dr
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl711.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl711.c
b/drivers/staging/c
> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Monday, August 31, 2015 7:02 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mpc624.c | 101
1 file changed, 51 insertions(+), 50 deletions(-)
diff --git a/drivers/staging
Fix the checkpatch.pl issues and tidy up this driver a bit.
H Hartley Sweeten (9):
staging: comedi: mpc624: tidy up multi-line comments
staging: comedi: mpc624: tidy up the ai conversion speed code
staging: comedi: mpc624: update MODULE_DESCRIPTION
staging: comedi: mpc624: tidy up subdevic
Rename the CamelCase private data 'ulConvertionRate' and MPC624_SPEED_*
defines.
Create a macro to set the OSR bits that set the ai conversion speed and
use it for the various MPC624_SPEED_* defines. Remove the unnecessary
comment describing the speeds, this information is alread in the comedi
dri
Change the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mpc624.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stag
According to the datasheet, this board has 4 differential analog
input channels not 8. Fix the subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mpc624.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
1 - 100 of 107 matches
Mail list logo
