Hi folks,
I'm reaching out to ask to gather input / consensus on the following
proposal: Since Spark Connect is effectively new code, I would like to
enforce scalafmt explicitly *only* on this module by adding a check in
`dev/lint-scala` that checks if there is a diff after running
./build/mvn -
I personally like this idea. At least we now do this in PySpark, and it's
pretty nice that you can just forget about formatting it manually by
yourself.
On Fri, 14 Oct 2022 at 16:37, Martin Grund
wrote:
> Hi folks,
>
> I'm reaching out to ask to gather input / consensus on the following
> propos
+1, I also think it's a good idea.
BTW, we might also consider adding some notes about `lint-scala` in [1],
just like `lint-python` in pyspark [2].
[1] https://spark.apache.org/developer-tools.html
[2]
https://spark.apache.org/docs/latest/api/python/development/contributing.html
Regards,
Yikun
I have prepared the following pull request that enforces scalafmt on the
Spark Connect module. Please feel free to have a look and leave comments.
If we're reaching consensus on the decision, I will take care of pushing a
PR as well for the previously mentioned website to add a small note on
using
+1
I agree with Jungtaek and Gabor about switching the default value of
configurations with the migration guide.
Dongjoon
On Thu, Oct 13, 2022 at 12:46 AM Gabor Somogyi
wrote:
> Hi Jungtaek,
>
> Good to hear that the new approach is working fine. +1 from my side.
>
> BR,
> G
>
>
> On Thu, Oct
