Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

> On 4/27/23, 1:51 AM, "Ferruh Yigit" mailto:ferruh.yi...@amd.com>> wrote: > > README doesn't say much. > > The usage is not standard, and intention is not clear. > Can you please dig this issue more to learn the the intention, may be we > can find a better way or get rid of them completely? Sur

Re: [PATCH next 0/7] vmxnet3: upgrade to version 7

> On 4/27/23, 2:16 AM, "Ferruh Yigit" > wrote: > > That document focuses on 1G and 10G network speeds, and uses "AMD > Opteron 2384 Processors" (which seems discontinued at this point). > I would expect there is an up to date version of the document, but if > there is

[PATCH v3 next 0/7] net/vmxnet3: upgrade to version 7

HRU as it was specific to vmxnet3 - added new features information in release notes - updated feature related information in vmxnet3 driver documentation Ronak Doshi (7): net/vmxnet3: prepare for version 7 changes net/vmxnet3: add support for capability registers net/vmxnet3: add support for larg

[PATCH v3 next 1/7] net/vmxnet3: prepare for version 7 changes

vmxnet3 is currently at version 6 and this patch initiates the preparation to accommodate changes for up to version 7. Introduced utility macros for vmxnet3 version 7 comparison. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++ 1 file changed

[PATCH v3 next 2/7] net/vmxnet3: add support for capability registers

: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 44 +--- drivers/net/vmxnet3/vmxnet3_ethdev.c| 60 + drivers/net/vmxnet3/vmxnet3_ethdev.h| 11 ++ 3 files changed, 110 insertions(+), 5 deletions

[PATCH v3 next 4/7] net/vmxnet3: add command to set ring buffer sizes

This patch adds a new command to set ring buffer sizes. This is required to pass the buffer size information to passthrough devices. Also, ring sizes are round down to power of 2. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 15

[PATCH v3 next 3/7] net/vmxnet3: add support for large passthrough BAR register

needs to be set by the device. If it is not set then the device will use legacy PT page layout. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 13 +++-- drivers/net/vmxnet3/vmxnet3_ethdev.c| 11 +++ drivers/net/vmxnet3

[PATCH v3 next 5/7] net/vmxnet3: limit number of TXDs used for TSO packet

Currently, vmxnet3 does not have a limit on number of descriptors used for a TSO packet. However, with UPT, for hardware performance reasons, this patch limits the number of transmit descriptors to 24 for a TSO packet. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3

[PATCH v3 next 6/7] net/vmxnet3: avoid updating rxprod register frequently

-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 7bbae4177e..39ad0726cb 100644 --- a/drivers/net

[PATCH v3 next 7/7] net/vmxnet3: update to version 7

With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 7, provided the emulation advertises support for version 7. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- doc/guides/nics/vmxnet3.rst| 30

[PATCH net] net/vmxnet3: fix drop of empty segments in tx

with multiple segments. Fixes: d863f19efa4f ("net/vmxnet3: skip empty segments in transmission") Cc: sta...@dpdk.org Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 33 +++-- 1 file changed, 19 insertions(+), 14

[PATCH next] net/vmxnet3: add interrupt handling for reset

vmxnet3 should call the reset callback when a queue is stopped by the host. This patch also fixes a logging issue. Currently, status of only first queue is checked and logged. But status of all queues should be checked. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net

[PATCH net v2] net/vmxnet3: fix drop of empty segments in tx

with multiple segments. Fixes: d863f19efa4f ("net/vmxnet3: skip empty segments in transmission") Cc: sta...@dpdk.org Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens -- Change log v2: fixed typo --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 33 +++-- 1 file c

Re: [PATCH v2] net/vmxnet3: fix a missing vmxnet3 register command

t3 > > driver yet. This can cause issue for commands added later. > > > > This patch fixes this issue by adding a reserved > > command in its place. > > > > Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers") > > Cc: sta...@dpdk.o

[PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command

fixes this issue by adding a reserved command in its place. Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers") Cc: sta...@dpdk.org Signed-off-by: Ronak Doshi -- Change log v2: fixed typo v3: updated commit message with more information --- drivers/net/vmxnet3/base/vmxn

[PATCH] net/vmxnet3: fix a missing vmxnet3 register command

. This patch fixes this issue by adding a reserved command in its place. Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers") Cc: sta...@dpdk.org Signed-off-by: Ronak Doshi --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH v2] net/vmxnet3: fix a missing vmxnet3 register command

. This patch fixes this issue by adding a reserved command in its place. Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers") Cc: sta...@dpdk.org Signed-off-by: Ronak Doshi -- Change log v2: fixed typo --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 1 + 1 file changed, 1

[PATCH next 0/7] vmxnet3: upgrade to version 7

, the driver can configure emulation to run at vmxnet3 version 7. Ronak Doshi (7): vmxnet3: prepare for version 7 changes vmxnet3: add support for capability registers vmxnet3: add support for large passthrough BAR register vmxnet3: add command to set ring buffer sizes vmxnet3: limit

[PATCH next 2/7] vmxnet3: add support for capability registers

: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 44 +--- drivers/net/vmxnet3/vmxnet3_ethdev.c| 71 + drivers/net/vmxnet3/vmxnet3_ethdev.h| 11 + lib/ethdev/rte_ethdev.h | 2 + 4 files

[PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

This patch adds a new command to set ring buffer sizes. This is required to pass the buffer size information to passthrough devices. Also, ring sizes are round down to power of 2. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 15

[PATCH next 5/7] vmxnet3: limit number of TXDs used for TSO packet

Currently, vmxnet3 does not have a limit on number of descriptors used for a TSO packet. However, with UPT, for hardware performance reasons, this patch limits the number of transmit descriptors to 24 for a TSO packet. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3

[PATCH next 6/7] vmxnet3: avoid updating rxprod register frequently

-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 7bbae4177e..39ad0726cb 100644 --- a/drivers/net

[PATCH next 7/7] vmxnet3: update to version 7

With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 7, provided the emulation advertises support for version 7. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 6

[PATCH next 1/7] vmxnet3: prepare for version 7 changes

vmxnet3 is currently at version 6 and this patch initiates the preparation to accommodate changes for upto version 7. Introduced utility macros for vmxnet3 version 7 comparison. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++ 1 file changed

[PATCH next 3/7] vmxnet3: add support for large passthrough BAR register

needs to be set by the device. If it is not set then the device will use legacy PT page layout. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 13 +++-- drivers/net/vmxnet3/vmxnet3_ethdev.c| 11 +++ drivers/net/vmxnet3

Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

On 4/26/23, 9:58 AM, "Ferruh Yigit" mailto:ferruh.yi...@amd.com>> wrote: > As far as I can see these "vmware_pack_begin.h" & "vmware_pack_end.h" > has only file license comment, and I can see this is used in a few other > type declaration. > > What is the reasoning behind using these headers?

Re: [PATCH next 0/7] vmxnet3: upgrade to version 7

> On 4/26/23, 11:16 AM, "Ferruh Yigit" mailto:ferruh.yi...@amd.com>> wrote: > > btw, while checking the driver documentation, it seems it is not updated > for a while, the paper it refers is old. > Do you have any newer version of documentation to reference? I don’t think we have any other docum

[PATCH v2 next 0/7] net/vmxnet3: upgrade to version 7

in release notes - updated feature related information in vmxnet3 driver documentation Ronak Doshi (7): net/vmxnet3: prepare for version 7 changes net/vmxnet3: add support for capability registers net/vmxnet3: add support for large passthrough BAR register net/vmxnet3: add command to set ring bu

[PATCH v2 next 1/7] net/vmxnet3: prepare for version 7 changes

vmxnet3 is currently at version 6 and this patch initiates the preparation to accommodate changes for up to version 7. Introduced utility macros for vmxnet3 version 7 comparison. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++ 1 file changed

[PATCH v2 next 2/7] net/vmxnet3: add support for capability registers

: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 44 +--- drivers/net/vmxnet3/vmxnet3_ethdev.c| 60 + drivers/net/vmxnet3/vmxnet3_ethdev.h| 11 ++ 3 files changed, 110 insertions(+), 5 deletions

[PATCH v2 next 3/7] net/vmxnet3: add support for large passthrough BAR register

needs to be set by the device. If it is not set then the device will use legacy PT page layout. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 13 +++-- drivers/net/vmxnet3/vmxnet3_ethdev.c| 11 +++ drivers/net/vmxnet3

[PATCH v2 next 5/7] net/vmxnet3: limit number of TXDs used for TSO packet

Currently, vmxnet3 does not have a limit on number of descriptors used for a TSO packet. However, with UPT, for hardware performance reasons, this patch limits the number of transmit descriptors to 24 for a TSO packet. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3

[PATCH v2 next 6/7] net/vmxnet3: avoid updating rxprod register frequently

-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 7bbae4177e..39ad0726cb 100644 --- a/drivers/net

[PATCH v2 next 4/7] net/vmxnet3: add command to set ring buffer sizes

This patch adds a new command to set ring buffer sizes. This is required to pass the buffer size information to passthrough devices. Also, ring sizes are round down to power of 2. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 15

[PATCH v2 next 7/7] net/vmxnet3: update to version 7

With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 7, provided the emulation advertises support for version 7. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- doc/guides/nics/vmxnet3.rst| 26