Hi Andrew,
On Thursday, July 07/01/21, 2021 at 17:50:19 +0300, Andrew Rybchenko wrote:
> On 6/3/21 6:30 PM, Rahul Lakkireddy wrote:
> > Remove queue stats from basic stats because they're now available
> > via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
&g
--
v2:
- Perform explicit checks for NULL in conditions.
- Use rte_strlcpy() instead of strcpy().
Rahul Lakkireddy (2):
net/cxgbe: add support for xstats API
net/cxgbe: remove queue stats from basic stats
drivers/net/cxgbe/cxgbe_ethdev.c | 321 ---
1 file changed
Add support to fetch port and queue stats via xstats API.
Signed-off-by: Rahul Lakkireddy
---
v2:
- Perform explicit checks for NULL in conditions.
- Use rte_strlcpy() instead of strcpy().
drivers/net/cxgbe/cxgbe_ethdev.c | 303 ++-
1 file changed, 294 insertions
Remove queue stats from basic stats because they're now available
via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
Signed-off-by: Rahul Lakkireddy
---
v2:
- No change.
drivers/net/cxgbe/cxgbe_ethdev.c | 18 +++---
1 file changed, 3 insertions(+), 15 dele
be: read firmware configuration file from
filesystem")
Reported-by: Daxue Gao
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c
index
of size 4
sprintf(p[i++], "%d", (int)n);
^
Bugzilla ID: 1029
Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support")
Cc: sta...@dpdk.org
Reported-by: Daxue Gao
Signed-off-by: Rahul Lakkireddy
---
app/test-flo
outb[IPSEC_TEST_PACKETS_MAX];
^~~
Fixes: d02c6bfcb99a ("test/crypto: add ESN and antireplay cases")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
app/test/test_cryptodev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test/test_cry
outb[IPSEC_TEST_PACKETS_MAX];
^~~
Bugzilla ID: 1032
Fixes: d02c6bfcb99a ("test/crypto: add ESN and antireplay cases")
Cc: sta...@dpdk.org
Reported-by: Daxue Gao
Signed-off-by: Rahul Lakkireddy
---
v2:
- Return TEST_FAILED, instead of TEST_SKIPPED
- Add th
On Friday, June 06/10/22, 2022 at 16:45:22 -0700, Stephen Hemminger wrote:
> On Sat, 11 Jun 2022 03:36:43 +0530
> Rahul Lakkireddy wrote:
>
> > Add comma after 1 in 1000 too, like 1,000. Also, since max uint64_t is
> > a 20 digit number, increase space in temporary ar
’ declared here
Reported-by: Ferruh Yigit
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/adapter.h | 2 -
drivers/net/cxgbe/base/t4_hw.c | 83
drivers/net/cxgbe/base/t4vf_hw.c | 28 +++
3 files changed, 49 insertions(+), 64 deletions(-)
diff
Hi Ferruh,
On Monday, January 01/17/22, 2022 at 14:36:30 +, Ferruh Yigit wrote:
> Observed with: gcc (GCC) 12.0.0 20220116 (experimental)
>
> In file included from ../lib/eal/linux/include/rte_os.h:14,
> from ../lib/eal/include/rte_common.h:28,
> from ../lib/
On Thursday, May 05/05/22, 2022 at 17:28:55 +0100, Ferruh Yigit wrote:
> On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote:
> > Rx packets can get dropped at TP due to congestion and this info
> > will not get propagated to MPS. Track these Rx dropped packets
> > in imissed cou
On Thursday, May 05/05/22, 2022 at 17:36:06 +0100, Ferruh Yigit wrote:
> On 5/5/2022 5:29 PM, Ferruh Yigit wrote:
> > On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote:
> > > Add support to read firmware configuration file from
> > > /lib/firmware/cxgb4/ path in the fil
nters. Also add xstats for these
counters.
Signed-off-by: Rahul Lakkireddy
---
v2:
- Update commit message with more info about the TP counters.
drivers/net/cxgbe/base/common.h | 2 ++
drivers/net/cxgbe/base/t4_hw.c | 14 --
drivers/net/cxgbe/base/t4_regs.h | 4
drivers/net/
On Tuesday, May 05/10/22, 2022 at 11:02:05 +0200, Thomas Monjalon wrote:
> 06/05/2022 13:36, Rahul Lakkireddy:
> > The Chelsio FW config file contains a list of register=value pairs to
> > change configuration of the NIC before firmware is initialized.
> > It closely resemble
On Tuesday, May 05/10/22, 2022 at 16:30:59 +0200, Thomas Monjalon wrote:
> 10/05/2022 16:11, Rahul Lakkireddy:
> > On Tuesday, May 05/10/22, 2022 at 11:02:05 +0200, Thomas Monjalon wrote:
> > > 06/05/2022 13:36, Rahul Lakkireddy:
> > > > The Chelsio FW config file con
to redistribute resources, like queues, TCAMs, etc.,
from disabled physical functions (PFs) to main PF, before
firmware init.
Signed-off-by: Rahul Lakkireddy
---
v2:
- Update cxgbe pmd doc about the firmware config file
- Update commit message to explain more about firmware config file
doc
On Monday, May 05/16/22, 2022 at 12:06:01 +0100, Ferruh Yigit wrote:
> On 5/16/2022 11:27 AM, Rahul Lakkireddy wrote:
> > Add support to read firmware configuration file from
> > /lib/firmware/cxgb4/ path in the filesystem. The firmware
> > config file is used to enable or
to redistribute resources, like queues, TCAMs, etc.,
from disabled physical functions (PFs) to main PF, before
firmware init.
Signed-off-by: Rahul Lakkireddy
---
v3:
- Update cxgbe pmd doc about copying t5-config.txt to
/lib/firmware/cxgb4/ directory.
- Update cxgbe pmd doc about firmware
and prevent flooding firmware debug logs with permission
errors.
Fixes: a83041b1e998 ("net/cxgbe: rework and simplify link handling")
Cc: sta...@dpdk.org
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_hw.c | 2 +-
1 file changed, 1 inser
This series of patches add following features.
Patch 1 adds support to fetch port and queue stats via xstats API
for VF.
Patch 2 adds support to get firmware version.
Thanks,
Rahul
Nikhil Vasoya (2):
net/cxgbe: add support for xstats API for the VF
net/cxgbe: add support to get firmware ver
From: Nikhil Vasoya
Add support to fetch port and queue stats via xstats API. Also remove
queue stats from basic stats because they're now available via xstats
API for the VF.
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c
From: Nikhil Vasoya
Implement eth_dev_ops callback to get firmware version.
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c | 26 ++
drivers/net/cxgbe/cxgbe_pfvf.h | 2 ++
drivers/net/cxgbe/cxgbevf_ethdev.c | 1
This series of patches add following features.
Patch 1 adds support to fetch port and queue stats via xstats API
for VF.
Patch 2 adds support to get firmware version.
Thanks,
Rahul
---
v2:
- Update Extended Stats and FW version features in cxgbe.ini and
cxgbevf.ini
Nikhil Vasoya (2):
net/c
From: Nikhil Vasoya
Add support to fetch port and queue stats via xstats API. Also remove
queue stats from basic stats because they're now available via xstats
API for the VF.
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
v2:
- Update Extended Stats feature in cxgbe.in
From: Nikhil Vasoya
Implement eth_dev_ops callback to get firmware version.
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
v2:
- Update FW version feature in cxgbe.ini and cxgbevf.ini
doc/guides/nics/features/cxgbe.ini | 1 +
doc/guides/nics/features/cxgbevf.ini | 1
h Yigit
Looks good. Thanks for fixing it up.
Reviewed-by: Rahul Lakkireddy
re-enabled once the link up event is received in the firmware
event queue.
Signed-off-by: Rahul Lakkireddy
---
doc/guides/nics/cxgbe.rst | 14 +++
drivers/net/cxgbe/base/adapter.h| 4 ++
drivers/net/cxgbe/base/common.h | 1 +
drivers/net/cxgbe/base/t4_hw.
deprecated rte_atomic ops to C11 atomics.
Patch 2 queries firmware for RAW MAC matchall filter support and
enables it when available.
Rahul Lakkireddy (2):
net/cxgbe: use C11 atomics instead of rte_atomic ops
net/cxgbe: add MAC matchall to track promisc traffic
doc/guides/nics/cxgbe.rst
Replace rte_atomic ops with C11 atomics.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_hw.c | 1 -
drivers/net/cxgbe/clip_tbl.c | 13 +++--
drivers/net/cxgbe/clip_tbl.h | 2 +-
drivers/net/cxgbe/cxgbe_ethdev.c | 1 -
drivers/net/cxgbe/cxgbe_main.c | 23
ed/removed when promisc mode is turned on/off
on the interface.
Signed-off-by: Rahul Lakkireddy
---
doc/guides/nics/cxgbe.rst | 14 ++---
drivers/net/cxgbe/base/common.h | 3 +
drivers/net/cxgbe/base/t4fw_interface.h | 2 +
drivers/net/cxgbe/cxgbe_ethdev.c| 14
This series of patches add support to fetch port and queue stats via
xstats API.
Patch 1 adds support to fetch port and queue stats via xstats API.
Patch 2 removes queue stats from basic stats since they're available
via xstats API. Also removes RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
Add support to fetch port and queue stats via xstats API.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c | 302 ++-
1 file changed, 293 insertions(+), 9 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe
Remove queue stats from basic stats because they're now available
via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --
/cxgb4/ to allow changing firmware parameters without
having to flash the configuration file onto the adapter.
Thanks,
Rahul
Rahul Lakkireddy (5):
net/cxgbe: fill correct port info in mbufs for Rx
net/cxgbe: fix Tx queue stuck with mbuf chain coalescing
net/cxgbe: simplify Rx payload buffer
Fill the correct DPDK ethdev port_id, instead of local adapter
physical port_id in mbufs allocated for Rx.
Fixes: 78fc1a716ae8 ("cxgbe: improve Rx performance")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/sge.c | 2 +-
1 file changed, 1 insertion(+),
acket through the normal Tx path.
Also use FW_ETH_TX_PKTS_WR to handle mbufs with chain for FW
to optimize.
Fixes: 6c2809628cd5 ("net/cxgbe: improve latency for slow traffic")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/sge.c | 38 +++---
Match the closest supported Rx payload buffer size with the mempool
data size and program it for the Rx queue. This removes unnecessary
need for handling additional padding, packing, and alignment, when
posting Rx buffers to hardware.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base
Rx packets can get dropped at TP due to congestion and this info
will not get propagated to MPS. Track these Rx dropped packets
in imissed counter. Also add xstats for these counters.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/common.h | 2 ++
drivers/net/cxgbe/base/t4_hw.c
Add support to read firmware configuration file from
/lib/firmware/cxgb4/ path in the filesystem.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4fw_interface.h | 1 +
drivers/net/cxgbe/cxgbe_main.c | 329
2 files changed, 217 insertions(+), 113
On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote:
> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> > Found with clang static analysis:
> > drivers/net/cxgbe/sge.c:900:3: warning:
> > Value stored to 'in_use' is never read
> > in_use += q->size;
> > ^
On Saturday, March 03/25/17, 2017 at 18:14:29 +0530, caihe wrote:
>Hi rahul,
>
>There is a bug without check the return value of alloc memory in function
>t4_wr_mbox_meat_timeout, if we should fix it as below:
>
>diff --git a/drivers/net/cxgbe/base/t4_hw.c
>b/drivers/net/cxgbe
ox_entry entry;
> u32 pcie_fw = 0;
>
>+ if (!temp)
>+ return -ENOMEM;
>+
> if ((size & 15) || size > MBOX_LEN) {
> free(temp);
> return -EINVAL;
>--
>1.8.3.1
Thanks for the fix!
Acked-by: Rahul Lakkireddy
Hi All,
We are seeing Pktgen-DPDK not building on ppc64le with latest dpdk git
repo.
Below build errors are seen:
-
[pktgen-dpdk]# make
== lib
== common
CC l2p.o
In file included from /root/pktgen-dpdk/lib/common/l2p.c:88:0:
/root/pktgen-dpdk/lib/common/l2p.h: In functio
Add code to detect and run T6 devices. Update PCI ID Device table
with Chelsio T6 device ids and update documentation.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
doc/guides/nics/cxgbe.rst | 41 +-
doc/guides/rel_notes
andle direct LSC interrupts.
Thanks,
Rahul
Rahul Lakkireddy (13):
cxgbe: add support to run Chelsio T6 cards
cxgbe: update register dump
cxgbe: update flash part information
cxgbe: grab available ports after firmware reset
cxgbe: update link speeds and port modules
cxgbe: add forward
Add 25G and 100G link speeds and update supported port modules.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/common.h | 4 ++--
drivers/net/cxgbe/base/t4_hw.c | 17 +
drivers/net/cxgbe/base/t4fw_interface.h | 18
Move code to get the available ports from the firmware after it had
been reset. This ensures that driver uses the latest info on available
ports after firmware reset.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/cxgbe_main.c | 36
Add Chelsio T6 registers to register dump.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/t4_hw.c | 567 +
1 file changed, 567 insertions(+)
diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base
Add forward error correction (FEC) support and update link
configuration.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/common.h | 8 +
drivers/net/cxgbe/base/t4_hw.c | 57 ++---
drivers/net/cxgbe/base
Update flash part identification and decoding to accommodate new
flash parts.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/t4_hw.c | 106 +++--
1 file changed, 81 insertions(+), 25 deletions(-)
diff --git a/drivers
Update TX path to reflect Chelsio T6 changes.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/sge.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
index 2f9e12c..699b577
Update informational prints pertaining to underlying hardware.
Add bootstrap firmware version and expansion ROM version prints.
Move the prints to a single function.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/common.h | 6 +-
drivers/net/cxgbe
pointer start address.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/adapter.h| 4 +-
drivers/net/cxgbe/base/common.h | 1 +
drivers/net/cxgbe/base/t4_hw.c | 104 +---
drivers/net/cxgbe/base
Update MPS buffer groups and TP ingress channel congestion map to
correct RXQ allocation for Chelsio T6.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/common.h | 3 +-
drivers/net/cxgbe/base/t4_hw.c | 85
Add support for compressed error vector available in cpl_rx_pkt for
Chelsio T6.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/common.h | 5 +
drivers/net/cxgbe/base/t4_hw.c | 8
drivers/net/cxgbe/base/t4_msg.h | 16
Do not count pause frames as part of normal TX/RX Frame/Byte counts.
Also, switch to using software counters rather than hardware for RX
stats.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/t4_hw.c | 20
drivers/net/cxgbe/base
Remove RTE_PCI_DRV_INTR_LSC from driver flags, since LSC interrupts
are currently not supported.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe
parameters not being applied
to all ports under same PF.
Patch 3 fixes rmb bottleneck in RX path.
Patch 4 adds ability to configure PCIe extended tags.
This series depend on following series:
"cxgbe: add support for Chelsio T6 family of adapters"
Thanks,
Rahul
Rahul Lakkireddy (4
is <= number of packets sent
by tx burst function, stop coalescing and transmit these packets
immediately.
Also added compile time option to favor throughput over latency by
default.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
config/common_b
Enabling rx queues with default interrupt parameters doesn't happen
for other ports under same PF due to FULL_INIT_DONE flag being set
by the first port.
Fix is to to allow each port to enable its own rx queues with default
parameters.
Signed-off-by: Rahul Lakkireddy
Signed-off-by:
rmb before determining rsp_type is a bottleneck.
Once we determine rsp-type is FL, we can directly go ahead and read
packets based on q->stat->pidx and budget_left.
This removes bottleneck of rmb once per every RX packet.
Now, rmb exists once per RX batch.
Signed-off-by: Rahul Lakkireddy
Add support to configure minimum and maximum PCIe extended tag.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/adapter.h | 1 +
drivers/net/cxgbe/base/t4_regs.h | 20
drivers/net/cxgbe/cxgbe_main.c | 31
On Tuesday, May 05/30/17, 2017 at 15:58:56 +0530, Thomas Monjalon wrote:
>27/05/2017 05:46, Rahul Lakkireddy:
>> This series of patches add support for Chelsio T6 family of adapters.
>
>It is almost one year since your last contribution,
>welcome back Rahul :)
Fixup alignment for data offset when refilling mbufs.
Fixes: edd04c619685 ("net/cxgbe: update Rx path for Chelsio T6")
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/sge.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/d
Hi Martin,
On Thursday, June 06/22/17, 2017 at 15:37:27 +0530, Martin Weiser wrote:
>These adapters support 100G link speed but the speed_capa bitmask in the
>device info did not reflect that.
>
>Signed-off-by: Martin Weiser
>---
> drivers/net/cxgbe/cxgbe_ethdev.c | 3 +++
>
Use port type to determine the supported speed capabilities.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
doc/guides/nics/features/cxgbe.ini | 2 +-
drivers/net/cxgbe/cxgbe.h | 1 +
drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
drivers/net/cxgbe/cxgbe_main.c
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/base/t4fw_interface.h | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/net/cxgbe/base/t4fw_interface.h
b/drivers/net/cxgbe/base/t4fw_interface.h
index 6283fe9..6ca4f31
Patch 1 updates supported port module types.
Patch 2 uses port type to determine the supported speed capabilities.
Thanks,
Rahul
Rahul Lakkireddy (2):
cxgbe: update supported port module types
cxgbe: fix supported speed capabilities
doc/guides/nics/features/cxgbe.ini | 2 +-
drivers
Hi,
For netmap_compat bridge application on Power8, in netmap_regif
function, the assignment to nmif->ring_ofs[i] is not getting reflected
immediately.
As a result, the subsequent call to netmap_ring_setup ends up writing
data at wrong offset. This causes segfault in the app.
If we print the nmi
disabled, the app is not hitting the segfault.
Thanks,
Rahul
>Regards,
>Gowrishankar
>On Thursday 06 April 2017 02:34 PM, Rahul Lakkireddy wrote:
>> Hi,
>>
>> For netmap_compat bridge application on Power8, in netmap_regif
>> function, th
Hi Thomas,
On Monday, November 11/30/15, 2015 at 05:43:18 -0800, Thomas Monjalon wrote:
> Hi,
>
> 2015-11-30 18:19, Rahul Lakkireddy:
> > 1. Add a new action 'switch' that will:
> >* Allow re-direction to different ports in hardware.
> >
> >
.name = "rte_cxgbe_pmd",
> .id_table = cxgb4_pci_tbl,
> .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
> --
> 2.1.4
>
Acked-by: Rahul Lakkireddy
ot supported and
hence are not affected.
Posting this series mainly for discussion on API change. Once this is
agreeable then, I will post the cxgbe PMD changes to use the new API.
Rahul Lakkireddy (3):
ethdev: add packet filter flow and new behavior switch to fdir
testpmd: add an example to
for port, mac, vlan, and nat.
Ex: allows to provide new ip and port addresses to rewrite the fields
of packets matching a filter rule before NAT'ing.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
lib/librte_ether/rte_eth_ctrl.h | 112 ++
Extend the existing flow_director_filter to add support for packet
filter flow. Also shows how to pass the extra behavior arguments
to rewrite fields in matched filter rules.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
app/test-pmd/cmdline.c | 435
Current filtering support will be enhanced to accommodate support
for Chelsio T5 hardware filtering support.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
doc/guides/rel_notes/deprecation.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes
Hi Andrey,
On Thursday, December 12/10/15, 2015 at 07:46:42 -0800, Chilikin, Andrey wrote:
> Hi Rahul,
>
> If ABI for fdir is going to be changed should we then take more general
> approach to accommodate other NICs as well? For example, for
> "rte_eth_ipv4_flow" you have "tos" and "proto" fie
check for freelist existence.
Thanks to John McNamara for reporting it.
Coverity issue: 107108
Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support")
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
drivers/net/cxgbe/sge.c | 2 +-
1 file changed, 1
/15, 2015 at 19:31:04 +0530, Rahul Lakkireddy wrote:
> Current filtering support will be enhanced to accommodate support
> for Chelsio T5 hardware filtering support.
>
> Signed-off-by: Rahul Lakkireddy
> Signed-off-by: Kumar Sanghvi
> ---
> doc/guides/rel_notes/deprecatio
Hi Thomas,
On Tuesday, December 12/15/15, 2015 at 00:55:20 -0800, Thomas Monjalon wrote:
> 2015-12-15 14:10, Rahul Lakkireddy:
> > Hi Thomas,
> >
> > I am preparing a v2 of this series where I will be accomodating some
> > more fields to be considered for filteri
Current filtering support will be enhanced to accommodate support
for Chelsio T5 hardware filtering support.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
doc/guides/rel_notes/deprecation.rst | 8
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes
the testpmd example to reflect the above new changes.
6. Dropped Patch 3 since the ABI announcement has already been merged.
Rahul Lakkireddy (2):
ethdev: add packet filter flow and new behavior switch to fdir
testpmd: add an example to show packet filter flow
app/tes
.
Ex: allows to provide new ip and port addresses to rewrite the fields
of packets matching a filter rule before NAT'ing.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
v2:
1. Added ttl to rte_eth_ipv4_flow and tc, flow_label, next_header,
and hop_limit to rte_eth_ipv6
Extend the existing flow_director_filter to add support for packet
filter flow. Also shows how to pass the extra behavior arguments
to rewrite fields in matched filter rules.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Kumar Sanghvi
---
v2:
1. Added new field filter-type to allow specifying
, instead of physical port number.
Fixes: 3a3aaabc7c77 ("net/cxgbe: add control queue to communicate filter
requests")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_main.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/d
number in the outermost TCP/UDP
>header.
>
>- ``port``: New TCP/UDP source port number.
>
> -- ``of_set_tp_dst``: Set a new destination port number in the outermost
> TCP/UDP
> +- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
>header.
>
>- ``port``: New TCP/UDP destination port number.
> --
> 1.8.3.1
>
Good catch!
Acked-by: Rahul Lakkireddy
.
Patch 4 fixes other misc build issues.
Patches are generated against dpdk-next-net tree.
Thanks,
Rahul
Rahul Lakkireddy (4):
net/cxgbe: use relative paths for including header files
net/cxgbe: fix macros related to logs for Windows
net/cxgbe: only redefine symbols when not available for
Explicitly state header file location using relative paths.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/Makefile | 2 --
drivers/net/cxgbe/base/adapter.h | 4 ++--
drivers/net/cxgbe/base/common.h| 2 +-
drivers/net/cxgbe/clip_tbl.c | 2 +-
drivers/net/cxgbe/cxgbe.h
Replace "args..." with "fmt, ..." and directly use __VA_ARGS__.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_compat.h | 40 ++--
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_compat.h
Redefine symbols only when they are not available for Windows
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_hw.c | 4 ++--
drivers/net/cxgbe/base/t4vf_hw.c | 2 +-
drivers/net/cxgbe/cxgbe_compat.h | 29 -
3 files changed, 31 insertions(+), 4
Fix following build errors:
warning: function declaration is incompatible with definition
error : expected an expression
error : expression must be a pointer to a complete object type
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/common.h | 2 +-
drivers/net/cxgbe/cxgbe_compat.h
Patch 1 fixes memory corruption due to overlapping regions in TID table.
Patch 2 fixes NULL pointer dereference when attempting to parse pattern
match items without any spec.
Thanks,
Rahul
Rahul Lakkireddy (2):
net/cxgbe: fix overlapping regions in TID table
net/cxgbe: skip parsing match
Implement logic to reset hit counters for offloaded flows.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_tcb.h | 6
drivers/net/cxgbe/cxgbe_filter.c | 49
drivers/net/cxgbe/cxgbe_filter.h | 2 ++
drivers/net/cxgbe/cxgbe_flow.c | 3
Location of filter TID table should be after active TID table memory,
and not from the beginning of TID table memory. This fixes memory
corruption due to overlapping regions.
Fixes: 3a381a4116ed ("net/cxgbe: query firmware for HASH filter resources")
Cc: sta...@dpdk.org
Signed-off
Skip parsing pattern match items that have no spec. This fixes NULL
dereference when accessing their non-existent spec.
Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_flow.c | 4
1 file
On Tuesday, December 12/18/18, 2018 at 23:55:26 +0530, Ferruh Yigit wrote:
> On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> > Replace "args..." with "fmt, ..." and directly use __VA_ARGS__.
>
> What do you mean exactly by "for Windows"? Which
On Tuesday, December 12/18/18, 2018 at 23:56:22 +0530, Ferruh Yigit wrote:
> On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> > Redefine symbols only when they are not available for Windows
> >
>
> Again "for Windows" is very vague, can you please add more conte
On Tuesday, December 12/18/18, 2018 at 23:53:38 +0530, Ferruh Yigit wrote:
> On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> > Explicitly state header file location using relative paths.
> >
> > Signed-off-by: Rahul Lakkireddy
> > ---
> > drivers/net/cxgbe/Mak
On Wednesday, December 12/19/18, 2018 at 19:15:39 +0530, Ferruh Yigit wrote:
> On 12/19/2018 12:39 PM, Rahul Lakkireddy wrote:
> > On Tuesday, December 12/18/18, 2018 at 23:55:26 +0530, Ferruh Yigit wrote:
> >> On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> >>&g
1 - 100 of 479 matches
Mail list logo