Re: [RFC 1/3] uapi: introduce kernel uAPI headers importation

2024-09-06 Thread Maxime Coquelin
On 9/6/24 08:46, Morten Brørup wrote: From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Friday, 6 September 2024 00.15 This patch introduces uAPI headers importation into the DPDK repository. This import is possible thanks to Linux Kernel licence exception for syscalls: https:/

Re: [RFC 1/3] uapi: introduce kernel uAPI headers importation

2024-09-06 Thread David Marchand
On Fri, Sep 6, 2024 at 12:15 AM Maxime Coquelin wrote: > > This patch introduces uAPI headers importation into the > DPDK repository. This import is possible thanks to Linux > Kernel licence exception for syscalls: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSE

Re: [PATCH 2/2] vhost: add reconnection support to VDUSE

2024-09-06 Thread Chenbo Xia
Hi Maxime, > On Sep 5, 2024, at 22:26, Maxime Coquelin wrote: > > External email: Use caution opening links or attachments > > > This patch enables VDUSE reconnection support making use of > the newly introduced reconnection mechanism in Vhost > library. > > At DPDK VDUSE device creation time

Re: [PATCH v1 1/1] usertools: add DPDK build directory setup script

2024-09-06 Thread fengchengwen
On 2024/9/5 15:29, David Marchand wrote: > On Wed, Sep 4, 2024 at 5:17 PM Anatoly Burakov > wrote: >> >> Currently, the only way to set up a build directory for DPDK development >> is through running Meson directly. This has a number of drawbacks. >> >> For one, the default configuration is very "

RE: [EXTERNAL] Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-09-06 Thread Akhil Goyal
> > > > Here's an idea... > > > > We can introduce a generic design pattern where we keep the _LIST_END enum > value at the end, somehow marking it private (and not part of the API/ABI), > and > move the _list_end() function inside the C file, so it uses the _LIST_END enum > value that the library

Re: [PATCH 2/2] vhost: add reconnection support to VDUSE

2024-09-06 Thread Maxime Coquelin
Hi Chenbo, Thanks for the review! On 9/6/24 09:14, Chenbo Xia wrote: Hi Maxime, On Sep 5, 2024, at 22:26, Maxime Coquelin wrote: External email: Use caution opening links or attachments This patch enables VDUSE reconnection support making use of the newly introduced reconnection mechanism

Re: [PATCH] net/hns3: dump queue head and tail pointer info

2024-09-06 Thread Ferruh Yigit
On 9/5/2024 7:48 AM, Jie Hai wrote: > From: Dengdui Huang > > Add dump the head and tail pointer of RxTx queue. > -- Rx queue head and tail info: > qid sw_head sw_hold hw_head hw_tail > 0288 32 256 320 > 1248 56 192 280 > 2264

RE: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-09-06 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Friday, 6 September 2024 08.33 > > On 2024/9/5 23:09, Morten Brørup wrote: > >> +++ b/app/test/test_cryptodev_asym.c > >> @@ -581,7 +581,7 @@ static inline void print_asym_capa( > >>rte_cryptodev_asym_get_xform_strin

Re: [PATCH] eal: increase max file descriptor for secondary process device

2024-09-06 Thread Ferruh Yigit
On 9/5/2024 5:20 PM, Stephen Hemminger wrote: > The TAP and XDP driver both are limited to only 8 queues when > because of the small limit imposed by EAL. Increase the limit > now since this release allows changing ABI. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/release_24

Re: [PATCH v2] doc: add new driver guidelines

2024-09-06 Thread fengchengwen
On 2024/8/15 3:08, Stephen Hemminger wrote: > From: Nandini Persad > > This document was created to assist contributors in creating DPDK drivers > and provides suggestions and guidelines on how to upstream effectively. > > Co-authored-by: Ferruh Yigit > Co-authored-by: Thomas Monjalon > Signed

RE: [PATCH] net/af_packet: add timestamp offloading support

2024-09-06 Thread Morten Brørup
> From: Stefan Lässer [mailto:stefan.laes...@omicronenergy.com] > Sent: Friday, 6 September 2024 08.23 > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Tuesday, 3 September 2024 18.22 > > > > > > On Tue, 3 Sep 2024 13:43:06 +0200 > > > Stefan Laesser wrote: > > > >

Re: [PATCH v2] doc: add new driver guidelines

2024-09-06 Thread Ferruh Yigit
On 9/6/2024 9:05 AM, fengchengwen wrote: > On 2024/8/15 3:08, Stephen Hemminger wrote: >> From: Nandini Persad >> >> This document was created to assist contributors in creating DPDK drivers >> and provides suggestions and guidelines on how to upstream effectively. >> >> Co-authored-by: Ferruh Yig

RE: [PATCH v1 1/1] usertools: add DPDK build directory setup script

2024-09-06 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Friday, 6 September 2024 09.41 > > On 2024/9/5 15:29, David Marchand wrote: > > On Wed, Sep 4, 2024 at 5:17 PM Anatoly Burakov > > wrote: > >> > >> Enter this script. It relies on Meson's introspection capabilities as well > >> as the

Re: [RFC 1/3] uapi: introduce kernel uAPI headers importation

2024-09-06 Thread Maxime Coquelin
On 9/6/24 09:13, David Marchand wrote: On Fri, Sep 6, 2024 at 12:15 AM Maxime Coquelin wrote: This patch introduces uAPI headers importation into the DPDK repository. This import is possible thanks to Linux Kernel licence exception for syscalls: https://git.kernel.org/pub/scm/linux/kernel/

Re: [RFC 0/2] introduce LLC aware functions

2024-09-06 Thread Burakov, Anatoly
Yes, this does help clarify things a lot as to why current NUMA support would be insufficient to express what you are describing. However, in that case I would echo sentiment others have expressed already as this kind of deep sysfs parsing doesn't seem like it would be in scope for EAL, it sou

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-06 Thread Ferruh Yigit
On 9/5/2024 3:01 PM, Jerin Jacob wrote: > On Thu, Sep 5, 2024 at 3:14 PM Morten Brørup > wrote: >> >>> From: David Marchand [mailto:david.march...@redhat.com] >>> Sent: Thursday, 5 September 2024 11.03 >>> >>> On Thu, Sep 5, 2024 at 10:55 AM Morten Brørup >>> wrote: > From: David Marcha

Re: [PATCH v1 1/1] usertools: add DPDK build directory setup script

2024-09-06 Thread Burakov, Anatoly
On 9/6/2024 10:28 AM, Morten Brørup wrote: From: fengchengwen [mailto:fengcheng...@huawei.com] Sent: Friday, 6 September 2024 09.41 On 2024/9/5 15:29, David Marchand wrote: On Wed, Sep 4, 2024 at 5:17 PM Anatoly Burakov wrote: Enter this script. It relies on Meson's introspection capabilitie

Re: 32-bit virtio failing on DPDK v23.11.1 (and tags)

2024-09-06 Thread Maxime Coquelin
Hello Chris, On 9/3/24 16:43, Chris Brezovec (cbrezove) wrote: Hi Maxime / others, I am just following up to see if you have had any chance to look at what I previously sent and had any ideas regarding the issue. It seems there are not a lot of people testing 32-bits builds with Virtio if it

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-06 Thread Ferruh Yigit
On 9/5/2024 8:58 AM, David Marchand wrote: > On Wed, Sep 4, 2024 at 8:10 PM Stephen Hemminger > wrote: >> >> The API's in ethtool from before 23.11 should be marked stable. > > EAL* ? > >> Should probably include the trace api's but that is more complex change. > > On the trace API itself it sh

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-06 Thread David Marchand
On Fri, Sep 6, 2024 at 11:34 AM Ferruh Yigit wrote: > > On the trace API itself it should be ok. > > The problem is with the tracepoint variables themselves, and I don't > > think we should mark them stable. > > > > We cleaned tracepoint variables from ethdev map file, why they exist for > 'eal'?

Re: 21.11.8 patches review and test

2024-09-06 Thread Kevin Traynor
On 05/09/2024 15:02, Kevin Traynor wrote: > On 05/09/2024 14:29, Ali Alnubani wrote: >>> -Original Message- >>> From: Kevin Traynor >>> Sent: Thursday, September 5, 2024 3:38 PM >>> To: sta...@dpdk.org >>> Cc: dev@dpdk.org; Abhishek Marathe ; Ali >>> Alnubani ; David Christensen ; >>> Hema

RE: [PATCH 0/3] eal: mark API's as stable

2024-09-06 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Friday, 6 September 2024 10.54 > > On 9/5/2024 3:01 PM, Jerin Jacob wrote: > > On Thu, Sep 5, 2024 at 3:14 PM Morten Brørup > wrote: > >> > >>> From: David Marchand [mailto:david.march...@redhat.com] > >>> Sent: Thursday, 5 September 2024

RE: [EXTERNAL] [PATCH] net/virtio-user: reset used index counter in dev reset

2024-09-06 Thread Shiva Shankar Kommula
Hello Maxime, could you please review the following change ? Thanks > Subject: [EXTERNAL] [PATCH] net/virtio-user: reset used index counter in dev > reset > > When the virtio device is reinitialized during ethdev reconfiguration, all the > virtio rings are recreated and repopulated on the devi

[PATCH 0/3] Error report improvement and fix

2024-09-06 Thread Gavin Li
This patch set is to improve error handling in pmd and under layer. Gavin Li (3): net/mlx5: set rte errno if malloc failed net/mlx5/hws: add log for failing to create rule in HWS net/mlx5/hws: print CQE error syndrome and more information drivers/net/mlx5/hws/mlx5dr_rule.c | 6 ++ dri

[PATCH 2/3] net/mlx5/hws: add log for failing to create rule in HWS

2024-09-06 Thread Gavin Li
From: "Minggang Li (Gavin)" Signed-off-by: Gavin Li Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_rule.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 1edb7eac74..5d66d81ea5 100644 --- a/drivers/

[PATCH 1/3] net/mlx5: set rte errno if malloc failed

2024-09-06 Thread Gavin Li
From: "Minggang Li (Gavin)" rte_errno should be set if anything wrong happened in under layer so that user can figure out what's going on. There were some cases that did not set it when ipool allcation failed. To fix the issue, set rte_errno to ENOMEM if mlx5_ipool_malloc failed to allocate ID.

[PATCH 3/3] net/mlx5/hws: print CQE error syndrome and more information

2024-09-06 Thread Gavin Li
From: "Minggang Li (Gavin)" Signed-off-by: Gavin Li Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index 3022c50260..c931896a79 100

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-06 Thread Ferruh Yigit
On 9/6/2024 10:48 AM, David Marchand wrote: > On Fri, Sep 6, 2024 at 11:34 AM Ferruh Yigit wrote: >>> On the trace API itself it should be ok. >>> The problem is with the tracepoint variables themselves, and I don't >>> think we should mark them stable. >>> >> >> We cleaned tracepoint variables fr

Yunsilicon Roadmap for 24.11

2024-09-06 Thread WanRenyong
Hello,  Please find below Yunsilicon roadmap for 24.11.   * Introduce XSC PMD for Yunsilicon metaScale SmartNIC Support Features -- - MTU update - TSO - RSS hash - RSS key update - RSS reta update - L3 checksum offload - L4 checksum offload - Inner L3 checksum - Inner L4 check

Re: Crash in tap pmd when using more than 8 rx queues

2024-09-06 Thread Ferruh Yigit
On 9/5/2024 1:55 PM, Edwin Brossette wrote: > Hello, > > I have recently stumbled into an issue with my DPDK-based application > running the failsafe pmd. This pmd uses a tap device, with which my > application fails to start if more than 8 rx queues are used. This issue > appears to be related to

[RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Anatoly Burakov
While initially, DPDK has used the term "socket ID" to refer to physical package ID, the last time DPDK read "physical_package_id" for socket ID was ~9 years ago, so it's been a while since we've actually switched over to using the term "socket" to mean "NUMA node". This wasn't a problem before, a

[RFC PATCH v1 1/5] eal: update socket ID API documentation

2024-09-06 Thread Anatoly Burakov
Currently, even though through out DPDK we refer to "socket ID's", in actuality we are referring to NUMA node ID's, which do not necessarily correspond to physical sockets. This is not an API change nor a semantics change, it is merely an update of API documentation to match what is already the ca

[RFC PATCH v1 2/5] lcore: rename socket ID to NUMA ID

2024-09-06 Thread Anatoly Burakov
Rename socket ID to NUMA ID in internal lcore structure. This does not change any user facing API's, although it does alter a couple of log messages. In particular, telemetry API and lcore dump API changes have been omitted as there may be consumers of these API that depend on specifics of message

[RFC PATCH v1 3/5] eal: rename socket ID to NUMA ID in internal config

2024-09-06 Thread Anatoly Burakov
This patch renames socket ID-related fields in internal EAL config structure to refer to NUMA ID instead. No user-facing API's are changed. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_dynmem.c | 14 +++--- lib/eal/common/eal_common_options.c | 16 lib/e

[RFC PATCH v1 4/5] eal: rename --socket-mem/--socket-limit

2024-09-06 Thread Anatoly Burakov
Currently, --socket-mem and --socket-limit EAL flags effectively refer to NUMA nodes, not CPU sockets. Update the flag names to reflect this. Old flag names are still supported for backward compatibility. Signed-off-by: Anatoly Burakov --- Notes: Technically, this is a user-facing change and

[RFC PATCH v1 5/5] lcore: store physical package ID internally

2024-09-06 Thread Anatoly Burakov
This patch introduces a new field in the lcore structure that stores the physical package ID of the core. This field is populated during EAL init. It is not exposed through any external API's for now. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_lcore.c | 18 ++ l

RE: [RFC 1/2] eal: add llc aware functions

2024-09-06 Thread Varghese, Vipin
[AMD Official Use Only - AMD Internal Distribution Only] > >Some SOCs may only show upper-level caches here, therefore > > cannot be use blindly without knowing the SOC. > > > > Can you please help us understand > > > > For instance, in Neoverse N1 can disable the use of SLC as LLC (a B

[PATCH 00/19] XSC PMD for Yunsilicon NICs

2024-09-06 Thread WanRenyong
This xsc PMD (**librte_net_xsc**) provides poll mode driver for Yunsilicon metaScale serials NICs. Features: - - MTU update - TSO - RSS hash - RSS key update - RSS reta update - L3 checksum offload - L4 checksum offload - Inner L3 checksum - Inner L4 checksum - Basic stats Support NICs:

[PATCH 02/19] net/xsc: add log macro

2024-09-06 Thread WanRenyong
Add log macro to print runtime messages and trace functions. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_ethdev.c | 11 + drivers/net/xsc/xsc_log.h| 44 2 files changed, 55 insertions(+) create mode 100644 drivers/net/xsc/xsc_log.h diff --

[PATCH 01/19] net/xsc: add doc and minimum build framework

2024-09-06 Thread WanRenyong
Add minimum PMD code, doc and build infrastructure for xsc. Signed-off-by: WanRenyong --- .mailmap | 4 MAINTAINERS | 9 + doc/guides/nics/features/xsc.ini | 9 + doc/guides/nics/index.rst| 1 + doc/guides/nics/xsc.rst

[PATCH 04/19] net/xsc: add xsc device init and uninit

2024-09-06 Thread WanRenyong
XSC device is a concept of low level device used to manage hardware resource and to interact with firmware. Signed-off-by: WanRenyong --- drivers/net/xsc/meson.build | 20 + drivers/net/xsc/xsc_defs.h | 23 + drivers/net/xsc/xsc_dev.c| 162 +++ dr

[PATCH 05/19] net/xsc: add ioctl command interface

2024-09-06 Thread WanRenyong
IOCTL command interface is one of methods used to interact with firmware by PMD. By using ioctl interface, PMD sends command to the kernel module, then the kernel module translates the command and sends it to firmware, at last, the kernel module send back PDM the result from firmware. Signed-off-b

[PATCH 06/19] net/xsc: initialize hardware information

2024-09-06 Thread WanRenyong
Getting hardware information is done by ioctl command, which contains the information of xsc device, as well as the common information of the NIC board. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_dev.c | 63 +++ drivers/net/xsc/xsc_dev.h | 32 ++

[PATCH 03/19] net/xsc: add PCI device probe and remove

2024-09-06 Thread WanRenyong
Support the following Yunsilicon NICs to be probed: - metaScale-200 - metaScale-200S - metaScale-50 - metaScale-100Q Signed-off-by: WanRenyong Signed-off-by: Na Na --- drivers/net/xsc/xsc_defs.h | 12 ++ drivers/net/xsc/xsc_ethdev.c | 74 drivers/net/

[PATCH 09/19] net/xsc: initial representor eth device

2024-09-06 Thread WanRenyong
Initialize xsc eth device private data. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_defs.h | 2 +- drivers/net/xsc/xsc_dev.h| 3 + drivers/net/xsc/xsc_ethdev.c | 64 + drivers/net/xsc/xsc_ethdev.h | 30 ++ drivers/net/xsc/xsc_utils.c | 105 +

[PATCH 10/19] net/xsc: add ethdev configure and rxtx queue setup ops

2024-09-06 Thread WanRenyong
Implement xsc ethdev configure, Rx and Tx queue setup functions. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_ethdev.c | 171 +++ drivers/net/xsc/xsc_ethdev.h | 6 ++ drivers/net/xsc/xsc_rxtx.h | 115 +++ 3 files changed, 292 insertion

[PATCH 08/19] net/xsc: create eth devices for representor ports

2024-09-06 Thread WanRenyong
Each representor port is a rte ethernet device. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_ethdev.c | 87 drivers/net/xsc/xsc_ethdev.h | 1 + 2 files changed, 88 insertions(+) diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c i

[PATCH 07/19] net/xsc: add representor ports probe

2024-09-06 Thread WanRenyong
XSC representor port is designed to store representor resources. In addition to common representor ports, xsc device is a special representor port. Signed-off-by: WanRenyong Signed-off-by: Na Na --- drivers/net/xsc/xsc_defs.h | 24 +++ drivers/net/xsc/xsc_dev.c | 103 +++

[PATCH 11/19] net/xsc: add mailbox and structure

2024-09-06 Thread WanRenyong
Mailbox is a communication channel between driver and firmware. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_ctrl.c | 8 drivers/net/xsc/xsc_ctrl.h | 31 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/xsc/xsc_ctrl.c b/drivers/net/xsc/xs

[PATCH 14/19] net/xsc: add ethdev Rx burst

2024-09-06 Thread WanRenyong
Implement xsc PMD receive function. Signed-off-by: WanRenyong Signed-off-by: Xiaoxiong Zhang --- drivers/net/xsc/xsc_rxtx.c | 189 - drivers/net/xsc/xsc_rxtx.h | 9 ++ 2 files changed, 197 insertions(+), 1 deletion(-) diff --git a/drivers/net/xsc/xsc_rxtx.

[PATCH 13/19] net/xsc: add ethdev start and stop ops

2024-09-06 Thread WanRenyong
Implement xsc ethdev start and stop function. Signed-off-by: WanRenyong Signed-off-by: Rong Qian --- drivers/net/xsc/meson.build | 1 + drivers/net/xsc/xsc_ctrl.h | 152 ++- drivers/net/xsc/xsc_defs.h | 2 + drivers/net/xsc/xsc_dev.h| 3 + drivers/net/xsc/xsc_ethdev.c | 740 +

[PATCH 15/19] net/xsc: add ethdev Tx burst

2024-09-06 Thread WanRenyong
Implement xsc PMD transmit function. Signed-off-by: WanRenyong Signed-off-by: Rong Qian --- doc/guides/nics/features/xsc.ini | 4 + drivers/net/xsc/xsc_rxtx.c | 231 ++- drivers/net/xsc/xsc_rxtx.h | 9 ++ 3 files changed, 242 insertions(+), 2 deletion

[PATCH 12/19] net/xsc: add ethdev RSS hash ops

2024-09-06 Thread WanRenyong
Implement xsc ethdev RSS hash config get and update functions. Signed-off-by: WanRenyong --- doc/guides/nics/features/xsc.ini | 3 +++ drivers/net/xsc/xsc_ctrl.h | 27 drivers/net/xsc/xsc_ethdev.c | 43 +++- drivers/net/xsc/xsc_ethdev.h

[PATCH 17/19] net/xsc: add dev link and MTU ops

2024-09-06 Thread WanRenyong
XSC PMD does not support update link right now, in order to start device successfully link_update function always return 0. Signed-off-by: WanRenyong --- doc/guides/nics/features/xsc.ini | 1 + drivers/net/xsc/xsc_ethdev.c | 50 drivers/net/xsc/xsc_utils.c

[PATCH 18/19] net/xsc: add dev infos get

2024-09-06 Thread WanRenyong
Implement xsc ethdev information get function. Signed-off-by: WanRenyong --- drivers/net/xsc/xsc_ethdev.c | 60 1 file changed, 60 insertions(+) diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c index 54b7e79145..0c8a620d03 100644 ---

[PATCH 19/19] net/xsc: add dev basic stats ops

2024-09-06 Thread WanRenyong
Implement xsc ethdev basic stats get and reset functions. Signed-off-by: WanRenyong --- doc/guides/nics/features/xsc.ini | 1 + drivers/net/xsc/xsc_ethdev.c | 76 drivers/net/xsc/xsc_rxtx.c | 11 - drivers/net/xsc/xsc_rxtx.h | 15 +++ 4 f

[PATCH 16/19] net/xsc: configure xsc device hardware table

2024-09-06 Thread WanRenyong
Configure hardware table to enable transmission and reception of the queues. Signed-off-by: WanRenyong Signed-off-by: Xiaoxiong Zhang --- drivers/net/xsc/meson.build | 1 + drivers/net/xsc/xsc_ctrl.h | 22 + drivers/net/xsc/xsc_ethdev.c | 39 drivers/net/xsc/xsc_flow.c | 1

RE: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Morten Brørup
> From: Anatoly Burakov [mailto:anatoly.bura...@intel.com] > Sent: Friday, 6 September 2024 13.47 > To: dev@dpdk.org > Subject: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK > > While initially, DPDK has used the term "socket ID" to refer to physical > package > ID, the last tim

[PATCH v1 1/3] crypto/ipsec_mb: add SM3 algorithm support

2024-09-06 Thread Brian Dooley
This patch introduces SM3 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 26 - 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/c

[PATCH v1 2/3] crypto/ipsec_mb: add HMAC SM3 algorithm support

2024-09-06 Thread Brian Dooley
This patch introduces HMAC SM3 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 3 +++ drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 24 - 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH v1 3/3] crypto/ipsec_mb: add SM4 algorithm support

2024-09-06 Thread Brian Dooley
This patch introduces SM4 algorithm support to the AESNI_MB PMD. Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 ++ drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 47 + 2 files changed, 69 insertions(+) diff --git a/drivers/crypto/ips

Re: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Burakov, Anatoly
On 9/6/2024 2:37 PM, Morten Brørup wrote: From: Anatoly Burakov [mailto:anatoly.bura...@intel.com] Sent: Friday, 6 September 2024 13.47 To: dev@dpdk.org Subject: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK While initially, DPDK has used the term "socket ID" to refer to physi

RE: [PATCH v2 1/3] app/testpmd: add register keyword

2024-09-06 Thread Varghese, Vipin
[AMD Official Use Only - AMD Internal Distribution Only] > > > >> --- a/app/test-pmd/macswap_sse.h > > > >> +++ b/app/test-pmd/macswap_sse.h > > > >> @@ -16,13 +16,13 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t > nb, > > > >>uint64_t ol_flags; > > > >>int i; > > > >>

RE: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Morten Brørup
> From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Friday, 6 September 2024 14.46 > > On 9/6/2024 2:37 PM, Morten Brørup wrote: > >> From: Anatoly Burakov [mailto:anatoly.bura...@intel.com] > >> Sent: Friday, 6 September 2024 13.47 > >> To: dev@dpdk.org > >> Subject: [RFC PATCH v1

Re: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Bruce Richardson
On Fri, Sep 06, 2024 at 03:02:53PM +0200, Morten Brørup wrote: > > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > > Sent: Friday, 6 September 2024 14.46 > > > > On 9/6/2024 2:37 PM, Morten Brørup wrote: > > >> From: Anatoly Burakov [mailto:anatoly.bura...@intel.com] > > >> Sent: Frida

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-06 Thread Jerin Jacob
On Fri, Sep 6, 2024 at 3:04 PM Ferruh Yigit wrote: > > On 9/5/2024 8:58 AM, David Marchand wrote: > > On Wed, Sep 4, 2024 at 8:10 PM Stephen Hemminger > > wrote: > >> > >> The API's in ethtool from before 23.11 should be marked stable. > > > > EAL* ? > > > >> Should probably include the trace api

[RFCv2 0/6] Stage-Ordered API and other extensions for ring library

2024-09-06 Thread Konstantin Ananyev
From: Konstantin Ananyev v1 -> v2: - dropped - rename 'elmst/objst' to 'meta' (Morten) - introduce new data-path APIs set: one with both meta{} and objs[], second with just objs[] (Morten) - split data-path APIs into burst/bulk flavours (same as rte_ring) - added dump function for te_soring an

[RFCv2 1/6] ring: common functions for 'move head' ops

2024-09-06 Thread Konstantin Ananyev
From: Konstantin Ananyev Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - code deduplication - ability in future to re-use the same code to introduce new functionality For each sync mode corresponding move_prod_head() and mo

[RFCv2 2/6] ring: make copying functions generic

2024-09-06 Thread Konstantin Ananyev
From: Konstantin Ananyev Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - improve code modularity and re-usability - ability in future to re-use the same code to introduce new functionality There is no real need for enqueue_

[RFCv2 3/6] ring: make dump function more verbose

2024-09-06 Thread Konstantin Ananyev
From: Eimear Morrissey The current rte_ring_dump function uses the generic rte_ring_headtail structure to access head/tail positions. This is incorrect for the RTS case where the head is stored in a different offset in the union of structs. Switching to a separate function for each sync type allo

[RFCv2 4/6] ring/soring: introduce Staged Ordered Ring

2024-09-06 Thread Konstantin Ananyev
From: Konstantin Ananyev Staged-Ordered-Ring (SORING) provides a SW abstraction for 'ordered' queues with multiple processing 'stages'. It is based on conventional DPDK rte_ring, re-uses many of its concepts, and even substantial part of its code. It can be viewed as an 'extension' of rte_ring fu

[RFCv2 5/6] app/test: add unit tests for soring API

2024-09-06 Thread Konstantin Ananyev
From: Konstantin Ananyev Add both functional and stess test-cases for soring API. Stress test serves as both functional and performance test of soring enqueue/dequeue/acquire/release operations under high contention (for both over committed and non-over committed scenarios). Signed-off-by: Eimea

[RFCv2 6/6] examples/l3fwd: make ACL work in pipeline and eventdev modes

2024-09-06 Thread Konstantin Ananyev
From: Konstantin Ananyev Note upfront: This is a huge commit that is combined from several ones. For now, I submit it just for reference and demonstration purposes and will probably remove it in future versions. If will decide to go ahead with it, then it needs to be reworked and split into sever

Re: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Burakov, Anatoly
On 9/6/2024 3:07 PM, Bruce Richardson wrote: On Fri, Sep 06, 2024 at 03:02:53PM +0200, Morten Brørup wrote: From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Friday, 6 September 2024 14.46 On 9/6/2024 2:37 PM, Morten Brørup wrote: From: Anatoly Burakov [mailto:anatoly.bura...@int

[RFC PATCH v1 00/12] DTS external DPDK build and stats

2024-09-06 Thread Juraj Linkeš
Add support for externally built DPDK. The supported scenarios are: * DPDK built on remote node * DPDK built locally * DPDK not built anywhere, source tree or tarball on remote node * DPDK not built anywhere, local source tree or tarball Remove multiple build targets per test run. If different bui

[RFC PATCH v1 01/12] dts: rename build target to DPDK build

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- dts/conf.yaml | 2 +- dts/framework/config/__init__.py | 26 ++--- dts/framework/config/conf_yaml_schema.json | 10 +- dts/framework/config/types.py | 4 +- dts/framework/logger.py

[RFC PATCH v1 03/12] dts: fix remote session transferring files

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Fix parameters layout between source and destination according to docs. Signed-off-by: Tomáš Ďurovec --- dts/framework/remote_session/remote_session.py | 14 -- dts/framework/remote_session/ssh_session.py| 8 dts/framework/testbed_model/os_session.

[RFC PATCH v1 02/12] dts: one dpdk build per test run

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- dts/conf.yaml | 14 +-- dts/framework/config/__init__.py | 9 +- dts/framework/config/conf_yaml_schema.json | 10 +- dts/framework/config/types.py | 2 +- dts/framework/logger.py

[RFC PATCH v1 04/12] dts: improve path handling for local and remote paths

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Update remote session to clearly differentiate between local and remote paths. Local paths now accept OS-aware path objects, while remote paths handle OS-agnostic paths. Signed-off-by: Tomáš Ďurovec --- dts/framework/remote_session/remote_session.py | 6 +++--- dts/framewor

[RFC PATCH v1 05/12] dts: add the ability to copy directories via remote

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- dts/framework/testbed_model/os_session.py| 88 +++--- dts/framework/testbed_model/posix_session.py | 93 --- dts/framework/utils.py | 97 ++-- 3 files changed, 246 insertio

[RFC PATCH v1 06/12] dts: add ability to prevent overwriting files/dirs

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- dts/framework/settings.py| 17 ++ dts/framework/testbed_model/os_session.py| 31 +++--- dts/framework/testbed_model/posix_session.py | 33 +--- 3 files changed, 71 insertions(+), 10

[RFC PATCH v1 07/12] dts: update argument option for prevent overwriting

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- doc/guides/tools/dts.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst index 515b15e4d8..059776c888 100644 --- a/doc/guides/tools/dts.rst +++ b/doc/guides/tools/dts.rst @@ -241,6 +241,

[RFC PATCH v1 08/12] dts: add support for externally compiled DPDK

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- dts/conf.yaml| 14 +- dts/framework/config/__init__.py | 87 - dts/framework/config/conf_yaml_schema.json | 41 ++- dts/framework/config/types.py| 17 +- dts/framework/exce

[RFC PATCH v1 09/12] doc: update argument options for external DPDK build

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- doc/guides/tools/dts.rst | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst index 059776c888..8aac22bc60 100644 --- a/doc/guides/tools/dts.rst +++ b/doc/guides/tools

[RFC PATCH v1 10/12] dts: remove git ref option

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- dts/framework/settings.py | 31 -- dts/framework/utils.py| 117 -- 2 files changed, 148 deletions(-) diff --git a/dts/framework/settings.py b/dts/framework/settings.py index 97acd62fd8..d514e8

[RFC PATCH v1 11/12] doc: remove git-ref argument

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- doc/guides/tools/dts.rst | 8 1 file changed, 8 deletions(-) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst index 8aac22bc60..55e9c37c9b 100644 --- a/doc/guides/tools/dts.rst +++ b/doc/guides/tools/dts.rst @@ -236,

[RFC PATCH v1 12/12] dts: improve statistics

2024-09-06 Thread Juraj Linkeš
From: Tomáš Ďurovec Signed-off-by: Tomáš Ďurovec --- dts/framework/runner.py | 5 +- dts/framework/test_result.py | 272 +++ 2 files changed, 187 insertions(+), 90 deletions(-) diff --git a/dts/framework/runner.py b/dts/framework/runner.py index c4ac5db19

[PATCH] eal/x86: fix 32-bit write-combined stores

2024-09-06 Thread Bruce Richardson
The "movdiri" instruction is given as a series of bytes in rte_io.h so that it works on compilers/assemblers which are unaware of the instruction. The REX prefix (0x40) on this instruction is invalid for 32-bit code, causing issues. Thankfully, the prefix is unnecessary in 64-bit code, since the da

[DPDK/ethdev Bug 1536] net/tap: crash in tap pmd when using more than RTE_MP_MAX_FD_NUM rx queues

2024-09-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1536 Bug ID: 1536 Summary: net/tap: crash in tap pmd when using more than RTE_MP_MAX_FD_NUM rx queues Product: DPDK Version: 22.03 Hardware: All OS: All Stat

Re: [PATCH v3 1/1] dts: add methods for modifying MTU to testpmd shell

2024-09-06 Thread Juraj Linkeš
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index ca24b28070..c1462ba2d3 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -888,6 +888,51 @@ def show_port_stats(self, por

RE: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Morten Brørup
> From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Friday, 6 September 2024 15.18 > Subject: Re: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK > > On 9/6/2024 3:07 PM, Bruce Richardson wrote: > > On Fri, Sep 06, 2024 at 03:02:53PM +0200, Morten Brørup wrote: > >

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-06 Thread Ferruh Yigit
On 9/6/2024 2:11 PM, Jerin Jacob wrote: > On Fri, Sep 6, 2024 at 3:04 PM Ferruh Yigit wrote: >> >> On 9/5/2024 8:58 AM, David Marchand wrote: >>> On Wed, Sep 4, 2024 at 8:10 PM Stephen Hemminger >>> wrote: The API's in ethtool from before 23.11 should be marked stable. >>> >>> EAL* ? >>

Re: Crash in tap pmd when using more than 8 rx queues

2024-09-06 Thread Edwin Brossette
Hello, I created a Bugzilla PR, just as you requested: https://bugs.dpdk.org/show_bug.cgi?id=1536 As for the bug resolution, I have other matters to attend to and I'm afraid I cannot spend more time on this issue, so I was only planning to report it. Regards, Edwin Brossette. On Fri, Sep 6, 202

RE: DPDK Summit Montreal - Schedule

2024-09-06 Thread Konstantin Ananyev
> > We will talk about the future of DPDK, the best userland networking > > libraries > > having an incredible hardware support from our large community. > > It will be an opportunity to connect, learn and collaborate with developers > > from around the world who contribute to and utilize DPDK.

[PATCH 2/4] net/ice: fix AVX-512 pointer copy on 32-bit

2024-09-06 Thread Bruce Richardson
The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: a4e480de268e ("net/ice: optimize Tx by using AVX512") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_rxtx_vec

[PATCH 0/4] fix issues with using AVX-512 drivers on 32-bit

2024-09-06 Thread Bruce Richardson
The AVX-512 copy code in multiple drivers was incorrect for 32-bit as it assumed that each pointer was always 8B in size. Bruce Richardson (4): net/i40e: fix AVX-512 pointer copy on 32-bit net/ice: fix AVX-512 pointer copy on 32-bit net/iavf: fix AVX-512 pointer copy on 32-bit common/idpf:

[PATCH 1/4] net/i40e: fix AVX-512 pointer copy on 32-bit

2024-09-06 Thread Bruce Richardson
The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: 5171b4ee6b6b ("net/i40e: optimize Tx by using AVX512") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- drivers/net/i40e/i40e_rxtx_

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-06 Thread Ferruh Yigit
On 9/6/2024 11:04 AM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Friday, 6 September 2024 10.54 >> >> On 9/5/2024 3:01 PM, Jerin Jacob wrote: >>> On Thu, Sep 5, 2024 at 3:14 PM Morten Brørup >> wrote: > From: David Marchand [mailto:david.march...@red

[PATCH 3/4] net/iavf: fix AVX-512 pointer copy on 32-bit

2024-09-06 Thread Bruce Richardson
The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- drivers/net/iavf/iavf_rxtx_vec_avx

[PATCH 4/4] common/idpf: fix AVX-512 pointer copy on 32-bit

2024-09-06 Thread Bruce Richardson
The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: 5bf87b45b2c8 ("net/idpf: add AVX512 data path for single queue model") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- drivers/com

  1   2   >