Re: [PATCH v2 1/4] power: refactor core power management library

Hi Sivaprasa, Some comments inline. /Huisong 在 2024/8/26 21:06, Sivaprasad Tummala 写道: This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/

RE: Bihash Support in DPDK

Hi Rajesh, Please clarify what do you mean by “bihash”? Bidirectional? Bounded index? As for concurrent lookup/updates, yes, DPDK hash table supports multi-process/multi-thread, please see the documentation: https://doc.dpdk.org/guides/prog_guide/hash_lib.html#multi-process-support From: rajes

[DPDK/DTS Bug 1528] Port MTU update test suite to DTS

https://bugs.dpdk.org/show_bug.cgi?id=1528 Bug ID: 1528 Summary: Port MTU update test suite to DTS Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Pr

Re: [PATCH v3 01/12] net/ice: use correct format specifiers for unsigned ints

On Fri, Aug 23, 2024 at 09:56:39AM +, Soumyadeep Hore wrote: > From: Yogesh Bhosale > > Firmware was giving a number for the MSIX vectors that was > way too big and obviously not right. Because of the wrong > format specifier, this big number ended up looking like a > tiny negative number in

Re: [PATCH] net/mana: support building the driver on arm64

On 8/26/2024 11:38 PM, lon...@linuxonhyperv.com wrote: > From: Long Li > > The driver has been verified on Linux arm64. Enable this build option and > add a missing header file for arm64. > > Signed-off-by: Long Li > Hi Long, I don't see this patch in the mail list and patchwork, it can be be

[PATCH] net/mana: support building the driver on arm64

From: Long Li The driver has been verified on Linux arm64. Enable this build option and add a missing header file for arm64. Signed-off-by: Long Li --- drivers/net/mana/meson.build | 4 ++-- drivers/net/mana/mp.c| 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/driv

Re: Bihash Support in DPDK

Hi All, Can we get some reply. Thanks Rajesh On Thu, Aug 22, 2024 at 9:32 PM Ferruh Yigit wrote: > On 8/22/2024 8:51 AM, rajesh goel wrote: > > Hi All, > > Need info if DPDK hash library supports bihash table where for multi- > > thread and multi-process we can update/del/lookup entries per buc

Re: [PATCH] net/mana: support building the driver on arm64

Hello, On Tue, Aug 27, 2024 at 12:01 PM Ferruh Yigit wrote: > > On 8/26/2024 11:38 PM, lon...@linuxonhyperv.com wrote: > > From: Long Li > > > > The driver has been verified on Linux arm64. Enable this build option and > > add a missing header file for arm64. > > > > Signed-off-by: Long Li > >

Re: [PATCH v2 2/4] power: refactor uncore power management library

Hi Sivaprasad, Suggest to split this patch into two patches for easiler to review: patch-1: abstract a file for uncore dvfs core level, namely, the rte_power_uncore_ops.c you did. patch-2: move and rename, lib/power/power_intel_uncore.c => drivers/power/intel_uncore/intel_uncore.c patch[1/4]

Re: [PATCH v3] net/gve: add support for TSO in DQO RDA

On 8/27/2024 4:11 AM, Rushil Gupta wrote: > On Fri, Aug 9, 2024 at 11:49 AM Tathagat Priyadarshi > wrote: >> >> The patch intends on adding support for TSO in DQO RDA format. >> >> Signed-off-by: Tathagat Priyadarshi >> Signed-off-by: Varun Lakkur Ambaji Rao > > Acked-by: Rushil Gupta > Appli

Re: [PATCH] net/mana: support building the driver on arm64

On 8/26/2024 11:38 PM, lon...@linuxonhyperv.com wrote: > From: Long Li > > The driver has been verified on Linux arm64. Enable this build option and > add a missing header file for arm64. > > Signed-off-by: Long Li > Applied to dpdk-next-net/main, thanks.

[RFC 0/2] introduce LLC aware functions

As core density continues to increase, chiplet-based core packing has become a key trend. In AMD SoC EPYC architectures, core complexes within the same chiplet share a Last-Level Cache (LLC). By packing logical cores within the same LLC, we can enhance pipeline processing stages due to reduced late

[RFC 1/2] eal: add llc aware functions

Introduce lcore functions which operates on Last Level Cache for core complexes or chiplet cores. On non chiplet core complexes, the function will iterate over all the available dpdk lcores. Functions added: - rte_get_llc_first_lcores - rte_get_llc_lcore - rte_get_llc_n_lcore Signed-off-by: Vi

[RFC 2/2] eal/lcore: add llc aware for each macro

add RTE_LCORE_FOREACH for dpdk lcore sharing the Last Level Cache. For core complexes with shared LLC, the macro iterates for same llc lcores. For cores within single LLC, the macro iterates over all availble lcores. MACRO added: - RTE_LCORE_FOREACH_LLC_FIRST - RTE_LCORE_FOREACH_LLC_FIRST_WORKER

Re: [PATCH v2 1/3] app/testpmd: add register keyword

On 8/21/2024 8:25 PM, Stephen Hemminger wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Wed, 21 Aug 2024 20:08:55 +0530 Vipin Varghese wrote: diff --git a/app/test-pmd/macswap_sse.h b/app/test-p

[PATCH v3 0/9] riscv: implement accelerated crc using zbc

The RISC-V Zbc extension adds instructions for carry-less multiplication we can use to implement CRC in hardware. This patch set contains two new implementations: - one in lib/hash/rte_crc_riscv64.h that uses a Barrett reduction to implement the four rte_hash_crc_* functions - one in lib/net/net

[PATCH v3 1/9] config/riscv: detect presence of Zbc extension

The RISC-V Zbc extension adds carry-less multiply instructions we can use to implement more efficient CRC hashing algorithms. The RISC-V C api defines architecture extension test macros https://github.com/riscv-non-isa/riscv-c-api-doc/blob/main/riscv-c-api.md#architecture-extension-test-macros The

[PATCH v3 2/9] hash: implement CRC using riscv carryless multiply

Using carryless multiply instructions from RISC-V's Zbc extension, implement a Barrett reduction that calculates CRC-32C checksums. Based on the approach described by Intel's whitepaper on "Fast CRC Computation for Generic Polynomials Using PCLMULQDQ Instruction", which is also described here (htt

[PATCH v3 3/9] net: implement CRC using riscv carryless multiply

Using carryless multiply instructions (clmul) from RISC-V's Zbc extension, implement CRC-32 and CRC-16 calculations on buffers. Based on the approach described in Intel's whitepaper on "Fast CRC Computation for Generic Polynomails Using PCLMULQDQ Instructions", we perform repeated folds-by-1 whils

[PATCH v3 4/9] config/riscv: add qemu crossbuild target

A new cross-compilation target that has extensions that DPDK uses and QEMU supports. Initially, this is just the Zbc extension for hardware CRC support. Signed-off-by: Daniel Gregory --- config/riscv/meson.build| 3 ++- config/riscv/riscv64_qemu_linux_gcc | 1

[PATCH v3 5/9] examples/l3fwd: use accelerated CRC on riscv

When the RISC-V Zbc (carryless multiplication) extension is present, an implementation of CRC hashing using hardware instructions is available. Use it rather than jhash. Signed-off-by: Daniel Gregory --- examples/l3fwd/l3fwd_em.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 6/9] ipfrag: use accelerated CRC on riscv

When the RISC-V Zbc (carryless multiplication) extension is present, an implementation of CRC hashing using hardware instructions is available. Use it rather than jhash. Signed-off-by: Daniel Gregory --- lib/ip_frag/ip_frag_internal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v3 8/9] hash/cuckoo: use accelerated CRC on riscv

When the RISC-V Zbc (carryless multiplication) extension is present, an implementation of CRC hashing using hardware instructions is available. Use it rather than jhash. Signed-off-by: Daniel Gregory --- lib/hash/rte_cuckoo_hash.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/hash/r

[PATCH v3 7/9] examples/l3fwd-power: use accelerated CRC on riscv

When the RISC-V Zbc (carryless multiplication) extension is present, an implementation of CRC hashing using hardware instructions is available. Use it rather than jhash. Signed-off-by: Daniel Gregory --- examples/l3fwd-power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v3 9/9] member: use accelerated CRC on riscv

When the RISC-V Zbc (carryless multiplication) extension is present, an implementation of CRC hashing using hardware instructions is available. Use it rather than jhash. Signed-off-by: Daniel Gregory --- lib/member/rte_member.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH v3 01/12] dts: fix default device error handling mode

On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > The device_error_handling_mode of testpmd port may not be present, e.g. > in VM ports. > > Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 02/12] dts: add the aenum dependency

On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > Regular Python enumerations create only one instance for members with > the same value, such as: > class MyEnum(Enum): > foo = 1 > bar = 1 > > MyEnum.foo and MyEnum.bar are aliases that return the same instance. > > DTS needs to retur

Re: [PATCH v3 08/12] dts: add NIC capability support

On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > diff --git a/dts/framework/testbed_model/capability.py > b/dts/framework/testbed_model/capability.py > index 8899f07f76..9a79e6ebb3 100644 > --- a/dts/framework/testbed_model/capability.py > +++ b/dts/framework/testbed_model/capability.py >

[PATCH v8 0/1] dts: add second scatter test case

From: Jeremy Spewock v8: * update test suite to use newly submitted capabilities series * split the MTU update patch into its own series. * now that the --max-pkt-len bug is fixed on mlx in 24.07, no longer need to set MTU directly so this is also removed. Jeremy Spewock (1): dts: ad

[PATCH v8 1/1] dts: add test case that utilizes offload to pmd_buffer_scatter

From: Jeremy Spewock Some NICs tested in DPDK allow for the scattering of packets without an offload and others enforce that you enable the scattered_rx offload in testpmd. The current version of the suite for testing support of scattering packets only tests the case where the NIC supports testin

Re: [RFC 1/2] eal: add llc aware functions

On Tue, 27 Aug 2024 20:40:13 +0530 Vipin Varghese wrote: > + "ls -d /sys/bus/cpu/devices/cpu%u/cache/index[0-9] | sort -r > | grep -m1 index[0-9] | awk -F '[x]' '{print $2}' " NAK Running shell commands from EAL is non-portable and likely to be flagged by security scanning tools.

Re: [PATCH v2 1/3] app/testpmd: add register keyword

On Tue, 27 Aug 2024 21:02:00 +0530 "Varghese, Vipin" wrote: > On 8/21/2024 8:25 PM, Stephen Hemminger wrote: > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > On Wed, 21 Aug 2024 20:08:55 +053

RE: [PATCH v8 2/3] eventdev: add support for independent enqueue

Hi Mattias, I will update patch tomorrow with updated suggestion from Pravin, If I don’t hear from you I guess you are okay?

Re: [PATCH v3 01/12] dts: fix default device error handling mode

On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > > The device_error_handling_mode of testpmd port may not be present, e.g. > in VM ports. > > Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") > > Signed-off-by: Juraj Linkeš > --- Reviewed-by: Nicholas Pratte

Re: [PATCH v3 02/12] dts: add the aenum dependency

On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > > Regular Python enumerations create only one instance for members with > the same value, such as: > class MyEnum(Enum): > foo = 1 > bar = 1 > > MyEnum.foo and MyEnum.bar are aliases that return the same instance. > > DTS needs to retu

RE: [RFC 1/2] eal: add llc aware functions

> -unsigned int rte_get_next_lcore(unsigned int i, int skip_main, int wrap) > +#define LCORE_GET_LLC \ > + "ls -d /sys/bus/cpu/devices/cpu%u/cache/index[0-9] | sort -r > | grep -m1 index[0-9] | awk -F '[x]' '{print $2}' " > This won't work for some SOCs. How to ensure the index yo

Re: [RFC 0/2] introduce LLC aware functions

On 2024-08-27 17:10, Vipin Varghese wrote: As core density continues to increase, chiplet-based core packing has become a key trend. In AMD SoC EPYC architectures, core complexes within the same chiplet share a Last-Level Cache (LLC). By packing logical cores within the same LLC, we can enhance p

[PATCH v2 0/1] bbdev: removing unnecessaray symbols

v2: Actually several functions can be removed from bbdev version map since they are inline and hence ABI versionning is not relevant. I checked with other lib (cryptodev/ethdev) and the same guideline is followed, with inline functions not part of version.map. Similarly the script as part of CICD d

[PATCH v2 1/1] bbdev: removing unnecessaray symbols from version map

A number of inline functions should not be in the version map since ABI versionning would be irrelevant. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.h| 1 - lib/bbdev/rte_bbdev_op.h | 2 -- lib/bbdev/version.map| 24 +--- 3 files changed, 1 insertion(+),

[PATCH v3 1/1] bbdev: removing unnecessary symbols from version map

A number of inline functions should not be in the version map since ABI versioning would be irrelevant. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.h| 1 - lib/bbdev/rte_bbdev_op.h | 2 -- lib/bbdev/version.map| 24 +--- 3 files changed, 1 insertion(+), 2

[PATCH v3 0/1] bbdev: removing unnecessaray symbols

v3: typo fixes. v2: Actually several functions can be removed from bbdev version map since they are inline and hence ABI versionning is not relevant. I checked with other lib (cryptodev/ethdev) and the same guideline is followed, with inline functions not part of version.map. Similarly the script

RE: [PATCH] net/mana: support building the driver on arm64

> > Hi Long, > > > > I don't see this patch in the mail list and patchwork, it can be > > because of the email address it has been sent, fyi. > > The mail was waiting in the moderation queue. > Long, please fix your send-email setup, or send with a mail address registered > to the dev@ ml. I thin

[PATCH] net/ice: support for more flexible loading of DDP package

The "Dynamic Device Personalization" package is loaded at initialization time by the driver, but the specific package file loaded depends upon what package file is found first by searching through a hard-coded list of firmware paths. To enable greater control over the package loading, this commit

[PATCH] net/ice: support for more flexible loading of DDP package

The "Dynamic Device Personalization" package is loaded at initialization time by the driver, but the specific package file loaded depends upon what package file is found first by searching through a hard-coded list of firmware paths. To enable greater control over the package loading, this commit

Re: [PATCH] net/mana: support building the driver on arm64

On Wed, Aug 28, 2024 at 1:59 AM Long Li wrote: > > The mail was waiting in the moderation queue. > > Long, please fix your send-email setup, or send with a mail address > > registered > > to the dev@ ml. > > I think the patch has made it to patchwork: > https://patchwork.dpdk.org/project/dpdk/pat

Re: Bihash Support in DPDK

Thanks for the reply. Bihash I mean bounded index what Vpp supports. Iam looking for the bucket level lock support. Currently Iam using hash table shared by multiple process or multiple core/threads. So I have to take the write lock by single core and then read lock by multiple cores to read the