RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-26 Thread Morten Brørup
Interesting requirement. I can easily imagine how a (non-forwarding, i.e. traffic terminating) application, which doesn’t really care about the preceding headers, can benefit from having its actual data at a specific offset for alignment purposes. I don’t consider this very exotic. (Even the Lin

[DPDK/examples Bug 1398] [dpdk-24.03] ptpclient causes NIC I225/I226 port RX missed

2024-03-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1398 tingtingx.l...@intel.com (tingtingx.l...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

RE: [PATCH 0/2] introduce PM QoS interface

2024-03-26 Thread Morten Brørup
> From: lihuisong (C) [mailto:lihuis...@huawei.com] > Sent: Tuesday, 26 March 2024 03.12 > > 在 2024/3/22 20:35, Morten Brørup 写道: > >> From: lihuisong (C) [mailto:lihuis...@huawei.com] > >> Sent: Friday, 22 March 2024 09.54 [...] > >> For the case need PM QoS in DPDK, I think, it is better to se

RE: release candidate 24.03-rc3

2024-03-26 Thread Xu, HailinX
> -Original Message- > From: Thomas Monjalon > Sent: Monday, March 18, 2024 11:46 AM > To: annou...@dpdk.org > Subject: release candidate 24.03-rc3 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v24.03-rc3 > > There are 153 new patches in

RE: [PATCH v13 01/11] windows: make getopt functions have const properties

2024-03-26 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 26 March 2024 02.57 > > Having different prototypes on different platforms can lead > to lots of unnecessary workarounds. Looks like the version of > getopt used from windows was based on an older out of date > version

[PATCH] doc: add tested AMD platforms

2024-03-26 Thread Ferruh Yigit
Add tested AMD platforms to v24.03 release note. Signed-off-by: Ferruh Yigit --- Cc: vipin.vargh...@amd.com Cc: sivaprasad.tumm...@amd.com Cc: keesang.s...@amd.com --- doc/guides/rel_notes/release_24_03.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/rel_note

RE: [PATCH 1/2] eal: provide macro for GCC builtin constant intrinsic

2024-03-26 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 20 March 2024 22.34 > > MSVC does not have a __builtin_constant_p intrinsic so provide > __rte_constant(e) that expands false for MSVC and to the intrinsic for > GCC. > > Signed-off-by: Tyler Retzlaff > --- Reviewed

RE: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

2024-03-26 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 20 March 2024 22.34 > > Use newly introduced __rte_constant(e) macro instead of directly using > __builtin_constant_p() allowing mempool to be built by MSVC. > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Mort

RE: [PATCH v7 1/4] net/i40e: use inline prefetch function

2024-03-26 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 20 March 2024 23.02 > > Don't directly access the cacheline1 field in rte_mbuf struct for > prefetch instead just use rte_mbuf_prefetch_part2() to prefetch. > > Signed-off-by: Tyler Retzlaff > --- > drivers/net/i40e

RE: [PATCH v7 3/4] security: remove rte marker fields

2024-03-26 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 20 March 2024 23.02 > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 a

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-26 Thread Thomas Monjalon
26/03/2024 02:42, lihuisong (C): > > 在 2024/3/25 17:30, Thomas Monjalon 写道: > > 25/03/2024 07:24, huangdengdui: > >> On 2024/3/22 21:58, Thomas Monjalon wrote: > >>> 22/03/2024 08:09, Dengdui Huang: > -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8) /**< 10 Gbps */ > -#define RTE_ETH_LI

RE: [PATCH v7 4/4] cryptodev: remove rte marker fields

2024-03-26 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 20 March 2024 23.02 > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 a

Re: [PATCH] doc: add tested AMD platforms

2024-03-26 Thread Thomas Monjalon
26/03/2024 10:46, Ferruh Yigit: > Add tested AMD platforms to v24.03 release note. > > Signed-off-by: Ferruh Yigit Applied, thanks.

RE: [PATCH v7 2/4] mbuf: remove rte marker fields

2024-03-26 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 20 March 2024 23.02 > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 a

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-26 Thread lihuisong (C)
在 2024/3/26 18:30, Thomas Monjalon 写道: 26/03/2024 02:42, lihuisong (C): 在 2024/3/25 17:30, Thomas Monjalon 写道: 25/03/2024 07:24, huangdengdui: On 2024/3/22 21:58, Thomas Monjalon wrote: 22/03/2024 08:09, Dengdui Huang: -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8) /**< 10 Gbps */ -#def

Re: [PATCH 0/2] introduce PM QoS interface

2024-03-26 Thread lihuisong (C)
在 2024/3/26 16:27, Morten Brørup 写道: From: lihuisong (C) [mailto:lihuis...@huawei.com] Sent: Tuesday, 26 March 2024 03.12 在 2024/3/22 20:35, Morten Brørup 写道: From: lihuisong (C) [mailto:lihuis...@huawei.com] Sent: Friday, 22 March 2024 09.54 [...] For the case need PM QoS in DPDK, I think

RE: [PATCH 0/2] introduce PM QoS interface

2024-03-26 Thread Morten Brørup
> From: lihuisong (C) [mailto:lihuis...@huawei.com] > Sent: Tuesday, 26 March 2024 13.15 > > 在 2024/3/26 16:27, Morten Brørup 写道: > >> From: lihuisong (C) [mailto:lihuis...@huawei.com] > >> Sent: Tuesday, 26 March 2024 03.12 > >> > >> 在 2024/3/22 20:35, Morten Brørup 写道: > From: lihuisong (C)

Re: [PATCH] graph: avoid id collisions

2024-03-26 Thread Jerin Jacob
On Mon, Mar 25, 2024 at 9:24 PM Robin Jarry wrote: > > The graph id is determined based on a global variable that is > incremented every time a graph is created, and decremented every time > a graph is destroyed. This only works if graphs are destroyed in the > reverse order in which they have bee

[PATCH v7 00/14] fix lcore ID restriction

2024-03-26 Thread Sivaprasad Tummala
With modern CPUs, it is possible to have higher CPU count thus we can have higher RTE_MAX_LCORES. In DPDK sample applications, the current config lcore options are hard limited to 255. The patchset fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Also the rx queue IDs are in

[PATCH v7 01/14] examples/l3fwd: fix queue ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently application supports rx queue IDs up to 255 and max queues of 256 irrespective of device support. This limits the number of active lcores to 256. The patch fixes these constraints by increasing the rx queue IDs to support up to 65535. Fixes: af75078fece3 ("first public release") Cc: sta

[PATCH v7 02/14] examples/l3fwd-power: fix queue ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently application supports rx queue IDs up to 255 and max queues of 256 irrespective of device support. This limits the number of active lcores to 256. The patch fixes these constraints by increasing the rx queue IDs to support up to 65535. Fixes: f88e7c175a68 ("examples/l3fwd-power: add high

[PATCH v7 03/14] examples/l3fwd-graph: fix queue ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently application supports rx queue IDs up to 255 and max queues of 256 irrespective of device support. This limits the number of active lcores to 256. The patch fixes these constraints by increasing the rx queue IDs to support up to 65535. Fixes: 08bd1a174461 ("examples/l3fwd-graph: add grap

[PATCH v7 04/14] examples/ipsec-secgw: fix queue ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently application supports rx queue IDs up to 255 and max queues of 256 irrespective of device support. This limits the number of active lcores to 256. The patch fixes these constraints by increasing the rx queue IDs to support up to 65535. Signed-off-by: Sivaprasad Tummala Acked-by: Konstan

[PATCH v7 05/14] examples/l3fwd: fix lcore ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Sivaprasad Tummala Acke

[PATCH v7 06/14] examples/l3fwd-power: fix lcore ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options") Cc: radu.nico...@intel

[PATCH v7 07/14] examples/l3fwd-graph: fix lcore ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Also the queue IDs are increased to support up to 65535. Fixes: 08bd1a174461 ("examples/l3fwd-graph: add

[PATCH v7 09/14] examples/qos_sched: fix lcore ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Also the queue IDs are increased to support up to 65535. Fixes: de3cfa2c9823 ("sched: initial import") Cc

[PATCH v7 11/14] examples/l3fwd: fix port ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently application supports port IDs up to 255 irrespective of RTE_MAX_ETHPORTS. The patch fixes these constraints by allowing port IDs up to RTE_MAX_ETHPORTS. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Sivaprasad Tummala Acked-by: Konstantin Ananyev Ack

[PATCH v7 08/14] examples/ipsec-secgw: fix lcore ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Also the queue IDs are increased to support up to 65535. Fixes: d299106e8e31 ("examples/ipsec-secgw: add

[PATCH v7 10/14] examples/vm_power_manager: fix lcore ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently the config option allows lcore IDs up to 255, irrespective of RTE_MAX_LCORES and needs to be fixed. The patch fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Also the queue IDs are increased to support up to 65535. Fixes: 0e8f47491f09 ("examples/vm_power: add com

[PATCH v7 12/14] examples/l3fwd-power: fix port ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently application supports port IDs up to 255 irrespective of RTE_MAX_ETHPORTS. The patch fixes these constraints by allowing port IDs up to RTE_MAX_ETHPORTS. Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options") Cc: radu.nico...@intel.com Cc: sta...@dpdk.org Sig

[PATCH v7 13/14] examples/l3fwd-graph: fix port ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently application supports port IDs up to 255 irrespective of RTE_MAX_ETHPORTS. The patch fixes these constraints by allowing port IDs up to RTE_MAX_ETHPORTS. Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton") Cc: ndabilpu...@marvell.com Cc: sta...@dpdk.org Signed-o

[PATCH v7 14/14] examples/ipsec-secgw: fix port ID restriction

2024-03-26 Thread Sivaprasad Tummala
Currently application supports port IDs up to 255 irrespective of RTE_MAX_ETHPORTS. The patch fixes these constraints by allowing port IDs up to RTE_MAX_ETHPORTS. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sergio.gonzalez.mon...@intel.com Cc: sta...@dpdk.org S

[PATCH v7 00/14] fix lcore ID restriction

2024-03-26 Thread Sivaprasad Tummala
With modern CPUs, it is possible to have higher CPU count thus we can have higher RTE_MAX_LCORES. In DPDK sample applications, the current config lcore options are hard limited to 255. The patchset fixes these constraints by allowing all lcore IDs up to RTE_MAX_LCORES. Also the rx queue IDs are in

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-26 Thread Ajit Khaparde
On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C) wrote: > > > 在 2024/3/26 18:30, Thomas Monjalon 写道: > > 26/03/2024 02:42, lihuisong (C): > >> 在 2024/3/25 17:30, Thomas Monjalon 写道: > >>> 25/03/2024 07:24, huangdengdui: > On 2024/3/22 21:58, Thomas Monjalon wrote: > > 22/03/2024 08:09, Dengd

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-26 Thread Garrett D'Amore
This could work. Not that we would like to have the exceptional case of IPv6 use less headroom.   So we would say 40 is our compiled in default and then we reduce it by 20 on IPv6 which doesn’t have to support all the same devices that IPv4 does. This would give the lowest disruption to the exis

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-26 Thread Morten Brørup
Something just struck me… The buffer address field in the RX descriptor of some NICs may have alignment requirements, i.e. the lowest bits in the buffer address field of the NIC’s RX descriptor may be used for other purposes (and assumed zero for buffer address purposes). 40 is divisible by 8,

[PATCH v2] graph: avoid id collisions

2024-03-26 Thread Robin Jarry
The graph id is determined based on a global variable that is incremented every time a graph is created, and decremented every time a graph is destroyed. This only works if graphs are destroyed in the reverse order in which they have been created. The following code produces duplicate graph IDs wh

Re: [PATCH 0/2] introduce PM QoS interface

2024-03-26 Thread Tyler Retzlaff
On Tue, Mar 26, 2024 at 10:20:45AM +0800, lihuisong (C) wrote: > Hi Tyler, > > 在 2024/3/23 1:55, Tyler Retzlaff 写道: > >On Fri, Mar 22, 2024 at 04:54:01PM +0800, lihuisong (C) wrote: > >>+Tyler, +Alan, +Wei, +Long for asking this similar feature on Windows. > >> > >>在 2024/3/21 21:30, Morten Brørup

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-26 Thread Konstantin Ananyev
Just wonder what would happen if you’ll receive an ipv6 packet with options or some fancy encapsulation IP-IP or so? BTW, there is an RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT offload: https://doc.dpdk.org/api/structrte__eth__rxseg__split.html Which might be close to what you are looking for, but right now

[PATCH v14 00/15] Logging unification and improvments

2024-03-26 Thread Stephen Hemminger
Improvements and unification of logging library (for 24.07 release). This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analy

[PATCH v14 01/15] maintainers: add for log library

2024-03-26 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7abb3aee49..54c28a601d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -180,6 +180,7 @@ F: app/te

[PATCH v14 02/15] windows: make getopt functions have const properties

2024-03-26 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v14 03/15] windows: add os shim for localtime_r

2024-03-26 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/incl

[PATCH v14 04/15] windows: common wrapper for vasprintf and asprintf

2024-03-26 Thread Stephen Hemminger
Replace the windows version of asprintf() that was only usable in eal. With a more generic one that supports both vasprintf() and asprintf(). This also eliminates duplicate code. Fixes: 8f4de2dba9b9 ("bus/pci: fill bus specific information") Fixes: 9ec521006db0 ("eal/windows: hide asprintf shim")

[PATCH v14 05/15] eal: make eal_log_level_parse common

2024-03-26 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 46 + lib/eal/common/eal_options.h| 1 + lib/eal/freebsd/eal.c | 42 --

[PATCH v14 06/15] eal: do not duplicate rte_init_alert() messages

2024-03-26 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --g

[PATCH v14 07/15] eal: change rte_exit() output to match rte_log()

2024-03-26 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v14 08/15] log: move handling of syslog facility out of eal

2024-03-26 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 51 ++--- lib/eal/freebsd/eal.c |

[PATCH v14 09/15] eal: initialize log before everything else

2024-03-26 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v14 10/15] log: drop syslog support, and make code common

2024-03-26 Thread Stephen Hemminger
This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_options.c | 3 - lib/log/log.c | 2

[PATCH v14 11/15] log: add hook for printing log messages

2024-03-26 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/log/log.c b/lib/log/log.c index f597da2e39..acd4

[PATCH v14 12/15] log: add timestamp option

2024-03-26 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v14 14/15] log: add support for systemd journal

2024-03-26 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v14 13/15] log: add optional support of syslog

2024-03-26 Thread Stephen Hemminger
Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger --- app/test/test_eal_flags.c | 5 +- doc/guides/linux_gsg/linux_eal_parameter

[PATCH v14 15/15] log: colorize log output

2024-03-26 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. Signed-off-by: Stephen Hemminger --- app/test/test_eal_flags.c | 24 doc

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-26 Thread Garrett D'Amore
This had occurred to me as well.  I think most hardware DMA engines can align on 32-bit boundaries.  I've yet to see a device that actually requires 64-bit DMA alignment.  (But I have only looked at a subset  of devices, and most of the  ones I have looked at are not ones that would be considere

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-26 Thread Garrett D'Amore
This ETH_RX_OFFLOAD_BUFFER_SPLIT sounds promising indeed. On Mar 26, 2024 at 9:14 AM -0700, Konstantin Ananyev , wrote: > Just wonder what would happen if you’ll receive an ipv6 packet with options > or some fancy encapsulation IP-IP or so? > BTW, there is an  RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT offl

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-26 Thread Ajit Khaparde
On Tue, Mar 26, 2024 at 6:47 AM Ajit Khaparde wrote: > > On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C) wrote: > > > > > > 在 2024/3/26 18:30, Thomas Monjalon 写道: > > > 26/03/2024 02:42, lihuisong (C): > > >> 在 2024/3/25 17:30, Thomas Monjalon 写道: > > >>> 25/03/2024 07:24, huangdengdui: > > On

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-26 Thread Damodharam Ammepalli
On Tue, Mar 26, 2024 at 11:12 AM Ajit Khaparde wrote: > > On Tue, Mar 26, 2024 at 6:47 AM Ajit Khaparde > wrote: > > > > On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C) wrote: > > > > > > > > > 在 2024/3/26 18:30, Thomas Monjalon 写道: > > > > 26/03/2024 02:42, lihuisong (C): > > > >> 在 2024/3/25 17:

[PATCH 0/6] dts: add testpmd params and statefulness

2024-03-26 Thread Luca Vizzarro
Hello! Sending in some major work relating to Bugzilla Bug 1371. In a few words I have created a common data structure to handle command line parameters for shells. I applied this to the current EalParameters class, and made it so it's reflected across the interactive shell classes for consistency

[PATCH 1/6] dts: add parameters data structure

2024-03-26 Thread Luca Vizzarro
This commit introduces a new "params" module, which adds a new way to manage command line parameters. The provided Params dataclass is able to read the fields of its child class and produce a string representation to supply to the command line. Any data structure that is intended to represent comma

[PATCH 2/6] dts: use Params for interactive shells

2024-03-26 Thread Luca Vizzarro
Make it so that interactive shells accept an implementation of `Params` for app arguments. Convert EalParameters to use `Params` instead. String command line parameters can still be supplied by using the `StrParams` implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Jack Bond-Preston Rev

[PATCH 3/6] dts: add testpmd shell params

2024-03-26 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Jack Bond-Preston Reviewed-by: Honnappa Nagarahalli --- dts/framework/remote_session/testpmd_shell.py | 633 +- 1 file changed, 615 insertions(+), 18 deletions(-) diff -

[PATCH 4/6] dts: use testpmd params for scatter test suite

2024-03-26 Thread Luca Vizzarro
Update the buffer scatter test suite to use TestPmdParameters instead of the StrParams implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Jack Bond-Preston Reviewed-by: Honnappa Nagarahalli --- dts/tests/TestSuite_pmd_buffer_scatter.py | 19 +++ 1 file changed, 11 insert

[PATCH 5/6] dts: add statefulness to InteractiveShell

2024-03-26 Thread Luca Vizzarro
The InteractiveShell class can be started in privileged mode, but this is not saved for reference to the tests developer. Moreover, originally a command timeout could only be set at initialisation, this can now be amended and reset back as needed. Signed-off-by: Luca Vizzarro Reviewed-by: Jack Bo

[PATCH 6/6] dts: add statefulness to TestPmdShell

2024-03-26 Thread Luca Vizzarro
This commit provides a state container for TestPmdShell. It currently only indicates whether the packet forwarding has started or not, and the number of ports which were given to the shell. This also fixes the behaviour of `wait_link_status_up` to use the command timeout as inherited from Interact

Re: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-26 Thread Stephen Hemminger
On Tue, 26 Mar 2024 10:43:30 -0700 Garrett D'Amore wrote: > This had occurred to me as well.  I think most hardware DMA engines can align > on 32-bit boundaries.  I've yet to see a device that actually requires 64-bit > DMA alignment.  (But I have only looked at a subset  of devices, and most o

Re: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-26 Thread Garrett D'Amore
Fair enough... I think that is just something we're going to have to live with. The other solutions are either much more painful, or much more work. If we can use header/buffer splitting that would be superior.  Right now we can't use that everywhere because it isn't available everywhere. On Mar

[PATCH v15 00/15] Logging unification and improvements

2024-03-26 Thread Stephen Hemminger
Improvements and unification of logging library (for 24.07 release). This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analy

[PATCH v15 01/15] maintainers: add for log library

2024-03-26 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7abb3aee49..54c28a601d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -180,6 +180,7 @@ F: app/te

[PATCH v15 02/15] windows: make getopt functions have const properties

2024-03-26 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v15 03/15] windows: add os shim for localtime_r

2024-03-26 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/incl

[PATCH v15 04/15] windows: common wrapper for vasprintf and asprintf

2024-03-26 Thread Stephen Hemminger
Replace the windows version of asprintf() that was only usable in eal. With a more generic one that supports both vasprintf() and asprintf(). This also eliminates duplicate code. Fixes: 8f4de2dba9b9 ("bus/pci: fill bus specific information") Fixes: 9ec521006db0 ("eal/windows: hide asprintf shim")

[PATCH v15 05/15] eal: make eal_log_level_parse common

2024-03-26 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 46 + lib/eal/common/eal_options.h| 1 + lib/eal/freebsd/eal.c | 42 --

[PATCH v15 06/15] eal: do not duplicate rte_init_alert() messages

2024-03-26 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --g

[PATCH v15 07/15] eal: change rte_exit() output to match rte_log()

2024-03-26 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v15 08/15] log: move handling of syslog facility out of eal

2024-03-26 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 51 ++--- lib/eal/freebsd/eal.c |

[PATCH v15 09/15] eal: initialize log before everything else

2024-03-26 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v15 10/15] log: drop syslog support, and make code common

2024-03-26 Thread Stephen Hemminger
This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_options.c | 3 - lib/log/log.c | 2

[PATCH v15 11/15] log: add hook for printing log messages

2024-03-26 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/log/log.c b/lib/log/log.c index f597da2e39..acd4

[PATCH v15 12/15] log: add timestamp option

2024-03-26 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v15 13/15] log: add optional support of syslog

2024-03-26 Thread Stephen Hemminger
Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger --- app/test/test_eal_flags.c | 5 +- doc/guides/linux_gsg/linux_eal_parameter

[PATCH v15 14/15] log: add support for systemd journal

2024-03-26 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v15 15/15] log: colorize log output

2024-03-26 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. Signed-off-by: Stephen Hemminger --- app/test/test_eal_flags.c | 24 doc

RE: [EXTERNAL] [PATCH v2] graph: avoid id collisions

2024-03-26 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Robin Jarry > Sent: Tuesday, March 26, 2024 9:20 PM > To: dev@dpdk.org; Jerin Jacob ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; Zhirun Yan > Subject: [EXTERNAL] [PATCH v2] graph: avoid id collisions > > Prioritize security for external email

[PATCH v1] net/i40e: updated 24.03 recommended matching list

2024-03-26 Thread hailinx
Signed-off-by: hailinx --- doc/guides/nics/i40e.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 38eab76539..ca6caa0cff 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.rst @@ -104,6 +104,8 @@ For X710/XL710/XXV7

[PATCH v1] net/ice: updated 24.03 recommended matching list

2024-03-26 Thread hailinx
Signed-off-by: hailinx --- doc/guides/nics/ice.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 3aeb3a32a4..3deeea9e6c 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/nics/ice.rst @@ -77,6 +77,8 @@ are listed in the Tested Pla