Just one more question.
On Sun, Mar 3, 2024 at 10:14 PM Honnappa Nagarahalli <
honnappa.nagaraha...@arm.com> wrote:
> Hello Abdullah,
> Thank you for the patch, few comments inline.
>
> The short commit log could be changed as follows:
>
> "lib/hash: add defer queue reclaim API”
>
> > On
On 3/4/2024 1:13 AM, Chaoyong He wrote:
>> On 2/28/2024 10:18 PM, Stephen Hemminger wrote:
>>> On Tue, 27 Feb 2024 19:15:49 +0800
>>> Chaoyong He wrote:
>>>
From: Peng Zhang
Add the elf module, which can get mip information from the firmware
ELF file.
Signed-off-by:
From: Shai Brandes
ENA device will send asynchronous notifications to the
driver in order to notify users about sub-optimal configurations
and refer them to public AWS documentation for further action.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
doc/guides/rel_notes/release_24
From: Shai Brandes
1. Changed the rte_memcpy call to use the precomputed buf_size.
2. Removed redundant address operators (ampersand symbol)
when providing memcpy source address parameter.
3. Code style related change.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net
From: Shai Brandes
Updated the rte_eth_dev_info device supported speed
bitmap to include 200Gbps and 400Gbps capabilities.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/ena_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ne
From: Shai Brandes
Hi all, the ena v2.9.0 release introduces:
1. HAL upgrade:
- renamed the 'base' folder to be 'hal'
- separated the HAL patches instead of a bulk update.
2. Restructured ena stats and metrics.
3. Restructured the LLQ configuration:
- configurable via devarg.
- suppor
Hi Mattias,
I have a comment about the _Generic. What if the user gives uint8_t * or
uint16_t * as the address. One improvement is that we could add a default
branch in _Generic to throw a compiler error or assert false.
Another question is what if nr >= sizeof(type) ? What if you do, for exa
From: Shai Brandes
limits the exponent in the exponential backoff
mechanism in order to avoid the value overflowing.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_com.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/en
From: Shai Brandes
Depending on its acceleration support, the device updates
a different statistic when an ingress packet is dropped
because no buffers are available to hold it.
- In AWS instance types from later generations
'rx_overruns' is updated.
- Otherwise, in legacy instance types,
'rx_dro
From: Shai Brandes
Add a new driver supported feature bit for TX IPv6 checksum offload.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/net
From: Shai Brandes
In case the application enables fast mbuf release optimization,
the driver releases 256 TX mbufs in bulk upon reaching the
TX free threshold.
The existing implementation utilizes rte_mempool_put_bulk for bulk
freeing TXs, which exclusively supports direct mbufs.
In case the app
From: Shai Brandes
Changed the base HAL folder to hal.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/{base => hal}/ena_com.c | 0
drivers/net/ena/{base => hal}/ena_com.h | 0
drivers/net/ena/{base => hal}/ena_defs/ena_admin_defs.
From: Shai Brandes
RX ring submission queue descriptors are always located in host memory
This optimization replaces the generic descriptor retrieval method
with a tailored method for host memory type descriptors to avoid
unnecessary if statement.
Signed-off-by: Shai Brandes
Reviewed-by: Amit B
From: Shai Brandes
The driver will set the size of the LLQ header size according to the
recommendation from the device.
Replaced `enable_llq` and `large_llq_hdr` devargs with
a new devarg `llq_policy` that accepts the following values:
0 - Disable LLQ.
Use with extreme caution as it leads to
From: Shai Brandes
ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id in order
to write to the device memory when using llq.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_eth_com.c | 3 ++-
drivers/net/ena/hal/ena_plat_dpdk.h | 3 ++-
2 files changed, 4 ins
From: Shai Brandes
Several reserved bits in ena_eth_io_tx_cdesc and
ena_eth_io_rx_cdesc_base have been renamed explicitly to
MBZ (Must Be Zero).
These bits are set by the device to zero before being sent
to the driver. The fields are used as an integrity check in
order to ensure that the received
From: Shai Brandes
Adding a check of the MBZ (Must Be Zero) fields in the
incoming tx and rx completion descriptors in order to
identify corrupted descriptors.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_eth_com.c | 13 +++--
drivers/net/ena/hal
From: Shai Brandes
Adding ENA_REGS_RESET_TX_DESCRIPTOR_MALFORMED to identify
cases where the returned TX completion descriptors are
corrupted.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_defs/ena_regs_defs.h | 1 +
1 file changed, 1 insertion(+)
diff -
From: Shai Brandes
When invoking an admin command, in interrupt mode, if the interrupt
is received after timeout and also after the calling function finished
running, the response will be written into a memory that is no longer
valid.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
From: Shai Brandes
The flags field in ena_eth_io_tx_cdesc is 8-bits long.
The current macro used is READ_ONCE16.
Switching to READ_ONCE8 to avoid reading extra data.
Given that there's an implicit cast to u8 in the assignment,
the correct value is being read, but this change makes it
even more ac
From: Shai Brandes
The unlikely mechanism is used to reduce pipe flush,
caused by a wrong branch prediction.
Moreover, it increases readability by wrapping unexpected errors.
This commit adds unlikely to error checks that are unlikely to happen.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Ber
From: Shai Brandes
There can be cases when we trigger reset if an admin interrupt
is missing.
In order to identify this use-case specifically,
this commit adds a new reset reason.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_com.c| 2 ++
From: Shai Brandes
This commit adds an API to query the aenq on whether
there is a pending keep alive notification.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_com.c | 39 +++
drivers/net/ena/hal/ena_com.h | 10 +
From: Shai Brandes
The dma_rmb() memory barrier guarantees that the device set the
phase bit before continuing to read the rest of the descriptor.
Because the phase bit and the rest of the descriptor are in the same
cache line this ensures coherency of the data from the descriptor.
Signed-off-by
From: Shai Brandes
1. PHC algorithm is updated to support reading new PHC values.
2. Update default PHC expiration timeout.
3. Fix a theoretical PHC destroy race.
4. Adjust PHC for multiple devices.
5. PHC activation version check point.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
From: Shai Brandes
RX ring submission queue descriptors are always located in host memory
This optimization replaces the generic update tail method with a
tailored method for host memory type descriptors to avoid unnecessary if
statement.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
From: Shai Brandes
Currently admin_queue->stats.aborted_cmd counter is incremented if an
admin command status is ENA_CMD_ABORTED and only if the admin queue is
in polling mode.
This commit fixes handling the case of incrementing
admin_queue->stats.aborted_cmd if the admin queue is in interrupt
mo
From: Shai Brandes
remove all othe operating system enumeration as they
are unrelated to DPDK. Use a constant value instead.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 13 +
drivers/net/ena/hal/ena_plat_dpdk.h
From: Shai Brandes
This patch makes several changes to improve
the style and readability of the code.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_com.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ena/h
From: Shai Brandes
Adds support for reset request message from the device to the driver,
over AENQ, which in turn should cause the driver to trigger reset.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 3 ++-
drivers/net/ena/hal/en
From: Shai Brandes
1. Set buffer length to zero in case memory allocation failed
and after memory is released.
2. The driver checks buffer_virt_addr for customer allocation
success. In case the allocation fails, buffer_virt_addr
may not necessarily be NULL.
Signed-off-by: Shai Brandes
From: Shai Brandes
1. modify log prints to use correct format specifier
for unsigned variables.
2. removed line breaks for lines that do not exceed
maximal line length.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_eth_com.c | 22 +++--
From: Shai Brandes
Selected AWS instances from later generations enable
large LLQ by default, allowing the transmission of
packets with headers exceeding 96 bytes.
Due to the overall ENA memory BAR size limitation,
large LLQ has the side effect of halving the maximum
number of LLQ entries (from
From: Shai Brandes
Change rte_intr_callback_unregister to its synchronous variant to
ensure all active interrupt callbacks are completed before proceeding
with the flow. Relocate the interrupt deregistration to precede the
release of stats memory, thereby preventing the interrupt handler
from acc
From: Shai Brandes
This commit implements a new operation mode that enables purely
polling-based functionality, eliminating the need for interrupts in
the control path. This mode is not activated by default and can be
toggled using the "control_poll_interval" devarg. When operating in
this mode,
From: Shai Brandes
upgrade driver version to 2.9.0.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/ena_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index af1f6d6d05..f47f58
From: Shai Brandes
Update the device-preferred size of the Tx ring to fall within the
valid range when a large LLQ is enabled. For consistency, align the
device-preferred size of the Rx ring accordingly.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/ena_ethdev.c
From: Satha Rao
Added CNXK APIs to get used txq descriptor count.
Signed-off-by: Satha Rao
---
doc/guides/nics/features/cnxk.ini | 1 +
doc/guides/rel_notes/release_24_03.rst | 1 +
drivers/net/cnxk/cn10k_tx_select.c | 22 ++
drivers/net/cnxk/cn9k_tx_select.c
Implemented a Tx wrapper to perform a thorough check on mbufs,
categorizing and counting invalid cases by type for diagnostic
purposes. The count of invalid cases is accessible through xstats_get.
Also, the devarg option "mbuf_check" was introduced to configure the
diagnostic parameters to enable
Implemented a Tx wrapper to perform a thorough check on mbufs,
categorizing and counting invalid cases by type for diagnostic
purposes. The count of invalid cases is accessible through xstats_get.
Also, the devarg option "mbuf_check" was introduced to configure the
diagnostic parameters to enable
From: Satha Rao
Added CNXK APIs to get used txq descriptor count.
Signed-off-by: Satha Rao
---
Depends-on: series-30833 ("ethdev: support Tx queue used count")
v2:
Updated release notes and fixed API for CPT queues.
v3:
Addressed review comments
v5:
Fixed compilation errors
v6:
Fixed
On Mon, Mar 4, 2024 at 2:38 AM Amit Prakash Shukla
wrote:
>
> Added support of dma driver callback assignment to eventdev
> enqueue and dequeue. The change also defines dma adapter
> capabilities function.
>
> Depends-on: series-30612 ("lib/dmadev: get DMA device using device ID")
>
> Signed-off-b
> > Subject: RE: [EXTERNAL] [PATCH] crypto/mlx5: add virtual function device ID
> >
> > > Subject: [EXTERNAL] [PATCH] crypto/mlx5: add virtual function device
> > > ID
> > >
> > > This adds the virtual function device ID to the list of supported
> > > NVIDIA devices that run the MLX5 compress PMD.
On Mon, Mar 04, 2024 at 01:37:51PM +0800, Wenwu Ma wrote:
> This patch fixes two null pointer dereferences detected by
> coverity scan.
>
> Coverity issue: 414096
> Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Wenwu Ma
Reviewed-by:
> Currently, for multi-segment mbuf, before crypto WQE an extra
> UMR WQE will be introduced to build the contiguous memory space.
> Crypto WQE uses that contiguous memory space key as input.
>
> This commit adds assert for maximum supported segments in debug
> mode in case the segments exceed UMR
> > > > From: Konstantin Ananyev
> > > > Sent: Friday, March 1, 2024 10:10 PM
> > > > To: dev@dpdk.org
> > > > Cc: Jerin Jacob ; Pavan Nikhilesh Bhagavatula
> > > > ; Konstantin Ananyev
> > > > ; sta...@dpdk.org
> > > > Subject: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port
> > >
On Thu, Feb 29, 2024 at 1:25 PM Maxime Coquelin
wrote:
>
> This series aims at improving the Vhost FD manager.
>
> First patch is a fix necessary to have VDUSE devices
> destroy to work. I expect it to be taken into v24.03
> release.
>
> The rest of the series are various improvements to the
> FD
From: Maxime Coquelin
VDUSE_DESTROY_DEVICE ioctl can fail because the device's
chardev is not released despite close syscall having been
called. It happens because the events handler thread is
still polling the file descriptor.
fdset_pipe_notify() is not enough because it does not
ensure the not
On Mon, Mar 4, 2024 at 3:30 PM wrote:
>
> From: Satha Rao
>
> Added CNXK APIs to get used txq descriptor count.
>
> Signed-off-by: Satha Rao
Applied to dpdk-next-net-mrvl/for-main. Thanks
> ---
>
> Depends-on: series-30833 ("ethdev: support Tx queue used count")
>
> v2:
> Updated release no
On Mon, Mar 04, 2024 at 09:33:21AM +, Mingjin Ye wrote:
> Implemented a Tx wrapper to perform a thorough check on mbufs,
> categorizing and counting invalid cases by type for diagnostic
> purposes. The count of invalid cases is accessible through xstats_get.
>
> Also, the devarg option "mbuf_c
From: Shai Brandes
Hi all, the ena v2.9.0 release introduces:
1. HAL upgrade:
- renamed the 'base' folder to be 'hal'
- separated the HAL patches instead of a bulk update.
2. Restructured ena stats and metrics.
3. Restructured the LLQ configuration:
- configurable via devarg.
- suppor
From: Shai Brandes
1. Changed the rte_memcpy call to use the precomputed buf_size.
2. Removed redundant address operators (ampersand symbol)
when providing memcpy source address parameter.
3. Code style related change.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net
From: Shai Brandes
Depending on its acceleration support, the device updates
a different statistic when an ingress packet is dropped
because no buffers are available to hold it.
- In AWS instance types from later generations
'rx_overruns' is updated.
- Otherwise, in legacy instance types,
'rx_dro
From: Shai Brandes
Updated the rte_eth_dev_info device supported speed
bitmap to include 200Gbps and 400Gbps capabilities.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/ena_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ne
From: Shai Brandes
In case the application enables fast mbuf release optimization,
the driver releases 256 TX mbufs in bulk upon reaching the
TX free threshold.
The existing implementation utilizes rte_mempool_put_bulk for bulk
freeing TXs, which exclusively supports direct mbufs.
In case the app
From: Shai Brandes
Changed the base HAL folder to hal.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/{base => hal}/ena_com.c | 0
drivers/net/ena/{base => hal}/ena_com.h | 0
drivers/net/ena/{base => hal}/ena_defs/ena_admin_defs.
From: Shai Brandes
The driver will set the size of the LLQ header size according to the
recommendation from the device.
Replaced `enable_llq` and `large_llq_hdr` devargs with
a new devarg `llq_policy` that accepts the following values:
0 - Disable LLQ.
Use with extreme caution as it leads to
From: Shai Brandes
limits the exponent in the exponential backoff
mechanism in order to avoid the value overflowing.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_com.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/en
From: Shai Brandes
Add a new driver supported feature bit for TX IPv6 checksum offload.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/net
From: Shai Brandes
ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id in order
to write to the device memory when using llq.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_eth_com.c | 3 ++-
drivers/net/ena/hal/ena_plat_dpdk.h | 3 ++-
2 files changed, 4 ins
From: Shai Brandes
ENA device will send asynchronous notifications to the
driver in order to notify users about sub-optimal configurations
and refer them to public AWS documentation for further action.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
doc/guides/rel_notes/release_24
From: Shai Brandes
RX ring submission queue descriptors are always located in host memory
This optimization replaces the generic descriptor retrieval method
with a tailored method for host memory type descriptors to avoid
unnecessary if statement.
Signed-off-by: Shai Brandes
Reviewed-by: Amit B
From: Shai Brandes
Adding a check of the MBZ (Must Be Zero) fields in the
incoming tx and rx completion descriptors in order to
identify corrupted descriptors.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_eth_com.c | 13 +++--
drivers/net/ena/hal
From: Shai Brandes
Several reserved bits in ena_eth_io_tx_cdesc and
ena_eth_io_rx_cdesc_base have been renamed explicitly to
MBZ (Must Be Zero).
These bits are set by the device to zero before being sent
to the driver. The fields are used as an integrity check in
order to ensure that the received
From: Shai Brandes
The flags field in ena_eth_io_tx_cdesc is 8-bits long.
The current macro used is READ_ONCE16.
Switching to READ_ONCE8 to avoid reading extra data.
Given that there's an implicit cast to u8 in the assignment,
the correct value is being read, but this change makes it
even more ac
From: Shai Brandes
Adding ENA_REGS_RESET_TX_DESCRIPTOR_MALFORMED to identify
cases where the returned TX completion descriptors are
corrupted.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_defs/ena_regs_defs.h | 1 +
1 file changed, 1 insertion(+)
diff -
From: Shai Brandes
1. PHC algorithm is updated to support reading new PHC values.
2. Update default PHC expiration timeout.
3. Fix a theoretical PHC destroy race.
4. Adjust PHC for multiple devices.
5. PHC activation version check point.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
From: Shai Brandes
When invoking an admin command, in interrupt mode, if the interrupt
is received after timeout and also after the calling function finished
running, the response will be written into a memory that is no longer
valid.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
From: Shai Brandes
The unlikely mechanism is used to reduce pipe flush,
caused by a wrong branch prediction.
Moreover, it increases readability by wrapping unexpected errors.
This commit adds unlikely to error checks that are unlikely to happen.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Ber
From: Shai Brandes
There can be cases when we trigger reset if an admin interrupt
is missing.
In order to identify this use-case specifically,
this commit adds a new reset reason.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_com.c| 2 ++
From: Shai Brandes
This commit adds an API to query the aenq on whether
there is a pending keep alive notification.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_com.c | 39 +++
drivers/net/ena/hal/ena_com.h | 10 +
From: Shai Brandes
The dma_rmb() memory barrier guarantees that the device set the
phase bit before continuing to read the rest of the descriptor.
Because the phase bit and the rest of the descriptor are in the same
cache line this ensures coherency of the data from the descriptor.
Signed-off-by
From: Shai Brandes
remove all other operating system enumeration as they
are unrelated to DPDK. Use a constant value instead.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 13 +
drivers/net/ena/hal/ena_plat_dpdk.h
From: Shai Brandes
1. Set buffer length to zero in case memory allocation failed
and after memory is released.
2. The driver checks buffer_virt_addr for customer allocation
success. In case the allocation fails, buffer_virt_addr
may not necessarily be NULL.
Signed-off-by: Shai Brandes
From: Shai Brandes
This patch makes several changes to improve
the style and readability of the code.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_com.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ena/hal
From: Shai Brandes
RX ring submission queue descriptors are always located in host memory
This optimization replaces the generic update tail method with a
tailored method for host memory type descriptors to avoid unnecessary if
statement.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
From: Shai Brandes
Adds support for reset request message from the device to the driver,
over AENQ, which in turn should cause the driver to trigger reset.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 3 ++-
drivers/net/ena/hal/en
From: Shai Brandes
1. modify log prints to use correct format specifier
for unsigned variables.
2. removed line breaks for lines that do not exceed
maximal line length.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/hal/ena_eth_com.c | 22 +++--
From: Shai Brandes
Currently admin_queue->stats.aborted_cmd counter is incremented if an
admin command status is ENA_CMD_ABORTED and only if the admin queue is
in polling mode.
This commit fixes handling the case of incrementing
admin_queue->stats.aborted_cmd if the admin queue is in interrupt
mo
From: Shai Brandes
Update the device-preferred size of the Tx ring to fall within the
valid range when a large LLQ is enabled. For consistency, align the
device-preferred size of the Rx ring accordingly.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/ena_ethdev.c
From: Shai Brandes
Selected AWS instances from later generations enable
large LLQ by default, allowing the transmission of
packets with headers exceeding 96 bytes.
Due to the overall ENA memory BAR size limitation,
large LLQ has the side effect of halving the maximum
number of LLQ entries (from
From: Shai Brandes
This commit implements a new operation mode that enables purely
polling-based functionality, eliminating the need for interrupts in
the control path. This mode is not activated by default and can be
toggled using the "control_poll_interval" devarg. When operating in
this mode,
From: Shai Brandes
upgrade driver version to 2.9.0.
Signed-off-by: Shai Brandes
Reviewed-by: Amit Bernstein
---
drivers/net/ena/ena_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index af1f6d6d05..f47f58
From: Shai Brandes
Change rte_intr_callback_unregister to its synchronous variant to
ensure all active interrupt callbacks are completed before proceeding
with the flow. Relocate the interrupt deregistration to precede the
release of stats memory, thereby preventing the interrupt handler
from acc
With loopback interface and IPsec Inbound traffic, getting
NIX_CQERRINT_CPT_DROP interrupt and dataflow is stopped.
This is due to flow control configuration is skipped as
roc_nix_is_esw() returns true for loopback device also.
Fixes: 978dc3a13f7b ("common/cnxk: base support for eswitch VF")
Fixes
On Thu, Feb 29, 2024 at 06:38:47PM +, Bruce Richardson wrote:
> On Mon, Feb 19, 2024 at 09:55:14AM +, Mingjin Ye wrote:
> > Implemented a Tx wrapper to perform a thorough check on mbufs,
> > categorizing and counting invalid cases by types for diagnostic
> > purposes. The count of invalid c
https://bugs.dpdk.org/show_bug.cgi?id=1394
Bug ID: 1394
Summary: vq_assert_lock__ fail in vhost_user_set_vring_addr
during live migration with HW vDPA
Product: DPDK
Version: unspecified
Hardware: x86
OS: Lin
On 3/1/2024 8:42 AM, Chaoyong He wrote:
> Add the necessary logic to get firmware version from firmware file, and
> only reload the firmware when the firmware version changed.
>
> Also add a device argument which can force reload the firmware and
> ignore the firmware version.
>
> ---
> v2:
> * U
> >> - Implemented SVE code for comparing signatures in bulk lookup.
> >> - Added Defines in code for SVE code support.
> >> - Optimise NEON code
> >> - New SVE code is ~5% slower than optimized NEON for N2 processor.
> >>
> >> Signed-off-by: Yoan Picchi
> >> Signed-off-by: Harjot Singh
> >> Re
The information for CNXK NPC MCAM aging poll frequency devargs is moved to
runtime config options section for ethdev device. Initially it was
incorrectly placed in runtime config options section for inline device.
Fixes: a44775505911 ("net/cnxk: support flow aging")
Cc: sta...@dpdk.org
Signed-off
> > On Mar 1, 2024, at 5:16 AM, Morten Brørup
> > wrote:
> >
> >> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com]
> >> Sent: Thursday, 22 February 2024 17.16
> >>
> >>> For some reason your email is not visible to me, even though it's in the
> >>> archive.
> >>
> >> No worries.
Le lun. 4 mars 2024, 11:36, David Marchand a
écrit :
> From: Maxime Coquelin
>
> VDUSE_DESTROY_DEVICE ioctl can fail because the device's
> chardev is not released despite close syscall having been
> called. It happens because the events handler thread is
> still polling the file descriptor.
>
>
zhoumin writes:
> On Wed, Feb 21, 2024 at 2:24AM, Patrick Robb wrote:
>
> On Tue, Feb 20, 2024 at 1:12 PM Aaron Conole wrote:
>
> Why not something like:
>
> Recheck-request: [attribute-list],[test-list]...
>
> For example, then we can do:
>
> Recheck-request: rebase=[identifier],
>
>
21/02/2024 11:32, Bruce Richardson:
> The event vector struct was missing comments on two members, and also
> was inadvertently creating a local variable called "__rte_aligned" in
> the doxygen output.
>
> Correct the comment markers to fix the former issue, and fix the latter
> by putting "#ifdef
On 2024-03-04 09:16, Heng Wang wrote:
Hi Mattias,
I have a comment about the _Generic. What if the user gives uint8_t * or
uint16_t * as the address. One improvement is that we could add a default
branch in _Generic to throw a compiler error or assert false.
If the user pass an incompati
On Mon, Mar 04, 2024 at 04:35:41PM +0100, Thomas Monjalon wrote:
> 21/02/2024 11:32, Bruce Richardson:
> > The event vector struct was missing comments on two members, and also
> > was inadvertently creating a local variable called "__rte_aligned" in
> > the doxygen output.
> >
> > Correct the com
On 3/3/2024 9:56 AM, Thomas Monjalon wrote:
> Speed capabilities of a NIC may be discovered through its Linux
> kernel driver. It is especially useful for bifurcated drivers,
> so they don't have to duplicate the same logic in the DPDK driver.
>
> Parsing ethtool speed capabilities is made easy th
On 2/29/2024 5:31 PM, Stephen Hemminger wrote:
> Add myself as maintainer for TAP device.
>
> Signed-off-by: Stephen Hemminger
>
Acked-by: Ferruh Yigit
On Sun, Mar 03, 2024 at 07:26:36AM +0100, Mattias Rönnblom wrote:
> On 2024-03-02 18:05, Stephen Hemminger wrote:
> >On Sat, 2 Mar 2024 14:53:22 +0100
> >Mattias Rönnblom wrote:
> >
> >>diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h
> >>index 449565eeae..9a368724d5 100644
On Mon, Mar 4, 2024 at 6:10 PM Rahul Bhansali wrote:
>
> With loopback interface and IPsec Inbound traffic, getting
> NIX_CQERRINT_CPT_DROP interrupt and dataflow is stopped.
> This is due to flow control configuration is skipped as
> roc_nix_is_esw() returns true for loopback device also.
>
> Fix
1 - 100 of 183 matches
Mail list logo
