01/03/2024 19:00, Stephen Hemminger:
> On Fri, 01 Mar 2024 16:20:56 +0100
> Thomas Monjalon wrote:
>
> > > >
> > > > The use case is to get capabilities from the kernel driver via ethtool
> > > > ioctl.
> > > >
> > >
> > > Sure, as it is adding kernel ethtool conversion, DPDK driver will ge
When the rte_memcpy() size is 16, the same 16 bytes are copied twice.
In the case where the size is known to be 16 at build tine, omit the
duplicate copy.
Reduced the amount of effectively copy-pasted code by using #ifdef
inside functions instead of outside functions.
Suggested-by: Stephen Hemmin
Speed capabilities of a NIC may be discovered through its Linux
kernel driver. It is especially useful for bifurcated drivers,
so they don't have to duplicate the same logic in the DPDK driver.
Parsing ethtool speed capabilities is made easy thanks to
the functions added in ethdev for internal usa
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Sunday, 3 March 2024 06.58
>
> On Sat, 2 Mar 2024 21:40:03 -0800
> Stephen Hemminger wrote:
>
> > On Sun, 3 Mar 2024 00:48:12 +0100
> > Morten Brørup wrote:
> >
> > > When the rte_memcpy() size is 16, the same 16 bytes are c
Hi.
> -Original Message-
> From: Dariusz Sosnowski
> Sent: Thursday, February 29, 2024 1:52 PM
> To: Slava Ovsiienko ; Ori Kam ;
> Suanming Mou ; Matan Azrad
>
> Cc: dev@dpdk.org; Raslan Darawsheh ; Bing Zhao
>
> Subject: [PATCH v2 00/11] net/mlx5: flow insertion performance
> improveme
Hi,
> -Original Message-
> From: Michael Baum
> Sent: Thursday, February 29, 2024 3:49 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Dariusz Sosnowski
> ; Raslan Darawsheh ; Slava
> Ovsiienko ; Ori Kam ;
> Suanming Mou
> Subject: [PATCH v2] net/mlx5: add HWS support for matching ingress
> me
On Sat, Mar 2, 2024 at 12:55 AM Harman Kalra wrote:
>
> Flow operations can be performed on cnxk ports as well as representor
> ports. Since representor ports are not cnxk ports but have eswitch as
> base device underneath, special handling is required to align with base
> infra. Introducing a fla
On Fri, Mar 1, 2024 at 9:05 AM wrote:
>
> From: Satheesh Paul
>
> The subtraction expression in mbox_memcpy() can wrap around
> causing an out-of-bounds access. Added a check on 'size' to
> fix this.
>
> Coverity issue: 384431, 384439
> Fixes: 585bb3e538f9 ("common/cnxk: add VF support to base de
On Fri, Mar 1, 2024 at 8:47 AM Rahul Bhansali wrote:
>
> Performance improvement is done for Tx fastpath flag MBUF_NOFF when
> tx_compl_ena is false and mbuf has an external buffer.
> In such case, Instead of individual external mbuf free before LMTST,
> a chain of external mbuf will be created an
On Fri, Mar 1, 2024 at 11:02 PM Amit Prakash Shukla
wrote:
>
> Added cnxk driver support for dma event enqueue and dequeue.
> Also added changes for work queue entry completion status and
> dual workslot DMA event enqueue.
>
> Signed-off-by: Pavan Nikhilesh
> Signed-off-by: Amit Prakash Shukla
Another option would be to just do what PPC already does.
The ENA part is because it has some garbage trying to use memcpy
always (which is one of those bad ideas).
From 74e7ab929e61e0481f6e0214d4d06a716b2f7d79 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger
Date: Sun, 3 Mar 2024 08:02:07 -0800
Introducing port representor support to CNXK drivers by adding virtual ethernet
ports providing a logical representation in DPDK for physical function(PF) or
SR-IOV virtual function (VF) devices for control and monitoring.
These port representor ethdev instances can be spawned on an as needed basi
Introducing a new Mailbox for registering base device behind
all representors and also registering debug log type for representors
and base device driver.
Signed-off-by: Harman Kalra
---
doc/guides/nics/cnxk.rst| 4
drivers/common/cnxk/roc_constants.h | 1 +
drivers/common/cnx
Eswitch device is a parent or base device behind all the representors,
acting as transport layer between representors and representees
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_eswitch.c | 379
drivers/net/cnxk/cnxk_eswitch.h | 103 +
drivers/
Configuring the hardware resources used by the eswitch device.
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_eswitch.c | 217 +++-
1 file changed, 216 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cnxk/cnxk_eswitch.c b/drivers/net/cnxk/cnxk_eswitch.c
Implementing the devargs parsing logic via which the representors
pattern is provided. These patterns define for which representies
representors shall be created.
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_eswitch.c | 88 +
drivers/net/cnxk/cnxk_eswitch.h
Basic skeleton for probing representor devices. If PF device is
passed with "representor" devargs, representor ports gets probed
as a separate ethdev device.
Signed-off-by: Harman Kalra
---
MAINTAINERS | 1 +
doc/guides/nics/cnxk.rst| 35 +
drivers/net/cnxk/cnx
Adding new MCAM API for installing flow using generic npc_install_flow
mbox and other helper APIs. Also adding rss action configuration for
eswitch.
Signed-off-by: Harman Kalra
---
drivers/common/cnxk/meson.build| 1 +
drivers/common/cnxk/roc_api.h | 3 +
drivers/common/cnxk/roc_esw
Introducing eswitch variant of set vlan tpid api which can be
using for PF and VF
Signed-off-by: Harman Kalra
---
drivers/common/cnxk/roc_eswitch.c | 15 +++
drivers/common/cnxk/roc_eswitch.h | 4
drivers/common/cnxk/roc_nix_priv.h | 11 +--
drivers/common/cnxk/roc_ni
Adding flow rules for eswitch PF and VF and implementing
interfaces to delete, shift flow rules
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_eswitch.c | 44 +++
drivers/net/cnxk/cnxk_eswitch.h | 25 +-
drivers/net/cnxk/cnxk_eswitch_devargs.c | 1 +
drivers/net/cnxk/c
Implementing fastpath RX and TX fast path routines which can be
invoked from respective representors rx burst and tx burst
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_eswitch.h | 5 +
drivers/net/cnxk/cnxk_eswitch_rxtx.c | 211 +++
drivers/net/cnxk/meson.
Implementing the control path for representor ports, where represented
ports can be configured using TLV messaging.
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_eswitch.c | 70 ++-
drivers/net/cnxk/cnxk_eswitch.h | 8 +
drivers/net/cnxk/cnxk_rep.c | 52 ++
drivers/net/cnxk/cnxk_
Setting up a callback which gets invoked every time a representee
comes up or goes down. Later this callback gets handled by network
counterpart.
Signed-off-by: Harman Kalra
---
drivers/common/cnxk/roc_dev.c | 70 ++
drivers/common/cnxk/roc_dev_priv.h | 3 ++
dr
In case of any representee coming up or going down, kernel sends a
mbox up call which signals a thread to process these messages and
enable/disable HW resources accordingly.
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_eswitch.c | 8 +
drivers/net/cnxk/cnxk_eswitch.h | 19 ++
drivers
Implementing ethernet device operation callbacks for
port representors PMD
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cnxk_rep.c | 28 +-
drivers/net/cnxk/cnxk_rep.h | 35 +++
drivers/net/cnxk/cnxk_rep_msg.h | 8 +
drivers/net/cnxk/cnxk_rep_ops.c | 495 +
Implementing an mbox interface to fetch the representees's ethernet
stats from the kernel.
Signed-off-by: Harman Kalra
---
drivers/common/cnxk/roc_eswitch.c | 45 +++
drivers/common/cnxk/roc_eswitch.h | 2 ++
drivers/common/cnxk/roc_mbox.h| 31 +++
Adding representor ethernet statistics support which can fetch stats
for representees which are operating independently or part of
companian app.
Adds xstats callback for representor port statistics.
Signed-off-by: Harman Kalra
Signed-off-by: Ankur Dwivedi
---
drivers/net/cnxk/cnxk_rep.h |
Base ROC layer changes for supporting eswitch VF and NIX lbk
changes for ESW
Signed-off-by: Harman Kalra
---
drivers/common/cnxk/roc_constants.h | 1 +
drivers/common/cnxk/roc_dev.c | 1 +
drivers/common/cnxk/roc_nix.c | 15 +--
drivers/common/cnxk/roc_nix.h | 1
Adding support for eswitch VF to probe as normal cnxk ethernet device
Signed-off-by: Harman Kalra
---
drivers/net/cnxk/cn10k_ethdev.c| 3 +++
drivers/net/cnxk/cnxk_ethdev.c | 41 +-
drivers/net/cnxk/cnxk_ethdev.h | 3 +++
drivers/net/cnxk/cnxk_ethdev_ops
From: Kiran Kumar K
Implementing the common infrastructural changes for supporting port
representors and represented ports used as action and pattern in net
layer.
Signed-off-by: Kiran Kumar K
Signed-off-by: Satheesh Paul
Signed-off-by: Harman Kalra
---
drivers/common/cnxk/roc_npc.c |
From: Kiran Kumar K
Adding support for represented_port item matching and action.
Signed-off-by: Kiran Kumar K
Signed-off-by: Satheesh Paul
Signed-off-by: Harman Kalra
---
doc/guides/nics/cnxk.rst | 1 +
doc/guides/nics/features/cnxk.ini | 1 +
doc/guides/nics/features/c
Adding support for representor port as item matching and action.
Signed-off-by: Harman Kalra
---
doc/guides/nics/cnxk.rst | 1 +
doc/guides/nics/features/cnxk.ini | 2 +
doc/guides/nics/features/cnxk_vec.ini | 2 +
doc/guides/nics/features/cnxk_vf.ini | 2 +
drivers/net
Flow operations can be performed on cnxk ports as well as representor
ports. Since representor ports are not cnxk ports but have eswitch as
base device underneath, special handling is required to align with base
infra. Introducing a flag to generic flow APIs to discriminate if the
operation request
Implementing base infra for handling flow operations performed on
representor ports, where these representor ports may be representing
native representees or part of companian apps. Also added support for
handling flow create operation
Signed-off-by: Harman Kalra
---
doc/guides/nics/features/cnx
Implementing other flow operations - validate, destroy, query,
flush, dump for representor ports
Signed-off-by: Harman Kalra
---
doc/guides/rel_notes/release_24_03.rst | 1 +
drivers/net/cnxk/cnxk_rep_flow.c | 414 +
drivers/net/cnxk/cnxk_rep_msg.h| 32 ++
Hello Abdullah,
Thank you for the patch, few comments inline.
The short commit log could be changed as follows:
"lib/hash: add defer queue reclaim API”
> On Mar 2, 2024, at 3:27 PM, Abdullah Ömer Yamaç wrote:
>
> This patch adds a new feature to the hash library to allow the user to
>
Adds support to configure writing result to offset of the DMA
response event.
Signed-off-by: Amit Prakash Shukla
---
v5:
- Fixed checkpatch warning.
v4:
- Fixed compilation error.
- Updated release notes.
v3:
- Rebased and fixed compilation error.
v2:
- Added dual workslot enqueue support.
- F
Added cnxk driver support for dma event enqueue and dequeue.
Also added changes for work queue entry completion status and
dual workslot DMA event enqueue.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Amit Prakash Shukla
---
v5:
- Fixed checkpatch warning.
v4:
- Fixed compilation error.
- Upda
Added support of dma driver callback assignment to eventdev
enqueue and dequeue. The change also defines dma adapter
capabilities function.
Depends-on: series-30612 ("lib/dmadev: get DMA device using device ID")
Signed-off-by: Amit Prakash Shukla
---
v5:
- Fixed checkpatch warning.
v4:
- Fixed
> On 2/28/2024 10:18 PM, Stephen Hemminger wrote:
> > On Tue, 27 Feb 2024 19:15:49 +0800
> > Chaoyong He wrote:
> >
> >> From: Peng Zhang
> >>
> >> Add the elf module, which can get mip information from the firmware
> >> ELF file.
> >>
> >> Signed-off-by: Peng Zhang
> >> Reviewed-by: Chaoyong He
> -Original Message-
> From: Richardson, Bruce
> Sent: Friday, March 1, 2024 6:35 PM
> To: Ma, WenwuX
> Cc: dev@dpdk.org; Jiale, SongX
> Subject: Re: [PATCH] net/ice: fix null pointer dereferences
>
> On Fri, Mar 01, 2024 at 01:20:29PM +0800, Wenwu Ma wrote:
> > This patch fixes two
This patch fixes two null pointer dereferences detected by
coverity scan.
Coverity issue: 414096
Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config")
Cc: sta...@dpdk.org
Signed-off-by: Wenwu Ma
---
v2:
- deleting rather than modifying the prints that
cause null pointer derefer
> Subject: RE: [EXTERNAL] [PATCH v5] common/qat: add virtual qat device (vQAT)
>
> > --- a/doc/guides/rel_notes/release_24_03.rst
> > +++ b/doc/guides/rel_notes/release_24_03.rst
> > @@ -146,6 +146,10 @@ New Features
> > to support TLS v1.2, TLS v1.3 and DTLS v1.2.
> >* Added PMD API to a
> This commit isolates qat device arguments from the common
> code. Now arguments are defined per service, and only appear
> in the application if the service is compiled-in.
>
> Depends-on: patch-137678 ("common/qat: add virtual qat device (vQAT)")
>
> Signed-off-by: Arkadiusz Kusztal
Applied t
> > Subject: [PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag
> >
> > This commit fixes a legacy flag, which was placed in a file that may not be
> > included in a building process.
> >
> > Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
> >
> > Signed-off-by: Arkadiusz
> Subject: [PATCH 0/7] add Nitrox compress device support
>
> Add the Nitrox PMD to support Nitrox compress device.
> ---
> v5:
> * Added missing entry for nitrox folder in compress meson.json
>
> v4:
> * Fixed checkpatch warnings.
> * Updated release notes.
>
> v3:
> * Fixed ABI compatibility i
> Subject: [EXTERNAL] [PATCH] crypto/mlx5: add virtual function device ID
>
> This adds the virtual function device ID to the list of
> supported NVIDIA devices that run the MLX5 compress PMD.
Compress PMD or crypto PMD?
>
> Signed-off-by: Suanming Mou
> Acked-by: Matan Azrad
> ---
> driver
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, March 4, 2024 3:24 PM
> To: Suanming Mou ; Matan Azrad
>
> Cc: dev@dpdk.org
> Subject: RE: [EXTERNAL] [PATCH] crypto/mlx5: add virtual function device ID
>
> > Subject: [EXTERNAL] [PATCH] crypto/mlx5: add virtual function device
> > Hi folks,
> >
> > The introduction of a more unified IPsec MB library for DPDK is causing the
> > snow3g tests to fail on ARM. Artifact here:
> > https://lab.dpdk.org/results/dashboard/patchsets/29315/
> > PMDs using the direct API (KASUMI, CHACHA, ZUC, SNOW3G) will use the job
> API,
> > from
On Sun, Mar 3, 2024 at 11:11 PM Harman Kalra wrote:
>
> Implementing other flow operations - validate, destroy, query,
> flush, dump for representor ports
>
> Signed-off-by: Harman Kalra
Applied following fix on merge
[for-main]dell[dpdk-next-net-mrvl] $ git diff
diff --git a/drivers/net/cnxk/c
50 matches
Mail list logo
