[PATCH v5 01/22] eal: provide macro to expand marker extensions

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Provide a new macro __rte_marker(type, name) that may be used to expand RTE_MARKER empty in struct definitions when building with MSVC. Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_common.h | 8 +++- 1 file changed, 7 inse

[PATCH v5 00/22] stop using RTE_MARKER extensions

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. This series hides the markers when building with MSVC and updates libraries and drivers to access compatibly typed pointers to the rte_mbuf struct offsets. This series, does the following. Introduces a new macro __rte_marker(type, name)

[PATCH v5 03/22] security: expand rte markers empty when building with MSVC

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use __rte_marker to expand RTE_MARKER fields empty in rte_security_session struct. Make slight adjustment to cacheline1 __rte_cache_min_aligned as to continue maintaining correct alignment with or without the marker expanding empty. Sig

[PATCH v5 02/22] mbuf: expand rte markers empty when building with MSVC

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use __rte_marker to expand RTE_MARKER fields empty in rte_mbuf struct. Make slight adjustment to cacheline1 __rte_cache_min_aligned as to continue maintaining correct alignment with or without the marker expanding empty. Signed-off-by:

[PATCH v5 04/22] cryptodev: expand rte markers empty when building with MSVC

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use __rte_marker to expand RTE_MARKER fields empty in rte_security_session struct. Make slight adjustment to cacheline1 __rte_cache_min_aligned as to continue maintaining correct alignment with or without the marker expanding empty. Sig

[PATCH v5 05/22] mbuf: stop using mbuf cacheline marker fields

Update prefetch inline functions to access rte_mbuf struct fields directly instead of via cacheline{0,1} marker extension fields. Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_m

[PATCH v5 06/22] mbuf: add mbuf descriptor accessors

Provide inline functions to access rearm data and rx descriptor fields in rte_mbuf struct. Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf.h | 20 1 file changed, 20 insertions(+) diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h index 04cde0f..7993730 100644 --- a

[PATCH v5 07/22] common/idpf: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/common/idpf/idpf_common_rxtx.c| 4 +---

[PATCH v5 08/22] net/bnxt: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 32 +++

[PATCH v5 10/22] net/enic: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/enic/enic_main.c | 4 +--- drivers

[PATCH v5 09/22] net/cnxk: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/cnxk/cn10k_rx.h| 36 ++--

[PATCH v5 14/22] net/iavf: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 32 +++

[PATCH v5 12/22] net/hns3: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/hns3/hns3_rxtx_vec.c | 4 +--- drivers

[PATCH v5 15/22] net/ice: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/ice/ice_rxtx_vec_avx2.c | 16 -

[PATCH v5 16/22] net/ionic: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/

[PATCH v5 13/22] net/i40e: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/i40e/i40e_rxtx_vec_altivec.c | 18 ++

[PATCH v5 11/22] net/fm10k: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/fm10k/fm10k_rxtx_vec.c | 19 +++-

[PATCH v5 18/22] net/mlx5: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_rxq.c | 2 +- driver

[PATCH v5 20/22] net/sfc: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/sfc/sfc_ef100_rx.c | 4 ++-- drivers/net/sfc

[PATCH v5 17/22] net/ixgbe: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 4 +--- dri

[PATCH v5 21/22] net/thunderx: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/thunderx/nicvf_ethdev.c | 4 +--- drivers/ne

[PATCH v5 22/22] net/virtio: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/virtio/virtio_rxtx_packed_avx.h | 10 +++

[PATCH v5 19/22] net/octeon_ep: use mbuf descriptor accessors

RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use new rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors that provide a compatible type pointer without using the marker fields. Signed-off-by: Tyler Retzlaff --- drivers/net/octeon_ep/cnxk_ep_rx.h | 2 +- drivers/

RE: [PATCH v5 00/22] stop using RTE_MARKER extensions

+to: Thomas > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Saturday, 24 February 2024 09.22 > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. This series > hides the markers when building with MSVC and updates libraries and > drivers to access compatibly typed

Re: [PATCH v5 01/22] eal: provide macro to expand marker extensions

24/02/2024 09:21, Tyler Retzlaff: > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Provide a > new macro __rte_marker(type, name) that may be used to expand RTE_MARKER > empty in struct definitions when building with MSVC. I don't think we need to define a new marker macro. I propose

Re: [PATCH v5 05/22] mbuf: stop using mbuf cacheline marker fields

24/02/2024 09:21, Tyler Retzlaff: > Update prefetch inline functions to access rte_mbuf struct fields > directly instead of via cacheline{0,1} marker extension fields. > > Signed-off-by: Tyler Retzlaff [...] > rte_mbuf_prefetch_part1(struct rte_mbuf *m) > { > - rte_prefetch0(&m->cacheline0)

Re: [PATCH v5 06/22] mbuf: add mbuf descriptor accessors

24/02/2024 09:21, Tyler Retzlaff: > Provide inline functions to access rearm data and rx descriptor fields > in rte_mbuf struct. [...] > +static inline > +uint64_t * > +rte_mbuf_rearm_data(struct rte_mbuf *m) > +{ > + RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) != > +

Re: [PATCH v5 00/22] stop using RTE_MARKER extensions

24/02/2024 11:42, Morten Brørup: > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. This series > > hides the markers when building with MSVC and updates libraries and > > drivers to access compatibly typed pointers to the r

RTE_MARKER with MSVC

Hi Tyler, Does MSVC permit empty structures, i.e. structures with no fields? Perhaps with some additional decoration, a la [[msvc::no_unique_address]]. If so, perhaps that would be a possible workaround for RTE_MARKERs. Med venlig hilsen / Kind regards, -Morten Brørup

Re: [PATCH v5 01/22] eal: provide macro to expand marker extensions

24/02/2024 11:51, Thomas Monjalon: > 24/02/2024 09:21, Tyler Retzlaff: > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Provide a > > new macro __rte_marker(type, name) that may be used to expand RTE_MARKER > > empty in struct definitions when building with MSVC. > > I don't think

RE: [PATCH v5 00/22] stop using RTE_MARKER extensions

> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, 24 February 2024 12.14 > > 24/02/2024 11:42, Morten Brørup: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. This > series > > > hides the markers

A couple of patches for dumpcap

Hi Stephen, Please take a look. Thanks! dumpcap_fixes.patch Description: Binary data

[PATCH v1] app/testpmd : return if no packets in GRO heavy weight mode

If there are no packets flushed in GRO heavy weight mode, return false as this fall through code would return true indicating that packets are available Fixes: 461c287ab553 ("app/testpmd: fix GRO packets flush on timeout") Cc: sta...@dpdk.org Signed-off-by: Kumara Parameshwaran --- app/test-pmd