Re: [PATCH] doc: fix test eventdev example commands

2024-01-09 Thread Jerin Jacob
On Fri, Jan 5, 2024 at 9:24 PM wrote: > > From: Pavan Nikhilesh > > Fix incorrect core masks in testeventdev example > commands. > > Fixes: f6dda59153f1 ("doc: add order queue test in eventdev test guide") > Fixes: dd37027f2ba6 ("doc: add order all types queue test in eventdev test > guide") > F

Re: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query

2024-01-09 Thread Bruce Richardson
On Mon, Jan 08, 2024 at 10:15:40PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Monday, 8 January 2024 11.54 > > > > On Tue, Dec 19, 2023 at 10:59:48PM +0530, jer...@marvell.com wrote: > > > From: Jerin Jacob > > > > > > Introduce a new API

Re: 21.11.6 patches review and test

2024-01-09 Thread Kevin Traynor
On 03/01/2024 14:43, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, December 20, 2023 3:23 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Ali Alnubani ; benjamin.wal...@intel.com; David >> Christensen ; Hemant Agrawal >> ; Ian Sto

Re: 21.11.6 patches review and test

2024-01-09 Thread Kevin Traynor
On 20/12/2023 13:22, Kevin Traynor wrote: > Hi all, > > Here is a list of patches targeted for stable release 21.11.6. > > The planned date for the final release is 12 January. > I have validation reports for Red Hat and Nvidia. Thank you. Is there any validation results from Intel, or an ETA

RE: [PATCH 2/2] common/idpf: enable AVX2 for single queue Tx

2024-01-09 Thread Huang, ZhiminX
> -Original Message- > From: Wenzhuo Lu > Sent: Thursday, December 7, 2023 2:35 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [PATCH 2/2] common/idpf: enable AVX2 for single queue Tx > > In case some CPUs don't support AVX512. Enable AVX2 for them to get better > per-core performanc

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-09 Thread Bruce Richardson
On Sat, Jan 06, 2024 at 08:50:03AM -0600, Lewis Donzis wrote: > Good morning. > > I just wanted to mention that this problem still persists in 22.11.3, and we > still have to patch the vmxnet3 driver every time we upgrade. > > As mentioned before, ixgbe_ethdev.c is an example of a driver that if

[PATCH v11] net/iavf: add diagnostic support in TX path

2024-01-09 Thread Mingjin Ye
Implemented a Tx wrapper to perform a thorough check on mbufs, categorizing and counting invalid cases by types for diagnostic purposes. The count of invalid cases is accessible through xstats_get. Also, the devarg option "mbuf_check" was introduced to configure the diagnostic parameters to enable

Re: [PATCH v1] net/axgbe: read and save the port property register

2024-01-09 Thread Ferruh Yigit
On 1/5/2024 11:32 AM, Venkat Kumar Ande wrote: > From: Venkat Kumar Ande > > Read and save the port property registers once during the device probe > and then use the saved values as they are needed. > Hi Venkat, Can you please describe what is the motivation/reason for the change? Is it addr

RE: [PATCH v1] net/axgbe: read and save the port property register

2024-01-09 Thread Ande, Venkat Kumar
[AMD Official Use Only - General] Hi Ferruh, This change will be refactoring for future code readability of AMD AXGBE driver. Regards, Venkat -Original Message- From: Yigit, Ferruh Sent: Tuesday, January 9, 2024 4:05 PM To: Ande, Venkat Kumar ; dev@dpdk.org Cc: Sebastian, Selwin Subje

Re: unnecessary rx callbacks when zero packets

2024-01-09 Thread Ferruh Yigit
On 1/8/2024 3:20 PM, Konstantin Ananyev wrote: > > rx callbacks when zero packets >> >> I noticed while looking at packet capture that currently the receive >> callbacks >> get called even if there are no packets. This seems unnecessary since if >> nb_rx is zero, then there are no packets to look

Re: [BUG] [bonding] bonding member delete bug

2024-01-09 Thread Ferruh Yigit
On 1/8/2024 4:07 PM, Kevin Traynor wrote: > On 08/01/2024 15:55, Ferruh Yigit wrote: >> On 12/18/2023 6:37 AM, Simon Jones wrote: >>> Oh, it's fixed by 0911d4ec and f5e72e8e >>> >> >> Thanks Simon for reporting. >> >> Do you know if the above fixes backported to the 21.11.x LTS release? >> > > Yes

Re: [PATCH v6 1/7] dts: add startup verification and forwarding modes to testpmd shell

2024-01-09 Thread Juraj Linkeš
On Mon, Jan 8, 2024 at 5:36 PM Jeremy Spewock wrote: > > > > On Mon, Jan 8, 2024 at 6:35 AM Juraj Linkeš > wrote: >> >> On Wed, Jan 3, 2024 at 11:33 PM wrote: >> > >> > From: Jeremy Spewock >> > >> > Added commonly used methods in testpmd such as starting and stopping >> > packet forwarding, c

[Bug 1344] Split testbed and test configuration

2024-01-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1344 Bug ID: 1344 Summary: Split testbed and test configuration Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [v5] doc: define qualification criteria for external library

2024-01-09 Thread Jerin Jacob
On Mon, Jan 8, 2024 at 6:57 PM Hemant Agrawal wrote: > > > On 08-Jan-24 2:01 PM, Jerin Jacob wrote: > > On Mon, Jan 8, 2024 at 1:47 PM Hemant Agrawal > > wrote: > >> > >> > >> On 08-Jan-24 1:28 PM, jer...@marvell.com wrote: > >>> From: Jerin Jacob > >>> > >>> Define qualification criteria for e

Re: [dpdk-dev] [v5] doc: define qualification criteria for external library

2024-01-09 Thread Jerin Jacob
On Tue, Jan 9, 2024 at 1:25 AM Morten Brørup wrote: > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 8 January 2024 18.19 > > > > The wording specifies the intent here, and that is not what matters. > > This is not a legal document where someone will take us to c

Re: [dpdk-dev] [v5] doc: define qualification criteria for external library

2024-01-09 Thread Jerin Jacob
On Mon, Jan 8, 2024 at 2:55 PM Morten Brørup wrote: > > > From: jer...@marvell.com [mailto:jer...@marvell.com] > > Sent: Monday, 8 January 2024 08.59 > > > > Define qualification criteria for external library > > based on a techboard meeting minutes [1] and past > > learnings from mailing list dis

RE: [PATCH v2 1/3] ethdev: rename action modify field data structure

2024-01-09 Thread Ori Kam
> -Original Message- > From: Suanming Mou > Sent: Tuesday, December 19, 2023 3:34 AM > > Current rte_flow_action_modify_data struct describes the pkt > field perfectly and is used only in action. > > It is planned to be used for item as well. This commit renames > it to "rte_flow_field

[dpdk-dev] [v6] doc: define qualification criteria for external library

2024-01-09 Thread jerinj
From: Jerin Jacob Define qualification criteria for external library based on a techboard meeting minutes [1] and past learnings from mailing list discussion. [1] http://mails.dpdk.org/archives/dev/2019-June/135847.html https://mails.dpdk.org/archives/dev/2024-January/284849.html Signed-off-by:

[PATCH] net/vmxnet3: fix use of interrupts on FreeBSD

2024-01-09 Thread Bruce Richardson
DPDK does not support interrupts on FreeBSD, so the vmxnet3 driver returns error when enabling interrupts as it initializes. We can fix this by #ifdef'ing out the interrupt calls when building for FreeBSD, allowing the driver to initialize correctly. Fixes: 046f11619567 ("net/vmxnet3: support MSI-

RE: [PATCH v2 2/3] ethdev: add compare item

2024-01-09 Thread Ori Kam
> -Original Message- > From: Suanming Mou > Sent: Tuesday, December 19, 2023 3:34 AM > > The new item type is added for the case user wants to match traffic > based on packet field compare result with other fields or immediate > value. > > e.g. take advantage the compare item user will

RE: [PATCH v2 3/3] net/mlx5: add compare item support

2024-01-09 Thread Ori Kam
> -Original Message- > From: Suanming Mou > Sent: Tuesday, December 19, 2023 3:34 AM > The compare item allows adding flow match with comparison > result. This commit adds compare item support to the PMD > code. > > Due to HW limitation: > - Only HWS supported. > - Only 32-bit compari

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-09 Thread Bruce Richardson
On Tue, Jan 09, 2024 at 07:46:47AM -0600, Lewis Donzis wrote: > Hi, Bruce. > > I'm even less familiar with it, but we do quite a lot of testing using VMs, > so it's been quite handy. > > Your patch seems very reasonable, however it also produces a warning: > > ../drivers/net/vmxnet3/vmxnet3_eth

Re: [PATCH v6 1/7] dts: add startup verification and forwarding modes to testpmd shell

2024-01-09 Thread Jeremy Spewock
On Tue, Jan 9, 2024 at 6:55 AM Juraj Linkeš wrote: > On Mon, Jan 8, 2024 at 5:36 PM Jeremy Spewock > wrote: > > > > > > > > On Mon, Jan 8, 2024 at 6:35 AM Juraj Linkeš > wrote: > >> > >> On Wed, Jan 3, 2024 at 11:33 PM wrote: > >> > > >> > From: Jeremy Spewock > >> > > >> > Added commonly use

Re: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query

2024-01-09 Thread Jerin Jacob
On Tue, Jan 9, 2024 at 2:24 AM Morten Brørup wrote: > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Friday, 5 January 2024 12.13 > > > > > From: Thomas Monjalon > > > Sent: Friday, January 5, 2024 10:04 AM > > > > > > 05/01/2024 10:57, Jerin Jacob: > > > > On Thu,

Re: [PATCH v3 5/6] examples/qos_sched: fix lcore ID restriction

2024-01-09 Thread Ferruh Yigit
On 12/20/2023 4:31 PM, Stephen Hemminger wrote: > On Wed, 20 Dec 2023 07:45:00 +0100 > Sivaprasad Tummala wrote: > >> diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c >> index e97273152a..22fe76eeb5 100644 >> --- a/examples/qos_sched/args.c >> +++ b/examples/qos_sched/args.c >>

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-09 Thread Bruce Richardson
On Tue, Jan 09, 2024 at 09:21:47AM -0600, Lewis Donzis wrote: > > > - On Jan 9, 2024, at 8:28 AM, Bruce Richardson bruce.richard...@intel.com > wrote: > > > On Tue, Jan 09, 2024 at 07:46:47AM -0600, Lewis Donzis wrote: > >> Hi, Bruce. > >> > >> I'm even less familiar with it, but we do qui

[PATCH v7 0/7] dts: Port scatter suite over

2024-01-09 Thread jspewock
From: Jeremy Spewock v7: Addressed comments and made appropriate changes. Most changes had to do with grammatical/spelling errors and expanding upon documentation. Also fixed the typing of eal parameters when creating interactive shells through the SUT node. Jeremy Spewock (7): dts: add start

[PATCH v7 1/7] dts: add startup verification and forwarding modes to testpmd shell

2024-01-09 Thread jspewock
From: Jeremy Spewock Added commonly used methods in testpmd such as starting and stopping packet forwarding, changing forward modes, and verifying link status of ports so that developers can configure testpmd and start forwarding through the provided class rather than sending commands to the test

[PATCH v7 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps

2024-01-09 Thread jspewock
From: Jeremy Spewock Changed the factory method for creating interactive apps in the SUT Node so that EAL parameters would only be passed into DPDK apps since non-DPDK apps wouldn't be able to process them. Also modified interactive apps to allow for the ability to pass parameters into the app on

[PATCH v7 3/7] dts: add optional packet filtering to scapy sniffer

2024-01-09 Thread jspewock
From: Jeremy Spewock Added the options to filter out LLDP and ARP packets when sniffing for packets with scapy. This was done using BPF filters to ensure that the noise these packets provide does not interfere with test cases. Signed-off-by: Jeremy Spewock --- dts/framework/test_suite.py

[PATCH v7 4/7] dts: add pci addresses to EAL parameters

2024-01-09 Thread jspewock
From: Jeremy Spewock Added allow list to the EAL parameters created in DTS to ensure that only the relevant PCI devices are considered when launching DPDK applications. Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/sut_node.py | 12 1 file changed, 12 insertions(+)

[PATCH v7 6/7] dts: add scatter to the yaml schema

2024-01-09 Thread jspewock
From: Jeremy Spewock Allow for scatter to be specified in the configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/confi

[PATCH v7 5/7] dts: allow configuring MTU of ports

2024-01-09 Thread jspewock
From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces so that suites that require the sending and receiving of packets of a specific size, or the rejection of packets over a certain size, can configure this maximum as needed. Signed-of

[PATCH v7 7/7] dts: add pmd_buffer_scatter test suite

2024-01-09 Thread jspewock
From: Jeremy Spewock This test suite provides testing of the support of scattered packets by Poll Mode Drivers using testpmd, verifying the ability to receive and transmit scattered multi-segment packets made up of multiple non-contiguous memory buffers. This is tested through 5 different cases i

Re: rte_eth_dev_data reorganization needed

2024-01-09 Thread Ferruh Yigit
On 1/8/2024 5:14 PM, Stephen Hemminger wrote: > While looking at ethdev (for pdump issues) noticed. > The rte_eth_dev_data structure layout is unorganized. > Lots of holes, fields not arranged in logical groups > and usage could be localized for better cache access. > For reference following is s

RE: [EXT] [PATCH] cryptodev: remove unused extern

2024-01-09 Thread Akhil Goyal
> The variable rte_cyptodev_names is unused and misspelled. > > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented") Cc: sta...@dpdk.org > Signed-off-by: Stephen Hemminger Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks for the fix Stephen.

RE: [PATCH 1/2] examples/ipsec-secgw: fix width of variables

2024-01-09 Thread Akhil Goyal
> > > 'rte_eth_rx_burst' returns uint16_t. The same value need to be passed > > to 'process_packets' functions which performs further processing. Having > > this function use 'uint8_t' can result in issues when MAX_PKT_BURST is > > larger. > > > > The route functions (route4_pkts & route6_pkts) ta

RE: [PATCH] examples/ipsec-secgw: use bulk free

2024-01-09 Thread Akhil Goyal
> Subject: [PATCH] examples/ipsec-secgw: use bulk free > > Use rte_pktmbuf_free_bulk() API instead of looping through the packets > and freeing individually. > > Signed-off-by: Anoob Joseph > Suggested-by: Stephen Hemminger Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [PATCH 2/3] net/nfp: fix free resource problem

2024-01-09 Thread Ferruh Yigit
On 1/9/2024 7:56 AM, Chaoyong He wrote: >> On 12/18/2023 1:50 AM, Chaoyong He wrote: On 12/14/2023 10:24 AM, Chaoyong He wrote: > From: Long Wu > > Set the representor array to NULL to avoid that close interface does > not free some resource. > > Fixes: a135bc1644d6 ("

Re: [PATCH] ethdev: add dump regs for telemetry

2024-01-09 Thread Ferruh Yigit
On 1/9/2024 2:19 AM, Jie Hai wrote: > On 2023/12/14 20:49, Ferruh Yigit wrote: >> On 12/14/2023 1:56 AM, Jie Hai wrote: >>> The ethdev library now registers a telemetry command for >>> dump regs. >>> >>> An example usage is shown below: >>> --> /ethdev/regs,test >>> { >>>    "/ethdev/regs": { >>>  

Re: [PATCH v1] net/axgbe: read and save the port property register

2024-01-09 Thread Ferruh Yigit
On 1/9/2024 11:14 AM, Ande, Venkat Kumar wrote: > [AMD Official Use Only - General] > > Hi Ferruh, > > This change will be refactoring for future code readability of AMD AXGBE > driver. > Thanks for clarification, I can update commit log with this info while merging. > Regards, > Venkat > >

[Bug 1345] net/i40e packet loss after Rx interrupt disable

2024-01-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1345 Bug ID: 1345 Summary: net/i40e packet loss after Rx interrupt disable Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[Bug 1346] net/i40e does not report interrupt for the second packet

2024-01-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1346 Bug ID: 1346 Summary: net/i40e does not report interrupt for the second packet Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED

[Bug 1347] net/i40e reports unexpected interrupt just after enable

2024-01-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1347 Bug ID: 1347 Summary: net/i40e reports unexpected interrupt just after enable Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED

Re: Depends-on patchseries support via git-pw or patchwork

2024-01-09 Thread Adam Hassick
I'm not sure yet. I've poked the issue thread about whether they need our help with anything and what the next steps are. On Mon, Jan 8, 2024 at 11:18 AM Ferruh Yigit wrote: > On 12/22/2023 5:26 PM, Patrick Robb wrote: > > Hi all, > > > > As some of you know from discussions at DPDK CI meetings

Re: Issues around packet capture when secondary process is doing rx/tx

2024-01-09 Thread Stephen Hemminger
On Tue, 9 Jan 2024 15:06:47 -0800 Stephen Hemminger wrote: > On Mon, 8 Jan 2024 15:13:25 + > Konstantin Ananyev wrote: > > > > I have been looking at a problem reported by Sandesh > > > where packet capture does not work if rx/tx burst is done in secondary > > > process. > > > > > > The r

[PATCH] doc: add testpmd latencystats option

2024-01-09 Thread Stephen Hemminger
Option was added but never added to documentation. Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation") Signed-off-by: Stephen Hemminger --- doc/guides/testpmd_app_ug/run_app.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/d

Re: Issues around packet capture when secondary process is doing rx/tx

2024-01-09 Thread Stephen Hemminger
On Mon, 8 Jan 2024 15:13:25 + Konstantin Ananyev wrote: > > I have been looking at a problem reported by Sandesh > > where packet capture does not work if rx/tx burst is done in secondary > > process. > > > > The root cause is that existing rx/tx callback model just doesn't work > > unless

[PATCH] testpmd: do not print bitrate-stats in help if not configured

2024-01-09 Thread Stephen Hemminger
Like other #ifdef options, bitrate-stats should not be printed in help if not configured. Fixes: e25e6c70fb56 ("app/testpmd: add --bitrate-stats option") Signed-off-by: Stephen Hemminger --- app/test-pmd/parameters.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/parameters.c

RE: 21.11.6 patches review and test

2024-01-09 Thread Xu, HailinX
Hi Kevin, Intel have started testing, I'm sorry for not sent test results. Because some personnel were on vacation before and should be able to produce results this week. I will send the test report as soon as possible, I am deeply sorry for any inconvenience caused to you. Regards, Xu, Haili

Re: [PATCH] ethdev: add dump regs for telemetry

2024-01-09 Thread fengchengwen
Hi Ferruh, On 2024/1/10 2:06, Ferruh Yigit wrote: > On 1/9/2024 2:19 AM, Jie Hai wrote: >> On 2023/12/14 20:49, Ferruh Yigit wrote: >>> On 12/14/2023 1:56 AM, Jie Hai wrote: The ethdev library now registers a telemetry command for dump regs. An example usage is shown below: >>>

[PATCH v11] net/iavf: add diagnostic support in TX path

2024-01-09 Thread Mingjin Ye
Implemented a Tx wrapper to perform a thorough check on mbufs, categorizing and counting invalid cases by types for diagnostic purposes. The count of invalid cases is accessible through xstats_get. Also, the devarg option "mbuf_check" was introduced to configure the diagnostic parameters to enable

Reminder - DPDK Techboard Meeting Tomorrow, Wed. Jan. 10th, 7am Pacific/10am Eastern/ 1500h UTC

2024-01-09 Thread Nathan Southern
Good evening DPDK Community, This is a reminder that the tech board meets tomorrow morning at 7am Pacific/10am Eastern/1500h UTC. As always, a read-only copy of the agenda can be found here: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db

[RFC 0/2] use traffic class PRM field for IPv6 modification

2024-01-09 Thread Gavin Li
New PRM defined new field OUT_IPV6_TRAFFIC_CLASS for IPv6 which will be used by both IPv6 ECN and DSCP. To apply the new ID and keep backward compatibility with different RDMA core and FW releases, 1) detect the support of the new ID in RDMA core and FW. 2) apply the new ID if possible otherwise, k

[RFC 1/2] net/mlx5: discover IPv6 traffic class support in RDMA core

2024-01-09 Thread Gavin Li
Previously, IPv6 traffic class used the same ids of IPv4 DSCP and ECN by rdam core and firmware. New FW support new IPv6 traffic class id which is recommended to be used though the old way is still working. FW exposed a new cap bit to indicate the supporting of the new id while RDMA core does not

[RFC 2/2] net/mlx5: use traffic class PRM field for IPv6 modification

2024-01-09 Thread Gavin Li
New PRM defined new field OUT_IPV6_TRAFFIC_CLASS for IPv6 which will be used by both IPv6 ECN and DSCP. A new cap bit modify_out_ipv6_traffic_class is added. It can be used to check if the new field is supported by FW. However, IPv6 ECN and DSCP starts from different offset in the same byte. Updat